[issue24934] django_v2 benchmark not working in Python 3.6

2015-12-06 Thread Florin Papa

Florin Papa added the comment:

No problem. Thank you for merging the patch!

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23788] test_urllib2_localnet.test_bad_address fails: OSError not raised by urlopen

2015-12-06 Thread Martin Panter

Martin Panter added the comment:

Actually test_bad_address() in /test/test_urllib2_localnet.py looks redundant 
with the test of the same name in /test/test_urllibnet.py. That test already 
has a nice precondition to skip the test if DNS does not fail, originating in 
revision 7d69d04522e3. And it has a failure message like I already proposed 
(added by Issue 3583, but probably not so important because that report was 
made before precondition in revision 7d69d04522e3 was added).

Long story short: Delete the redundant test from test_urllib2_localnet.

Makes me wonder what other redundancies there are. I guess this is leftover 
baggage from Python 2’s dual urllib and urllib2 modules.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue25777] Misleading descriptions in docs about invoking descriptors.

2015-12-06 Thread Raymond Hettinger

Changes by Raymond Hettinger :


--
assignee: docs@python -> rhettinger
nosy: +rhettinger

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23788] test_urllib2_localnet.test_bad_address fails: OSError not raised by urlopen

2015-12-06 Thread Martin Panter

Martin Panter added the comment:

Steve and/or Raniere: I suspect this is the same problem as mentioned in the 
giant comment, Issue 17564. In other words, it is probably your ISP or DNS 
which is broken, not Python.

However, rather than expecting everyone to automatically read the giant wall of 
comment in the source code, perhaps we could improve the failure message:

with self.assertRaises(OSError,
msg="Perhaps your ISP hijacked the DNS request; "
"see the source code comments"):
# Giant comment
urllib.request.urlopen(...)

Then the failure would look like this:

AssertionError: OSError not raised : Perhaps your ISP hijacked the DNS request; 
see the source code comments

--
nosy: +martin.panter

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue25709] Problem with string concatenation and utf-8 cache.

2015-12-06 Thread Roundup Robot

Roundup Robot added the comment:

New changeset 376b100107ba by Serhiy Storchaka in branch '3.5':
Issue #25709: Fixed problem with in-place string concatenation and utf-8 cache.
https://hg.python.org/cpython/rev/376b100107ba

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue14771] Occasional failure in test_ioctl when run parallel with test_gdb

2015-12-06 Thread Martin Panter

Martin Panter added the comment:

I found that if you redirect GDB’s stdin if fixes all the problems. I don’t 
fully understand what GDB is doing to change the terminal’s foreground process 
group.

In my patch I set stdin to a pipe. It is like using DEVNULL, but should be 
compatible with Python 2 as well.

--
keywords: +patch
nosy: +martin.panter
stage: needs patch -> patch review
versions: +Python 3.5, Python 3.6 -Python 3.2, Python 3.3, Python 3.4
Added file: http://bugs.python.org/file41260/gdb-stdin.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue25815] Improper subprocess output of arguments with braces in them on windows

2015-12-06 Thread Zachary Ware

Changes by Zachary Ware :


--
stage:  -> resolved

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue25815] Improper subprocess output of arguments with braces in them on windows

2015-12-06 Thread Anthony Sottile

Anthony Sottile added the comment:

```
C:\Users\Anthony> C:\Users\Anthony\AppData\Local\Programs\Git\usr\bin\echo.exe 
hi{1}
hi1
```

Must be the provider of echo.exe.  I'll take it up with them

Sorry for the trouble!

--
resolution:  -> not a bug
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue25815] Improper subprocess output of arguments with braces in them on windows

2015-12-06 Thread Eryk Sun

Eryk Sun added the comment:

AFAICT, there's no place where subprocess.Popen would be responsible for 
removing braces from the output. I think it's something unusual with the 
"echo.exe" program. In the cmd.exe shell -- i.e. no msys, bash, etc -- what do 
you get for the following?

C:\Users\Anthony\AppData\Local\Programs\Git\usr\bin\echo.exe hi{1}

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue25815] Improper subprocess output of arguments with braces in them on windows

2015-12-06 Thread Anthony Sottile

Anthony Sottile added the comment:

To clarify further, the echo.exe on my path reacts correctly:

```
Anthony@AnthonysDesktop MINGW64 ~/Desktop/git/pre-commit 
(allow_curly_braces_in_args)
$ /usr/bin/echo hi{1}
hi{1}
Anthony@AnthonysDesktop MINGW64 ~/Desktop/git/pre-commit 
(allow_curly_braces_in_args)
$ 'C:\Users\Anthony\AppData\Local\Programs\Git\usr\bin\echo.exe' hi{1}
hi{1}

```

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue25815] Improper subprocess output of arguments with braces in them on windows

2015-12-06 Thread Anthony Sottile

Anthony Sottile added the comment:

It *is* in my path (otherwise it wouldn't produce any output at all).  I'm not 
trying to use the shell builtin, I'm trying to use the executable.

--
resolution: not a bug -> 
status: closed -> open

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue25815] Improper subprocess output of arguments with braces in them on windows

2015-12-06 Thread Emanuel Barry

Changes by Emanuel Barry :


--
resolution:  -> not a bug
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue25815] Improper subprocess output of arguments with braces in them on windows

2015-12-06 Thread Eryk Sun

Eryk Sun added the comment:

Using the cmd shell's "echo" command requires shell=True. You must have an 
"echo.exe" somewhere in your PATH. Check "where echo" in cmd.

--
nosy: +eryksun

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue25815] Improper subprocess output of arguments with braces in them on windows

2015-12-06 Thread Anthony Sottile

New submission from Anthony Sottile:

First some expected output:

```
# from cmd.exe
C:\Users\Anthony>echo hi{1}
hi{1}
# from MINGW
$ echo hi{1}
hi{1}
```

```
# On ubuntu
$ echo 'hi{1}'
hi{1}
$ python3.5 -c "import subprocess; print(subprocess.check_output(('echo', 
'hi{1}')))"
b'hi{1}\n'
```

Now for the unexpected output (produced only by python on windows) (notice the 
missing braces)

```
C:\Python27\python.exe -c "import subprocess; 
print(subprocess.check_output(('echo', 'hi{1}')))"
hi1
C:\Python34\python.exe -c "import subprocess; 
print(subprocess.check_output(('echo', 'hi{1}')))"
b'hi1\n'
C:\Python35\python.exe -c "import subprocess; 
print(subprocess.check_output(('echo', 'hi{1}')))"
b'hi1\n'
```

Peculiarly, these all produce the output I expect:

```
C:\Python35\python.exe -c "import subprocess; 
print(subprocess.check_output(('echo', 'hi {1}')))"
b'hi {1}\n'
C:\Python35\python.exe -c "import subprocess; 
print(subprocess.check_output(('echo', 'hi{1}'), shell=True))"
b'hi{1}\r\n'
```

I don't have access to 3.6, but I imagine the issue exists there too.

--
components: Windows
messages: 256043
nosy: Anthony Sottile, paul.moore, steve.dower, tim.golden, zach.ware
priority: normal
severity: normal
status: open
title: Improper subprocess output of arguments with braces in them on windows
versions: Python 2.7, Python 3.4, Python 3.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue10351] Add autocompletion for keys in dictionaries

2015-12-06 Thread Martin Panter

Martin Panter added the comment:

Some thoughts and observations from trying this patch out:

* It supports single and double quotes, but triple-quoted strings get trashed
* It supports Python 2’s u". . ." syntax, but not r". . .", b". . .", etc
* It supports integer keys, but not indexes of lists
* It does not seem to support multi-level dictionaries (e.g. config parser): 
d[key1][key2]
* Control codes in strings are awkward
* Escape codes in strings don’t seem to be parsed or generated properly
* The module doc string would sort of become out of date: “indexing operations 
are *not* evaluated”

It works for custom dictionaries, so it can invoke custom code to list the 
keys. Maybe this is okay; I wouldn’t expect listing an object’s keys to have a 
serious effect. But you could add a Mapping (and Sequence) ABC check in case 
the object implements keys() but is not really a dictionary.

It would be nice for this to work by default, because Tab completion is now 
enabled by default. But I worry if changing the default completer delimiters 
globally will be a compatibility problem.

There is a mega ugly regular expression in the patch. Is there another way to 
do whatever it is doing? Failing that, you could add comments, group names, etc 
to make it more understandable.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18967] Find a less conflict prone approach to Misc/NEWS

2015-12-06 Thread Jesús Cea Avión

Changes by Jesús Cea Avión :


--
nosy: +jcea

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue25194] Opt-in motivations & affiliations page for core contributors

2015-12-06 Thread Jesús Cea Avión

Changes by Jesús Cea Avión :


--
nosy: +jcea

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue14285] Traceback wrong on ImportError while executing a package

2015-12-06 Thread Nick Coghlan

Nick Coghlan added the comment:

+1, latest iteration looks good to me.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue25701] Document that tp_setattro and tp_setattr are used for deleting attributes

2015-12-06 Thread Martin Panter

Martin Panter added the comment:

setattr.3.patch changes to documenting setting as the main purpose, but 
mentions deleting also works but is deprecated in favour of the main deletion 
functions. I also clarified that the slots have to support deleting via NULL.

--
Added file: http://bugs.python.org/file41259/setattr.3.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue25814] Propagate all errors from ElementTree.iterparse

2015-12-06 Thread Serhiy Storchaka

Changes by Serhiy Storchaka :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue25638] Verify the etree_parse and etree_iterparse benchmarks are working appropriately

2015-12-06 Thread Roundup Robot

Roundup Robot added the comment:

New changeset dd67c8c53aea by Serhiy Storchaka in branch 'default':
Issue #25638: Optimized ElementTree.iterparse(); it is now 2x faster.
https://hg.python.org/cpython/rev/dd67c8c53aea

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue25610] Add typing.Awaitable

2015-12-06 Thread Guido van Rossum

Guido van Rossum added the comment:

Fixed by e9aeae1b2ea9 in 3.5, ad855c779bf3 in 3.6.]

--
versions: +Python 3.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue25809] "Invalid" tests on locales

2015-12-06 Thread Martin Panter

Martin Panter added the comment:

Some history:

1. Issue 23474 (Feb 2015): Testing fr_FR thousands_sep = ASCII space

2. Issue 24299 (Jun 2015): Changed to fr_FR.UTF-8 because Solaris uses the 
non-breaking space if it can be encoded as a single byte (i.e Latin-1)

So I tend to agree with Serhiy about changing back to the untested empty 
string. I don’t see the need to completely remove the whole test though.

--
nosy: +martin.panter

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue14285] Traceback wrong on ImportError while executing a package

2015-12-06 Thread Martin Panter

Martin Panter added the comment:

The test suite does check run_module() with some relative names; see 
test_invalid_names() in test_runpy. But there does not appear to be a test for 
“python -m .relative”.

Changes in init-ancestor.3.patch:

* Added a comment explaining the exception handling
* Added check, tests and documentation for relative module names

--
Added file: http://bugs.python.org/file41258/init-ancestor.3.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue25814] Propagate all errors from ElementTree.iterparse

2015-12-06 Thread Roundup Robot

Roundup Robot added the comment:

New changeset 2df330606cd0 by Serhiy Storchaka in branch '3.4':
Issue25814: Propagate all errors from custom XML parser handlers
https://hg.python.org/cpython/rev/2df330606cd0

New changeset de9ef294a3ef by Serhiy Storchaka in branch '2.7':
Issue25814: Propagate all errors from custom XML parser handlers
https://hg.python.org/cpython/rev/de9ef294a3ef

New changeset 0d1bbfe8fd09 by Serhiy Storchaka in branch '3.5':
Issue25814: Propagate all errors from custom XML parser handlers
https://hg.python.org/cpython/rev/0d1bbfe8fd09

New changeset 2cf16918b632 by Serhiy Storchaka in branch 'default':
Issue25814: Propagate all errors from custom XML parser handlers
https://hg.python.org/cpython/rev/2cf16918b632

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue24682] Add Quick Start: Communications section to devguide

2015-12-06 Thread R. David Murray

Changes by R. David Murray :


--
stage: commit review -> needs patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue25701] Document that tp_setattro and tp_setattr are used for deleting attributes

2015-12-06 Thread Martin Panter

Martin Panter added the comment:

Okay, I will look at making it say deleting via SetAttr etc is possible but is 
not the main purpose, and using DelAttr etc is recommended instead.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue24682] Add Quick Start: Communications section to devguide

2015-12-06 Thread Carol Willing

Carol Willing added the comment:

David, I love the three paragraph intro. It captures the essence of the dev 
guide usage from newcomers to the project to experienced core devs. I really 
like the second paragraph and how it suggests focusing on the issue at hand. 
Thanks, and I will take these three suggested paragraphs and rework the patch.

I'll use the three paragraphs as an intro, circular file the quickstart, and 
rework some of the remaining content into its own section(s).

I respect how you like a quality Table of Contents when looking for 
information. Alternatively, other folks use search extensively to find 
information, and search gives a different, less linear walk through the 
document. So I think it is reasonable to err on the side of a quality 
uncluttered Table of Contents.

However, I also do think that those that are new to the project are looking for 
a bit more guidance. Though I concur that the guidance does not need to be in a 
quickstart; though it should be in an easily discoverable place.  Quickstarts 
are common on other open source projects so new contributors will likely look 
for one (or something similar). What new contributors are looking for are brief 
pathways (i.e. a few steps toward productivity) specific to documentation, 
testing, issue triaging, etc. Whether called pathways or a quickstart isn't 
critical, what is important is guiding those that need more assistance and 
those that don't have the time privilege to read the devguide in its entirety.

Thanks for the suggestions. I'll make another pass at it. :D

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue25761] Improve unpickling errors handling

2015-12-06 Thread Serhiy Storchaka

Serhiy Storchaka added the comment:

When pickle stream is unexpectedly ended, different exceptions can be raised. 
EOFError("Ran out of input") is raised when the stream is unexpectedly ended 
without the STOP opcode. But it can be raised also when the data for the opcode 
is incomplete. Other possible exceptions are UnpicklingError, AttributeError 
and ValueError.

Examples:

>>> pickle.loads(b'L')
Traceback (most recent call last):
  File "", line 1, in 
_pickle.UnpicklingError: pickle data was truncated
>>> pickle.loads(b'L10')
Traceback (most recent call last):
  File "", line 1, in 
EOFError: Ran out of input
>>> pickle.loads(b'L10L')
Traceback (most recent call last):
  File "", line 1, in 
ValueError: invalid literal for int() with base 10: '10L'
>>> pickle.loads(b"S'abc'")
Traceback (most recent call last):
  File "", line 1, in 
_pickle.UnpicklingError: the STRING opcode argument must be quoted
>>> pickle.loads(b'(cbuiltins\nlist')
Traceback (most recent call last):
  File "", line 1, in 
AttributeError: Can't get attribute 'lis' on 

Following patch makes C implementation of unpickler always raise 
UnpicklingError("pickle data was truncated") if the data for the opcode is 
truncated (above examples). EOFError("Ran out of input") is raised when the 
stream is unexpectedly ended without the STOP opcode, as before.

I'm not sure, may be always raise UnpicklingError or EOFError? Or change error 
message?

--
Added file: http://bugs.python.org/file41257/unpickling_eof_errors.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue25814] Propagate all errors from ElementTree.iterparse

2015-12-06 Thread Martin Panter

Martin Panter added the comment:

The patch looks good as far as I can tell. I left a question about an 
inconsistency with checking for a null pointer.

--
nosy: +martin.panter

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue24454] Improve the usability of the match object named group API

2015-12-06 Thread Eric V. Smith

Eric V. Smith added the comment:

I've been playing around with this. My implementation is basically the naive:

def __getitem__(self, value):
return self.group(value)

I have the following tests passing:

def test_match_getitem(self):
pat = re.compile('(?:(?Pa)|(?Pb))(?Pc)?')

m = pat.match('a')
self.assertEqual(m['a1'], 'a')
self.assertEqual(m['b2'], None)
self.assertEqual(m['c3'], None)
self.assertEqual(m[0], 'a')
self.assertEqual(m[1], 'a')
self.assertEqual(m[2], None)
self.assertEqual(m[3], None)
with self.assertRaises(IndexError):
m['X']

m = pat.match('ac')
self.assertEqual(m['a1'], 'a')
self.assertEqual(m['b2'], None)
self.assertEqual(m['c3'], 'c')
self.assertEqual(m[0], 'ac')
self.assertEqual(m[1], 'a')
self.assertEqual(m[2], None)
self.assertEqual(m[3], 'c')
with self.assertRaises(IndexError):
m['X']

# Cannot assign.
with self.assertRaises(TypeError):
 m[0] = 1

# No len().
self.assertRaises(TypeError, len, m)

But because I'm just calling group(), you'll notice a few oddities. Namely:

- indexing with integers works, as would group(i). See the discussion of 
omitting len().
- for defined but missing group names, you get None instead of KeyError
- for invalid group names, you get IndexError instead of KeyError

I can't decide if these are good (because they're consistent with group()), or 
bad (because they're surprising. I'm interested in your opinions.

I'll attach the patch when I'm at a better computer.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue24682] Add Quick Start: Communications section to devguide

2015-12-06 Thread R. David Murray

R. David Murray added the comment:

Looking over this...I'm -0.

I really don't like the organization of the front page of the developers guide. 
 The idea of a "quick start" section is fine, but is it appropriate? (I'm 
talking about the code quick start)  The first pages of the document, to my 
mind, should be either a collection of almost-bare links to the 
most-often-referenced material, or a simple introduction, or (what I expect and 
am continually annoyed by not finding) a well organized table of contents.

I do not recall ever finding anything I wanted in the document without going to 
the table of contents.  Of course, I'm not a newbie...but it is a little hard 
for me to see how the intro material actually helps the newbie, either.  I am 
especially struck by the statement in the "contributing" section that says it 
is recommended the articles be read in the order listed...if so, why isn't that 
the table of contents?  In other words, the document should be organized in the 
way the material is best read.

On the other hand, I'm not offering to rewrite it, so take my comments for what 
they are worth in that regard :)

Coming back to adding this section in particular: It feels like it is trying to 
be that "short introduction" I mentioned above, without quite succeeding in 
being one.  It seems to have a mix of goals: welcoming, pointing to newbie 
resources, and talking about community communication norms.  I really don't 
know what I'd do with this information if I were a newbie, and it doesn't seem 
to answer enough questions about how to contribute to justify being the first 
"quick start" thing the newbie reads.  That form of presentation, especially in 
the context of the succeeding section that shows how to get set up, make it 
sound like these are action items (as does the "quick start" in the 
title)...but none of them are sequential action items; they are, rather, 
informational links and discussions of norms.

So, I'd propose rewriting it to take the form of an introduction.  Perhaps 
something like this:

-
Welcome to the Python development community.  This guide collects the 
accumulated knowledge and wisdom of the Python community around how the Python 
language and the CPython implementation (the "reference implementation") of the 
Python language are developed and maintained. It strives to be a comprehensive 
resource for contributing to Python, and the definitive collection (insofar as 
possible) of the "corporate knowledge and culture" of the Python community.  
The guide contains information that new, developing, and experienced 
contributors have found helpful. It is maintained by the same community that 
maintains Python.

The Python community places a high value on collegiality and mutual support.  
We strive to be welcoming to everyone.  Inevitably there will be disagreements, 
and occasionally these can get heated.  A big part of being a contributor is 
communicating respectfully with others in the community.  We all make mistakes, 
though, so being able to apologize and move on is a very helpful skill.  The 
best technique for avoiding problems is to stay focused on the issue at hand: 
how to solve whatever problem is under discussion.  That often means reaching a 
compromise, something the Python community is pretty good at doing.

If you are new to Python development, in addition to reading this guide you 
will want to take advantage of the community's contributor mentorship program: 
 and .  There you can get direct advice from 
experienced contributors to help smooth the process of contributing.  As the 
adage goes, the only stupid question is the question that isn't asked.  So come 
ask us.


I haven't included the links to other resources.  It seems to me that that list 
of resources deserves its own section, in which case a link to it could be 
added to the above intro.

Now, this is just my opinion...if everyone else likes the "quick start" 
approach I'm not going to object :)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue25761] Improve unpickling errors handling

2015-12-06 Thread Roundup Robot

Roundup Robot added the comment:

New changeset 5c670af0100f by Serhiy Storchaka in branch 'default':
Issue #25761: Improved detecting errors in broken pickle data.
https://hg.python.org/cpython/rev/5c670af0100f

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue1322] Deprecate platform.dist() and platform.linux_distribution() functions

2015-12-06 Thread Nir Cohen

Nir Cohen added the comment:

Apologies.

This can be simply installed by running `pip install ld` (from 
https://pypi.python.org/pypi/ld).

Some notes:

* I've just now started writing tests
* Haven't tested on versions other than 2.7.x and 2.6.x
* There's some stray code there. This works.. but it's obviously WIP.
* I'm all into getting as many pull requests to make this as robust as possible 
as fast as possible.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue1322] Deprecate platform.dist() and platform.linux_distribution() functions

2015-12-06 Thread Marc-Andre Lemburg

Marc-Andre Lemburg added the comment:

> This deprecation and eventual removal, will result in a pypi module created 
> with such functionality anyway, that everyone will try to pull in or 
> falling that copying in.

That's the plan, right.

The stdlib is not the right place for things that change this often. Just look 
at how many semi standards we've seen in the last few years. There's no point 
in trying to follow these in a slow moving code base as the Python stdlib. It's 
much better to put the functionality into a PyPI module which can be updated 
much more frequently.

Perhaps you could upload your code to PyPI and then reference it here for 
people to find ?!

Thanks.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue24682] Add Quick Start: Communications section to devguide

2015-12-06 Thread R. David Murray

R. David Murray added the comment:

Well, you got agreement from Stephen :)  But you are right, I had overlooked 
the fact that this was your patch.  I also just gave Stephen Developer privs on 
the tracker so he can do it in the future on issues he thinks are ready.

All that said, I don't think there's anything wrong with moving one's own patch 
to commit review if you really think it is ready, if you have had other eyes on 
it.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue24682] Add Quick Start: Communications section to devguide

2015-12-06 Thread Carol Willing

Carol Willing added the comment:

R. David Murray wrote:
>
> R. David Murray added the comment:
>
> Carol: as part of requesting a commit you can set the stage to 'commit 
> review' (I've done that for this one) and that may lead to at least a 
> couple of us noticing it where we wouldn't otherwise :)
>

Thank you David for the tip and for changing the stage. I didn't realize 
that I could select 'commit review' for my own patch. :-)

>
> --
> nosy: +r.david.murray
> stage: patch review -> commit review
>
> ___
> Python tracker
> 
> ___

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue25529] Provide access to the validated certificate chain in ssl module

2015-12-06 Thread R. David Murray

R. David Murray added the comment:

If there's no reply, that would be a no :)

So, pinging the issue after a month as you just did is appropriate, let's see 
if one of the openssl experts replies.

On the other hand, how is this different from issue 24107, where Crys did reply?

--
nosy: +r.david.murray

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue25810] Python 3 documentation for eval is incorrect

2015-12-06 Thread R. David Murray

R. David Murray added the comment:

As I recall it, in the python2 docs we used the [... notation, sometimes even 
when the actual arguments were or accepted keywords.  In the python3 docs we 
converted to always using keyword notation...and then realized that that also 
caused confusion, in the other direction.  Some things we converted back to 
[... notation.  Then argument clinic came along, and we kind of postponed 
worrying about it until we converted as much as practical to argument clinic.

I think we are moving toward using (and documenting in the main docs) the / 
notation.  Especially since it shows up in the inspect module as well as the 
docstring help.

Martin, if you don't think you have consensus on your patch, perhaps it is time 
to ping python-dev.

--
nosy: +r.david.murray

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue25495] binascii documentation incorrect

2015-12-06 Thread R. David Murray

R. David Murray added the comment:

See also Issue 1753718.  I will try to review both of these issues soon.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue1753718] base64 "legacy" functions violate RFC 3548

2015-12-06 Thread R. David Murray

R. David Murray added the comment:

See also the discussion in issue 25495.  I will try to review both of these 
issues soon.

--
nosy: +r.david.murray
versions: +Python 3.4, Python 3.5, Python 3.6 -Python 3.1, Python 3.2

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue24682] Add Quick Start: Communications section to devguide

2015-12-06 Thread R. David Murray

R. David Murray added the comment:

Carol: as part of requesting a commit you can set the stage to 'commit review' 
(I've done that for this one) and that may lead to at least a couple of us 
noticing it where we wouldn't otherwise :)

--
nosy: +r.david.murray
stage: patch review -> commit review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue1322] Deprecate platform.dist() and platform.linux_distribution() functions

2015-12-06 Thread Nir Cohen

Nir Cohen added the comment:

I didn't mean to say that it was. Still, it's important to have some 
implementation of identifying linux distributions and their properties..

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue1322] Deprecate platform.dist() and platform.linux_distribution() functions

2015-12-06 Thread Matthias Klose

Matthias Klose added the comment:

this is not "fixable".  and now when parsing os-release you get different 
values then you got before, e.g. changing "Ubuntu" to "ubuntu".

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue1322] Deprecate platform.dist() and platform.linux_distribution() functions

2015-12-06 Thread Nir Cohen

Nir Cohen added the comment:

I have a premliminary implementation of it: https://github.com/nir0s/ld

Would love some help. It tries to use adhere to the standards (os-release 
first, lsb-release later, then, distro-specific release files).

It also returns more types of values then there were before.

--
nosy: +nir0s

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue25701] Document that tp_setattro and tp_setattr are used for deleting attributes

2015-12-06 Thread Serhiy Storchaka

Serhiy Storchaka added the comment:

I think the conclusion of Python_Dev discussion is that it is not worth to 
deprecate this behavior in the code. Current behavior of  PyObject_SetAttr and 
PySequence_SetItem should be documented with a deprecation notice.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue25717] tempfile.TemporaryFile fails when dir option set to directory residing on host OS mount

2015-12-06 Thread STINNER Victor

STINNER Victor added the comment:

Thank you.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue25638] Verify the etree_parse and etree_iterparse benchmarks are working appropriately

2015-12-06 Thread Serhiy Storchaka

Serhiy Storchaka added the comment:

Thank you for your review Brett. First than apply this optimization I want to 
fix errors propagating issue (issue25814). The patch for it is mainly the 
simplified part of the patch for this issue.

--
dependencies: +Propagate all errors from ElementTree.iterparse

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue25814] Propagate all errors from ElementTree.iterparse

2015-12-06 Thread Serhiy Storchaka

New submission from Serhiy Storchaka:

Some memory errors raised in handlers during XML parsing are explicitly or 
implicitly propagated to the caller of XMLParser methods feed(), close(), and 
_parse_whole(). But others are silenced with PyErr_Clear() with added comments 
"FIXME: propagate error". There are no reasons why one errors are propagated 
and others are not. For example memory error during creating tuple is not 
propagated, but memory error during resizing a list to which this tuple is 
appended is propagated. Looks as this is not intentional.

Not propagated errors can cause the lost of events. Proposed patch makes the 
parser to propagate all errors. Since it extracts common code into the 
treebuilder_append_event() function and inlines the 
treebuilder_handle_namespace() function, the resulting code becomes even 
simpler, its size is decreased by 49 lines.

--
components: Extension Modules, XML
files: etree_propagate_errors.patch
keywords: patch
messages: 256012
nosy: brett.cannon, scoder, serhiy.storchaka
priority: normal
severity: normal
stage: patch review
status: open
title: Propagate all errors from ElementTree.iterparse
type: behavior
versions: Python 2.7, Python 3.4, Python 3.5, Python 3.6
Added file: http://bugs.python.org/file41256/etree_propagate_errors.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue22742] IDLE shows traceback when printing non-BMP character

2015-12-06 Thread irdb

Changes by irdb :


--
nosy: +irdb

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21084] IDLE can't deal with characters above the range (U+0000-U+FFFF)

2015-12-06 Thread irdb

Changes by irdb :


--
nosy: +irdb

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue13153] IDLE crashes when pasting non-BMP unicode char on Py3

2015-12-06 Thread irdb

Changes by irdb :


--
nosy: +irdb

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue6395] Infinite Recursion during Unpickling a codecs Object

2015-12-06 Thread Serhiy Storchaka

Serhiy Storchaka added the comment:

There is also a problem with deepcopying:

>>> class MemReader:
... def __init__(self, data):
... self.buf = memoryview(data).cast('B')
... def read(self, size=-1):
... if size < 0:
... size = len(self.buf)
... res = bytes(self.buf[:size])
... self.buf = self.buf[size:]
... return res
... def close():
... pass
... def __deepcopy__(self, memo):
... return MemReader(self.buf)
... def __reduce__(self):
... return MemReader, (bytes(self.buf),)
... 
>>> import codecs, copy
>>> s1 = codecs.getreader('utf-8')(MemReader(b'abcd'))
>>> s2 = copy.deepcopy(s1)
>>> s1.read()
'abcd'
>>> s2.read()
b'abcd'
>>> s2
<__main__.MemReader object at 0xb701988c>

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue14285] Traceback wrong on ImportError while executing a package

2015-12-06 Thread Nick Coghlan

Nick Coghlan added the comment:

Ah, I think I understand the problem you're getting at now:

* if the parent package is missing entirely, we still want to suppress the 
traceback by throwing the runpy specific exception
* if the parent package is present, but one of the modules *that* tries to 
import is missing (or otherwise doesn't load), we want to let the traceback 
happen normally

The exception handler in the new code snippet addresses that by checking the 
name attribute on the ImportError, but could likely use a comment explaining 
the subtlety.

The way you've handled checking the result of the rpartition call also 
highlights a deficiency in the runpy docs, and likely also the test suite as 
well: runpy.run_module and the -m switch only work with absolute module names, 
but this isn't stated explicitly in the documentation, nor is there any early 
check in _get_module_details() to bail out if given a relative module name.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue25717] tempfile.TemporaryFile fails when dir option set to directory residing on host OS mount

2015-12-06 Thread Roundup Robot

Roundup Robot added the comment:

New changeset e9bf5803b716 by Martin Panter in branch '3.5':
Issue #25717: Add comment explaining why errors are ignored
https://hg.python.org/cpython/rev/e9bf5803b716

New changeset 8bf69413ec01 by Martin Panter in branch 'default':
Issue #25717: Merge comment from 3.5
https://hg.python.org/cpython/rev/8bf69413ec01

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue25717] tempfile.TemporaryFile fails when dir option set to directory residing on host OS mount

2015-12-06 Thread Martin Panter

Martin Panter added the comment:

Okay will do

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue25813] co_flags section of inspect module docs out of date

2015-12-06 Thread Mark Lawrence

Mark Lawrence added the comment:

None of these constants are documented either:-
inspect.CO_COROUTINE
inspect.CO_GENERATOR
inspect.CO_ITERABLE_COROUTINE
inspect.CO_NESTED
inspect.CO_NEWLOCALS
inspect.CO_NOFREE
inspect.CO_OPTIMIZED
inspect.CO_VARARGS
inspect.CO_VARKEYWORDS

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue25717] tempfile.TemporaryFile fails when dir option set to directory residing on host OS mount

2015-12-06 Thread STINNER Victor

STINNER Victor added the comment:

Martin, please add a comment to explain the rationale on ignoring errors
other than EBADF. At least, mention this issue number.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com