[issue25702] Link Time Optimizations support for GCC and CLANG

[Alecsandru Patrascu]

Alecsandru Patrascu added the comment:

>From our experience, pybench only is not a representative benchmark. Instead, 
>if you like to measure performance close to real workloads, you can run the 
>Grand Unified Python Benchmark suite, that is more complete. 

Also, you need to take into consideration the hardware and software 
environment. For this, you can read the initial comment at this issue, section 
"Hardware and OS Configuration", to see the approach we have here at Intel.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26478] dict views don't implement subtraction correctly

[Roundup Robot]

Roundup Robot added the comment:

New changeset 0cae6b6e3d7d by Benjamin Peterson in branch '3.4':
properly use the ObjArgs variant of CallMethod in dictview binary operations 
(closes #26478)
https://hg.python.org/cpython/rev/0cae6b6e3d7d

New changeset a5bc5c9490f5 by Benjamin Peterson in branch '3.5':
merge 3.4 (closes #26478)
https://hg.python.org/cpython/rev/a5bc5c9490f5

New changeset 9532a8815a9c by Benjamin Peterson in branch 'default':
merge 3.5 (closes #26478)
https://hg.python.org/cpython/rev/9532a8815a9c

--
nosy: +python-dev
resolution:  -> fixed
stage:  -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26478] dict views don't implement subtraction correctly

[Xiang Zhang]

Changes by Xiang Zhang <18518281...@126.com>:


--
nosy: +xiang.zhang

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25702] Link Time Optimizations support for GCC and CLANG

[INADA Naoki]

INADA Naoki added the comment:

I've tried LTO without PGO in Debian Jessie.

$ LTOFLAGS='-flto -fuse-linker-plugin -ffat-lto-objects -flto-partition=none'
$ CFLAGS=$LTOFLAGS LDFLAGS=$LTOFLAGS ./configure --prefix=...
$ make -j32

results is here (compared with neither LTO and PGO):

Test minimum run-timeaverage  run-time
 thisother   diffthisother   diff
---
  BuiltinFunctionCalls:47ms50ms   -6.6%48ms51ms   -6.0%
   BuiltinMethodLookup:29ms29ms   -1.3%29ms29ms   -0.1%
 CompareFloats:32ms33ms   -2.8%34ms34ms   -0.5%
 CompareFloatsIntegers:67ms70ms   -3.9%69ms71ms   -3.1%
   CompareIntegers:48ms46ms   +5.1%49ms47ms   +5.8%
CompareInternedStrings:30ms31ms   -1.9%31ms31ms   -1.6%
  CompareLongs:28ms26ms   +8.0%29ms27ms   +8.5%
CompareStrings:26ms26ms   -0.9%27ms26ms   +1.5%
ComplexPythonFunctionCalls:47ms51ms   -8.9%48ms52ms   -7.8%
 ConcatStrings:32ms33ms   -3.2%33ms34ms   -2.2%
   CreateInstances:51ms52ms   -2.5%52ms53ms   -3.5%
CreateNewInstances:38ms40ms   -4.5%39ms41ms   -4.4%
   CreateStringsWithConcat:68ms69ms   -1.4%70ms71ms   -0.4%
  DictCreation:53ms51ms   +5.2%55ms52ms   +6.7%
 DictWithFloatKeys:41ms42ms   -2.2%43ms43ms   -0.0%
   DictWithIntegerKeys:34ms34ms   +0.1%35ms35ms   +0.5%
DictWithStringKeys:31ms32ms   -1.3%32ms32ms   -1.6%
  ForLoops:26ms30ms  -12.1%28ms30ms   -8.7%
IfThenElse:42ms41ms   +2.6%43ms41ms   +5.0%
   ListSlicing:40ms40ms   -0.8%41ms41ms   -0.4%
NestedForLoops:42ms42ms   -0.3%43ms43ms   +0.6%
  NestedListComprehensions:42ms47ms  -11.9%45ms50ms  -10.5%
  NormalClassAttribute:89ms96ms   -7.9%92ms98ms   -5.9%
   NormalInstanceAttribute:47ms45ms   +4.8%48ms45ms   +4.9%
   PythonFunctionCalls:41ms44ms   -7.5%41ms45ms   -7.4%
 PythonMethodCalls:53ms59ms   -9.4%55ms60ms   -8.5%
 Recursion:69ms73ms   -5.1%71ms74ms   -4.2%
  SecondImport:36ms41ms  -12.0%38ms42ms   -9.9%
   SecondPackageImport:45ms42ms   +6.5%46ms43ms   +7.0%
 SecondSubmoduleImport:   115ms   107ms   +7.9%   117ms   108ms   +7.9%
   SimpleComplexArithmetic:27ms29ms   -6.5%28ms30ms   -4.5%
SimpleDictManipulation:60ms65ms   -7.8%61ms66ms   -7.0%
 SimpleFloatArithmetic:33ms30ms   +7.4%34ms31ms   +8.3%
  SimpleIntFloatArithmetic:36ms38ms   -3.3%37ms38ms   -4.0%
   SimpleIntegerArithmetic:36ms38ms   -5.2%37ms38ms   -4.1%
  SimpleListComprehensions:36ms37ms   -3.2%38ms41ms   -7.5%
SimpleListManipulation:34ms34ms   -1.3%35ms38ms   -6.8%
  SimpleLongArithmetic:26ms26ms   +0.3%27ms30ms   -7.5%
SmallLists:45ms47ms   -4.1%46ms56ms  -17.2%
   SmallTuples:51ms54ms   -6.3%53ms62ms  -14.8%
 SpecialClassAttribute:92ms97ms   -5.0%95ms99ms   -4.8%
  SpecialInstanceAttribute:46ms45ms   +2.5%48ms46ms   +3.9%
StringMappings:71ms   100ms  -29.0%73ms   101ms  -27.8%
  StringPredicates:49ms59ms  -17.8%50ms60ms  -16.5%
 StringSlicing:48ms47ms   +3.3%79ms47ms  +66.2%
 TryExcept:24ms29ms  -16.9%25ms30ms  -15.8%
TryFinally:35ms37ms   -6.0%36ms38ms   -4.6%
TryRaiseExcept:12ms13ms   -7.5%13ms14ms   -7.2%
  TupleSlicing:48ms50ms   -2.9%49ms51ms   -2.7%
   WithFinally:52ms57ms   -8.4%53ms58ms   -8.2%
   WithRaiseExcept:42ms46ms   -8.8%43ms47ms   -9.1%
---
Totals:  2291ms  2398ms   -4.5%  2390ms  2470ms   -3.2%

(this=lto.pybench, other=default.pybench)

--

___
Python tracker 

___

[issue26478] dict views don't implement subtraction correctly

[Josh Rosenberg]

Changes by Josh Rosenberg :


--
components: +Interpreter Core

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26478] dict views don't implement subtraction correctly

[Josh Rosenberg]

New submission from Josh Rosenberg:

Don't know when the problem was introduced, but dictviews_sub is doing:

tmp = _PyObject_CallMethodId(result, _difference_update, "O", other);

to implement subtraction (after creating result as a set of the keys in 
question). That's violating the CallMethod contract though (which states the 
format string should produce a tuple), and while it looks like CallMethod does 
fixups when the contract is violated, this creates some very odd behaviors.

With a list, everything is fine:

>>> d = {0: 'zero', 1: 'one', 2: 'two', 3: 'three'}
>>> d.keys() - [0, 2]
{1, 3}
>>> d.keys() - (0, 2)
TypeError: 'int' object is not iterable

Basically, the fix up doesn't get applied when you subtract a tuple, so it's as 
if it's trying to call:

result.difference_update(*(0, 2))  # Unpacking used to illustrate, effect 
is  result.difference_update(0, 2)

With the list, it's wrapping to make a one element tuple, so it behaves like:

result.difference_update(*([0, 2],))  # Unpacking used to illustrate, 
effect is  result.difference_update([0, 2])

For more details, see http://stackoverflow.com/q/35784258/364696

Fix should be to change call line to:

tmp = _PyObject_CallMethodObjArgsId(result, _difference_update, other, 
NULL);

(assuming _PyObject_CallMethodObjArgsId is a thing), or if it's not a thing, to 
fix the format string to force tuple wrapping:

tmp = _PyObject_CallMethodId(result, _difference_update, "(O)", other);

--
messages: 261180
nosy: josh.r
priority: normal
severity: normal
status: open
title: dict views don't implement subtraction correctly
versions: Python 3.5, Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26268] Update python.org installers to use OpenSSL 1.0.2f

[Steve Dower]

Steve Dower added the comment:

Doesn't really matter, since we get to do it all again with #26465.

--
resolution: fixed -> out of date
stage: commit review -> resolved
status: pending -> closed
superseder:  -> Upgrade OpenSSL shipped with python installers

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26456] import _tkinter + TestForkInThread leaves zombie with stalled thread

[Zachary Ware]

Zachary Ware added the comment:

I can confirm that child-exit.patch fixes the immediate issue, so I'm +1 on 
just committing it since it will make several buildbots useful again.  
Improving general handling of the situation can be done in a new issue.

For the record, I agree that this seems to be a relatively recent phenomenon.  
I tried bisecting cpython to find a source for it (using `./python -m 
test.regrtest test_tcl test_thread`), but the bisect just came up with the 
first changeset that allows _tkinter to actually build.  Perhaps 
Tcl_FindExecutable starting a thread is a new thing?

--
assignee:  -> martin.panter
stage:  -> commit review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26477] typing forward references and module attributes

[Martijn Pieters]

Martijn Pieters added the comment:

> I wonder why they forward references are evaluated *at all* at this point. 

The Union type tries to reduce the set of allowed types by removing any 
subclasses (so Union[int, bool] becomes Union[int] only). That's all fine, but 
it should not at that point fail if a forward reference is not available yet.

Arguably, the except NameError there should be converted to a except Exception, 
since forward references are supposed to be *a valid Python expression [...] 
and it should evaluate without errors once the module has been fully loaded.* 
(from the PEP); anything goes, and thus any error goes until the module is 
loaded.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26477] typing forward references and module attributes

[Antti Haapala]

Antti Haapala added the comment:

Indeed, the assumption is be that if a string is used, it is used there because 
the actual thing cannot be referenced by name at that point. Then trying to 
evaluate it at all would be an optimization in only those cases where it is 
used incorrectly / needlessly.

--
nosy: +ztane

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26477] typing forward references and module attributes

[Alex Grönholm]

Alex Grönholm added the comment:

I wonder why they forward references are evaluated *at all* at this point. 
Seems senseless to me. This should be the job of the static type checker or the 
get_type_hints() function.

--
nosy: +alex.gronholm

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26477] typing forward references and module attributes

[Martijn Pieters]

Martijn Pieters added the comment:

A temporary work-around is to use a function to raise a NameError exception 
when the module attribute doesn't exist yet:

def _forward_A_reference():
try:
return a.A
except AttributeError:
# not yet..
raise NameError('A')

class B:
def spam(self: 'B', eggs: typing.Union['_forward_A_reference()', None]):
pass

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26477] typing forward references and module attributes

[Martijn Pieters]

Martijn Pieters added the comment:

Sorry, that should have read "the forward references section of PEP 484".

The section uses this example:

# File models/a.py
from models import b
class A(Model):
def foo(self, b: 'b.B'): ...

# File models/b.py
from models import a
class B(Model):
def bar(self, a: 'a.A'): ...

# File main.py
from models.a import A
from models.b import B

which doesn't fail because the forward references are not being tested until 
after all imports have completed; creating a Union however triggers a subclass 
test between the different types in the union.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26477] typing forward references and module attributes

[Martijn Pieters]

New submission from Martijn Pieters:

Forward references to a module can fail, if the module doesn't yet have the 
required object. The "forward references" section names circular dependencies 
as one use for forward references, but the following example fails:

$ cat test/__init__.py
from .a import A
from .b import B
$ cat test/a.py
import typing
from . import b

class A:
def foo(self: 'A', bar: typing.Union['b.B', None]):
pass
$ cat test/b.py
import typing
from . import a

class B:
def spam(self: 'B', eggs: typing.Union['a.A', None]):
pass
$  bin/python -c 'import test'
Traceback (most recent call last):
  File "", line 1, in 
  File "/Users/mjpieters/Development/venvs/stackoverflow-3.5/test/__init__.py", 
line 1, in 
from .a import A
  File "/Users/mjpieters/Development/venvs/stackoverflow-3.5/test/a.py", line 
2, in 
from . import b
  File "/Users/mjpieters/Development/venvs/stackoverflow-3.5/test/b.py", line 
4, in 
class B:
  File "/Users/mjpieters/Development/venvs/stackoverflow-3.5/test/b.py", line 
5, in B
def spam(self: 'B', eggs: typing.Union['a.A', None]):
  File 
"/Users/mjpieters/Development/Library/buildout.python/parts/opt/lib/python3.5/typing.py",
 line 537, in __getitem__
dict(self.__dict__), parameters, _root=True)
  File 
"/Users/mjpieters/Development/Library/buildout.python/parts/opt/lib/python3.5/typing.py",
 line 494, in __new__
for t2 in all_params - {t1} if not isinstance(t2, TypeVar)):
  File 
"/Users/mjpieters/Development/Library/buildout.python/parts/opt/lib/python3.5/typing.py",
 line 494, in 
for t2 in all_params - {t1} if not isinstance(t2, TypeVar)):
  File 
"/Users/mjpieters/Development/Library/buildout.python/parts/opt/lib/python3.5/typing.py",
 line 185, in __subclasscheck__
self._eval_type(globalns, localns)
  File 
"/Users/mjpieters/Development/Library/buildout.python/parts/opt/lib/python3.5/typing.py",
 line 172, in _eval_type
eval(self.__forward_code__, globalns, localns),
  File "", line 1, in 
AttributeError: module 'test.a' has no attribute 'A'

The forward reference test fails because only NameError exceptions are caught, 
not AttributeError exceptions.

--
components: Library (Lib)
messages: 261172
nosy: mjpieters
priority: normal
severity: normal
status: open
title: typing forward references and module attributes
versions: Python 3.5, Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26474] ctypes: Memory leak at malloc_closure.c

[Brett Cannon]

Brett Cannon added the comment:

As Victor pointed out, it's a cache so it's not meant to free its initially 
allocated memory but to reuse it.

Closing this as "not a bug".

--
nosy: +brett.cannon
resolution:  -> not a bug
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26476] Constness in _PyErr_BadInternalCall

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


--
resolution:  -> fixed
stage: commit review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26476] Constness in _PyErr_BadInternalCall

[Roundup Robot]

Roundup Robot added the comment:

New changeset 0e3526ab6a9b by Serhiy Storchaka in branch '2.7':
Issue #26476: Fixed compilation error when use PyErr_BadInternalCall() in C++.
https://hg.python.org/cpython/rev/0e3526ab6a9b

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26476] Constness in _PyErr_BadInternalCall

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

OK, now I understand. Since _PyErr_BadInternalCall() is private function, we 
will not break any code. Since it is used only by the PyErr_BadInternalCall() 
macro and always called with string literal as an argument, C++ user can't use 
PyErr_BadInternalCall() (without a trick described below). Thus the patch fixes 
a bug. Thank you Jeroen.

The workaround for unpatched Python 2.7 is to undefine the 
PyErr_BadInternalCall() macro.

#undef PyErr_BadInternalCall

There is the PyErr_BadInternalCall() function hidden by the macro. It provides 
less detailed error message, without file name and line number.

--
assignee:  -> serhiy.storchaka
stage:  -> commit review
type:  -> compile error

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26039] More flexibility in zipfile interface

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Sorry for the delay Thomas. This is complex and important to me issue and I 
want to be attentive to it.

I think we should preserve long existing behavior even if it is not documented 
(documenting or deprecating it is other issue). Concurrent reading and wring 
with concurrent reading always (at least since adding ZipFile.open()) worked, 
but was never documented nor tested. Concurrent writing was added rather as a 
side effect of issue14099. If there is a benefit from getting rid of it, we can 
break it.

For preserving current behavior ZipFile.open(mode='w') should acquire the lock 
and it should be released in _ZipWriteFile.close().

I have added other comments on Rietveld. The patch needs to be updated to 
resolve conflicts with committed zipinfo-from-file5.patch.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26434] multiprocessing cannot spawn grandchild from a Windows service

[Marc Schlaich]

Marc Schlaich added the comment:

Wrong bug...

--
status: closed -> open

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25918] AssertionError in lib2to3 on 2.7.11 Windows

[Marc Schlaich]

Marc Schlaich added the comment:

We have some business privilege management solution running which might have 
corrupted the installation. As no one else is reporting this issue, this is my 
best guest for this phenomena and I'm going to close this issue.

--
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26434] multiprocessing cannot spawn grandchild from a Windows service

[Marc Schlaich]

Marc Schlaich added the comment:

We have some business privilege management solution running which might have 
corrupted the installation. As no one else is reporting this issue, this is my 
best guest for this phenomena and I'm going to close this issue.

--
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26476] Constness in _PyErr_BadInternalCall

[Jeroen Demeyer]

Jeroen Demeyer added the comment:

> CPython is written on C and provides C API.

If you look at the title of https://docs.python.org/2/extending/extending.html 
clearly C++ extensions are also supported.

> Even if change the signature of one function, this will not help much, 
> because a lot of other functions require "char *" instead of "const char *".

I don't know which functions you mean, I only encountered this problem for 
PyErr_BadInternalCall().

I should also add that the problem cannot be avoided or worked around for 
PyErr_BadInternalCall() because it's a CPython header itself which does an 
illegal conversion of a string constant to char*.

> This will lead to incompatibility of your extension with older bugfix 
> releases.

I don't see why there would be ABI incompatibility. My patch is only adding 
"const" in the call of a C function.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2202] urllib2 fails against IIS 6.0 (No support for MD5-sess auth)

[Mathieu Dupuy]

Mathieu Dupuy added the comment:

I'm waiting for reviews.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26039] More flexibility in zipfile interface

[Thomas Kluyver]

Thomas Kluyver added the comment:

Serhiy, have you had a chance to look at what the zf.open(mode='w') patch does 
with the lock?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26476] Constness in _PyErr_BadInternalCall

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

CPython is written on C and provides C API.

Even if change the signature of one function, this will not help much, because 
a lot of other functions require "char *" instead of "const char *".

There is small disadvantage of changing the signature in a bugfix release. This 
will lead to incompatibility of your extension with older bugfix releases.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26476] Constness in _PyErr_BadInternalCall

[Jeroen Demeyer]

Jeroen Demeyer added the comment:

> It is questionable wherever it should be backported to 2.7.

It violates the C++ standard (for extension modules written in C++), so it's 
clearly a bug.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26476] Constness in _PyErr_BadInternalCall

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Was already fixed in 84618b2064c1. It is questionable wherever it should be 
backported to 2.7. Most other "const" additions were applied only to the 
default branch (see issue25923, issue24436, issue1772673, issue9369, 
issue16369, issue12173, issue1419652 and many others).

--
nosy: +nnorwitz, serhiy.storchaka

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26466] could not build python 2.7.11 on AIX

[STINNER Victor]

Changes by STINNER Victor :


--
nosy:  -haypo

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25702] Link Time Optimizations support for GCC and CLANG

[Alecsandru Patrascu]

Alecsandru Patrascu added the comment:

I understand now your question. LTO is not enabled when running just `make`, 
only in `make profile-opt`

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26476] Constness in _PyErr_BadInternalCall

[Jeroen Demeyer]

New submission from Jeroen Demeyer:

PyErr_BadInternalCall() calls _PyErr_BadInternalCall(__FILE__, __LINE__). Since 
__FILE__ is a string constant, the first argument of _PyErr_BadInternalCall 
should be a "const char*" instead of a "char*".

This is a follow-up to #4949. Most of the patch from #4949 was applied, but not 
the change to _PyErr_BadInternalCall on Python 2.

--
components: Interpreter Core
files: PyErr_BadInternalCall_const.patch
keywords: patch
messages: 261156
nosy: jdemeyer
priority: normal
severity: normal
status: open
title: Constness in _PyErr_BadInternalCall
versions: Python 2.7
Added file: http://bugs.python.org/file42068/PyErr_BadInternalCall_const.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue4949] Constness in PyErr_NewException

[Jeroen Demeyer]

Jeroen Demeyer added the comment:

Follow-up: #26476

--
nosy: +jdemeyer

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25702] Link Time Optimizations support for GCC and CLANG

[INADA Naoki]

INADA Naoki added the comment:

Sorry my poor English.
I meant that "Does `./configure --with-lto && make` use LTO?".

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25702] Link Time Optimizations support for GCC and CLANG

[Alecsandru Patrascu]

Alecsandru Patrascu added the comment:

Yes, you can use LTO without PGO, but the proposed ways it's more efficient and 
makes more sense for CPython builds.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19450] Bug in sqlite in Windows binaries

[Marc Schlaich]

Marc Schlaich added the comment:

This wasn't decided yet for 2.7 so I'm reopening it until a decision is made.

I'm still +1 for an update to 3.8.3.1 on Windows so that this is on par with 
the version on OSX and the version in Python 3.

--
resolution: fixed -> 
status: closed -> open

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26466] could not build python 2.7.11 on AIX

[Michael Felt]

Changes by Michael Felt :


--
title: cannot build python 2.7.11 on AIX -> could not build python 2.7.11 on AIX

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26466] cannot build python 2.7.11 on AIX

[Michael Felt]

Michael Felt added the comment:

Would just like to add my heartfelt thanks for the simple hint

And, perhaps something to add to the Docs

After adding "--without-computed-gotos" I can complete a (default) configure, 
make, make (DESTDIR=xxx) install of

* python-2.7.11 (was not needed for 2.7.10 and earlier 2.7 releases)
* python-3.4.4
* python-3.5.1

That said, there may still be some minor issues yet to come - but the root 
cause of my recent failures (emphasis on my) are resolved.

If not in the Dev-Guide paragraph for AIX - please add
use --without-computed-gotos when using IBM xlc (aka vac) compiler.

Again,

THANKS!

--
components: +Devguide
nosy: +ezio.melotti, willingc
versions: +Python 3.4, Python 3.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25852] smtplib's SMTP.connect() should store the server name in ._host for .starttls()

[gigaplastik]

gigaplastik added the comment:

Found the same issue independently, but I believe my version of the patch is a 
little more thoughtful. Since the host is allowed to be supplied in 
'hostname:port' format the assignment to ._host should be made _after_ checking 
(and probably parsing) this format.

The reason for this is that ._host is passed to ssl.SSLContext.wrap_socket 
method where it is used for SNI, defined in [1]. According to this RFC, 
"[c]urrently, the only server names supported are DNS hostnames; ... Literal 
IPv4 and IPv6 addresses are not permitted in [HostName]."

Checking if hostname passed is really a DNS name and not an IP address is up to 
ssl library, but here, in .connect method, at least the port number should be 
stripped off.

[1] https://tools.ietf.org/html/rfc4366.html

--
nosy: +gigaplastik
Added file: http://bugs.python.org/file42067/issue25852_v2.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com