[issue20774] collections.deque should ship with a stdlib json serializer

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Seems there are reference leaks. And I afraid that importing a module for every 
serialized object can significantly hit the performance. Can you run some 
benchmarks?

> An __json__ attribute would have to convert to a list first.  Adding support 
> directly to the json module would allow the deque to be read directly.

With PR 830 the deque is converted to a list by json encoder.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29162] pyshell.py: name 'sys' is not defined

[Berker Peksag]

Changes by Berker Peksag :


--
resolution:  -> fixed
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29908] Inconsistent crashing with an access violation

[Cameron Mckain]

Cameron Mckain added the comment:

The problem was fixed after updating to Django 1.11; apparently, Django 1.10 is 
not fully compatible with Python 3.6. Thanks for your time.

--
resolution:  -> out of date
stage:  -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19824] string.Template: Rewrite docs to emphasize i18n use case

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

In that case issue20314 looks related.

--
stage:  -> needs patch
type:  -> enhancement

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29763] test_site failing on AppVeyor

[Zachary Ware]

Changes by Zachary Ware :


--
pull_requests: +738

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27425] Tests fail because of git's newline preferences on Windows

[Zachary Ware]

Changes by Zachary Ware :


--
pull_requests: +737

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29908] Inconsistent crashing with an access violation

[Eryk Sun]

Eryk Sun added the comment:

Steve, I added 3.5 because the crash involved ucrtbase.dll. I'll remove it for 
now since the problem is only confirmed in 3.6.

Offset 0x3bd9e in 32-bit ucrtbase.dll is in wdupenv_s [1]. It's probably from 
calling new_spawnve in pydev_monkey.py, as shown in the faulthandler output. I 
don't use PyCharm, so I can't confirm this, but we know wdupenv_s is called by 
the CRT's wspawnve function. For example:

>>> os.spawnve(os.P_WAIT, sys.executable, ['python', '-V'], os.environ)

Breakpoint 0 hit
eax=01b412b0 ebx= ecx=01b41280 edx=01b412b2 esi=01b41280 
edi=
eip=7672bd9e esp=013ef368 ebp=013ef380 iopl=0 nv up ei pl nz na po 
nc
cs=0023  ss=002b  ds=002b  es=002b  fs=0053  gs=002b 
efl=0202
ucrtbase!wdupenv_s+0x18e:
7672bd9e 668b08  mov cx,word ptr [eax]
ds:002b:01b412b0=0070
0:000> kc 7
ucrtbase!wdupenv_s
ucrtbase!wsearchenv_s
ucrtbase!wspawnlpe
ucrtbase!wspawnlpe
ucrtbase!wspawnve
python36!os_spawnve_impl
python36!os_spawnve

[1]: https://msdn.microsoft.com/en-us/library/ms175774.aspx

--
versions:  -Python 3.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20774] collections.deque should ship with a stdlib json serializer

[Raymond Hettinger]

Raymond Hettinger added the comment:

Thanks Lisa.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20552] Use specific asserts in bytes tests

[Terry J. Reedy]

Terry J. Reedy added the comment:

Raymond, Am I correct in thinking that your comment is not specific to bytes 
but applies to all patches like this?  If so, I think I agree because any 
future changes that break tests will almost certain happen in 3.7+, so that the 
extra work of backporting will have almost 0 gain.  In a few years, the changes 
will be in all currently active branches for free.

--
nosy: +terry.reedy

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29888] The link referring to "Python download page" is broken

[Ned Deily]

Changes by Ned Deily :


--
resolution:  -> fixed
stage: commit review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29888] The link referring to "Python download page" is broken

[Ned Deily]

Ned Deily added the comment:


New changeset 6f95b37f290e0225aed5f8f7733ad0730601201b by Ned Deily (cocoatomo) 
in branch '2.7':
bpo-29888: Fix the link referring to "Python download page" (GH-823)
https://github.com/python/cpython/commit/6f95b37f290e0225aed5f8f7733ad0730601201b


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29911] Uninstall command line in Windows registry does not uninstall

[Zachary Ware]

Changes by Zachary Ware :


--
nosy:  -zach.ware

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29911] Uninstall command line in Windows registry does not uninstall

[Christian Ullrich]

Christian Ullrich added the comment:

Thank you.


As for the pointing out: It worked for Cato, didn't it? He may not have lived 
to see it, but his perseverance in the face of rejection eventually brought 
about the years-long bloody war he had dreamed about.

(Any historical inaccuracies in the above are the property of the author.)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29162] pyshell.py: name 'sys' is not defined

[Mariatta Wijaya]

Changes by Mariatta Wijaya :


--
pull_requests: +736

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29162] pyshell.py: name 'sys' is not defined

[Jelle Zijlstra]

Changes by Jelle Zijlstra :


--
pull_requests: +735

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29162] pyshell.py: name 'sys' is not defined

[Terry J. Reedy]

Terry J. Reedy added the comment:

Reopening because I missed file=sys.__stderr__ in the print() above sys.exit 
;-(.  Reported by JelleZijlstra in PR.

I wonder if there is any way to force an import to fail when testing.  I could 
at least partly test by moving the code for import failure and that for "if 
TkVersion < 8.5" into functions.

--
resolution: fixed -> 
status: closed -> open

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29888] The link referring to "Python download page" is broken

[Kinebuchi Tomohiko]

Kinebuchi Tomohiko added the comment:

@ned.deily Thank you for the commend. I updated the 2.7 PR.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20774] collections.deque should ship with a stdlib json serializer

[Lisa Roach]

Lisa Roach added the comment:

I made PR 830 for this issue, it seems to be a nice feature to have in my 
opinion. 

Let me know if I should add some unit tests :)

--
nosy: +lisroach
pull_requests: +734

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29911] Uninstall command line in Windows registry does not uninstall

[Steve Dower]

Steve Dower added the comment:

I'll take a look at having separate commands set, but the component responsible 
is external and this may be an issue for them.

Also, for future reference, continuing to point out that you would have 
preferred an MSI does not help you get faster assistance, and does not count as 
more "votes" towards any change. Continuing to add it will eventually annoy the 
volunteers who work on CPython sufficiently that you may find it very hard to 
get any attention at all.

--
assignee:  -> steve.dower
versions: +Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29908] Inconsistent crashing with an access violation

[Steve Dower]

Steve Dower added the comment:

Have you confirmed this occurring with 3.5? PyCharm has a very invasive 
debugger that is almost certainly responsible, but there's a significant 
difference between the 3.5 and 3.6 implementations that is probably relevant.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19824] string.Template: Rewrite docs to emphasize i18n use case

[R. David Murray]

R. David Murray added the comment:

Let's retitle this, then.

--
nosy: +r.david.murray
title: string.Template: Add PHP-style variable expansion example -> 
string.Template: Rewrite docs to emphasize i18n use case

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29909] types.coroutine monkey patches original function

[Eric Hopper]

Eric Hopper added the comment:

Here's an update to types.coroutine that fixes the problem for me.

--
Added file: http://bugs.python.org/file46756/types.coroutine.py

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29912] Overlapping tests between list_tests and seq_tests

[Jim Fasarakis-Hilliard]

New submission from Jim Fasarakis-Hilliard:

Seems the CommonTests class defined in list_tests duplicates the testing 
performed by seq_tests.CommonTests in the following functions:

test_index, test_count

Additionally, a part of test_imul from list_tests.CommonTests can be moved to 
seq_tests.CommonTests. (specifically, up until `self.assertEqual(u, 
self.type2test([]))`).

Am I missing some non-obvious thing here or can I safely remove the two test 
functions in list_tests.CommonTests and move (while also adding a super call) 
part of test_imul from list_tests.CommonTests to test_imul in 
seq_tests.CommonTests?

Some links:

[1a] seq_tests test_index: 
https://github.com/python/cpython/blob/1e73dbbc29c96d0739ffef92db36f63aa1aa30da/Lib/test/seq_tests.py#L363
[1b] list_tests test_index:
https://github.com/python/cpython/blob/1e73dbbc29c96d0739ffef92db36f63aa1aa30da/Lib/test/list_tests.py#L376

[2a] seq_tests test_count:
https://github.com/python/cpython/blob/1e73dbbc29c96d0739ffef92db36f63aa1aa30da/Lib/test/seq_tests.py#L344
[2b] list_tests test_count:
https://github.com/python/cpython/blob/1e73dbbc29c96d0739ffef92db36f63aa1aa30da/Lib/test/list_tests.py#L357

[3a] seq_tests test_imul:
https://github.com/python/cpython/blob/1e73dbbc29c96d0739ffef92db36f63aa1aa30da/Lib/test/seq_tests.py#L300
[3b] list_tests test_imul:
https://github.com/python/cpython/blob/1e73dbbc29c96d0739ffef92db36f63aa1aa30da/Lib/test/list_tests.py#L550

--
components: Tests
messages: 290550
nosy: Jim Fasarakis-Hilliard
priority: normal
severity: normal
status: open
title: Overlapping tests between list_tests and seq_tests
type: behavior

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29910] Ctrl-D eats a character on IDLE

[Terry J. Reedy]

Terry J. Reedy added the comment:

Checking, I see that the default ^D binding to DEL is documented in IDLE Help, 
section 2, Editing and Navigation, along with other Text defaults.  (I need to 
determine if the list is complete.  Is it the same on all systems?)  

I question whether IDLE should allow these to be changed, or whether at least 
some should be fixed.  The information should certainly be made available 
somehow in the key customization UI. The UI should inform users when a proposed 
customization creates a conflict with existing bindings.  (This last is more or 
less covered by other issues.)

In Shell, ^D is treated as EOF and closes the window (but not IDLE if another 
window is open), even (recently) on Windows.

> Ctrl-D is binded to commenting out a block in IDLE.

This is only true in the IDLE Modern UNIX binding that you wrote for 3.6 (and 
possibly in user customizations).  All other builtin bindings use Alt-3 for 
'comment-region'.  If I had noticed the conflict before pushing, I would have 
brought it up.  Too late.

As for the patch.  Adding "return 'break'" in general looks good, but I have 
not checked each case yet.  (Not having side by side diffs as with Rietveld 
makes this much harder.)  In some places, you add "return None" instead.  I am 
not sure why the difference.  If there is a masked binding, having 'key-x' do 
one thing sometimes and something else other times would seem disconcerting. 

Removing "assertIsNone()" in test_parenmatch.py appears valid 
since the assert did not really test much for calls that always returned None 
(and now always 'break').  Improving that test file would be a new issue.

Testing the change in wrapper functions of the form
def xyz_event(event):
xyz()
return 'break'
will be easy: check that a mock xyz is called and that the wrapper returns 
'break'.  Testing xyz itself can be deferred.  Testing event handlers that do 
the work internally, as in (un)comment_region_event, will require some fixture 
setup.  As before, I expect to work on adding tests.

Since idelib essentially identical in 3.6 and 3.7, I think your original 
cherry-pick 3.6 tag was correct in that the patch should work as is.  It would 
have to be changed at least as far as file names is concerned for other 
versions, but since the Modern Unix keyset and associated changes were new in 
3.6 and not backported, I am not inclined to backport this either.

--
stage: patch review -> test needed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19824] string.Template: Add PHP-style variable expansion example

[Barry A. Warsaw]

Barry A. Warsaw added the comment:

We should really restructure string.Template documentation to emphasize i18n.  
That's always been its prime use case, and f-strings don't change that (because 
f-strings are not really appropriate for translations).  Before f-strings, 
string.Template had other common uses. But f-strings do fulfill most other 
cases where people were using string.Template, so let's make sure that 
distinction is clear to people.

--
status: pending -> open

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19824] string.Template: Add PHP-style variable expansion example

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Formatting with locals() and globals() should be used with careful. This is not 
the most idiomatic way of formatting. I think that the post in specialised blog 
would be better place for describing it than Python stdlib documentation.

Peoples coming from PHP world can use f-strings.

--
nosy: +serhiy.storchaka
status: open -> pending

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue12414] getsizeof() on code objects is wrong

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

See gettotalsizeof.py attached to issue19048. It contains two functions that 
calculates the total size of the object with subobjects recursively. The 
problem is that virtually all objects are linked, two functions use slightly 
different criteria for stopping.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29908] Inconsistent crashing with an access violation

[Cameron Mckain]

Cameron Mckain added the comment:

C:\Users\cmcka\PycharmProjects\test>wevtutil qe application /rd:true /c:1 
/format:text /q:"*[System[Provider[@Name='Application 
Error']]][EventData[Data='python.exe'][Data='ucrtbase.dll']]"
Event[0]:
  Log Name: Application
  Source: Application Error
  Date: 2017-03-26T01:46:20.230
  Event ID: 1000
  Task: Application Crashing Events
  Level: Error
  Opcode: Info
  Keyword: Classic
  User: N/A
  User Name: N/A
  Computer: CAMERON-OMEN
  Description:
Faulting application name: python.exe, version: 3.6.1150.1013, time stamp: 
0x58d169bd
Faulting module name: ucrtbase.dll, version: 10.0.14393.0, time stamp: 
0x57898db2
Exception code: 0xc005
Fault offset: 0x0003bd9e
Faulting process id: 0x4464
Faulting application start time: 0x01d2a60d6fdf23d2
Faulting application path: C:\Python36\python.exe
Faulting module path: C:\windows\System32\ucrtbase.dll
Report Id: 109058c0-4e02-4bb6-a799-d6a975fe0d6f
Faulting package full name:
Faulting package-relative application ID:

This is from Python's faulthandler as well:
Windows fatal exception: access violation

Thread 0x44b0 (most recent call first):
  File 
"C:\Users\cmcka\AppData\Local\JetBrains\Toolbox\apps\PyCharm-P\ch-0\171.3780.115\helpers\pydev\pydevd.py",
 line 96 in _on_run
  File 
"C:\Users\cmcka\AppData\Local\JetBrains\Toolbox\apps\PyCharm-P\ch-0\171.3780.115\helpers\pydev\_pydevd_bundle\pydevd_comm.py",
 line 291 in run
  File "C:\Python36\lib\threading.py", line 916 in _bootstrap_inner
  File "C:\Python36\lib\threading.py", line 884 in _bootstrap

Thread 0x44ac (most recent call first):
  File 
"C:\Users\cmcka\AppData\Local\JetBrains\Toolbox\apps\PyCharm-P\ch-0\171.3780.115\helpers\pydev\_pydevd_bundle\pydevd_comm.py",
 line 353 in _on_run
  File 
"C:\Users\cmcka\AppData\Local\JetBrains\Toolbox\apps\PyCharm-P\ch-0\171.3780.115\helpers\pydev\_pydevd_bundle\pydevd_comm.py",
 line 291 in run
  File "C:\Python36\lib\threading.py", line 916 in _bootstrap_inner
  File "C:\Python36\lib\threading.py", line 884 in _bootstrap

Thread 0x39d4 (most recent call first):
  File "C:\Python36\lib\threading.py", line 299 in wait
  File "C:\Python36\lib\queue.py", line 173 in get
  File 
"C:\Users\cmcka\AppData\Local\JetBrains\Toolbox\apps\PyCharm-P\ch-0\171.3780.115\helpers\pydev\_pydevd_bundle\pydevd_comm.py",
 line 430 in _on_run
  File 
"C:\Users\cmcka\AppData\Local\JetBrains\Toolbox\apps\PyCharm-P\ch-0\171.3780.115\helpers\pydev\_pydevd_bundle\pydevd_comm.py",
 line 291 in run
  File "C:\Python36\lib\threading.py", line 916 in _bootstrap_inner
  File "C:\Python36\lib\threading.py", line 884 in _bootstrap

Current thread 0x446c (most recent call first):
  File 
"C:\Users\cmcka\AppData\Local\JetBrains\Toolbox\apps\PyCharm-P\ch-0\171.3780.115\helpers\pydev\_pydev_bundle\pydev_monkey.py",
 line 380 in new_spawnve
  File "C:\Python36\lib\site-packages\django\utils\autoreload.py", line 290 in 
restart_with_reloader
  File "C:\Python36\lib\site-packages\django\utils\autoreload.py", line 304 in 
python_reloader
  File "C:\Python36\lib\site-packages\django\utils\autoreload.py", line 333 in 
main
  File 
"C:\Python36\lib\site-packages\django\core\management\commands\runserver.py", 
line 106 in run
  File 
"C:\Python36\lib\site-packages\django\core\management\commands\runserver.py", 
line 97 in handle
  File "C:\Python36\lib\site-packages\django\core\management\base.py", line 345 
in execute
  File 
"C:\Python36\lib\site-packages\django\core\management\commands\runserver.py", 
line 58 in execute
  File "C:\Python36\lib\site-packages\django\core\management\base.py", line 294 
in run_from_argv
  File "C:\Python36\lib\site-packages\django\core\management\__init__.py", line 
359 in execute
  File "C:\Python36\lib\site-packages\django\core\management\__init__.py", line 
367 in execute_from_command_line
  File "C:/Users/cmcka/PycharmProjects/test/manage.py", line 22 in 
  File 
"C:\Users\cmcka\AppData\Local\JetBrains\Toolbox\apps\PyCharm-P\ch-0\171.3780.115\helpers\pydev\_pydev_imps\_pydev_execfile.py",
 line 18 in execfile
  File 
"C:\Users\cmcka\AppData\Local\JetBrains\Toolbox\apps\PyCharm-P\ch-0\171.3780.115\helpers\pydev\pydevd.py",
 line 1015 in run
  File 
"C:\Users\cmcka\AppData\Local\JetBrains\Toolbox\apps\PyCharm-P\ch-0\171.3780.115\helpers\pydev\pydevd.py",
 line 1578 in 

Process finished with exit code -1073741819 (0xC005)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29911] Uninstall command line in Windows registry does not uninstall

[Christian Ullrich]

New submission from Christian Ullrich:

The Windows installation package registers a command line for uninstalling the 
package. Running this command line does not uninstall the package.

The command line ends with "/modify". For uninstallation, it should be 
"/passive /uninstall".

Windows provides for separate command lines for modifying and uninstalling 
packages to be set in the "Uninstall" subkey:

- ModifyPath: Command line for modifying the package
- UninstallString: Command line for removing the package

By setting both keys, the ARP control panel will display separate buttons for 
the two operations.

Having an uninstallation command line that does not do what it says, and in 
fact causes modal UI to be presented, also interferes with automated package 
management.

Ceterum censeo: This bug would have been avoided by using MSI as the 
distribution package format, because "msiexec /qn /x [ProductCode]" would have 
been correct regardless of what the registry says, and even if the registry 
does not say anything because the Uninstall key (as well as the uninstaller 
executable itself) were actually deleted months ago as part of some expired 
user profile. See bug #25166.

--
components: Windows
messages: 290544
nosy: Christian.Ullrich, paul.moore, steve.dower, tim.golden, zach.ware
priority: normal
severity: normal
status: open
title: Uninstall command line in Windows registry does not uninstall
type: behavior
versions: Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29888] The link referring to "Python download page" is broken

[Ned Deily]

Ned Deily added the comment:

Thanks for the pull requests!  I've merged to master, 3.6, and 3.5 and I left a 
comment for the 2.7 PR.  By the way, next time you make a PR, please feel free 
to add your name to Misc/ACKS.

--
stage:  -> commit review
versions: +Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29888] The link referring to "Python download page" is broken

[Ned Deily]

Ned Deily added the comment:


New changeset 8ce3085bf167b702989a9db466078b5676e825e3 by Ned Deily in branch 
'3.5':
bpo-29888: Fix the link referring to the "Python download page" (GH-824) 
(GH-827)
https://github.com/python/cpython/commit/8ce3085bf167b702989a9db466078b5676e825e3


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29888] The link referring to "Python download page" is broken

[Ned Deily]

Ned Deily added the comment:


New changeset ceff32fb833e7be42508ffa73344e2e56865e54b by Ned Deily in branch 
'3.6':
bpo-29888: Fix the link referring to the "Python download page" (GH-824) 
(GH-826)
https://github.com/python/cpython/commit/ceff32fb833e7be42508ffa73344e2e56865e54b


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29888] The link referring to "Python download page" is broken

[Ned Deily]

Changes by Ned Deily :


--
pull_requests: +733

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29888] The link referring to "Python download page" is broken

[Ned Deily]

Changes by Ned Deily :


--
pull_requests: +732

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29888] The link referring to "Python download page" is broken

[Ned Deily]

Ned Deily added the comment:


New changeset f8beb9831acd5cf80b9c56aea5864e16118c5400 by Ned Deily (cocoatomo) 
in branch 'master':
bpo-29888: Fix the link referring to the "Python download page" (GH-824)
https://github.com/python/cpython/commit/f8beb9831acd5cf80b9c56aea5864e16118c5400


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29910] Ctrl-D eats a character on IDLE

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


--
pull_requests: +731

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29910] Ctrl-D eats a character on IDLE

[Serhiy Storchaka]

New submission from Serhiy Storchaka:

Ctrl-D is binded to commenting out a block in IDLE. But additionally it deletes 
the first character of the line after the block. The default binding of Ctrl-D 
in Text widget is deleting a character under cursor. IDLE first comment out 
selected block, and after that runs the default handler.

Proposed patch fixes this issue and presumably other potential conflicts with 
default bindings. It just adds `return "break"` at the end of most event 
handlers.

--
assignee: terry.reedy
components: IDLE
messages: 290539
nosy: serhiy.storchaka, terry.reedy
priority: normal
severity: normal
stage: patch review
status: open
title: Ctrl-D eats a character on IDLE
type: behavior
versions: Python 2.7, Python 3.5, Python 3.6, Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29909] types.coroutine monkey patches original function

[Yury Selivanov]

Yury Selivanov added the comment:

Yeah, we can fix this. However, I don't want to push the fix to 3.6, too much 
code uses this function now. So it's going to be 3.7 only.

--
assignee:  -> yselivanov
versions: +Python 3.7 -Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21301] pathlib missing Path.expandvars(env=os.environ)

[Alain Mellan]

Alain Mellan added the comment:

Yes, you can close it.

— alain.

On Mar 25, 2017, at 23:51 , Serhiy Storchaka  wrote:

http://bugs.python.org/issue21301 

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29908] Inconsistent crashing with an access violation

[Eryk Sun]

Eryk Sun added the comment:

The offset in ucrtbase.dll where it's crashing may hint at the culprit. The 
following command should print the full event log for the most recent crash:

wevtutil qe application /rd:true /c:1 /format:text 
/q:"*[System[Provider[@Name='Application 
Error']]][EventData[Data='python.exe'][Data='ucrtbase.dll']]"

--
components: +Windows
nosy: +eryksun, paul.moore, steve.dower, tim.golden, zach.ware
versions: +Python 3.5, Python 3.6, Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue12414] getsizeof() on code objects is wrong

[Raymond Hettinger]

Raymond Hettinger added the comment:

Not including the Python accessible referred-to objects is consistent with how 
sys.getsizeof() works elsewhere (i.e. for object instances, the size of 
__dict__ is not included).

>>> import sys
>>> class A:
pass

>>> a = A()
>>> sys.getsizeof(a)
56
>>> sys.getsizeof(a.__dict__)
112

The result is easily misleading but this seems to have been an early design 
decision about the semanatics __sizeof__.

--
nosy: +pitrou

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18022] Inconsistency between quopri.decodestring() and email.quoprimime.decode()

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Thus currently the table of discrepancies looks as:

   quoprimime  binascii  quopri

 b'='  ''  b''   b'='
 b'= ' ''  b'= ' b'= '
 b'= \n'   ''  b'= \n'   b''
 b'=\r'''  b''   b'=\r'
 b'==41'   '=A'b'=41'b'=41'

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29909] types.coroutine monkey patches original function

[R. David Murray]

R. David Murray added the comment:

Oops, I didn't meant to close this.

--
resolution: not a bug -> 
stage: resolved -> 
status: closed -> open

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29909] types.coroutine monkey patches original function

[R. David Murray]

R. David Murray added the comment:

Yes, that looks wrong to me.  IMO it should be returning a new function object, 
not updating the __code__ of the existing object.  I couldn't figure when that 
is actually triggered, though.  

There are also some other oddnesses, given the definition of 'coroutine' in the 
'types' module docs.  type(x) returns 'coroutine' only when you actually *call* 
the async def function.  I think that's correct, but the docs need rewording.  
However, if I call coroutine on the equivalent non-async-def generator, 
types(x()) returns generator, not coroutine.  So it doesn't seem to be doing 
what it says on the label, at least not in all cases.

--
nosy: +r.david.murray
resolution:  -> not a bug
stage:  -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29888] The link referring to "Python download page" is broken

[Kinebuchi Tomohiko]

Kinebuchi Tomohiko added the comment:

I just created two pull requests.

+ PR for 2.7 -> https://github.com/python/cpython/pull/823
+ PR for 3.5 or newer -> https://github.com/python/cpython/pull/824

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29888] The link referring to "Python download page" is broken

[Kinebuchi Tomohiko]

Changes by Kinebuchi Tomohiko :


--
pull_requests: +730

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27827] pathlib is_reserved fails for some reserved paths on Windows

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Thanks for the estimation Eryk. Can you create a pull request for your patch?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19791] test_pathlib should use can_symlink or skip_unless_symlink from test.support

[ppperry]

Changes by ppperry :


--
pull_requests: +729

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue12414] getsizeof() on code objects is wrong

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

I concur with Martin. sys.getsizeof() should only count the memory that is not 
exposed as separate Python objects. In case of a code object this is the memory 
of the PyCodeObject structure and the memory of dynamic array co_cellvars 
(issue15456). Other subobjects are exposed as code object attributes and by 
gc.get_referents(). For counting the summary size you should recursively call 
sys.getsizeof() for objects returned by gc.get_referents(). But be aware that 
some subobjects (for example interned strings) can be shared between different 
code objects, so the average memory consumption is less than the simple sum.

--
nosy: +serhiy.storchaka

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29907] Unicode encoding failure

[Eryk Sun]

Eryk Sun added the comment:

I'm closing this issue since Python's encodings in this case -- 852 (OEM) and 
1250 (ANSI) -- both correctly map U+0159:

>>> u'\u0159'.encode('852')
'\xfd'
>>> u'\u0159'.encode('1250')
'\xf8'

You must be using an encoding that doesn't map U+0159. If you're using the 
console's default codepage (i.e. you haven't run chcp.com, mode.com, or called 
SetConsoleOutputCP), then Python started with stdout.encoding set to your 
locale's OEM codepage encoding. For example, if you're using a U.S. locale, 
it's cp437, and if you're using a Western Europe locale, it's cp850. Neither of 
these includes U+0159.

We're presented with this codepage hell because the WriteFile and WriteConsoleA 
functions write a stream of bytes to the console, and it needs to be told how 
to decode these bytes to get Unicode text. It would be nice if the console's 
UTF-8 implementation (codepage 65001) wasn't buggy, but Microsoft has never 
cared enough to fix it (at least not completely; it's still broken for input in 
Windows 10). 

That leaves the wide-character UTF-16 function, WriteConsoleW, as the best 
alternative. Using this function requires bypassing Python's normal standard 
I/O implementation. This has been implemented as of 3.6. But for older versions 
you'll need to install and enable win_unicode_console.

--
nosy: +eryksun
stage:  -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8488] Docstrings of non-data descriptors "ignored"

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Since the descriptor is classified as a routine (inspect.isroutine() returns 
True because inspect.ismethoddescriptor() returns True), pydoc outputs it in 
the "Methods defined here" section and uses the docroutine(). But docroutine() 
requires the __name__ attribute for determining whether this is an original 
method or an alias. That descriptor doesn't have the __name__ attribute. 
Actually it is even not callable, so it is questionable whether it can be 
classified as a method.

I don't know on what level this should be fixed. docroutine()? 
classify_class_attrs()? isroutine()? ismethoddescriptor()?

--
nosy: +serhiy.storchaka, yselivanov

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29888] The link referring to "Python download page" is broken

[Kinebuchi Tomohiko]

Changes by Kinebuchi Tomohiko :


--
pull_requests: +728

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27827] pathlib is_reserved fails for some reserved paths on Windows

[Eryk Sun]

Eryk Sun added the comment:

For COM[n] and LPT[n], only ASCII 1-9 and superscript 1-3 (U+00b9, U+00b2, and 
U+00b3) are handled as decimal digits. For example:

>>> print(*(ascii(chr(c)) for c in range(1, 65536)
... if _getfullpathname('COM%s' % chr(c))[0] == '\\'), sep=', ')
'1', '2', '3', '4', '5', '6', '7', '8', '9', '\xb2', '\xb3', '\xb9'

The implementation uses iswdigit in ntdll.dll. (ntdll.dll is the system DLL 
that has the user-mode runtime library and syscall stubs -- except the Win32k 
syscall stubs are in win32u.dll.) ntdll's private CRT uses the C locale 
(Latin-1, not just ASCII), and it classifies these superscript digits as 
decimal digits:

>>> ntdll = ctypes.WinDLL('ntdll')
>>> print(*(chr(c) for c in range(1, 65536) if ntdll.iswdigit(c)))
0 1 2 3 4 5 6 7 8 9 ² ³ ¹

Unicode, and thus Python, does not classify these superscript digits as decimal 
digits, so I just hard-coded the list. 

Here's an example with an attached debugger to show the runtime library calling 
iswdigit:

>>> name = 'COM\u2074'
>>> _getfullpathname(name)

Breakpoint 0 hit
ntdll!iswdigit:
7ffe`9ad89d90 ba0400  mov edx,4
0:000> kc 6
Call Site
ntdll!iswdigit
ntdll!RtlpIsDosDeviceName_Ustr
ntdll!RtlGetFullPathName_Ustr
ntdll!RtlGetFullPathName_UEx
KERNELBASE!GetFullPathNameW
python36_d!os__getfullpathname_impl

The argument is in register rcx:

0:000> r rcx
rcx=2074

Skip to the ret instruction, and check the result in register rax:

0:000> pt
ntdll!iswctype+0x20:
7ffe`9ad89e40 c3  ret
0:000> r rax
rax=
0:000> g

Since U+2074 isn't considered a decimal digit, 'COM⁴' is not a reserved DOS 
device name. The system handles it as a regular filename:

'C:\\Temp\\COM⁴'

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18022] Inconsistency between quopri.decodestring() and email.quoprimime.decode()

[Martin Panter]

Martin Panter added the comment:

The double equals "==" case for the “quopri” implementation in Python is now 
consistent with the others thanks to the fix in Issue 23681 (see also Issue 
21511).

According to Issue 20121, the quopri (Python) implementation only supports LF 
(\n) characters as line breaks, and the binascii (C) implementation also 
supports CRLF. So I agree that the whitespace-before-newline case "= \n" is a 
genuine bug (see Issue 16473). But the CR case "=\r" is not supported because 
neither quopri nor binascii support universal newlines or CR line breaks on 
their own.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1697943] msgfmt cannot cope with BOM

[Christoph Zwerschke]

Christoph Zwerschke added the comment:

> Corresponding GNU gettext issue [1] was closed as "Not a Bug".

Though I think the rationale given there pointing to RFC3629 section 6 is 
wrong, since that section explicitly refers to Internet protocols, but PO files 
are not an Internet protocol.

Anyway, if silently ignoring BOMs is considered a bad idea, then at least there 
should be a more helpful error message. Because the BOM is invisible, users - 
who may not even be aware that something like a BOM exist or that their editor 
saves files with BOM - may be frustrated about the current error message 
because they don't see any invalid character when they open the PO file in 
their editor. A more explicit error message like "PO files should not be saved 
with a byte order mark" might point users in the right direction.

After all, these tools are supposed to be used directly by human beings on the 
command line. Who said that command line tools must not be user friendly?

--
status: pending -> open
versions: +Python 3.4, Python 3.5, Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19791] test_pathlib should use can_symlink or skip_unless_symlink from test.support

[Vajrasky Kok]

Vajrasky Kok added the comment:

Okay, this is the pull request: https://github.com/python/cpython/pull/822

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11989] deprecate shutil.copy2

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


--
status: open -> pending

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22962] ipaddress: Add optional prefixlen argument to ip_interface and ip_network

[Gary van der Merwe]

Gary van der Merwe added the comment:

Indeed. Thanks to whoever fixed this.

--
resolution:  -> fixed
stage:  -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue7913] Enhance Cmd support for docstrings and document it.

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Can you create a pull request David?

--
nosy: +serhiy.storchaka
versions: +Python 3.7 -Python 3.3

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18022] Inconsistency between quopri.decodestring() and email.quoprimime.decode()

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Ping.

--
versions: +Python 3.5, Python 3.6, Python 3.7 -Python 3.3, Python 3.4

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1697943] msgfmt cannot cope with BOM

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Corresponding GNU gettext issue [1] was closed as "Not a Bug".

[1] https://savannah.gnu.org/bugs/?18345

--
nosy: +serhiy.storchaka
resolution:  -> not a bug
status: open -> pending

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29909] types.coroutine monkey patches original function

[Eric Hopper]

New submission from Eric Hopper:

The types.coroutine decorator for Python 3.6 (and I suspect for Python 3.6.1 as 
well) simply monkey patches the function it's passed and then returns it. This 
results in behavior that I found somewhat surprising.

def bar():
   yield 5

foo = types.coroutine(bar)

foo is bar

And, so now both foo and bar are now awaitable. I wasn't really expecting this, 
and while it's minor, it also doesn't really seem like the right thing to do.

--
components: asyncio
messages: 290518
nosy: Omnifarious, yselivanov
priority: normal
severity: normal
status: open
title: types.coroutine monkey patches original function
type: behavior
versions: Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29907] Unicode encoding failure

[STINNER Victor]

STINNER Victor added the comment:

For Python 2, there is https://pypi.python.org/pypi/win_unicode_console

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27200] make doctest in CPython has failures

[Marco Buttu]

Changes by Marco Buttu :


--
pull_requests: +727

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29899] zlib missing when --enable--optimizations option appended

[kyren]

kyren added the comment:

There's no build errors. The compiling and installing process is error-free. 
Take 3.5.3 as example, it's all good until you enter 3.5.3 python shell and 
type `import zlib`, it gives `No module name zlib`. I solved by make a 
`libz.so` link in my `/lib` dir to the `libz.so.1` file in my 
`/lib/x86_64-linux-gnu` dir according to a thread in Ubuntu forum. It may be 
system specific, I don't know yet.

--
nosy: +kyren

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27827] pathlib is_reserved fails for some reserved paths on Windows

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Are 'COM\u0661' or 'COM\u2074' reserved names?

--
nosy: +serhiy.storchaka

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19791] test_pathlib should use can_symlink or skip_unless_symlink from test.support

[Vajrasky Kok]

Vajrasky Kok added the comment:

Okay, Serhiy. I'll create a pull request.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29888] The link referring to "Python download page" is broken

[Kinebuchi Tomohiko]

Changes by Kinebuchi Tomohiko :


--
pull_requests: +726

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29907] Unicode encoding failure

[Paul Moore]

Paul Moore added the comment:

Also, you need to:

1. Ensure you are using characters that are available in the encoding that 
sys.stdout uses - in Python prior to 3.6, this would be your Windows *console* 
code page, and in 3.6+ would be UTF-8.
2. Declare the encoding of your source code if you are not using the default 
(which is ASCII in Python 2, and UTF-8 in Python 3).

Specifically, if you write your source in UTF-8, or use an encoding declaration 
or \u escapes, and you use Python 3.6, this problem will likely have gone away.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19791] test_pathlib should use can_symlink or skip_unless_symlink from test.support

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Can you create a pull request on GitHub Vajrasky?

--
nosy: +serhiy.storchaka

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22062] Fix pathlib.Path.(r)glob doc glitches.

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Can you create a pull request on GitHub Mike?

--
nosy: +serhiy.storchaka

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com