[issue31401] Dynamic compilation that uses function in comprehension fails when compiled inside function

[Vedran Čačić]

Vedran Čačić added the comment:

Hm... then it _is_ a bug (in 3.7). Or we have "fast locals and slow locals" 
nightmare again... :-/

I don't have 3.7 to test... what do you mean is working? jpc's example or mine?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31417] Use the enumerate function where appropriate

[Vedran Čačić]

Vedran Čačić added the comment:

Sorry, this seems like a classical example of "When all you have is a hammer, 
everything looks like a nail. Then, when you learn of a screwdriver, you 
suddenly see half of these nails as screws, completely ignoring there are other 
tools besides those two."

In fact, enumerate is _not_ the good choice in most of those cases, as the 
comments show. One should use zip, another should use ordinary iteration 
because the index isn't needed at all, and yet another should probably stay as 
it is, since that way it's more obvious that we're transforming each item in 
place. [When LHS is consts[i] and right is const, it's not easy to see they 
refer to the same place.]

Even the fourth I would argue is more readable in the current form, for a 
similar reason: when you base the decision on words[i], and the decision is to 
del words[i:], it's obvious you delete "it and everything after". Not so much 
in the "refactored" code.

Please don't do such things. One of Python's great strengths, especially in 
stdlib, is code stability. The only reason we're able to get anything done is 
that we have (or at least used to have) a great policy referred to in 
https://bugs.python.org/issue31417#msg301879, so we don't lose ourselves in 
enormous bikeshedding about how to best use the enormous expressivity of Python 
to write the code that works perfectly fine in some slightly different way.

--
nosy: +veky

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26103] Contradiction in definition of "data descriptor" between (dotted lookup behavior/datamodel documentation) and (inspect lib/descriptor how-to)

[Raymond Hettinger]

Changes by Raymond Hettinger :


--
assignee: rhettinger -> 

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16251] pickle special methods are looked up on the instance rather than the type

[Łukasz Langa]

Changes by Łukasz Langa :


--
keywords: +patch
pull_requests: +3503
stage: needs patch -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31404] undefined behavior and crashes in case of a bad sys.modules

[Eric Snow]

Eric Snow added the comment:

This is pretty messy. :(  Ideally we would disallow setting sys.modules to 
anything except a dict (or perhaps any mapping).  However, we don't have that 
option currently (see 
https://github.com/ericsnowcurrently/cpython/tree/sys-module).  In the meantime 
we have to fix up all the places that are expecting a mapping.

Part of the problem here is that a number of places fail silently, as evidenced 
by the failures Oren pointed out...

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31417] Use the enumerate function where appropriate

[R. David Murray]

R. David Murray added the comment:

Mark: Yeah, I think my comment was directed more to haypo than you :)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30860] Consolidate stateful C globals under a single struct.

[Eric Snow]

Eric Snow added the comment:


New changeset fc1bf872e9d31f3e837f686210f94e57ad3d6582 by Eric Snow in branch 
'master':
bpo-30860: Move windows.h include out of internal/*.h. (#3458)
https://github.com/python/cpython/commit/fc1bf872e9d31f3e837f686210f94e57ad3d6582


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31265] Remove doubly-linked list from C OrderedDict

[Eric Snow]

Eric Snow added the comment:

On Sun, Sep 10, 2017 at 10:27 PM, Serhiy Storchaka
 wrote:
> Note that mixed insertion and deletion is worst-case O(n) in current 
> implementation.

Could you elaborate?  Note that every operation of the current
implementation matches the complexity of the Python implementation.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29505] Submit the re, json, & csv modules to oss-fuzz testing

[R. David Murray]

R. David Murray added the comment:

Seems like it ought to be possible to use the same hooks that venv uses to make 
this work, but I haven't looked at the details of how those work.

--
nosy: +r.david.murray

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31420] Reference leaks introduced by bpo-30860

[Eric Snow]

Changes by Eric Snow :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30860] Consolidate stateful C globals under a single struct.

[STINNER Victor]

STINNER Victor added the comment:


New changeset 8728018624f257c7cfe44014742ae46134047f49 by Victor Stinner (Eric 
Snow) in branch 'master':
bpo-30860: Fix a refleak. (#3506)
https://github.com/python/cpython/commit/8728018624f257c7cfe44014742ae46134047f49


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1612262] Class Browser doesn't show internal classes

[Terry J. Reedy]

Terry J. Reedy added the comment:

Would it make any difference if the module were renamed? and made to only work 
with IDLE?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1612262] Class Browser doesn't show internal classes

[Terry J. Reedy]

Terry J. Reedy added the comment:

Nick, this over-due improvement to IDLE depends on the over-due improvement to 
pyclbr in 3.7.  I would like to backport the IDLE improvement by putting a copy 
of 3.7 pyclbr in 3.6 idlelib.  Do you agree that PEP434 allows this?

--
nosy: +ncoghlan

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31407] --without-pymalloc broken

[Eric Snow]

Eric Snow added the comment:


New changeset ba6d5d1defd7a281c8c8804e4b4cfd7370886236 by Eric Snow in branch 
'master':
bpo-30860: Always provide serialno. (#3507)
https://github.com/python/cpython/commit/ba6d5d1defd7a281c8c8804e4b4cfd7370886236


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31407] --without-pymalloc broken

[Eric Snow]

Changes by Eric Snow :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30860] Consolidate stateful C globals under a single struct.

[Eric Snow]

Eric Snow added the comment:


New changeset ba6d5d1defd7a281c8c8804e4b4cfd7370886236 by Eric Snow in branch 
'master':
bpo-30860: Always provide serialno. (#3507)
https://github.com/python/cpython/commit/ba6d5d1defd7a281c8c8804e4b4cfd7370886236


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31404] undefined behavior and crashes in case of a bad sys.modules

[Eric Snow]

Eric Snow added the comment:

I'm looking into this.

--
assignee:  -> eric.snow

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31407] --without-pymalloc broken

[Eric Snow]

Eric Snow added the comment:

I've verified that the PR fixes the problem.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31407] --without-pymalloc broken

[Eric Snow]

Changes by Eric Snow :


--
keywords: +patch
pull_requests: +3502
stage: needs patch -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30860] Consolidate stateful C globals under a single struct.

[Eric Snow]

Changes by Eric Snow :


--
pull_requests: +3501

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31407] --without-pymalloc broken

[Eric Snow]

Eric Snow added the comment:

I'm looking into this.

--
assignee:  -> eric.snow

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31408] Leak in typeobject.c

[Eric Snow]

Eric Snow added the comment:

@skrah, could you see if the PR for issue #31420 resolves this?  I'm guessing 
it won't, but you indicated that the two issues might be related.  Thanks!

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31420] Reference leaks introduced by bpo-30860

[Eric Snow]

Changes by Eric Snow :


--
keywords: +patch
pull_requests: +3500
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30860] Consolidate stateful C globals under a single struct.

[Eric Snow]

Changes by Eric Snow :


--
pull_requests: +3499

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29505] Submit the re, json, & csv modules to oss-fuzz testing

[Devin Jeanpierre]

Devin Jeanpierre added the comment:

Oops, so it is. I can't read apparently.

I'll spend my time on making more fuzz tests in the meantime.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31417] Use the enumerate function where appropriate

[Mark Byrne]

Mark Byrne added the comment:

Generally, we consider the danger of introducing bugs to be more significant 
than the benefit of the "cleanup" changes.  The fact that you are discussing 
further changes to the code in the PR make this more likely.

I haven't updated the PR with further code changes as suggested in the PR 
comments because the comments don't strictly relate to the changes put forward 
in this issue, and I don't want to go beyond the scope of the issue - the 
requested changes could go in a separate PR as needed.

The motivation is to use enumerate where it is a natural fit.
If you decide not to merge, then that is ok; let me know if I can help with 
anything.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17085] test_socket crashes the whole test suite

[STINNER Victor]

STINNER Victor added the comment:

I believe that my commit 40996d3f6fbd1adcb2e69e426fa311aaf90762ff fixes the 
root issue in Python 2.7 and so I close the issue. Thanks for the bug report!

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17085] test_socket crashes the whole test suite

[STINNER Victor]

STINNER Victor added the comment:


New changeset 40996d3f6fbd1adcb2e69e426fa311aaf90762ff by Victor Stinner in 
branch '2.7':
bpo-17085: test_socket: cancel scheduled alarm on test failure (#3505)
https://github.com/python/cpython/commit/40996d3f6fbd1adcb2e69e426fa311aaf90762ff


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29505] Submit the re, json, & csv modules to oss-fuzz testing

[Gregory P. Smith]

Gregory P. Smith added the comment:

misquote.  that was me objecting to running it internally. :)

i believe this is solvable, i haven't had time to spend on this part yet.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31425] Expose AF_QIPCRTR in socket module

[Bjorn Andersson]

New submission from Bjorn Andersson:

The address family AF_QIPCRTR represents a socket based communication 
mechanism, available since Linux v4.7, for communicating with services running 
on co-processors in Qualcomm based platforms; e.g. the modem services.

Expose this address family in the socket module to allow python access to this 
interface.

--
components: Extension Modules
messages: 301917
nosy: Bjorn Andersson
priority: normal
severity: normal
status: open
title: Expose AF_QIPCRTR in socket module
type: enhancement
versions: Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24725] test_socket testFDPassEmpty fails on OS X 10.11+ with "Cannot allocate memory"

[STINNER Victor]

STINNER Victor added the comment:

Ned Deily:
> This issue slipped off the radar (so to speak) after being closed.  For one, 
> the tests also fail on 3.5.x (and probably earlier systems) and fail on macOS 
> 10.12, not just 10.11.  And, two, I'm not sure if anyone opened an issue with 
> Apple about it.  I'm re-opening it and assigning it to me to address those 
> things.

Did you report the bug to Apple? Any update? Should we just close the issue?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31022] ERROR: testRegularFile (test.test_socket.SendfileUsingSendTest) random failure on AppVeyor

[STINNER Victor]

STINNER Victor added the comment:

I didn't see this issue recently, but I didn't check much Appveyor. Let's hope 
that the bug was fixed in the meanwhile. I will reopen the issue if the bug 
comes back.

--
resolution:  -> out of date
stage:  -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29269] test_socket failing in solaris

[STINNER Victor]

STINNER Victor added the comment:

Since it seems like Solaris is dying, I'm not sure that it still makes sense to 
fix Python issues specific to Solaris. Here, I don't understand the issue, no 
patch is proposed and I'm not really interested to investigate :-/

--
nosy: +haypo

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17085] test_socket crashes the whole test suite

[STINNER Victor]

STINNER Victor added the comment:

Charles-François Natali:
> the crash occurs because the test doesn't reset the alarm (with alarm(0)) 
> upon exit, so if the alarm didn't go off during the test, it comes later when 
> the original signal handler has been reset, and the default handler just 
> exits.
> (...)
> Note that 3.4 and default aren't affected, because the alarm is properly 
> reset.

Right, I fixed this issue in the master branch: I proposed attached PR 3505 to 
backport the fix.

--
nosy: +haypo

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17085] test_socket crashes the whole test suite

[STINNER Victor]

Changes by STINNER Victor :


--
pull_requests: +3498

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23669] test_socket.NonBlockingTCPTests failing due to race condition

[STINNER Victor]

STINNER Victor added the comment:

I didn't see this message last 6 months even if we now have a long list of 
Windows buildbots. So I consider that the bug was fixed in the meanwhile.

--
nosy: +haypo
resolution:  -> fixed
stage:  -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30928] Copy modified blurbs to idlelib/NEWS.txt

[Terry J. Reedy]

Terry J. Reedy added the comment:

Making the upper merge context be

"


" (a line of equals and 2 blanks) has worked great to eliminate backport merge 
conflicts.)

--
stage: patch review -> needs patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30928] Copy modified blurbs to idlelib/NEWS.txt

[Terry J. Reedy]

Terry J. Reedy added the comment:


New changeset 99b941b420d63027654dc6722f1648a8f36d2925 by Terry Jan Reedy (Miss 
Islington (bot)) in branch '3.6':
[3.6] bpo-30928: Update idlelib/NEWS.txt to 2017-09-11. (GH-3503) (#3504)
https://github.com/python/cpython/commit/99b941b420d63027654dc6722f1648a8f36d2925


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31424] test_socket hangs on x86 Gentoo Installed with X 3.x

[STINNER Victor]

STINNER Victor added the comment:

The failing build was triggered by the commit 
834a5cecac0e77e907762611c06fa460545487e7. Maybe it's related?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29767] build python failed on test_socket due to unused_port is actually used.

[STINNER Victor]

STINNER Victor added the comment:

I am sorry but it is not possible to fix the issue since we don't have enough 
information to identify or reproduce the bug.

--
nosy: +haypo
resolution:  -> out of date
stage:  -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31424] test_socket hangs on x86 Gentoo Installed with X 3.x

[STINNER Victor]

New submission from STINNER Victor:

http://buildbot.python.org/all/builders/x86%20Gentoo%20Installed%20with%20X%203.x/builds/1004/steps/test/logs/stdio

...
running: test_socket (35311 sec)
running: test_socket (35341 sec)
running: test_socket (35371 sec)
running: test_socket (35401 sec)
running: test_socket (35431 sec)
running: test_socket (35461 sec)
9:54:31 load avg: 2.86 [405/405] test_socket interrupted
sys:1: ResourceWarning: unclosed 

Zachary Ware killed the test_socket process manually, he owns the buildbot and 
so has access to it.

--
components: Tests
keywords: buildbot
messages: 301907
nosy: haypo
priority: normal
severity: normal
status: open
title: test_socket hangs on x86 Gentoo Installed with X 3.x
versions: Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31420] Reference leaks introduced by bpo-30860

[Eric Snow]

Eric Snow added the comment:

Moving warnoptions (and xoptions) out of PyInterpreterState seems like a good 
idea to me for the same reasons as applied to sys.modules.  The case for these 
two is even stronger since they are only used in sysmodule.c.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31417] Use the enumerate function where appropriate

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

I concur with David in general. And as you can see there are questions to the 
concrete patch.

--
nosy: +serhiy.storchaka

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31420] Reference leaks introduced by bpo-30860

[Eric Snow]

Changes by Eric Snow :


--
assignee:  -> eric.snow

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31420] Reference leaks introduced by bpo-30860

[Eric Snow]

Eric Snow added the comment:

I'm looking into this.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31416] assertion failures in warn_explicit() in case of a bad warnings.filters or warnings.defaultaction

[Serhiy Storchaka]

Serhiy Storchaka added the comment:


New changeset 9d984fd2b097c8c29479d1c3eb740995fe1ccb0d by Serhiy Storchaka 
(Oren Milman) in branch 'master':
bpo-31416: Fix assertion failures in case of a bad warnings.filters or 
warnings.defaultaction. (#3496)
https://github.com/python/cpython/commit/9d984fd2b097c8c29479d1c3eb740995fe1ccb0d


--
nosy: +serhiy.storchaka

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25218] Automate creation of idlelib/help.html from Doc/.../idle.html

[Terry J. Reedy]

Terry J. Reedy added the comment:

Zach, I currently build idlelib/help.html by first building a complete doc set 
and then copying from Doc/.../idle.html, stripping trailing whitespace on the 
say.  One problem is that the result has a lot of extraneous stuff aside from 
the doc text itself: the code for the header, sidebar, and footer. These are a 
nuisance when committing changes and for extracting just the text we want.

I would prefer to create a clean .html from Doc/library/idle.rst that just has 
the code for the doc, without the extraneous matter.  Do you know how?  I 
looked in Doc/make.bat and it says it will not work on single files.

--
versions: +Python 3.7 -Python 2.7, Python 3.4, Python 3.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29505] Submit the re, json, & csv modules to oss-fuzz testing

[Devin Jeanpierre]

Devin Jeanpierre added the comment:

kcc strongly disagrees though. Copying latest comment:

"""
fwiw - I object to us running any of this internally at Google. We need to be 
part of the main oss-fuzz project pulling from upstream revisions. Doing this 
testing within our blackhole of internal stuff adds more work for us internally 
(read: which we're not going to do) and wouldn't provide results feedback to 
the upstream CPython project in a useful timely manner.

We must figure out how to get this to build and run on the external oss-fuzz 
infrastructure
"""

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31413] Support importing anything in ._pth files.

[Steve Dower]

Steve Dower added the comment:

This is by design. You should not be using the ._pth file for anything other 
than initializing sys.path.

If you want to run code at startup, consider using sitecustomize.py or a 
regular .pth file, all of which will be imported when you include "import site" 
in the ._pth file.

--
resolution:  -> not a bug
stage:  -> resolved
status: open -> closed
type: crash -> behavior

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31420] Reference leaks introduced by bpo-30860

[Eric Snow]

Changes by Eric Snow :


--
nosy: +eric.snow

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30928] Copy modified blurbs to idlelib/NEWS.txt

[Roundup Robot]

Changes by Roundup Robot :


--
pull_requests: +3497

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30928] Copy modified blurbs to idlelib/NEWS.txt

[Terry J. Reedy]

Terry J. Reedy added the comment:


New changeset 8239fd704637d7cbf59273883fbe487fc0f568fc by Terry Jan Reedy in 
branch 'master':
bpo-30928: Update idlelib/NEWS.txt to 2017-09-11. (#3503)
https://github.com/python/cpython/commit/8239fd704637d7cbf59273883fbe487fc0f568fc


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31414] IDLE: Entry tests should delete before insert.

[Terry J. Reedy]

Terry J. Reedy added the comment:


New changeset 31b242459cef0835057f08c8756559b3261aa8ff by Terry Jan Reedy (Miss 
Islington (bot)) in branch '3.6':
[3.6] bpo-31414: IDLE -- fix tk entry box tests by deleting first. (GH-3501) 
(#3502)
https://github.com/python/cpython/commit/31b242459cef0835057f08c8756559b3261aa8ff


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30928] Copy modified blurbs to idlelib/NEWS.txt

[Terry J. Reedy]

Changes by Terry J. Reedy :


--
keywords: +patch
pull_requests: +3496
stage: needs patch -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29505] Submit the re, json, & csv modules to oss-fuzz testing

[Devin Jeanpierre]

Devin Jeanpierre added the comment:

> i'd rather make this work in oss-fuzz on cpython.  can you point me to how 
> oss-fuzz works and what it wants to do so i can better understand what it 
> needs?

I don't have any details except for what's in the PR to oss-fuzz 
(https://github.com/google/oss-fuzz/pull/731)  My understanding is matches what 
you've said so far:

Python is built to one directory (/out/), but then needs to be run from another 
directory (/out/ is renamed to /foo/bar/baz/out/). We need python to still 
work. I have no idea how to do this.

The only suggestion on #python-dev IRC was to statically link a libpython.a, 
but this doesn't avoid needing to import libraries like "encodings" 
dynamically, so they still need to be locatable on disk.

Is there a way to build python so that it doesn't use absolute paths to 
everything, and so that the install can be moved at will? Or is there a way to 
tell it that it was moved at runtime? (I am unconvinced PYTHONPATH is a 
maintainable solution, if it works at all...)


oss-fuzz is not going to change away from its model (I asked if they could, 
they said no), so we're stuck with making Python compatible with it one way or 
another.  This is why I am so drawn to running the test internally on Google's 
infrastructure anyway: we already _did_ all this work already, via hermetic 
python. Doing it a second time, but worse, seems annoying.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31414] IDLE: Entry tests should delete before insert.

[Roundup Robot]

Changes by Roundup Robot :


--
pull_requests: +3495

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31414] IDLE: Entry tests should delete before insert.

[Terry J. Reedy]

Terry J. Reedy added the comment:


New changeset 667522efa8fedfb57fd89d7335d7dfd270f274d5 by Terry Jan Reedy in 
branch 'master':
bpo-31414: IDLE -- fix tk entry box tests by deleting first. (#3501)
https://github.com/python/cpython/commit/667522efa8fedfb57fd89d7335d7dfd270f274d5


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31423] Error while building PDF documentation

[Julien Palard]

New submission from Julien Palard:

Since the docsbuild-scripts [1] upgraded its sphinx-build [2], we're having 
this error when building the docs:

! Undefined control sequence.
\py@authoraddress -> \strong

{Python Software Foundation}\\ Email: \email {d...
l.58 \sphinxtableofcontents
   
!  ==> Fatal error occurred, no output PDF file produced!


it looks like to be from conf.py line 97 [3]:

conf.py-95-# Additional stuff for the LaTeX preamble.
conf.py-96-latex_elements['preamble'] = r'''
conf.py:97:\authoraddress{
conf.py-98-  \strong{Python Software Foundation}\\
conf.py-99-  Email: \email{d...@python.org}
conf.py-100-}


 [1]: https://github.com/python/docsbuild-scripts 
 [2]: we merged https://github.com/python/docsbuild-scripts/pull/12
 [3]: 
https://github.com/python/cpython/blob/909a6f626ff343937cd3f06fda996870e7890724/Doc/conf.py#L97

--
assignee: docs@python
components: Documentation
messages: 301895
nosy: docs@python, mdk
priority: normal
severity: normal
status: open
title: Error while building PDF documentation
versions: Python 2.7, Python 3.6, Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31414] IDLE: Entry tests should delete before insert.

[Terry J. Reedy]

Changes by Terry J. Reedy :


--
keywords: +patch
pull_requests: +3494
stage: needs patch -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31417] Use the enumerate function where appropriate

[R. David Murray]

R. David Murray added the comment:

Anyone who uses stdlib code as examples of best practice doesn't understand the 
history of stdlib code.

Generally, we consider the danger of introducing bugs to be more significant 
than the benefit of the "cleanup" changes.  The fact that you are discussing 
further changes to the code in the PR make this more likely.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31422] tkinter.messagebox and tkinter.filedialog don't show default button's keyboard shortcuts

[jcrmatos]

New submission from jcrmatos:

tkinter.messagebox windows (eg. askokcancel, showerror, showinfo, ...) in 
Tkinter 8.6 running on Python 3.5.3, don't don't show the keyboard 
shortcuts/accelerators in the default buttons.

And the askopenfilename from tkinter.filedialog only shows the Open one. The 
Cancel does not appear and does not work.

I'm using it under Windows 7 Pro.

--
components: Tkinter
messages: 301893
nosy: jcrmatos
priority: normal
severity: normal
status: open
title: tkinter.messagebox and tkinter.filedialog don't show default button's 
keyboard shortcuts
type: behavior
versions: Python 3.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30389] distutils._msvccompiler cannot find VS 2017

[STINNER Victor]

STINNER Victor added the comment:

The fix:

commit af8d6b90723daa943c5cd0a38ee7564790d8687a
Author: Steve Dower 
Date:   Fri Sep 8 11:35:38 2017 -0700

Fixes reference leak (#3457)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31420] Reference leaks introduced by bpo-30860

[STINNER Victor]

STINNER Victor added the comment:

Extract of my msg295399: "The problem is that warnoptions is stored in a C 
global variable *and* in sys.warnoptions of each interpreter. The ownership of 
this variable is unclear."

Maybe we need a change similar to bpo-28411 (commit 
86b7afdfeee77993fe896a2aa13b3f4f95973f16) which removed the "modules" field 
from Py_InterpreterState.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30598] Py_NewInterpreter() leaks a reference on warnoptions in _PySys_EndInit()

[STINNER Victor]

STINNER Victor added the comment:

This bug came back in master: see bpo-31420.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31414] IDLE: Entry tests should delete before insert.

[Henk-Jaap Wagenaar]

Changes by Henk-Jaap Wagenaar :


--
nosy:  -Henk-Jaap Wagenaar

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31420] Reference leaks introduced by bpo-30860

[STINNER Victor]

STINNER Victor added the comment:

The leak comes from the following lines of _PySys_EndInit():
---
PyObject *warnoptions = get_warnoptions();
if (warnoptions == NULL)
return -1;
SET_SYS_FROM_STRING_BORROW_INT_RESULT("warnoptions", warnoptions);

PyObject *xoptions = get_xoptions();
if (xoptions == NULL)
return -1;
SET_SYS_FROM_STRING_BORROW_INT_RESULT("_xoptions", xoptions);
---

It's not the first time that I have an issue with these attributes. The last 
reference weak caused by multiple interpreters was also related to this one if 
I recall correctly.

See bpo-30598 and my commit 865de27dd79571a4a5c7a7d22a07fb909c4a9f8e.

--
nosy: +eric.smith, ncoghlan

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31421] IDLE doc: add section on developing tkinter apps.

[Henk-Jaap Wagenaar]

Changes by Henk-Jaap Wagenaar :


--
nosy: +Henk-Jaap Wagenaar

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31414] IDLE: Entry tests should delete before insert.

[Henk-Jaap Wagenaar]

Changes by Henk-Jaap Wagenaar :


--
nosy: +Henk-Jaap Wagenaar

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31421] IDLE doc: add section on developing tkinter apps.

[Terry J. Reedy]

Changes by Terry J. Reedy :


--
assignee: docs@python -> terry.reedy

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31421] IDLE doc: add section on developing tkinter apps.

[Terry J. Reedy]

New submission from Terry J. Reedy:

One of IDLE's great features is being able to interactively work with tkinter 
gui's because run calls update, without blocking, in the background. Document 
it in a new subsection, '3.5 Developing tkinter applications'.

Adapt the following (written for a python-list response):

Mainloop is a blocking call, and while it is running, one can only interact 
with the data and gui in ways that one has already programmed.  If you run the 
above with python -i, or equivalently, from an IDLE editor, you will not see a 
>>> prompt until you close the tk windows, at which point there is nothing left 
to interact with.

However, if you run the code above from an IDLE editor, you can omit or comment 
out the mainloop call and still see the board, because IDLE's run code calls 
tk's update in a non-blocking manner about 20 times a second.  Without mainloop 
running, you immediately get a >>> prompt and can interact with the gui in a 
live exploratory fashion.  You can enter statements like the color assignment 
above, and the background updates will make them quickly take effect.

--
assignee: docs@python
components: Documentation, IDLE
messages: 301888
nosy: docs@python, terry.reedy
priority: normal
severity: normal
stage: needs patch
status: open
title: IDLE doc: add section on developing tkinter apps.
type: enhancement
versions: Python 3.6, Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31421] IDLE doc: add section on developing tkinter apps.

[Terry J. Reedy]

Changes by Terry J. Reedy :


--
components:  -Documentation

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31336] Speed up _PyType_Lookup() for class creation

[STINNER Victor]

STINNER Victor added the comment:

Serhiy on the PR: "This is overgeneralization. Can tp_dict be not exact dict at 
all? I don't think this is possible. In many places concrete dict API is used 
with tp_dict. If you want to allow tp_dict be not exact dict, please open a 
separate issue for this."

Using the following code, A.__dict__ type is dict even if the metaclass creates 
a different type, probably because type_new() calls PyDict_Copy(orig_dict):
---
class mydict(dict):
def __setitem__(self, name, value):
if name == "__module__":
value = ""
super().__setitem__(name, value)

class MetaClass(type):
@classmethod
def __prepare__(mcl, name, bases):
return mydict()

class A(metaclass=MetaClass):
pass

print(A.__module__)
---

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31420] Reference leaks introduced by bpo-30860

[Stefan Krah]

Stefan Krah added the comment:

Could be the same as #31408.

--
nosy: +skrah

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30860] Consolidate stateful C globals under a single struct.

[STINNER Victor]

STINNER Victor added the comment:


New changeset 4866957e86594935ec2e6434b6e470ebeb0c79b4 by Victor Stinner in 
branch 'master':
bpo-30860: Add Include/internal/ in "make tags" (#3498)
https://github.com/python/cpython/commit/4866957e86594935ec2e6434b6e470ebeb0c79b4


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30860] Consolidate stateful C globals under a single struct.

[STINNER Victor]

STINNER Victor added the comment:

The commit 2ebc5ce42a8a9e047e790aefbf9a94811569b2b6 introduced reference leaks: 
see bpo-31420 which tracks them.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31420] Reference leaks introduced by bpo-30860

[STINNER Victor]

STINNER Victor added the comment:

> The following commands show memory leaks introduced by bpo-30860:

Oh, I'm talking about the commit 2ebc5ce42a8a9e047e790aefbf9a94811569b2b6.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31420] Reference leaks introduced by bpo-30860

[STINNER Victor]

New submission from STINNER Victor:

The following commands show memory leaks introduced by bpo-30860:

$ ./python -m test -R 3:3 test_atexit -m 
test.test_atexit.SubinterpreterTest.test_callbacks_leak

$ ./python -m test -R 3:3 test_atexit -m 
test.test_atexit.SubinterpreterTest.test_callbacks_leak_refcycle

$ ./python -m test -R 3:3 test_threading -m 
test.test_threading.SubinterpThreadingTests.test_threads_join

$ ./python -m test -R 3:3 test_capi -m 
test.test_capi.SubinterpreterTest.test_subinterps

--
messages: 301882
nosy: haypo
priority: normal
severity: normal
status: open
title: Reference leaks introduced by bpo-30860
type: resource usage
versions: Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30389] distutils._msvccompiler cannot find VS 2017

[Steve Dower]

Steve Dower added the comment:

I fixed the ref leak during the sprints but forgot to tag this issue in the PR.

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31417] Use the enumerate function where appropriate

[STINNER Victor]

STINNER Victor added the comment:

> Thanks for wanting to improve Python, but we don't usually accept refactoring 
> requests like this.  We "fix" such issues when the code is touched for other 
> reasons.  We'll see what other developers think, though.

The standard library is used by some developers are the reference style for 
best practices. So it makes sense to "upgrade" to code to use enumarate(). I 
read the short change, enumerate() usage is appropriate.

--
nosy: +haypo

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31417] Use the enumerate function where appropriate

[R. David Murray]

R. David Murray added the comment:

Thanks for wanting to improve Python, but we don't usually accept refactoring 
requests like this.  We "fix" such issues when the code is touched for other 
reasons.  We'll see what other developers think, though.

--
nosy: +r.david.murray

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31336] Speed up _PyType_Lookup() for class creation

[STINNER Victor]

STINNER Victor added the comment:

I ran a microbenchmark on the current PR 3279 using:

./python -m perf timeit --inherit=PYTHONPATH 'class C: pass'

Result:

haypo@selma$ ./python -m perf compare_to ref.json patch.json 
Mean +- std dev: [ref] 9.71 us +- 0.38 us -> [patch] 8.74 us +- 0.22 us: 1.11x 
faster (-10%)

I compiled Python using "./configure && make", no LTO nor PGO.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22559] [2.7] Backport ssl.MemoryBIO to Python 2.7 - PEP 546

[STINNER Victor]

STINNER Victor added the comment:

ssl_io_loop() currently ignores the timeout parameter: 
https://github.com/python/cpython/pull/3500 fixes it in the master branch.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30860] Consolidate stateful C globals under a single struct.

[STINNER Victor]

Changes by STINNER Victor :


--
pull_requests: +3493

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30860] Consolidate stateful C globals under a single struct.

[STINNER Victor]

Changes by STINNER Victor :


--
pull_requests: +3492

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31419] Can not install python3.6.2 due to Error 0x80070643: Failed to install MSI package

[Fernado]

New submission from Fernado:

HI:
I tried to install python3.5.1 64bit and python3.6.2 64bit on wondows, I 
met the same problem.
Error 0x80070643: Failed to install MSI package.
[2BD0:2360][2017-09-11T14:56:47]e000: Error 0x80070643: Failed to configure 
per-user MSI package.
[2BD0:2360][2017-09-11T14:56:47]i319: Applied execute package: core_JustForMe, 
result: 0x80070643, restart: None
[2BD0:2360][2017-09-11T14:56:47]e000: Error 0x80070643: Failed to execute MSI 
package.

--
components: Installation
files: Python 3.6.2 (64-bit)_20170911145619.log
messages: 301876
nosy: fernado
priority: normal
severity: normal
status: open
title: Can not install python3.6.2 due to Error 0x80070643: Failed to install 
MSI package
type: crash
versions: Python 3.5
Added file: https://bugs.python.org/file47133/Python 3.6.2 
(64-bit)_20170911145619.log

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30758] test_pydoc hangs sometimes on 3.6 and master branches on ARMv7 Ubuntu 3.x

[STINNER Victor]

STINNER Victor added the comment:

http://buildbot.python.org/all/builders/ARMv7%20Ubuntu%203.x/builds/1337/steps/test/logs/stdio

The issue still exists:

0:10:38 load avg: 7.31 [403/405] test_multiprocessing_forkserver passed (110 
sec) -- running: test_pydoc (590 sec), test_buffer (55 sec)
0:10:41 load avg: 6.88 [404/405] test_buffer passed (57 sec) -- running: 
test_pydoc (593 sec)

command timed out: 1200 seconds without output running ['make', 'buildbottest', 
'TESTOPTS=-j2 -j8', 'TESTPYTHONOPTS=', 'TESTTIMEOUT=900'], attempting to kill
process killed by signal 9
program finished with exit code -1
elapsedTime=1843.787084

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31418] assertion failure in PyErr_WriteUnraisable() in case of an exception with a bad __module__

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

I think this patch doesn't need a test (which would require using a subprocess).

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31418] assertion failure in PyErr_WriteUnraisable() in case of an exception with a bad __module__

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Printing '' LGTM.

Implicit converting to str can raise a warning or exception if __module__ is a 
bytes object.

--
nosy: +serhiy.storchaka

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31418] assertion failure in PyErr_WriteUnraisable() in case of an exception with a bad __module__

[Oren Milman]

New submission from Oren Milman:

The following code causes an assertion failure in PyErr_WriteUnraisable() (in
Python/errors.c):

class BadException(Exception):
__module__ = None

class BadClass:
def __del__(self):
raise BadException

foo = BadClass()
del foo


this is because PyErr_WriteUnraisable() assumes that __module__ is a string,
and passes it to _PyUnicode_EqualToASCIIId(), which asserts it received a 
string.


what is the wanted behavior in such a case?
should we ignore the bad __module__ and print '' as the module name
in the traceback?

--
components: Interpreter Core
messages: 301872
nosy: Oren Milman
priority: normal
severity: normal
status: open
title: assertion failure in PyErr_WriteUnraisable() in case of an exception 
with a bad __module__
type: crash
versions: Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31417] Use the enumerate function where appropriate

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


--
assignee:  -> rhettinger
nosy: +rhettinger

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31417] Use the enumerate function where appropriate

[Roundup Robot]

Changes by Roundup Robot :


--
keywords: +patch
pull_requests: +3490
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31416] assertion failures in warn_explicit() in case of a bad warnings.filters or warnings.defaultaction

[Oren Milman]

Changes by Oren Milman :


--
keywords: +patch
pull_requests: +3489
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31417] Use the enumerate function where appropriate

[Mark Byrne]

New submission from Mark Byrne:

To make code explicit and more readable

Use the enumerate function to replace occurrences of the pattern:

for i in range(len(sources)):
src = sources[i]

--
messages: 301871
nosy: Mark Byrne
priority: normal
severity: normal
status: open
title: Use the enumerate function where appropriate
type: behavior
versions: Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31400] SSL module returns incorrect error codes on Windows

[Christian Heimes]

Christian Heimes added the comment:

Patch has landed in 3.6 and master, thanks!

--
resolution:  -> fixed
stage: backport needed -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29988] with statements are not ensuring that __exit__ is called if __enter__ succeeds

[Nick Coghlan]

Nick Coghlan added the comment:

I've pushed a variant that relies entirely on checking for instruction pointer 
changes, and it seems quite promising. However, a test_io failure introduced by 
this variant shows a new way for this version to *create* problems: because of 
the shift in the way signals are handled, the failing test switches from 
raising the exception as the last item inside the with statement to instead 
raising it as the first thing inside the __exit__ statement for a pure-Python 
context manager.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31308] forkserver process isn't re-launched if it died

[Antoine Pitrou]

Antoine Pitrou added the comment:

> 1) The implicit restart of the forkserver process seems in conflict with the 
> zen of making things explicit.

Well, the forkserver process really is an implementation detail.  It already is 
started on-demand, so restarting it if needed sounded like a natural evolution.

Another example: in a multiprocessing Pool, if a worker process crashes, 
another will be restarted transparently (same in 
concurrent.futures.ProcessPoolExecutor, incidentally).

> 2) This would seem to make forkserver's behavior inconsistent with the 
> behavior of things like the Manager which similarly creates its own process 
> for managing resources but does not automatically restart that process if it 
> should die or become unreachable.

That's possible.  I've never seen the Manager used in the wild.  Though if some 
fundamental difference justifies the inconsistency, the inconsistency is not 
really a problem.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31416] assertion failures in warn_explicit() in case of a bad warnings.filters or warnings.defaultaction

[Oren Milman]

New submission from Oren Milman:

The following code causes an assertion failure in warn_explicit() (in
Python/_warnings.c):

import warnings
warnings.filters = [(None, None, Warning, None, 0)]
warnings.warn_explicit(message='foo', category=Warning, filename='bar',
   lineno=1)

this is because warn_explicit() assumes that get_filter() returned a string,
and passes the return value (of get_filter()) to 
_PyUnicode_EqualToASCIIString(),
which asserts it received a string.


In addition, get_filter() might return warnings.defaultaction, and so the
following code also causes an assertion failure in warn_explicit():

import warnings
warnings.defaultaction = None
warnings.filters = []
warnings.warn_explicit(message='foo', category=Warning, filename='bar',
   lineno=1)

--
components: Extension Modules
messages: 301867
nosy: Oren Milman
priority: normal
severity: normal
status: open
title: assertion failures in warn_explicit() in case of a bad warnings.filters 
or warnings.defaultaction
type: crash
versions: Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31411] SystemError raised by warn_explicit() in case warnings.onceregistry is not a dict

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31411] SystemError raised by warn_explicit() in case warnings.onceregistry is not a dict

[Serhiy Storchaka]

Serhiy Storchaka added the comment:


New changeset 7972ed2111ea2f01e8712eef91bcf2260e05ad8b by Serhiy Storchaka in 
branch '3.6':
[3.6] bpo-31411: Prevent raising a SystemError in case warnings.onceregistry is 
not a dictionary. (GH-3485). (#3494)
https://github.com/python/cpython/commit/7972ed2111ea2f01e8712eef91bcf2260e05ad8b


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31411] SystemError raised by warn_explicit() in case warnings.onceregistry is not a dict

[Serhiy Storchaka]

Serhiy Storchaka added the comment:


New changeset 004547f97067be2e23ae770f300c0c0d1db1ba27 by Serhiy Storchaka in 
branch '2.7':
[2.7] bpo-31411: Prevent raising a SystemError in case warnings.onceregistry is 
not a dictionary. (GH-3485). (#3493)
https://github.com/python/cpython/commit/004547f97067be2e23ae770f300c0c0d1db1ba27


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com