[issue32747] remove trailing spaces in docstring

[Qian Yun]

Change by Qian Yun :


--
keywords: +patch
pull_requests: +5324
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32747] remove trailing spaces in docstring

[Qian Yun]

New submission from Qian Yun :

This is a simple PR that removes trailing spaces in docstring,
which are found by:
grep -R ' \\n\\$' .

--
assignee: docs@python
components: Documentation
messages: 311484
nosy: Qian Yun, docs@python
priority: normal
severity: normal
status: open
title: remove trailing spaces in docstring
versions: Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32729] socket error handling needed

[INADA Naoki]

INADA Naoki  added the comment:

Please give us reproducible example.
Otherwise, we can't know it's our bug or it's bug of caller.

--
nosy: +inada.naoki

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20082] Misbehavior of BufferedRandom.write with raw file in append mode

[Nitish]

Change by Nitish :


--
nosy: +nitishch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20285] Improve object.__doc__ and help(object) output

[Terry J. Reedy]

Terry J. Reedy  added the comment:

I posted "Is object the most base type?  (bpo-20285)" on pydev.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32733] test_coroutines is failed when run with -We

[Nathaniel Smith]

Nathaniel Smith  added the comment:

Thanks!

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32733] test_coroutines is failed when run with -We

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:

Thank you Nathaniel. And congratulate with getting core developer status!

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20285] Improve object.__doc__ and help(object) output

[Terry J. Reedy]

Terry J. Reedy  added the comment:

Since this modifies the output of a library module function for a specific 
input, I will not backport unless and until there is agreement on doing so.

--
versions:  -Python 3.6, Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29317] test_copyxattr_symlinks fails

[Alexander Mohr]

Change by Alexander Mohr :


--
nosy: +thehesiod
versions: +Python 3.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20285] Improve object.__doc__ and help(object) output

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:

It is better to ask Guido or other language expert.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32733] test_coroutines is failed when run with -We

[Nathaniel Smith]

Nathaniel Smith  added the comment:


New changeset 709f6ad7f84855ebdbe3e7702571b0e1447b885b by Nathaniel J. Smith 
(Miss Islington (bot)) in branch '3.7':
bpo-32733: Make test_coroutines robust against -Werror (GH-5487) (GH-5490)
https://github.com/python/cpython/commit/709f6ad7f84855ebdbe3e7702571b0e1447b885b


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32746] More misspellings, mostly in source code.

[Leo Arias]

Change by Leo Arias :


--
keywords: +patch
pull_requests: +5323
stage: commit review -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32746] More misspellings, mostly in source code.

[Terry J. Reedy]

New submission from Terry J. Reedy :

This is similar to #32297.  I intend to backport, if not too much problem, for 
the reason Victor gave on the PR 4803: "to reduce conflicts when backporting 
fixes into Python 3.6."

I propose to not backport to Python 2.7, again for the reason Victor gave: 
"since Python 2.7 is dying and minor fixes are no more backported to 2.7."

--
assignee: terry.reedy
messages: 311476
nosy: terry.reedy
priority: normal
severity: normal
stage: commit review
status: open
title: More misspellings, mostly in source code.
versions: Python 3.6, Python 3.7, Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32297] Few misspellings found in Python source code comments.

[Terry J. Reedy]

Change by Terry J. Reedy :


--
versions: +Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20285] Improve object.__doc__ and help(object) output

[Terry J. Reedy]

Change by Terry J. Reedy :


--
assignee: docs@python -> terry.reedy
components: +Library (Lib)
stage: patch review -> commit review
versions: +Python 3.6, Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32206] Run modules with pdb

[Mario Corchero]

Change by Mario Corchero :


--
pull_requests: +5321, 5322

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32206] Run modules with pdb

[Mario Corchero]

Change by Mario Corchero :


--
pull_requests: +5321

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32733] test_coroutines is failed when run with -We

[miss-islington]

Change by miss-islington :


--
pull_requests: +5320

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32733] test_coroutines is failed when run with -We

[Nathaniel Smith]

Nathaniel Smith  added the comment:


New changeset 2efb9735899c7c642f3e75a121af82b1679577d3 by Nathaniel J. Smith in 
branch 'master':
bpo-32733: Make test_coroutines robust against -Werror (GH-5487)
https://github.com/python/cpython/commit/2efb9735899c7c642f3e75a121af82b1679577d3


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32674] minor documentation fix for '__import__'

[miss-islington]

Change by miss-islington :


--
pull_requests: +5319

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32674] minor documentation fix for '__import__'

[Mariatta Wijaya]

Mariatta Wijaya  added the comment:


New changeset 461d225b195eec5269f317323b41115516144c41 by Mariatta (oldk) in 
branch 'master':
bpo-32674: Improve the docstring for __import__ (GH-5339)
https://github.com/python/cpython/commit/461d225b195eec5269f317323b41115516144c41


--
nosy: +Mariatta

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32674] minor documentation fix for '__import__'

[miss-islington]

Change by miss-islington :


--
pull_requests: +5318

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32611] Tkinter taskbar icon (Windows)

[Terry J. Reedy]

Change by Terry J. Reedy :


--
resolution:  -> works for me
stage:  -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32436] Implement PEP 567

[Yury Selivanov]

Yury Selivanov  added the comment:


New changeset 78767786a87b00925506c32b3b55cf65b56ef3d7 by Yury Selivanov (Miss 
Islington (bot)) in branch '3.7':
bpo-32436: Fix compiler warning (GH-5483) (GH-5486)
https://github.com/python/cpython/commit/78767786a87b00925506c32b3b55cf65b56ef3d7


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32733] test_coroutines is failed when run with -We

[Nathaniel Smith]

Change by Nathaniel Smith :


--
keywords: +patch
pull_requests: +5317
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32436] Implement PEP 567

[miss-islington]

Change by miss-islington :


--
pull_requests: +5316

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32436] Implement PEP 567

[Yury Selivanov]

Yury Selivanov  added the comment:


New changeset 55e0839f2672e029c2b96514028c77c31ffbe41f by Yury Selivanov in 
branch 'master':
bpo-32436: Fix compiler warning (#5483)
https://github.com/python/cpython/commit/55e0839f2672e029c2b96514028c77c31ffbe41f


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32739] collections.deque rotate(n=1) default value not documented

[Raymond Hettinger]

Change by Raymond Hettinger :


--
versions: +Python 3.7, Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32739] collections.deque rotate(n=1) default value not documented

[Raymond Hettinger]

Change by Raymond Hettinger :


--
keywords: +patch
pull_requests: +5315
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32436] Implement PEP 567

[Yury Selivanov]

Change by Yury Selivanov :


--
pull_requests: +5314

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32590] Proposal: add an "ensure(arg)" builtin for parameter validation

[Xavier G. Domingo]

Change by Xavier G. Domingo :


--
nosy: +xgdomingo

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32720] Format mini-language integer definition is incorrect

[Nathan Kerr]

Nathan Kerr  added the comment:

Just submitted a PR for this issue, however I only signed the CLA an hour ago 
so it hasn't gone through yet.

This is my first contribution, I followed the guide but please let me know if I 
missed anything. Thanks!

--
nosy: +nkerr

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32720] Format mini-language integer definition is incorrect

[Nathan Kerr]

Change by Nathan Kerr :


--
keywords: +patch
pull_requests: +5313
stage: needs patch -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30449] Improve __slots__ datamodel documentation

[Cheryl Sabella]

Cheryl Sabella  added the comment:

It looks like this documentation patch was applied to master.  Does it need to 
be backported to 3.6 and 2.7 for the issue to be closed?  Thanks!

--
nosy: +csabella

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32540] venv docs - doesn't match behavior

[Cheryl Sabella]

Change by Cheryl Sabella :


--
keywords: +easy
stage:  -> needs patch
type:  -> enhancement
versions: +Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32720] Format mini-language integer definition is incorrect

[Cheryl Sabella]

Change by Cheryl Sabella :


--
keywords: +easy

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32493] UUID Module - FreeBSD build failure

[Michael Felt]

Michael Felt  added the comment:

Now that it is visible - maybe OpenBSD will treat it as a bug and get 
the "version bits" to work as their man page 
(https://man.openbsd.org/uuid.3) says it does:

  STANDARDS 

The *uuid_compare*(), *uuid_create*(), *uuid_create_nil*(), 
*uuid_equal*(), *uuid_from_string*(), *uuid_hash*(), *uuid_is_nil*(), 
and *uuid_to_string*() functions are compatible with the DCE 1.1 RPC 
specification.

The FreeBSD man page 
(https://www.freebsd.org/cgi/man.cgi?query=uuid_create) says:

*NAME* 
  *uuid*_*compare*,*uuid*_*create*, 
*uuid*_*create*_*nil*,*uuid*_*equal*,*uuid*_*from*_*string*,
  *uuid*_*hash*,*uuid*_*is*_*nil*,*uuid*_*to*_*string*  -- DCE 1.1 
compliant UUID func-
  tions

Re the DCE 1.1 RPC implementation/description - I found this link:
http://pubs.opengroup.org/onlinepubs/9629399/apdxa.htm

And this comment:

The version number is multiplexed in the 4 most significant bits of the 
*time_hi_and_version* field. UUID version Field 
 
lists currently defined versions of the UUID.

*msb1*  *msb2*  *msb3*  *msb4*  *Version*   *Description*
0   0   0   1   1   DCE version, as specified herein.
0   0   1   0   2   DCE Security version, with embedded 
POSIX UIDs.

So, maybe either, or both: OpenBSD and FreeBSD fix their implementation. 
Problem solved?!

On 1/23/2018 3:34 PM, David CARLIER wrote:
> David CARLIER  added the comment:
>
> In OpenBSD it s even "worse", the version for each call is random (not a 
> surprise when looking at the source). The question is, do we go back to 
> support only AIX or do we accept somehow wrong version ?
>
> --
>
> ___
> Python tracker 
> 
> ___
>

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32745] ctypes string pointer fields should accept embedded null characters

[Eryk Sun]

Eryk Sun  added the comment:

PyUnicode_AsWideCharString was updated to raise ValueError for embedded nulls 
if the `size` output parameter is NULL. Z_set in cfield.c should be updated to 
get the size, which can be ignored here. For example:

Py_ssize_t size; 
buffer = PyUnicode_AsWideCharString(value, );

--
nosy: +eryksun
stage:  -> test needed
type:  -> behavior
versions: +Python 3.7, Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32394] socket lib beahavior change in 3.6.4

[Steve Dower]

Steve Dower  added the comment:

PR looks good to me. Unfortunately without SMS (I'm travelling) I can't get 
into my account from my phone, so if someone else wants to add the backport 
tags (3.7 and 3.6) and finish it then feel free.

--
versions: +Python 3.7, Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32739] collections.deque rotate(n=1) default value not documented

[Raymond Hettinger]

Raymond Hettinger  added the comment:

Thanks for noticing this.

--
assignee: docs@python -> rhettinger
nosy: +rhettinger

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32394] socket lib beahavior change in 3.6.4

[Steve Dower]

Steve Dower  added the comment:

Yes, adding the member back will put you back in the broken state, but there's 
nothing we can do to stop it.

Thanks for the PR - I'll take a look, and if I'm able to log into GitHub on my 
phone maybe finish it.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32303] Namespace packages have inconsistent __loader__ and __spec__.loader

[Barry A. Warsaw]

Change by Barry A. Warsaw :


--
keywords: +patch
pull_requests: +5311
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32305] Namespace packages have inconsistent __file__ and __spec__.origin

[Barry A. Warsaw]

Change by Barry A. Warsaw :


--
keywords: +patch
pull_requests: +5312
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32303] Namespace packages have inconsistent __loader__ and __spec__.loader

[Barry A. Warsaw]

Barry A. Warsaw  added the comment:

3.5 is in security fix only mode, and this is not a security issue.

--
versions:  -Python 3.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32305] Namespace packages have inconsistent __file__ and __spec__.origin

[Barry A. Warsaw]

Barry A. Warsaw  added the comment:

3.5 is in security fix only mode, and this is not a security issue.

--
versions:  -Python 3.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32741] Add asyncio.TimerHandle.when() function

[Andrew Svetlov]

Change by Andrew Svetlov :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32745] ctypes string pointer fields should accept embedded null characters

[Thomas Heller]

New submission from Thomas Heller :

ctypes Structure fields of type c_char_p or c_wchar_p used to accept strings 
with embedded null characters.  I noticed that Python 3.6.4 does refuse them.  
It seems this has been changed in recent version(s).

There ARE use-cases for this:  The Windows-API OPENFILENAME structure is one 
example.  The Microsoft docs for the lpstrFilter field:

"""
lpstrFilter

Type: LPCTSTR

A buffer containing pairs of null-terminated filter strings. The last 
string in the buffer must be terminated by two NULL characters.
"""

I have attached a simple script which demonstrates this new behaviour; the 
output with Python 3.6.4 is this:

Traceback (most recent call last):
  File "nullchars.py", line 8, in 
t.unicode = u"foo\0bar"
ValueError: embedded null character

--
components: ctypes
files: nullchars.py
keywords: 3.6regression
messages: 311462
nosy: theller
priority: normal
severity: normal
status: open
title: ctypes string pointer fields should accept embedded null characters
versions: Python 3.6
Added file: https://bugs.python.org/file47420/nullchars.py

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32744] PEP 342 double colons typos in code

[Dmitry Alimov]

Dmitry Alimov  added the comment:

Merged. It's fixed now: https://www.python.org/dev/peps/pep-0342/

--
resolution:  -> fixed
stage:  -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32741] Add asyncio.TimerHandle.when() function

[miss-islington]

Change by miss-islington :


--
pull_requests: +5310

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32741] Add asyncio.TimerHandle.when() function

[Andrew Svetlov]

Andrew Svetlov  added the comment:

Thanks.
Let's do it.
The addition is really very trivial.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32744] PEP 342 double colons typos in code

[Dmitry Alimov]

Dmitry Alimov  added the comment:

https://github.com/python/peps/pull/567

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32744] PEP 342 double colons typos in code

[Dmitry Alimov]

New submission from Dmitry Alimov :

I've found "double colons" typos in examples:

@consumer
def jpeg_writer(dirname)::  # 1) here
fileno = 1

and

try:
while self.running and self.queue::  # 2) here
   func = self.queue.popleft()

--
assignee: docs@python
components: Documentation
messages: 311458
nosy: delimitry, docs@python
priority: normal
severity: normal
status: open
title: PEP 342 double colons typos in code
type: enhancement
versions: Python 2.7, Python 3.4, Python 3.5, Python 3.6, Python 3.7, Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32711] Fix warnings for Python/ast_unparse.c

[Christian Heimes]

Christian Heimes  added the comment:

Thanks!

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed
type:  -> compile error
versions: +Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32711] Fix warnings for Python/ast_unparse.c

[Christian Heimes]

Christian Heimes  added the comment:


New changeset 78758f29b13aba6136f4c0a15d4457fbf92c5eef by Christian Heimes 
(Miss Islington (bot)) in branch '3.7':
[3.7] bpo-32711: Fix warnings for Python/ast_unparse.c (GH-5426) (#5475)
https://github.com/python/cpython/commit/78758f29b13aba6136f4c0a15d4457fbf92c5eef


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32734] Asyncio Lock safety issue (unlimited acquire)

[Bar Harel]

Bar Harel  added the comment:

Finished fixing CR and adding backports.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32572] Add the ftplib option, overrides the IP address.

[Giampaolo Rodola']

Giampaolo Rodola'  added the comment:

Considering the security implications and the fact that it's a corner case I 
don't think this is worth adding as a new, public API, sorry. I think ftplib 
should expose and promote APIs reflecting common scenarios and good practices, 
yet be flexible enough in order to allow "breaking the rules". FWIW, you may 
get away with something like this, which IMO is not too bad (not tested): 


class FTP(ftplib.FTP):
externalip = None

def sendport(self, host, port):
return super().sendport(self.externalip or host, port)

def sendeprt(self, host, port):
return super().sendeprt(self.externalip or host, port)

--
resolution:  -> rejected
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32734] Asyncio Lock safety issue (unlimited acquire)

[Bar Harel]

Change by Bar Harel :


--
pull_requests: +5309

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32743] Typo in hamt.c comments

[Dmitry Alimov]

Change by Dmitry Alimov :


--
keywords: +patch
pull_requests: +5307
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32743] Typo in hamt.c comments

[Yury Selivanov]

Yury Selivanov  added the comment:

Yeah, please submit a PR

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32743] Typo in hamt.c comments

[Dmitry Alimov]

New submission from Dmitry Alimov :

In the comments to `hamt_node_collision_without` function in hamt.c module, I 
think should be `so convert` instead of `co convert`:

```
 if (new_count == 1) {
 /* The node has two keys, and after deletion the
new Collision node would have one.  Collision nodes
-   with one key shouldn't exist, co convert it to a
+   with one key shouldn't exist, so convert it to a
Bitmap node.
 */
```

--
assignee: docs@python
components: Documentation
messages: 311452
nosy: delimitry, docs@python, yselivanov
priority: normal
severity: normal
status: open
title: Typo in hamt.c comments
type: enhancement
versions: Python 3.7, Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32734] Asyncio Lock safety issue (unlimited acquire)

[Bar Harel]

Change by Bar Harel :


--
pull_requests: +5306

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32734] Asyncio Lock safety issue (unlimited acquire)

[Bar Harel]

Change by Bar Harel :


--
pull_requests: +5305

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17611] Move unwinding of stack for "pseudo exceptions" from interpreter to compiler.

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
versions: +Python 3.8 -Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32711] Fix warnings for Python/ast_unparse.c

[miss-islington]

Change by miss-islington :


--
pull_requests: +5304

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32711] Fix warnings for Python/ast_unparse.c

[Christian Heimes]

Christian Heimes  added the comment:


New changeset 83ab995871ffd504ac229bdbf5b9e9ffc1032815 by Christian Heimes 
(Stéphane Wirtel) in branch 'master':
bpo-32711: Fix warnings for Python/ast_unparse.c (#5426)
https://github.com/python/cpython/commit/83ab995871ffd504ac229bdbf5b9e9ffc1032815


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32741] Add asyncio.TimerHandle.when() function

[Yury Selivanov]

Yury Selivanov  added the comment:

Andrew, I'm indifferent about this feature.  It's entirely up to you if you 
want to merge it in 3.7.  I already used up my allowance for post-beta1 feature 
merges.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32572] Add the ftplib option, overrides the IP address.

[Hideyuki]

Hideyuki  added the comment:

I understand that it is best to use PASV.
But this FTP server is managed by another person, and that server required 
active mode. 
Also, my host is in a VPC environment, it is connected by 1:1 NAT. This NAT BOX 
does not support FTP transparent.

In this case, we recognize that IP packet received by the FTP server is from 
the external IP address of the NAT BOX, but ftplib will send the IP address on 
host NIC.
So dose not match IP packet source address and PORT address, it will be closed 
with the indicated code.

The purpose of this feature is to communicate by overriding the IP address 
sending by PORT command with the NAT external IP address(so the client IP 
address seen by server).

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31508] Running test_ttk_guionly logs "test_widgets.py:1562: UserWarning: Deprecated API of Treeview.selection() should be removed" warnings

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:


New changeset 97f1ca167385bafd9be5d226f61c33412fc081bf by Serhiy Storchaka in 
branch 'master':
[3.8] bpo-31508: Remove support of arguments in tkinter.ttk.Treeview.selection. 
(GH-3651)
https://github.com/python/cpython/commit/97f1ca167385bafd9be5d226f61c33412fc081bf


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32741] Add asyncio.TimerHandle.when() function

[Ned Deily]

Ned Deily  added the comment:

We have feature freezes for a good reason.  But I will trust your judgement on 
this one. (Removing 3.6 for version list.)

--
versions:  -Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27362] json.dumps to check for obj.__json__ before raising TypeError

[Ulrich Petri]

Change by Ulrich Petri :


--
nosy: +ulope

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32206] Run modules with pdb

[Mario Corchero]

Change by Mario Corchero :


--
pull_requests:  -5301

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32691] "pdb -m " sets __main__.__package__ incorrectly

[Mario Corchero]

Mario Corchero  added the comment:

Sent a PR for the fix. I'll update PRs for trace. profile does not need it

Thanks a lot for bringing it up Jason!

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31356] Add context manager to temporarily disable GC

[Yury Selivanov]

Yury Selivanov  added the comment:

Raymond, do you need help with reverts?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32741] Add asyncio.TimerHandle.when() function

[Yury Selivanov]

Yury Selivanov  added the comment:

> Let's get it into master for 3.8 first and then we'll have something to 
> discuss.

The PR has a "versionadded" tag.  If you plan to allow this, Andrew can commit 
it set to 3.7...

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32741] Add asyncio.TimerHandle.when() function

[Andrew Svetlov]

Change by Andrew Svetlov :


--
keywords: +patch
pull_requests: +5300
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32691] "pdb -m " sets __main__.__package__ incorrectly

[Mario Corchero]

Change by Mario Corchero :


--
keywords: +patch
pull_requests: +5302
stage: test needed -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32206] Run modules with pdb

[Mario Corchero]

Change by Mario Corchero :


--
pull_requests: +5301

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32741] Add asyncio.TimerHandle.when() function

[Yury Selivanov]

Yury Selivanov  added the comment:

The PR is LGTM.  Up to Ned to allow this in 3.7.  I agree that the feature is 
(a) trivial, (b) new, so it's safe to go in 3.7.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32305] Namespace packages have inconsistent __file__ and __spec__.origin

[Barry A. Warsaw]

Change by Barry A. Warsaw :


--
assignee:  -> barry
versions: +Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32303] Namespace packages have inconsistent __loader__ and __spec__.loader

[Barry A. Warsaw]

Change by Barry A. Warsaw :


--
assignee:  -> barry
versions: +Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32572] Add the ftplib option, overrides the IP address.

[R. David Murray]

R. David Murray  added the comment:

I too wondered if pasv was the correct solution to the problem.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32691] "pdb -m " sets __main__.__package__ incorrectly

[Mario Corchero]

Mario Corchero  added the comment:

OK, just managed to reproduce it.

This appears only when you run a python script as a module. Running a module 
with  __main__ does not show the issue.

Will get a patch ready

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32572] Add the ftplib option, overrides the IP address.

[Giampaolo Rodola']

Giampaolo Rodola'  added the comment:

Mmmm out of curiosity, how common is this? Usually when client is behind a NAT 
it's supposed to use PASV. What you're proposing is a configuration option 
which typically belong to servers, not clients. I don't remember ever bumping 
into a FTP client allowing such an option (e.g. does FileZilla have it?). Also, 
this has some security implications as you could potentially dictate a naive 
FTP server to connect to a malicious host:port, and basically this is the 
reasons why servers do such a "IP replacement", not clients. In pyftpdlib 
(which is a server) I explicitly reject PORT connections with an IP != client's 
IP (because it's a security concern), even though the check can be disabled:  
https://github.com/giampaolo/pyftpdlib/blob/9dcbf685e10906fbdf4969cda1138a25f96bf16d/pyftpdlib/handlers.py#L383-L396
I believe proftpd and vsftpd does the same by default.

--
assignee:  -> giampaolo.rodola

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32691] "pdb -m " sets __main__.__package__ incorrectly

[Nick Coghlan]

Nick Coghlan  added the comment:

I forget we had mod_spec.parent available to us these days, so yes, we should 
use that rather than recalculating the parent with str.rpartition.

As Mario noted, we only want to change the behaviour when the executed module 
is a plain module or submodule, rather than being a package in its own right 
with a pkg.__main__ submodule (since the current behaviour is correct in the 
latter case).

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32742] zipfile extractall needlessly re-wraps ZipInfo instances

[Peter Bengtsson]

Change by Peter Bengtsson :


--
keywords: +patch
pull_requests: +5298
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32741] Add asyncio.TimerHandle.when() function

[Ned Deily]

Ned Deily  added the comment:

Let's get it into master for 3.8 first and then we'll have something to discuss.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32741] Add asyncio.TimerHandle.when() function

[Yury Selivanov]

Yury Selivanov  added the comment:

OK, makes sense. Can you submit a PR?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32742] zipfile extractall needlessly re-wraps ZipInfo instances

[Peter Bengtsson]

Peter Bengtsson  added the comment:

(PS. I'm new to filing Python bugs and submitting patches. I *think* this is 
the right version. I've only been looking at 'master'.)

--
versions: +Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32742] zipfile extractall needlessly re-wraps ZipInfo instances

[Peter Bengtsson]

New submission from Peter Bengtsson :

The ZipFile class as a extractall method [0] that allows you to leave the 
'members' empty. If empty, the 'members' becomes a list of all the *names* of 
files in the zip. Then it iterates over the names as sends each to 
`self._extract_member`. But that method needs it to be a ZipInfo object instead 
of a file name, so it re-wraps it [2].

Instead we can use `self.infolist()` to avoid that re-wrapping inside each 
`self._extract_member` call. 


[0] 
hhttps://github.com/python/cpython/blob/12e7cd8a51956a5ce373aac692ae6366c5f86584/Lib/zipfile.py#L1579
[1] 
https://github.com/python/cpython/blob/12e7cd8a51956a5ce373aac692ae6366c5f86584/Lib/zipfile.py#L1586
[2] 
https://github.com/python/cpython/blob/12e7cd8a51956a5ce373aac692ae6366c5f86584/Lib/zipfile.py#L1615-L1616

--
components: Library (Lib)
messages: 311434
nosy: peterbe
priority: normal
severity: normal
status: open
title: zipfile extractall needlessly re-wraps ZipInfo instances
type: enhancement

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32741] Add asyncio.TimerHandle.when() function

[Andrew Svetlov]

Andrew Svetlov  added the comment:

In aiohttp we have HTTP keepalivve support.

A function schedules a delayed callback.
On processing a new request the callback is cancelled and rescheduled to a new 
time.

I like to check cancellation state (now it is possible with public API) and 
scheduled time.

I did the check with mocking but proposed method allows to do it easy and more 
obviously.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32572] Add the ftplib option, overrides the IP address.

[Stéphane Wirtel]

Stéphane Wirtel  added the comment:

+1 for this point David,

but also the minimum is the documentation and a test, I suppose you will
confirm.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32572] Add the ftplib option, overrides the IP address.

[R. David Murray]

R. David Murray  added the comment:

I'd like confirmation from someone involved in maintaining the ftplib package 
that this is in fact the correct solution.

--
nosy: +r.david.murray

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32741] Add asyncio.TimerHandle.when() function

[Yury Selivanov]

Yury Selivanov  added the comment:

How will such test look like? I'm still not sure we need it.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31106] os.posix_fallocate() generate exception with errno 0

[Andrew Svetlov]

Andrew Svetlov  added the comment:


New changeset 3a04c52a9eb03e31c60037248b872f3662002a4d by Andrew Svetlov (Miss 
Islington (bot)) in branch '3.6':
bpo-31106: Fix handling of erros in posix_fallocate() and posix_fadvise() 
(GH-3000) (GH-3000) (#4101)
https://github.com/python/cpython/commit/3a04c52a9eb03e31c60037248b872f3662002a4d


--
nosy: +asvetlov

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32711] Fix warnings for Python/ast_unparse.c

[Stéphane Wirtel]

Stéphane Wirtel  added the comment:

Christian, I just pushed my code, wait for the feedback from Travis.

Thanks

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32711] Fix warnings for Python/ast_unparse.c

[Stéphane Wirtel]

Stéphane Wirtel  added the comment:

then I will use the approach of Victor with the Py_UNREACHABLE macro and will 
push asap.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32738] CDLL : Can't find module

[Christian Heimes]

Christian Heimes  added the comment:

Your library is probably missing dependencies.

Please use the Python mailing list or IRC to get assistance. bugs.python.org is 
a bug tracker, not a supported forum. You can find more information about 
community support forums on https://www.python.org/community/

--
nosy: +christian.heimes
resolution:  -> not a bug
stage:  -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32711] Fix warnings for Python/ast_unparse.c

[Christian Heimes]

Christian Heimes  added the comment:

In my experience, Serhiy's example won't work. C doesn't guarantee that the 
functions will not be called with an unsupported op. Either my proposal or 
Victor's proposal are the correct way to solve the warning. Victor's proposal 
is even better because it makes the interpreter fail when an invalid operator 
is used.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32711] Fix warnings for Python/ast_unparse.c

[Stéphane Wirtel]

Stéphane Wirtel  added the comment:

Hi Serhiy,

but currently, there is some warnings because op has no value and can not be 
assigned to NULL because _PyUnicodeWriter_WriteASCIIString can't accept a NULL 
value.

What do you propose? Warnings at the compilation step and an eventual crash if 
we don't handle this case because there is no default?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32565] Document the version of adding opcodes

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed
versions: +Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com