[issue37345] Add formal support for UDPLITE protococl

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
versions:  -Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36231] Support builds on macOS without installed system header files

[Ned Deily]

Ned Deily  added the comment:

Thanks again everyone.  The general solution has now been merged to all active 
branches for release in 3.8.0, 3.7.4, and 2.7.17.

Note that Issue19960 identifies an additional problem only on 2.7 where a few 
extension modules, notably zlib, are still not being built when header files 
are not installed; a PR for that issue is currently awaiting review.

--
components: +Build
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed
title: no "proper" header files on macOS 10.14 Mojave -> Support builds on 
macOS without installed system header files

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37345] Add formal support for UDPLITE protococl

[Gabe Appleton]

Change by Gabe Appleton :


--
keywords: +patch
pull_requests: +14088
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/14258

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37345] Add formal support for UDPLITE protococl

[Gabe Appleton]

New submission from Gabe Appleton :

At the moment you can definitely use UDPLITE sockets on Linux systems, but it 
would be good if this support were formalized such that you can detect support 
at runtime easily.

At the moment, to make and use a UDPLITE socket requires something like the 
following code:

>>> import socket
>>> a = socket.socket(socket.AF_INET, socket.SOCK_DGRAM, 136)
>>> b = socket.socket(socket.AF_INET, socket.SOCK_DGRAM, 136)
>>> a.bind(('localhost', 4))
>>> b.sendto(b'test'*256, ('localhost', 4))
>>> b.setsockopt(136, 10, 16)
>>> b.sendto(b'test'*256, ('localhost', 4))
>>> b.setsockopt(136, 10, 32)
>>> b.sendto(b'test'*256, ('localhost', 4))
>>> b.setsockopt(136, 10, 64)
>>> b.sendto(b'test'*256, ('localhost', 4))

If you look at this through Wireshark, you can see that the packets are 
different in that the checksums and checksum coverages change.

With the pull request that I am submitting momentarily, you could do the 
following code instead:

>>> import socket
>>> a = socket.socket(socket.AF_INET, socket.SOCK_DGRAM, socket.IPPROTO_UDPLITE)
>>> b = socket.socket(socket.AF_INET, socket.SOCK_DGRAM, socket.IPPROTO_UDPLITE)
>>> a.bind(('localhost', 4))
>>> b.sendto(b'test'*256, ('localhost', 4))
>>> b.set_send_checksum_coverage(16)
>>> b.sendto(b'test'*256, ('localhost', 4))
>>> b.set_send_checksum_coverage(32)
>>> b.sendto(b'test'*256, ('localhost', 4))
>>> b.set_send_checksum_coverage(64)
>>> b.sendto(b'test'*256, ('localhost', 4))

One can also detect support for UDPLITE just by checking

>>> hasattr(socket, 'IPPROTO_UDPLITE')

--
components: Library (Lib)
messages: 346103
nosy: gappleto97
priority: normal
severity: normal
status: open
title: Add formal support for UDPLITE protococl
type: enhancement
versions: Python 3.8, Python 3.9

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19960] zlib skipped when building 2.7 on macOS without /usr/include installed

[Ned Deily]

Ned Deily  added the comment:

Now that Apple, as of 10.14, has removed the option to install system header 
files into their traditional locations (like /usr/include), thus making every 
build a build from an SDK, this problem is now more noticeable.  At least, I 
finally noticed it while fixing the more general problems that setup.py had on 
all branches (see Issue36231).  This issue is in addition and is specific to 
2.7.  As can be seen in Ronald's patch, which I didn't find until after I had 
written my own, the problem is that, in 2.7's setup.py, add_dir_to_list() does 
not take the SDK manipulation into account and, in particular, skips adding 
/usr/include because that directory doen't exist in the root filesystem 
anymore.  On my systems, besides zlib, the dbm and nis modules were also being 
skipped. Curiously, some other extension modules with system library 
dependencies do get built properly, like _sqlite3, because their build step in 
setup.py explicitly added /usr/include to the SDK search paths.

Anyway, the PR I produced is somewhat more complicated that Ronald's original 
patch.  It's more careful about what paths it checks for and it also stores the 
directory name, if found, without the prepended SDK path.  That may be 
important in other steps in setup.py where it is doing path comparisons.  The 
SDK will eventually get added again, either explicitly or implicitly by the 
compiler tool chain.

--
priority: normal -> high
title: MacOSX: Building 2.7 without the xcode command line  tools installed -> 
zlib skipped when building 2.7 on macOS without /usr/include installed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19960] MacOSX: Building 2.7 without the xcode command line tools installed

[Ned Deily]

Change by Ned Deily :


--
pull_requests: +14087
pull_request: https://github.com/python/cpython/pull/14257

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36231] no "proper" header files on macOS 10.14 Mojave

[Ned Deily]

Ned Deily  added the comment:


New changeset c421c66a58a6caae30f0679d7e61411418e67cec by Ned Deily in branch 
'2.7':
bpo-36231: Support building on macOS without /usr/include (GH-13773) (GH-14256)
https://github.com/python/cpython/commit/c421c66a58a6caae30f0679d7e61411418e67cec


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36231] no "proper" header files on macOS 10.14 Mojave

[Ned Deily]

Change by Ned Deily :


--
pull_requests: +14086
pull_request: https://github.com/python/cpython/pull/14256

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37250] C files generated by Cython set tp_print to 0: PyTypeObject.tp_print removed

[Jeroen Demeyer]

Jeroen Demeyer  added the comment:

The fact that tp_vectorcall_offset replaces tp_print was a very conscious 
decision that we made already when designing the PEPs (both PEP 580 and PEP 
590). We shouldn't just throw that away without a good reason.

So far I haven't seen any good reason, only an unsubstantiated claim that it is 
supposedly more backwards compatible to put tp_vectorcall_offset at the end.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9665] Buid issues on Cygwin - _curses, _curses_panel, and _io

[Inada Naoki]

Change by Inada Naoki :


--
resolution:  -> out of date
stage: needs patch -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37250] C files generated by Cython set tp_print to 0: PyTypeObject.tp_print removed

[Jeroen Demeyer]

Jeroen Demeyer  added the comment:

> This isn't a supported scenario though.

Of course it's not! I was trying to tell you that already in msg345969 but you 
insisted in msg345988 that we should support that anyway.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37301] CGIHTTPServer doesn't handle long POST requests

[vsbogd]

vsbogd  added the comment:

My last comment was imprecise. Not `CGIHTTPRequestHandler` reads data from 
`rfile` but CGI script itself makes few reads.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37205] time.perf_counter() is not system-wide on Windows, in disagreement with documentation

[Mariatta Wijaya]

Mariatta Wijaya  added the comment:

> can you explain why you removed 3.5 and 3.6 from the versions list? 

3.5 and 3.6 are closed for regular bug fix maintenance. We're only fixing 
issues in 3.7 and 3.8 now.

Only security fixes will be applied to 3.5 or 3.6, and this issue is not 
considered a security issue.

More details in https://devguide.python.org/#status-of-python-branches

--
nosy: +Mariatta

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37301] CGIHTTPServer doesn't handle long POST requests

[vsbogd]

vsbogd  added the comment:

Hi @shajianrui,

Thank you for such detailed explanation of experiments.

As you mentioned it is a expected behavior of the io.RawIOBase.read() (see 
https://docs.python.org/3/library/io.html#io.RawIOBase), but 
io.BufferedIOBase.read() has different behavior (see 
https://docs.python.org/3/library/io.html#io.BufferedIOBase.read) and returns 
requested number of bytes (if stream is not interactive). So it is not 
surprising that this issue is being reproducible randomly and differently for 
Windows and Linux. 

I think it may be better reproducible in CGIHTTPRequestHandler because it reads 
header of the request first.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37205] time.perf_counter() is not system-wide on Windows, in disagreement with documentation

[Ken Healy]

Ken Healy  added the comment:

Hi Terry,

I'm new to this so apologies in advance if this is a silly question...can you 
explain why you removed 3.5 and 3.6 from the versions list? I have tested that 
the issue is present in 3.6 and the offending code has been present since 
time.perf_counter() was introduced in 3.3.

It it because these versions are in maintenance-only status or similar, such 
that this type of bug fix would not be considered?

Thanks,
Ken

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37340] remove free_list for bound method objects

[Inada Naoki]

Inada Naoki  added the comment:

> Are the benchmark results that you posted above for removing the free list 
> completely or for the one-element free list as in PR 14232?

Yes.  I see +3% overhead in several benchmarks and I want to see how one free 
obj save them.

> it's worse than no free list because you still have the overhead of dealing 
> with the one object.

Yes.  But it still helps some common simple cases.
(e.g. PyObject_CallMethod() (not CallMethodObjArg))

> And it's worse than a free list of 256 because it won't for nested calls.

256 free list may bother 256 pools are reused.  But one free obj keeps only one 
pool.  And we can remove the overhead of linked list too.

Of course, I prefer a simple code.  But let's wait for benchmark result.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29505] Submit the re, json, & csv modules to oss-fuzz testing

[Ammar Askar]

Change by Ammar Askar :


--
pull_requests: +14085
pull_request: https://github.com/python/cpython/pull/14255

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37342] A type error in typeobj.rst

[miss-islington]

miss-islington  added the comment:


New changeset 6258c1f7160c1b073a228c9fc49ad5ac894d66ad by Miss Islington (bot) 
in branch '3.8':
bpo-37342: Fix the incorrect nb_index's type in typeobj documentation (GH-14241)
https://github.com/python/cpython/commit/6258c1f7160c1b073a228c9fc49ad5ac894d66ad


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37342] A type error in typeobj.rst

[miss-islington]

Change by miss-islington :


--
pull_requests: +14084
pull_request: https://github.com/python/cpython/pull/14254

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37342] A type error in typeobj.rst

[miss-islington]

miss-islington  added the comment:


New changeset bc5caf88ca19b4c8cb9bc912c832b4807a515a60 by Miss Islington (bot) 
(Hai Shi) in branch 'master':
bpo-37342: Fix the incorrect nb_index's type in typeobj documentation (GH-14241)
https://github.com/python/cpython/commit/bc5caf88ca19b4c8cb9bc912c832b4807a515a60


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37251] Mocking a MagicMock with a function spec results in an AsyncMock

[Lisa Roach]

Lisa Roach  added the comment:

Thanks for the patch!

To answer your question, I do not think we can remove _is_async_func in favor 
of _is_async_obj, _is_async_obj will evaluate to True in cases where 
_is_async_func would not. 

For example:

>>> class NewCoroutine(Awaitable):
... def __await__():
... pass
...
>>> c = NewCoroutine()
>>> import inspect
>>> inspect.isawaitable(c)
True
>>> inspect.iscoroutinefunction(c)
False


BUT I think removing the `if getattr(obj, '__code__', None)` from 
`_is_async_obj` actually makes this work correctly. It is possible for a 
coroutine object to not have a __code__, but I don't think it is possible for a 
coroutine function to be missing a __code__. 

Before removing the __code__ check:

>>> from unittest.mock import _is_async_func, _is_async_obj
>>> import asyncio
>>> _is_async_obj(asyncio.sleep(1))
:1: RuntimeWarning: coroutine 'sleep' was never awaited
RuntimeWarning: Enable tracemalloc to get the object allocation traceback
False
>>> _is_async_func(asyncio.sleep(1))
False

_is_async_obj evaluates to False when it should be True

After removing it:

>>> from unittest.mock import _is_async_func, _is_async_obj
>>> import asyncio
>>> _is_async_obj(asyncio.sleep(1))
:1: RuntimeWarning: coroutine 'sleep' was never awaited
RuntimeWarning: Enable tracemalloc to get the object allocation traceback
True
>>> _is_async_func(asyncio.sleep(1))
False

It correctly evaluates to True

All tests pass as well. What do you think?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31122] SSLContext.wrap_socket() throws OSError with errno == 0

[Dima Tisnek]

Change by Dima Tisnek :


--
nosy: +Dima.Tisnek

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37344] plistlib doesn't skip whitespace in XML format detection

[Ned Deily]

Ned Deily  added the comment:

Thanks for the report.  Would you be interested in providing a pull request 
with a fix?

--
nosy: +ned.deily, ronaldoussoren
versions: +Python 3.8, Python 3.9

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37344] plistlib doesn't skip whitespace in XML format detection

[Shane G]

New submission from Shane G :

plistlib in Python 3.7.3 (and earlier) does not autodetect plist data as XML if 
it contains whitespace before the "https://github.com/python/cpython/blob/3.7/Lib/plistlib.py#L493

--
messages: 346089
nosy: shaneg
priority: normal
severity: normal
status: open
title: plistlib doesn't skip whitespace in XML format detection
type: behavior
versions: Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36710] Pass _PyRuntimeState as an argument rather than using the _PyRuntime global variable

[STINNER Victor]

STINNER Victor  added the comment:


New changeset b45d259bdda1de2b2d369458a9ad2e4d6f750687 by Victor Stinner in 
branch 'master':
bpo-36710: Use tstate in pylifecycle.c (GH-14249)
https://github.com/python/cpython/commit/b45d259bdda1de2b2d369458a9ad2e4d6f750687


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36511] Add Windows ARM32 buildbot

[Paul Monson]

Change by Paul Monson :


--
pull_requests: +14083
pull_request: https://github.com/python/cpython/pull/14251

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36710] Pass _PyRuntimeState as an argument rather than using the _PyRuntime global variable

[STINNER Victor]

Change by STINNER Victor :


--
pull_requests: +14082
pull_request: https://github.com/python/cpython/pull/14250

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36710] Pass _PyRuntimeState as an argument rather than using the _PyRuntime global variable

[STINNER Victor]

Change by STINNER Victor :


--
pull_requests: +14081
pull_request: https://github.com/python/cpython/pull/14249

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37250] C files generated by Cython set tp_print to 0: PyTypeObject.tp_print removed

[Steve Dower]

Steve Dower  added the comment:

> a class compiled with 3.7 could subclass a class compiled with 3.8 which uses 
> vectorcall.

This isn't a supported scenario though. The only way to mix extension modules 
compiled against different Python versions is to use the limited ABI, which 
does not include PyTypeObject. And PyType_FromSpec is going to allocate a 
PyTypeObject according to the version of Python that is running, not the one it 
was compiled against. So even if someone could force this scenario, it's not 
one we have to worry about.

> The idea is just to give more time (one Python major release) to maintainers 
> of C extensions to regenerate their Cython .c files.

If the beta cycle isn't long enough for this, then we need a longer beta cycle, 
since that's the whole point of it. Projects that can't make at least one new 
release with update Cython in time for Python 3.8 are presumably completely 
unmaintained - it's not like the 3.8 release is a huge surprise - and if 
completely unmaintained they aren't going to get a new release for 3.9 either. 
So either we fix them permanently by not removing tp_print ever, or we give 
them an entire beta release period to update their code for the new version of 
Python.

There's a discussion at 
https://discuss.python.org/t/pep-596-python-3-9-release-schedule-doubling-the-release-cadence/1828
 about updating the release cycle, and a couple of PEPs being written. That 
would be a good place to suggest that our current beta release is not long 
enough for packages to adapt to new releases.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20175] Derby #6: Convert 50 sites to Argument Clinic across 8 files

[Zackery Spytz]

Zackery Spytz  added the comment:

PR 14245 converts Modules/_multiprocessing/semaphore.c and 
Modules/_multiprocessing/multiprocessing.c.

--
nosy: +ZackerySpytz

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20175] Derby #6: Convert 50 sites to Argument Clinic across 8 files

[Zackery Spytz]

Change by Zackery Spytz :


--
pull_requests: +14080
pull_request: https://github.com/python/cpython/pull/14245

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37250] C files generated by Cython set tp_print to 0: PyTypeObject.tp_print removed

[STINNER Victor]

STINNER Victor  added the comment:

> If we should put in the workaround for 3.8, how does that make it okay to 
> remove in 3.9?

Cython has been modified to no longer set tp_print. The idea is just to give 
more time (one Python major release) to maintainers of C extensions to 
regenerate their Cython .c files.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37250] C files generated by Cython set tp_print to 0: PyTypeObject.tp_print removed

[Jeroen Demeyer]

Jeroen Demeyer  added the comment:

> We haven't released vectorcall yet, so it has no compatibility baseline.

I'm talking about the "extremely unlikely" scenario mentioned earlier: a class 
compiled with 3.7 could subclass a class compiled with 3.8 which uses 
vectorcall.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37250] C files generated by Cython set tp_print to 0: PyTypeObject.tp_print removed

[Steve Dower]

Steve Dower  added the comment:

> It will break ABI compatibility in any case where vectorcall is used, while 
> my proposal of putting tp_print at the end does not.

ABI compatibility with what? We haven't released vectorcall yet, so it has no 
compatibility baseline.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37333] Fail build on windows 10(visual studio 2019)

[miss-islington]

miss-islington  added the comment:


New changeset 389abd37ba50a327ae7388c6b016604cbd980e4b by Miss Islington (bot) 
in branch '3.8':
bpo-37333: Ensure IncludeTkinter has a value (GH-14240)
https://github.com/python/cpython/commit/389abd37ba50a327ae7388c6b016604cbd980e4b


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36511] Add Windows ARM32 buildbot

[Steve Dower]

Steve Dower  added the comment:


New changeset f355069a3337711642c3403429afb9faef93f512 by Steve Dower (Paul 
Monson) in branch 'master':
bpo-36511: Add buildbot scripts and fix tests for Windows ARM32 buildbot 
(GH-13454)
https://github.com/python/cpython/commit/f355069a3337711642c3403429afb9faef93f512


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36511] Add Windows ARM32 buildbot

[miss-islington]

Change by miss-islington :


--
pull_requests: +14079
pull_request: https://github.com/python/cpython/pull/14244

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37333] Fail build on windows 10(visual studio 2019)

[Steve Dower]

Steve Dower  added the comment:

Backport will automerge when it's done.

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37333] Fail build on windows 10(visual studio 2019)

[miss-islington]

Change by miss-islington :


--
pull_requests: +14078
pull_request: https://github.com/python/cpython/pull/14243

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34347] AIX: test_utf8_mode.test_cmd_line fails

[STINNER Victor]

STINNER Victor  added the comment:


New changeset 15e7d2432294ec46f1ad84ce958fdeb9d4ca78b1 by Victor Stinner 
(Michael Felt) in branch '3.7':
[3.7] bpo-34347: Fix test_utf8_mode.test_cmd_line for AIX (GH-8923) (GH-14233)
https://github.com/python/cpython/commit/15e7d2432294ec46f1ad84ce958fdeb9d4ca78b1


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37333] Fail build on windows 10(visual studio 2019)

[Steve Dower]

Steve Dower  added the comment:


New changeset 12f1c726d8328e5e096c35c36901f6d19bc942d3 by Steve Dower in branch 
'master':
bpo-37333: Ensure IncludeTkinter has a value (GH-14240)
https://github.com/python/cpython/commit/12f1c726d8328e5e096c35c36901f6d19bc942d3


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37341] str.format and f-string divergence

[Tim Hatch]

Tim Hatch  added the comment:

ok, I suppose it's just documentation then.

--
assignee:  -> docs@python
components: +Documentation -Library (Lib)
nosy: +docs@python

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37342] A type error in typeobj.rst

[Karthikeyan Singaravelan]

Karthikeyan Singaravelan  added the comment:

This was added with 9e7c92193cc98fd3c2d4751c87851460a33b9118 so adding Eric.

--
nosy: +eric.snow, xtreak
type:  -> behavior
versions: +Python 3.8, Python 3.9

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34373] test_time errors on AIX

[Michael Felt]

Change by Michael Felt :


--
pull_requests: +14077
pull_request: https://github.com/python/cpython/pull/14242

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37250] C files generated by Cython set tp_print to 0: PyTypeObject.tp_print removed

[Jeroen Demeyer]

Jeroen Demeyer  added the comment:

> If compatibility is the concern here, then we should be aiming for the 
> smallest diff between 3.7 and 3.8

I challenge that assertion.

The smallest diff may superficially look like the best solution, but on closer 
inspection, it is not. It will break ABI compatibility in any case where 
vectorcall is used, while my proposal of putting tp_print at the end does not.

What you propose is *worse* than the status quo.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37343] pip: Warn on vulnerable packages

[Brett Cannon]

Change by Brett Cannon :


--
resolution:  -> third party
stage:  -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37343] pip: Warn on vulnerable packages

[Karthikeyan Singaravelan]

Karthikeyan Singaravelan  added the comment:

Thanks for the report. pip development happens at https://github.com/pypa/pip/ 
where this could get better attention since CPython just vendors latest pip. 
pipenv does similar check with "pipenv check" command [0]. Similar issue on 
GitHub : https://github.com/pypa/pip/issues/6087 . I think this can be closed 
as third party issue.

[0] https://docs.pipenv.org/en/latest/#pipenv-check

--
nosy: +xtreak

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37341] str.format and f-string divergence

[Brett Cannon]

Brett Cannon  added the comment:

I also agree with Eric's assessment.

Thanks for the idea, Tim, but I'm closing this as rejected.

--
nosy: +brett.cannon
resolution:  -> rejected
stage:  -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37343] pip: Warn on vulnerable packages

[Andrew Pennebaker]

New submission from Andrew Pennebaker :

Compared to pip, NPM warns users when a dependency subtree about to be 
installed, includes known vulnerabilities. This helps devs catch security 
issues earlier, so they can update or replace critical dependencies.

Similarly, the dependency-check pip package offers the ability to detect pip 
dependencies with known vulnerabilities.

https://pypi.org/project/dependency-check/

Now that we have a workaround for warning on vulnerable pip packages, let's 
move this logic into the default pip install code, so that all Python devs are 
alerted on vulnerable dependencies.

--
messages: 346072
nosy: Andrew Pennebaker
priority: normal
severity: normal
status: open
title: pip: Warn on vulnerable packages
type: security

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37342] A type error in typeobj.rst

[hai shi]

Change by hai shi :


--
keywords: +patch
pull_requests: +14076
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/14241

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37342] A type error in typeobj.rst

[hai shi]

New submission from hai shi :

nb_index's type is unaryfunc

--
assignee: docs@python
components: Documentation
messages: 346071
nosy: docs@python, shihai1991
priority: normal
severity: normal
status: open
title: A type error in typeobj.rst

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37341] str.format and f-string divergence

[Raymond Hettinger]

Raymond Hettinger  added the comment:

I concur with Eric.  This differences are there by design.  The technical and 
security reasons are both compelling.

--
nosy: +rhettinger

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37250] C files generated by Cython set tp_print to 0: PyTypeObject.tp_print removed

[Steve Dower]

Steve Dower  added the comment:

> Can you give a least an argument of why that's better than putting back 
> tp_print at the end?

Minimal change, that's why. If there are compatibility issues with the current 
change that we need to fix, then we should make the least incompatible change 
possible, which is adding the new field at the end of the struct.

> I gave 3 why that's NOT a good idea: msg345357

Those are equally good reasons for putting tp_print back where it was, so I'm 
not sure what your point is?

Compatibility has to be measured against the 3.7 release, not previous 3.8 
prereleases. If compatibility is the concern here, then we should be aiming for 
the smallest diff between 3.7 and 3.8, even if that means we change things 
significantly between 3.8.0b1 and b2.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37339] os.path.ismount returns true on nested btrfs subvolumes

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:

os.path.ismount() uses the same simple algorithm as a portable version of 
mountpoint. But mountpoint (and findmnt) from util-linux uses Linux specific 
methods (reads /proc/mounts or something like). See also issue29707.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37250] C files generated by Cython set tp_print to 0: PyTypeObject.tp_print removed

[Jeroen Demeyer]

Jeroen Demeyer  added the comment:

> If we should put in the workaround for 3.8, how does that make it okay to 
> remove in 3.9?

I can easily change my PR to keep it in 3.9, no problem. Nick, what do you 
think?

> put the new field at the end and leave the deprecated one exactly as it was.

Can you give a least an argument of why that's better than putting back 
tp_print at the end? I gave 3 why that's NOT a good idea: msg345357

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37333] Fail build on windows 10(visual studio 2019)

[Steve Dower]

Change by Steve Dower :


--
assignee:  -> steve.dower
type:  -> compile error
versions: +Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37333] Fail build on windows 10(visual studio 2019)

[Steve Dower]

Change by Steve Dower :


--
keywords: +patch
pull_requests: +14075
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/14240

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37341] str.format and f-string divergence

[Eric V. Smith]

Eric V. Smith  added the comment:

> str.format, string.Formatter, and the _string module can only
> parse literal keys, not expressions, despite appearing to take the
> same syntax as f-strings.  I'm happy to contribute code to change
> this, but unsure if it's considered a bug or feature (now that we're
> past feature freeze for 3.8).  I would love to see these converge to
> prevent confusion and let us document in just one place.

It's a feature that str.format does not accept expressions. If it did, it would:
1: require compiler support (eval isn't good enough)
2: be a security hole magnet

I think both of these are sufficiently strong arguments that I won't support 
making expressions work in str.format().

For the security hole, you don't want:

user_provided_string.format()

to be able to execute arbitrary code. You're basically eval-ing (parts of) 
strings, and everyone would suddenly have to audit all of their code to make 
sure there are no security holes exposed.

--
versions:  -Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37341] str.format and f-string divergence

[Tim Hatch]

New submission from Tim Hatch :

TL;DR

f"{x+2}" and f"{x=}" do something sensible.
"{x+2}".format(x=1) and "{x=}".format(x=1) raise KeyError.
f"{0.1}" and "{0.1}".format(...) are different.

Having had a feature request to be able to codemod f-strings[1] and just 
learning about issue36817[2] last night, I went digging into how these are 
parsed in the standard library to be able to reuse that.

str.format, string.Formatter, and the _string module can only parse literal 
keys, not expressions, despite appearing to take the same syntax as f-strings.  
I'm happy to contribute code to change this, but unsure if it's considered a 
bug or feature (now that we're past feature freeze for 3.8).  I would love to 
see these converge to prevent confusion and let us document in just one place.

The {} and {1} style are still exceptional.

We already parse expressions and the "=" suffix acceptably,

>>> list(_string.formatter_parser("{1+1}"))
[('', '1+1', '', None)]
>>> list(_string.formatter_parser("{(x)}"))
[('', '(x)', '', None)]
>>> list(_string.formatter_parser("{x=!r:1}"))
[('', 'x=', '1', 'r')]
>>> list(_string.formatter_parser("{ x = }"))
[('', ' x = ', '', None)]

But the consumers would need to check for /=\s*$/ and call eval on the items in 
formatter_field_name_split.  (I lack a good heuristic, maybe we eval every time 
unless it's strictly numeric?)

It would also break unusual uses like these in the name of unification

>>> "{1+1}".format(**{"1+1": "zzz"})
'zzz'

and

>>> class T:
...   pass
... 
>>> setattr(T, "0", "zero")
>>> f"{T.0}"
  File "", line 1
(T.0)
   ^
SyntaxError: invalid syntax
>>> "{0.0}".format(T)
'zero'

[1] https://github.com/facebookincubator/Bowler/issues/87
[2] incorrectly listed in Misc/NEWS.d/3.8.0b1.rst as issue36774 btw

--
components: Library (Lib)
messages: 346065
nosy: barry, eric.smith, larry, lisroach, lukasz.langa, serhiy.storchaka, thatch
priority: normal
severity: normal
status: open
title: str.format and f-string divergence
type: enhancement
versions: Python 3.8, Python 3.9

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37250] C files generated by Cython set tp_print to 0: PyTypeObject.tp_print removed

[Steve Dower]

Steve Dower  added the comment:

If we should put in the workaround for 3.8, how does that make it okay to 
remove in 3.9? It's been deprecated since 3.0 already, so if we can't remove it 
after eight releases, I don't see how it's consistent to remove it after a 
ninth. Once we put it back, it basically has to stay.

The middle ground doesn't make sense. We should either replace it with the new 
field, or put the new field at the end and leave the deprecated one exactly as 
it was.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37339] os.path.ismount returns true on nested btrfs subvolumes

[Eike Fokken]

Eike Fokken  added the comment:

mountpoint /nested_subvolume returns
/nested_subvolume is not a mountpoint

mountpoint /explicitely_mounted_subvolume returns
/explicitely_mounted_subvolume is a mountpoint

so agrees with findmnt.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36753] Python modules not linking to libpython causes issues for RTLD_LOCAL system-wide

[STINNER Victor]

Change by STINNER Victor :


--
nosy: +vstinner

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36231] no "proper" header files on macOS 10.14 Mojave

[Ned Deily]

Change by Ned Deily :


--
versions: +Python 2.7, Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36231] no "proper" header files on macOS 10.14 Mojave

[Ned Deily]

Ned Deily  added the comment:

Thank you again for the suggested PR. Using "xcrun --show-sdk-path" at 
configure time *is* appealing.  Unfortunately, it does not cover all of the 
necessary use cases.

One, the --show-sdk-path option is not available on old versions of xcrun, 
versions we still build with to support older releases of macOS.  Second, some 
users build Python for macOS with compiler tool chains other than the 
Apple-supplied ones (for example, current gcc) that do not necessarily support 
the transparent selection of header and library files location via xcrun and 
friends.  Third, capturing the selected SDK path at configure time is no 
guarantee that the same SDK path will be used for extension module builds when 
setup.py runs.  With the Apple-supplied tools, the actual SDK path used is 
determined each time the compiler front-end is invoked and depends on the 
then-current selected values (e.g. the most recent value set by 'xcode-select 
--switch') and the current value of environment variables (e.g. like 
DEVELOPER_DIR and SDKROOT). Or a different or non-Apple compiler could now be 
in use by overriding CC.  In other words, lots of edge cases largely due to the 
inherent fle
 xibility of Apple's compiler frontend.

The other issue here is the behavior of setup.py in trying to make reasonable 
default choices for finding header and library files for the extension modules 
it is building; to do so, it tries to guess what the compiler frontend is going 
to do and that's the real hack.  Life would be much simpler if Python relied on 
a modern autotools build setup - although some of the same issues of dynamic 
SDK locations would still apply but at least they would apply consistently - 
and not the legacy mixture of build tools we have today.  Unfortunately, it 
would be a big deal to replace the current build system and, while it would be 
desirable, that's a very big project.

One other point: while scraping the output of the compiler is hacky, it is a 
well-known and widely-used technique and is already in use elsewhere in 
setup.py; this code was adapted from that in add_multiarch_paths().

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37258] Logging cache not cleared properly when setting level

[Vinay Sajip]

Change by Vinay Sajip :


--
stage:  -> resolved

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37258] Logging cache not cleared properly when setting level

[Vinay Sajip]

Change by Vinay Sajip :


--
stage: resolved -> 

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37301] CGIHTTPServer doesn't handle long POST requests

[shajianrui]

shajianrui  added the comment:

Yes I reproduce this problem with a slight modification to your demo. 

Using your origianl version I fail to reproduce, maybe 2*65536 bytes size is 
too small.

I just change the size of data (in test_cgi_client.py ) to 8*65536, 16*65536 
and 32*65536, and the result is shown on the image I attach.

>From the image you can see
- From 1 to 7 the length received doesn't change: always
  195540 bytes.And the process of sending are really slow.
- At 8th test the server receive complete data. And the 
  sending is finished in a flash.(Maybe the socket suddenly
  enlarge the buffer?)
- From 9 to 10 seems the "buffer" become smaller and smaller.

However, in my demo(Post in my last message), the data can be up to 65536*1024 
bytes and 【seldom】 produce this problem.

I use "seldom" because I now confirm: If too many (more than 10) testclient.py 
are executed at the same time, the testserver.py will produce the problem too. 
Like this:

testserver.py output:
Connection closed.
67108864
0
Connection closed.
67108864
0
Connection closed.
67108864
0
Connection closed.
195640   # From here the problem show up.
42440740
2035240
9327940
13074300
35004
0
Connection closed.
67108864
0
Connection closed.

Seems this is a normal behavior of rfile.read() that it may not return as many 
bytes as we tell it to read.

Now I have a problem: Why the bytes returned from "rfile.read()" is so few when 
the rfile is in CGIHTTPRequestHandler?

--
Added file: https://bugs.python.org/file48428/image.PNG

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37339] os.path.ismount returns true on nested btrfs subvolumes

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:

What does the mountpoint command returns?

--
nosy: +serhiy.storchaka

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29001] logging.handlers.RotatingFileHandler rotation broken under gunicorn

[Vinay Sajip]

Vinay Sajip  added the comment:

Closing, as per last comment.

--
resolution:  -> not a bug
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35185] Logger race condition - loses lines if removeHandler called from another thread while logging

[Vinay Sajip]

Vinay Sajip  added the comment:

The other alternative would be to lock around callHandlers(). With the change 
you propose to addHandler/removeHandler, there are no errors, but the output of 
your test program is (with the lock acquisition/release in place):

Thread finished after 468 iterations
Thread finished after 488 iterations
Thread finished after 476 iterations
Thread finished after 462 iterations

If the lock acquisition/release is removed from addHandler/removeHandler, then 
there are still no errors, and the output is:

Thread finished after 479 iterations
Thread finished after 453 iterations
Thread finished after 468 iterations
Thread finished after 469 iterations

If I leave addHandler/removeHandler as they were and add locking around 
callHandlers(), there are no errors and the output is:

Thread finished after 566 iterations
Thread finished after 608 iterations
Thread finished after 612 iterations
Thread finished after 605 iterations

This seems to suggest that locking around callHandlers() is better (more 
performant) than the copying of handler lists involved in your suggestion. Any 
comments on that? Also it will work in non-GIL environments like 
Jython/IronPython.

The callHandlers() locking will of course add a cost even for those situations 
where handlers aren't added and removed in multi-threading scenarios, but I 
haven't benchmarked it yet. It's generally not good practice to add/remove 
handlers willy-nilly in threads, though of course it's not forbidden (e.g. the 
configuration functionality allows a thread to listen for configuration changes 
at runtime and then reconfigure logging, which adds/removes handlers in the 
thread. However, loggers are disabled while the reconfiguration is in progress, 
and some loss of messages would be expected to be tolerable in such a case).

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34720] Fix test_importlib.test_bad_traverse for AIX

[Michael Felt]

Change by Michael Felt :


--
pull_requests: +14074
pull_request: https://github.com/python/cpython/pull/14238

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37340] remove free_list for bound method objects

[Inada Naoki]

Inada Naoki  added the comment:

Sorry, I just pushed another idea before I leave my office.
I will benchmark both ideas after bpo-37337 is finished.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28890] logging.handlers: Document that QueueListener is a daemon thread

[Vinay Sajip]

New submission from Vinay Sajip :

Why does that particularly need documenting? If it were a non-daemon thread, 
that might need documenting as the program would have to join() it or else seem 
to hang, but what does it matter if it's a daemon thread?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36033] logging.makeLogRecord should update "rv" using a dict defined with bytes instead of strings

[Vinay Sajip]

Vinay Sajip  added the comment:

Closing, as no further feedback from issue reporter. Feel free to reopen if you 
have a good response to my last comment.

--
resolution:  -> not a bug
stage:  -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35995] logging.handlers.SMTPHandler

[Vinay Sajip]

Vinay Sajip  added the comment:

Closing, as no answer has been received to the last question.

--
resolution:  -> not a bug
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11192] test_socket error on AIX

[Michael Felt]

Change by Michael Felt :


--
pull_requests: +14073
pull_request: https://github.com/python/cpython/pull/14237

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37331] logging.handlers.DatagramHandler sends bad data to socketserver.DatagramRequestHandler

[Vinay Sajip]

Change by Vinay Sajip :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed
versions: +Python 3.8, Python 3.9

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37331] logging.handlers.DatagramHandler sends bad data to socketserver.DatagramRequestHandler

[Vinay Sajip]

Vinay Sajip  added the comment:


New changeset d7232f0e4646803f0bbaede6e1fa124156135512 by Vinay Sajip (Miss 
Islington (bot)) in branch '3.8':
bpo-37331: Clarify format of socket handler messages in the documentation. 
(GH-14234) (GH-14235)
https://github.com/python/cpython/commit/d7232f0e4646803f0bbaede6e1fa124156135512


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37331] logging.handlers.DatagramHandler sends bad data to socketserver.DatagramRequestHandler

[Vinay Sajip]

Vinay Sajip  added the comment:


New changeset b64e42e931a3598d6f0605ec78673772f97ecd4c by Vinay Sajip (Miss 
Islington (bot)) in branch '3.7':
bpo-37331: Clarify format of socket handler messages in the documentation. 
(GH-14234) (GH-14236)
https://github.com/python/cpython/commit/b64e42e931a3598d6f0605ec78673772f97ecd4c


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36704] logging.FileHandler currently hardcodes errors='strict'

[Vinay Sajip]

Vinay Sajip  added the comment:

Fixed as part of the fix for bpo-37111.

--
resolution:  -> fixed
stage:  -> resolved
status: open -> closed
versions: +Python 3.9 -Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28595] shlex.shlex should not augment wordchars

[Vinay Sajip]

Change by Vinay Sajip :


--
resolution:  -> fixed
stage:  -> resolved
status: open -> closed
versions: +Python 3.8 -Python 3.6, Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37331] logging.handlers.DatagramHandler sends bad data to socketserver.DatagramRequestHandler

[miss-islington]

Change by miss-islington :


--
pull_requests: +14072
pull_request: https://github.com/python/cpython/pull/14236

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37331] logging.handlers.DatagramHandler sends bad data to socketserver.DatagramRequestHandler

[miss-islington]

Change by miss-islington :


--
pull_requests: +14071
pull_request: https://github.com/python/cpython/pull/14235

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37331] logging.handlers.DatagramHandler sends bad data to socketserver.DatagramRequestHandler

[Vinay Sajip]

Vinay Sajip  added the comment:


New changeset f06b569305cf604f070776ea3f800ed61fdd7d61 by Vinay Sajip in branch 
'master':
bpo-37331: Clarify format of socket handler messages in the documentation. 
(GH-14234)
https://github.com/python/cpython/commit/f06b569305cf604f070776ea3f800ed61fdd7d61


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36231] no "proper" header files on macOS 10.14 Mojave

[Jeroen Demeyer]

Change by Jeroen Demeyer :


--
nosy: +jdemeyer

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37331] logging.handlers.DatagramHandler sends bad data to socketserver.DatagramRequestHandler

[Vinay Sajip]

Change by Vinay Sajip :


--
keywords: +patch
pull_requests: +14070
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/14234

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34347] AIX: test_utf8_mode.test_cmd_line fails

[Michael Felt]

Change by Michael Felt :


--
pull_requests: +14069
pull_request: https://github.com/python/cpython/pull/14233

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36231] no "proper" header files on macOS 10.14 Mojave

[Dmitrii Pasechnik]

Dmitrii Pasechnik  added the comment:

I find it puzzling that a relatively clean and short solution using autotools 
and the Apple-approved way to get the location of the headers is rejected, and 
a hacky, longer way that scrapes output of the compiler is being pushed instead.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37331] logging.handlers.DatagramHandler sends bad data to socketserver.DatagramRequestHandler

[Vinay Sajip]

Vinay Sajip  added the comment:

It is mentioned here:

https://docs.python.org/3/library/logging.handlers.html?highlight=datagramhandler#logging.handlers.SocketHandler.makePickle

although that doesn't go into the detail of the struct.pack format. I'll update 
the documentation to rectify this.

--
assignee:  -> docs@python
components: +Documentation -Library (Lib)
nosy: +docs@python

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37258] Logging cache not cleared properly when setting level

[Vinay Sajip]

Change by Vinay Sajip :


--
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37258] Logging cache not cleared properly when setting level

[Vinay Sajip]

Vinay Sajip  added the comment:


New changeset 95ff622028b4f5d2eefbff557eadbb08fbcd42b1 by Vinay Sajip (Miss 
Islington (bot)) in branch '3.8':
bpo-37258: Not a bug, but added a unit test and updated documentation. 
(GH-14229) (GH-14230)
https://github.com/python/cpython/commit/95ff622028b4f5d2eefbff557eadbb08fbcd42b1


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37258] Logging cache not cleared properly when setting level

[Vinay Sajip]

Vinay Sajip  added the comment:


New changeset 9eb4b2c8a3387ea901dad793e8d5586880a5968e by Vinay Sajip (Miss 
Islington (bot)) in branch '3.7':
bpo-37258: Not a bug, but added a unit test and updated documentation. 
(GH-14229) (GH-14231)
https://github.com/python/cpython/commit/9eb4b2c8a3387ea901dad793e8d5586880a5968e


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37340] remove free_list for bound method objects

[Jeroen Demeyer]

Jeroen Demeyer  added the comment:

Are the benchmark results that you posted above for removing the free list 
completely or for the one-element free list as in PR 14232?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37340] remove free_list for bound method objects

[Jeroen Demeyer]

Jeroen Demeyer  added the comment:

> GH-14232 uses only one free object instead of at most 256 free list.

That sounds like a compromise which is worse than either extreme: it's worse 
than no free list because you still have the overhead of dealing with the one 
object. And it's worse than a free list of 256 because it won't for nested 
calls.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37340] remove free_list for bound method objects

[Inada Naoki]

Inada Naoki  added the comment:

GH-14232 uses only one free object instead of at most 256 free list.

--
stage: patch review -> 

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37340] remove free_list for bound method objects

[Inada Naoki]

Change by Inada Naoki :


--
keywords: +patch
pull_requests: +14068
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/14232

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37340] remove free_list for bound method objects

[Jeroen Demeyer]

Jeroen Demeyer  added the comment:

> I will run pyperformance again after bpo-37337 is merged.

Good idea. bpo-37337 removes many calls of _PyObject_CallMethodId() which does 
NOT use the LOAD_METHOD optimization.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37340] remove free_list for bound method objects

[Inada Naoki]

Inada Naoki  added the comment:

PyCFunction has similar free_list.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37340] remove free_list for bound method objects

[Inada Naoki]

New submission from Inada Naoki :

LOAD_METHOD avoids temporary bound method object.
PyObject_CallMethodObjArgs now use same optimization.

Now I think there is not enough performance benefit from free_list.
When free_list is not used often enough, it may bother obmalloc reuse memory 
pool.

This is performance diff of removing free_list (with LTO, without PGO, 
patched=removed free_list):

```
$ ./python -m pyperf compare_to master.json patched.json -G --min-speed=1
Slower (19):
- sqlite_synth: 4.03 us +- 0.10 us -> 4.20 us +- 0.08 us: 1.04x slower (+4%)
- genshi_text: 41.2 ms +- 0.4 ms -> 42.6 ms +- 0.4 ms: 1.03x slower (+3%)
- scimark_sparse_mat_mult: 6.29 ms +- 0.03 ms -> 6.50 ms +- 0.50 ms: 1.03x 
slower (+3%)
- mako: 26.5 ms +- 0.1 ms -> 27.4 ms +- 0.3 ms: 1.03x slower (+3%)
- html5lib: 130 ms +- 4 ms -> 134 ms +- 5 ms: 1.03x slower (+3%)
- genshi_xml: 83.4 ms +- 1.1 ms -> 85.6 ms +- 1.2 ms: 1.03x slower (+3%)
- pickle: 15.1 us +- 0.5 us -> 15.5 us +- 0.5 us: 1.03x slower (+3%)
- float: 161 ms +- 1 ms -> 165 ms +- 1 ms: 1.02x slower (+2%)
- logging_simple: 13.9 us +- 0.2 us -> 14.2 us +- 0.2 us: 1.02x slower (+2%)
- xml_etree_process: 108 ms +- 1 ms -> 110 ms +- 1 ms: 1.02x slower (+2%)
- pathlib: 28.0 ms +- 0.2 ms -> 28.5 ms +- 0.3 ms: 1.02x slower (+2%)
- pickle_pure_python: 703 us +- 8 us -> 715 us +- 7 us: 1.02x slower (+2%)
- sympy_expand: 553 ms +- 5 ms -> 563 ms +- 12 ms: 1.02x slower (+2%)
- xml_etree_generate: 136 ms +- 2 ms -> 138 ms +- 1 ms: 1.02x slower (+2%)
- logging_format: 15.3 us +- 0.2 us -> 15.5 us +- 0.2 us: 1.01x slower (+1%)
- json_dumps: 17.4 ms +- 0.1 ms -> 17.7 ms +- 0.2 ms: 1.01x slower (+1%)
- logging_silent: 266 ns +- 5 ns -> 269 ns +- 9 ns: 1.01x slower (+1%)
- django_template: 163 ms +- 1 ms -> 165 ms +- 2 ms: 1.01x slower (+1%)
- sympy_sum: 219 ms +- 2 ms -> 222 ms +- 2 ms: 1.01x slower (+1%)

Faster (6):
- regex_effbot: 4.51 ms +- 0.04 ms -> 4.44 ms +- 0.03 ms: 1.02x faster (-2%)
- pickle_list: 5.21 us +- 0.04 us -> 5.13 us +- 0.04 us: 1.01x faster (-1%)
- crypto_pyaes: 164 ms +- 1 ms -> 162 ms +- 1 ms: 1.01x faster (-1%)
- xml_etree_parse: 202 ms +- 7 ms -> 200 ms +- 3 ms: 1.01x faster (-1%)
- scimark_sor: 287 ms +- 6 ms -> 284 ms +- 6 ms: 1.01x faster (-1%)
- raytrace: 758 ms +- 26 ms -> 750 ms +- 11 ms: 1.01x faster (-1%)

Benchmark hidden because not significant (35)
```

I think free_list is useful only when several benchmarks in pyperformance shows 
more than 5% speedup.
The benefit is smaller than my threshold.  I will run pyperformance again after 
bpo-37337 is merged.

FWIW, In case of sqlite_synth, I think performance difference came from here:
https://github.com/python/cpython/blob/015000165373f8db263ef5bc682f02d74e5782ac/Modules/_sqlite/connection.c#L662
If performance of user-defined aggregate feature is really important, we can 
optimize it further.

--
components: Interpreter Core
messages: 346040
nosy: inada.naoki, jdemeyer
priority: normal
severity: normal
status: open
title: remove free_list for bound method objects
type: performance
versions: Python 3.9

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34831] Asyncio Tutorial

[Caleb Hattingh]

Caleb Hattingh  added the comment:

I'm removing the GUI section of the chat case study. Yury was right, it's not 
going to add anything useful. The CLI chat client will work well because 
prompt-toolkit has actual support for asyncio.  Tkinter does not, and I think 
it'll be better to add a GUI section to this tutorial only once Tkinter gets 
first-class support for asyncio.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com