[issue41559] Add support for PEP 612 (Parameter Specification Variables) to typing.py

[Ken Jin]

Ken Jin  added the comment:

I have just one more PR - one that converts genericalias nested lists to
tuples by default. It'll simplify the code a little bit and prepare 3.9.x
for PEP 612.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42807] smtplib send_message should gives more clear exception if the msg is None

[oon arfiandwi]

New submission from oon arfiandwi :

I want to enhance the error message on the send_message method of class SMTP, 
in module smtplib.

One of the parameters on send_message is msg which is email.message.Message 
object, this is a required argument. If the msg is None, currently it will 
raise "AttributeError: 'NoneType' object has no attribute 'get_all'".
This message is not straight forward and a bit hard to debug.

As the easy fix with additional check if msg is None in send_message method.

I want to add PR on this, also with the additional test(s). This is my first 
issue, appreciate any feedback. thank you.

--
components: Library (Lib)
messages: 384216
nosy: oon
priority: normal
severity: normal
status: open
title: smtplib send_message should gives more clear exception if the msg is None
type: behavior
versions: Python 3.10

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42756] smtplib.LMTP.connect() raises TypeError if `timeout` is not specified

[Dong-hee Na]

Dong-hee Na  added the comment:

Thanks, Ross Rhodes for the fix!
And thanks, Wüstengecko for the report!

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42756] smtplib.LMTP.connect() raises TypeError if `timeout` is not specified

[Dong-hee Na]

Dong-hee Na  added the comment:


New changeset 69120613c071e9327a9dc6e4b1ff21b2e94d885e by Ross in branch '3.9':
[3.9] bpo-42756: Configure LMTP Unix-domain socket to use global default 
timeout when timeout not provided (GH-23969) (GH-24050)
https://github.com/python/cpython/commit/69120613c071e9327a9dc6e4b1ff21b2e94d885e


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue7946] Convoy effect with I/O bound threads and New GIL

[David Beazley]

Change by David Beazley :


--
stage:  -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16894] Function attribute access doesn't invoke methods in dict subclasses

[David Beazley]

Change by David Beazley :


--
stage:  -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24844] Python 3.5rc1 compilation error with Apple clang 4.2 included with Xcode 4

[David Beazley]

Change by David Beazley :


--
stage:  -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32810] Expose ags_gen and agt_gen in asynchronous generators

[David Beazley]

Change by David Beazley :


--
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27436] Strange code in selectors.KqueueSelector

[David Beazley]

Change by David Beazley :


--
stage:  -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16132] ctypes incorrectly encodes .format attribute of memory views

[David Beazley]

Change by David Beazley :


--
stage:  -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41559] Add support for PEP 612 (Parameter Specification Variables) to typing.py

[Guido van Rossum]

Guido van Rossum  added the comment:

Looks like we can close this now, right? You can open a separate issue in the 
python/typing repo to update typing_extensions.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41559] Add support for PEP 612 (Parameter Specification Variables) to typing.py

[Guido van Rossum]

Guido van Rossum  added the comment:


New changeset 11276cd9c49faea66ce7760f26a238d1edbf6421 by Ken Jin in branch 
'master':
bpo-41559: Documentation for PEP 612 (GH-24000)
https://github.com/python/cpython/commit/11276cd9c49faea66ce7760f26a238d1edbf6421


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42806] Incorrect offsets in new parser for f-string substitutions

[Anthony Sottile]

Anthony Sottile  added the comment:

I didn't initially, but now I have and it has the same bug in the current 
master: 3bf05327c2b25d42b92795d9d280288c22a0963d

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42806] Incorrect offsets in new parser for f-string substitutions

[Guido van Rossum]

Guido van Rossum  added the comment:

Did you check this with master?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30044] shutil.copystat should (allow to) copy ownership, and other attributes

[Rahul Jha]

Change by Rahul Jha :


--
nosy: +RJ722

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42806] Incorrect offsets in new parser for f-string substitutions

[Anthony Sottile]

Anthony Sottile  added the comment:

+peg parser individuals to nosy

--
nosy: +gvanrossum, lys.nikolaou, pablogsal

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34451] docs: tutorial/introduction doesn't mention toggle of prompts

[Rahul Jha]

Change by Rahul Jha :


--
nosy: +RJ722

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42806] Incorrect offsets in new parser for f-string substitutions

[Anthony Sottile]

New submission from Anthony Sottile :

here's a sample file.  this is distilled down from an example which broke a 
code formatter here: https://github.com/asottile/add-trailing-comma/issues/106

def f():
x = (
'PERL_MM_OPT', (
f'INSTALL-BASE={shlex.quote(venv)} '
f'wat'
),
)


A diff from astpretty (https://github.com/asottile/astpretty) between the old 
and new parser:

```console
$ diff -u <(.tox/py39/bin/python -X oldparser -m astpretty perl.py) 
<(.tox/py39/bin/python -m astpretty perl.py)
--- /dev/fd/63  2021-01-01 15:58:09.108060968 -0800
+++ /dev/fd/62  2021-01-01 15:58:09.108060968 -0800
@@ -35,19 +35,19 @@
 end_col_offset=22,
 value=Call(
 lineno=4,
-col_offset=32,
+col_offset=16,
 end_lineno=4,
-end_col_offset=49,
+end_col_offset=33,
 func=Attribute(
 lineno=4,
-col_offset=32,
+col_offset=16,
 end_lineno=4,
-end_col_offset=43,
-value=Name(lineno=4, 
col_offset=32, end_lineno=4, end_col_offset=37, id='shlex', ctx=Load()),
+end_col_offset=27,
+value=Name(lineno=4, 
col_offset=16, end_lineno=4, end_col_offset=21, id='shlex', ctx=Load()),
 attr='quote',
 ctx=Load(),
 ),
-args=[Name(lineno=4, 
col_offset=44, end_lineno=4, end_col_offset=48, id='venv', ctx=Load())],
+args=[Name(lineno=4, 
col_offset=28, end_lineno=4, end_col_offset=32, id='venv', ctx=Load())],
 keywords=[],
 ),
 conversion=-1,
```

the old parser is correct here, and the new parser is wrong

notably it thinks that the call inside the f-string substitution is positioned 
at column 16 which is the position of the f-string start

this bug is also present in 3.10:

```console
$ venv/bin/python3.10 --version
Python 3.10.0a3
$ diff -u <(.tox/py39/bin/python -X oldparser -m astpretty perl.py) 
<(venv/bin/python3.10 -m astpretty perl.py)
--- /dev/fd/63  2021-01-01 15:59:54.59968 -0800
+++ /dev/fd/62  2021-01-01 15:59:54.59968 -0800
@@ -35,19 +35,19 @@
 end_col_offset=22,
 value=Call(
 lineno=4,
-col_offset=32,
+col_offset=16,
 end_lineno=4,
-end_col_offset=49,
+end_col_offset=33,
 func=Attribute(
 lineno=4,
-col_offset=32,
+col_offset=16,
 end_lineno=4,
-end_col_offset=43,
-value=Name(lineno=4, 
col_offset=32, end_lineno=4, end_col_offset=37, id='shlex', ctx=Load()),
+end_col_offset=27,
+value=Name(lineno=4, 
col_offset=16, end_lineno=4, end_col_offset=21, id='shlex', ctx=Load()),
 attr='quote',
 ctx=Load(),
 ),
-args=[Name(lineno=4, 
col_offset=44, end_lineno=4, end_col_offset=48, id='venv', ctx=Load())],
+args=[Name(lineno=4, 
col_offset=28, end_lineno=4, end_col_offset=32, id='venv', ctx=Load())],
 keywords=[],
 ),
 conversion=-1,
```

--
components: Interpreter Core
messages: 384208
nosy: Anthony Sottile
priority: normal
severity: normal
status: open

[issue42805] broken pygame integration into wxpython

[monchy]

monchy  added the comment:

The only thing I changed was the version of python I was using, which means
that whatever caused the problem was python itself
if something was changed in how the interpreter operates the environmental
variables or something then that might do it
PYTHON broke MY software, so this and this alone is the appropriate bug
tracker

On Fri, 1 Jan 2021 at 15:54, Serhiy Storchaka 
wrote:

>
> Serhiy Storchaka  added the comment:
>
> Pygame and wxpython are not parts of the stdlib. Please use an appropriate
> bug tracker.
>
> --
> nosy: +serhiy.storchaka
> resolution:  -> third party
> stage:  -> resolved
> status: open -> closed
>
> ___
> Python tracker 
> 
> ___
>

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42805] broken pygame integration into wxpython

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:

Pygame and wxpython are not parts of the stdlib. Please use an appropriate bug 
tracker.

--
nosy: +serhiy.storchaka
resolution:  -> third party
stage:  -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42759] Take into acount a Tcl interpreter when compare variables and fonts

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26407] csv.writer.writerows masks exceptions from __iter__

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
resolution:  -> fixed
stage: commit review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39068] Base 85 encoding initialization race condition

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed
versions: +Python 3.10, Python 3.8, Python 3.9 -Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39068] Base 85 encoding initialization race condition

[miss-islington]

miss-islington  added the comment:


New changeset 0d6e40744ae40ff397883ff90ca235efd3b63f18 by Miss Islington (bot) 
in branch '3.9':
bpo-39068: Fix race condition in base64 (GH-17627)
https://github.com/python/cpython/commit/0d6e40744ae40ff397883ff90ca235efd3b63f18


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42686] include built-in Math functions in SQLite to 3.35.0 of march 2021

[Erlend Egeberg Aasland]

Change by Erlend Egeberg Aasland :


--
keywords: +patch
pull_requests: +22888
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/24053

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42686] include built-in Math functions in SQLite to 3.35.0 of march 2021

[Erlend Egeberg Aasland]

Erlend Egeberg Aasland  added the comment:

Yes, R. Hipp has fixed this here: 
https://www2.sqlite.org/cgi/src/info/e5d7209e118a8453
We still need to modify PCbuild in order to build the SQLite library with math 
functions from 3.35.0 and onwards.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42805] broken pygame integration into wxpython

[monchy]

New submission from monchy :

in previous python verions a pygame window could be embedded into wxpython by 
assigning the SDL_WINDOWID to the current wx.Panel.GetHandle() and the 
SDL_VIDEODRIVER to 'windib' before importing python
the same code creates a separate pygame window in the newest python version
a basic implementation can be found here:
https://github.com/Monchytales/Puppet-Theatre/blob/main/pygame_panel.py

--
messages: 384203
nosy: MonchyTales
priority: normal
severity: normal
status: open
title: broken pygame integration into wxpython
type: behavior
versions: Python 3.9

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42794] test_nntplib fails on CI

[STINNER Victor]

STINNER Victor  added the comment:

Thanks Dong-hee Na for the fix!

We have many tests using external services, like test_ssl that Christian may 
know ;-)
https://pythondev.readthedocs.io/infra.html#services-used-by-unit-tests

--
resolution:  -> fixed
stage:  -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42804] Unable to compile the cpython code x86 windows

[Sunny]

Sunny  added the comment:

I am running using admin rights but still getting the error

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42804] Unable to compile the cpython code x86 windows

[Bharath Posa]

Bharath Posa  added the comment:

I just ran the file but got the below error 
 saying permission denied 

PermissionError: [WinError 5] Access is denied: 
'E:\\Libarary\\workspace\\python_dev\\cpython\\PCbuild\\..\\externals\\cpython-bin-deps-tcltk-8.6.9.0'
 -> 
'E:\\Libarary\\workspace\\python_dev\\cpython\\PCbuild\\..\\externals\\tcltk-8.6.9.0'

--
Added file: https://bugs.python.org/file49716/errors_python.JPG

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42804] Unable to compile the cpython code x86 windows

[Dennis Sweeney]

Dennis Sweeney  added the comment:

Were you able to run PCbuild\get_externals.bat ?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42794] test_nntplib fails on CI

[Ned Deily]

Ned Deily  added the comment:


New changeset 546baba63a446e261d0248338f9034e56eccfc46 by Miss Islington (bot) 
in branch '3.6':
bpo-42794: Update test_nntplib to use offical group name for testing (GH-24037) 
(GH-24042)
https://github.com/python/cpython/commit/546baba63a446e261d0248338f9034e56eccfc46


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42794] test_nntplib fails on CI

[Ned Deily]

Ned Deily  added the comment:


New changeset 8200ee66697601a8766f234d6eb8e4c8735216fd by Miss Islington (bot) 
in branch '3.7':
bpo-42794: Update test_nntplib to use offical group name for testing (GH-24037) 
(GH-24041)
https://github.com/python/cpython/commit/8200ee66697601a8766f234d6eb8e4c8735216fd


--
nosy: +ned.deily

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42804] Unable to compile the cpython code x86 windows

[Bharath Posa]

Bharath Posa  added the comment:

Followed the instructions as per the link 
https://devguide.python.org/setup/#setup


While running the command build.bat

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42804] Unable to compile the cpython code x86 windows

[Dennis Sweeney]

Dennis Sweeney  added the comment:

What commands did you enter? Are you following the instructions at 
https://devguide.python.org/setup/ ?

--
nosy: +Dennis Sweeney

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42804] Unable to compile the cpython code x86 windows

[Bharath Posa]

Change by Bharath Posa :


--
title: Unable to compile the code x86 windows -> Unable to compile the cpython 
code x86 windows
type:  -> compile error

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42804] Unable to compile the code x86 windows

[Bharath Posa]

New submission from Bharath Posa :

Hi Team,

While I am trying to build the  cpython in windows 10. I am getting tcl.h file 
not found error.

You can find the screen shot of the error along with the bug.

regards
Sunny

--
components: Build
files: error_python_compilation.JPG
messages: 384194
nosy: pbharat
priority: normal
severity: normal
status: open
title: Unable to compile the code x86 windows
versions: Python 3.8
Added file: https://bugs.python.org/file49715/error_python_compilation.JPG

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42686] include built-in Math functions in SQLite to 3.35.0 of march 2021

[Big Stone]

Big Stone  added the comment:

it seems resolved now, at least with VS 2019

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2142] difflib.unified_diff(...) produces invalid patches

[Paul "TBBle" Hampson]

Paul "TBBle" Hampson  added the comment:

I just bounced off this issue and proposed a work-around for it in Black 
(https://github.com/psf/black/pull/1897).

Since it wasn't mentioned here earlier, the `\` marker _is_ documented in the 
GNU Diffutils documentation, under "Incomplete Lines" 
(https://www.gnu.org/software/diffutils/manual/html_node/Incomplete-Lines.html#Incomplete-Lines),
 and applies to both Context and Normal diff output formats.

--
nosy: +TBBle

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39068] Base 85 encoding initialization race condition

[miss-islington]

Change by miss-islington :


--
pull_requests: +22887
pull_request: https://github.com/python/cpython/pull/24051

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26407] csv.writer.writerows masks exceptions from __iter__

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:


New changeset 6dffa67b98f78ae41b596f84478f3379f55d4d03 by Serhiy Storchaka in 
branch '3.8':
[3.8] bpo-26407: Do not mask errors in csv. (GH-20536) (GH-24021)
https://github.com/python/cpython/commit/6dffa67b98f78ae41b596f84478f3379f55d4d03


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39068] Base 85 encoding initialization race condition

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:


New changeset b863607d303a87e8680149361ac987328b35ca5f by Serhiy Storchaka in 
branch '3.8':
[3.8] bpo-39068: Fix race condition in base64 (GH-17627) (GH-24022)
https://github.com/python/cpython/commit/b863607d303a87e8680149361ac987328b35ca5f


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36589] Incorrect error handling in curses.update_lines_cols()

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:


New changeset 187785e2fa2050156a6eda93fb2da31db13f07a6 by Serhiy Storchaka in 
branch '3.8':
[3.8] bpo-36589: Fix the error handling in curses.update_lines_cols(). 
(GH-12766) (GH-24023)
https://github.com/python/cpython/commit/187785e2fa2050156a6eda93fb2da31db13f07a6


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42425] Possible leak in initialization of errmap for OSError

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:


New changeset 1a544e1dcf8e0880ee35ce78a7f90fc4e5c98c4f by Serhiy Storchaka in 
branch '3.8':
[3.8] bpo-42425: Fix possible leak in initialization of errmap for OSError 
(GH-23446). (GH-24025)
https://github.com/python/cpython/commit/1a544e1dcf8e0880ee35ce78a7f90fc4e5c98c4f


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42759] Take into acount a Tcl interpreter when compare variables and fonts

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:


New changeset e3a9adba329681b1b73b7223515e71e94fc35e12 by Serhiy Storchaka in 
branch '3.8':
[3.8] bpo-42759: Fix equality comparison of Variable and Font in Tkinter 
(GH-23968) (GH-24026)
https://github.com/python/cpython/commit/e3a9adba329681b1b73b7223515e71e94fc35e12


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42756] smtplib.LMTP.connect() raises TypeError if `timeout` is not specified

[Ross Rhodes]

Change by Ross Rhodes :


--
pull_requests: +22886
pull_request: https://github.com/python/cpython/pull/24050

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42756] smtplib.LMTP.connect() raises TypeError if `timeout` is not specified

[Dong-hee Na]

Change by Dong-hee Na :


--
pull_requests:  -22885

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42756] smtplib.LMTP.connect() raises TypeError if `timeout` is not specified

[Dong-hee Na]

Change by Dong-hee Na :


--
pull_requests: +22885
pull_request: https://github.com/python/cpython/pull/24049

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42756] smtplib.LMTP.connect() raises TypeError if `timeout` is not specified

[Dong-hee Na]

Dong-hee Na  added the comment:


New changeset 3bf05327c2b25d42b92795d9d280288c22a0963d by Ross in branch 
'master':
bpo-42756: Configure LMTP Unix-domain socket to use global default timeout when 
timeout not provided (GH-23969)
https://github.com/python/cpython/commit/3bf05327c2b25d42b92795d9d280288c22a0963d


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42802] distutils: Remove bdist_wininst command

[Jeremy Kloth]

Change by Jeremy Kloth :


--
nosy: +jkloth

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42794] test_nntplib fails on CI

[Marc-Andre Lemburg]

Marc-Andre Lemburg  added the comment:

Thanks for the patch, Dong-hee Na.

Christian: Tests relying on external resources will always have such issues. 
This doesn't mean that the code which is being tested is outdated or broken. 
It's just an issue with the tests. Perhaps we ought to disable external tests 
for NNTP on CI or ask the PSF to setup a news server for testing purposes (just 
like we have for SSL tests), e.g. news.pythontest.net mirroring 
comp.lang.python.

--
stage: patch review -> 

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42794] test_nntplib fails on CI

[Christian Heimes]

Christian Heimes  added the comment:

> The test fails because it was relying on an external news server's
> configuratoin. This doesn't mean the code itself is broken, just the
> test, so clearly: no.

Broken and unstable tests are one of two reasons why I listed nntplib in my 
PEP, https://www.python.org/dev/peps/pep-0594/#nntplib .

Q.E.D.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue4643] cgitb.html fails if getattr call raises exception

[Irit Katriel]

Irit Katriel  added the comment:

On closer scrutiny I'm not sure this patch should be merged. 

The getattr call here has a default value, so it should not raise 
AttributeError. It should also not raise any other exception because a valid 
implementation of __getattr__ should raise only AttributeError:

https://docs.python.org/3/reference/datamodel.html#object.__getattr__

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue4643] cgitb.html fails if getattr call raises exception

[Irit Katriel]

Change by Irit Katriel :


--
Removed message: https://bugs.python.org/msg384182

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue4643] cgitb.html fails if getattr call raises exception

[Irit Katriel]

Irit Katriel  added the comment:

On closer scrutiny I'm not sure this patch should not be merged. 

The getattr call here has a default value, so it should not raise 
AttributeError. It should also not raise any other exception because a valid 
implementation of __getattr__ should raise only AttributeError:

https://docs.python.org/3/reference/datamodel.html#object.__getattr__

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42802] distutils: Remove bdist_wininst command

[STINNER Victor]

STINNER Victor  added the comment:

I created a https://discuss.python.org/t/remove-bdist-wininst-command/6434 
topic to check if anyone wants to keep the command, or if it's ok to remove it 
right now.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42802] distutils: Remove bdist_wininst command

[STINNER Victor]

STINNER Victor  added the comment:

Note: bdist_msi is deprecated since Python 3.9 (bpo-39586). I prefer to wait 
for Python 3.11 to remove it:

commit 29b3fc0a18f105de666fdd586b537f34e349766d
Author: Hugo van Kemenade 
Date:   Mon Feb 10 15:26:40 2020 +0200

bpo-39586: Deprecate distutils bdist_msi command (GH-18415)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42802] distutils: Remove bdist_wininst command

[STINNER Victor]

STINNER Victor  added the comment:

FYI last year, I fixed setuptools v45.2 (released in February 2020) when 
bdist_wininst is missing:
https://github.com/pypa/setuptools/commit/5d17586a56077dfa3109a5861cf0ff579095a42e

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42802] distutils: Remove bdist_wininst command

[STINNER Victor]

Change by STINNER Victor :


--
keywords: +patch
pull_requests: +22884
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/24043

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42803] Traced line number is wrong for "if not __debug__"

[Ned Batchelder]

New submission from Ned Batchelder :

(Using CPython commit 6b1ac809b9)

This program never executes line 4, but the "if not __debug__" is partly 
attributed to line 4, giving an incorrect trace:

for value in [True, False]:
if value:
if not __debug__:
1/0 # line 4
else:
x = 6

Using a simple trace program 
(https://github.com/nedbat/coveragepy/blob/master/lab/run_trace.py), it 
produces this output:

call  1 @-1
line  1 @0
line  2 @8
line  3 @12
line  4 @14
line  1 @4
line  2 @8
line  6 @16
line  1 @4
return  1 @24

Various simplifications of the program make the problem go away.

--
components: Interpreter Core
messages: 384178
nosy: Mark.Shannon, nedbat
priority: normal
severity: normal
status: open
title: Traced line number is wrong for "if not __debug__"
versions: Python 3.10

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42794] test_nntplib fails on CI

[miss-islington]

miss-islington  added the comment:


New changeset b20d5e5ce95248e0fa77c5d7bf8f6f5b1231fa53 by Miss Islington (bot) 
in branch '3.9':
bpo-42794: Update test_nntplib to use offical group name for testing (GH-24037)
https://github.com/python/cpython/commit/b20d5e5ce95248e0fa77c5d7bf8f6f5b1231fa53


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42794] test_nntplib fails on CI

[miss-islington]

miss-islington  added the comment:


New changeset 381f3e4bfd4b1c440f7cb3025972fe0acd0406fc by Miss Islington (bot) 
in branch '3.8':
bpo-42794: Update test_nntplib to use offical group name for testing (GH-24037)
https://github.com/python/cpython/commit/381f3e4bfd4b1c440f7cb3025972fe0acd0406fc


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42802] distutils: Remove bdist_wininst command

[STINNER Victor]

STINNER Victor  added the comment:

There are 19 issues (+ this one) on bdist_wininst. Once distutils bdist_wininst 
command will be removed, I propose to all these issues.

Search for open issues with "bdist_wininst" in the title.

Only bpo-41771 was active recently (3 months ago). The 18 other issues are 
inactive for between 18 months and 121 months (10 years!).

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42801] Exception catching function crashes on recursive list

[Steve Stagg]

Steve Stagg  added the comment:

This is fixed by https://github.com/python/cpython/pull/23744

--
nosy: +stestagg

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42802] distutils: Remove bdist_wininst command

[STINNER Victor]

New submission from STINNER Victor :

Attached PR removes it.

The bdist_wininst command was deprecated in Python 3.8:

commit 1da4462765b084dfa8d869b6cb5855e8f6014a11
Author: Victor Stinner 
Date:   Fri Jul 5 10:44:12 2019 +0200

bpo-37481: Deprecate distutils bdist_wininst command (GH-14553)

The distutils bdist_wininst command is now deprecated, use
bdist_wheel (wheel packages) instead.


"What’s New In Python 3.9: Build Changes" also announced:

* On non-Windows platforms, creating ``bdist_wininst`` installers is now
  officially unsupported.  (See :issue:`10945` for more details.)

https://docs.python.org/dev/whatsnew/3.9.html#build-changes


See bpo-37481 and:
https://discuss.python.org/t/deprecate-bdist-wininst/1929

--
components: Distutils
messages: 384173
nosy: dstufft, eric.araujo, vstinner
priority: normal
severity: normal
status: open
title: distutils: Remove bdist_wininst command
versions: Python 3.10

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42796] tempfile doesn't seem to play nicely with os.chdir on Windows

[Eryk Sun]

Eryk Sun  added the comment:

> def test_chdir():
> with tempfile.TemporaryDirectory() as tempdir:
> old = os.getcwd()
> os.chdir(tempdir)
> with open(os.path.join(tempdir, "delme")) as fout:
> fout.write("Hello")
> os.chdir(old)

The open() call in test_chdir() fails before os.chdir(old) executes. You would 
need to call os.chdir(old) in a `finally` block.

But the cleanup routine could still fail due to a sharing violation from some 
other process (likely a child process) setting the directory or a child 
directory as the working directory. Also, a sharing violation when trying to 
delete a regular file in the tree causes the cleanup routine to fail with 
NotADirectoryError because the onerror function calls rmtree() if unlink() 
fails with a PermissionError.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42794] test_nntplib fails on CI

[miss-islington]

Change by miss-islington :


--
pull_requests: +22883
pull_request: https://github.com/python/cpython/pull/24042

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42794] test_nntplib fails on CI

[miss-islington]

Change by miss-islington :


--
pull_requests: +22882
pull_request: https://github.com/python/cpython/pull/24041

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42794] test_nntplib fails on CI

[miss-islington]

Change by miss-islington :


--
pull_requests: +22881
pull_request: https://github.com/python/cpython/pull/24040

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42794] test_nntplib fails on CI

[miss-islington]

Change by miss-islington :


--
nosy: +miss-islington
nosy_count: 7.0 -> 8.0
pull_requests: +22880
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/24039

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42794] test_nntplib fails on CI

[Dong-hee Na]

Dong-hee Na  added the comment:


New changeset ec3165320e81ac87edcb85c86c452528ddbaec1c by Dong-hee Na in branch 
'master':
bpo-42794: Update test_nntplib to use offical group name for testing (GH-24037)
https://github.com/python/cpython/commit/ec3165320e81ac87edcb85c86c452528ddbaec1c


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue4643] cgitb.html fails if getattr call raises exception

[karl]

karl  added the comment:

Converted into GitHub PR https://github.com/python/cpython/pull/24038

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue4643] cgitb.html fails if getattr call raises exception

[karl]

Change by karl :


--
nosy: +karlcow
nosy_count: 4.0 -> 5.0
pull_requests: +22878
stage: test needed -> patch review
pull_request: https://github.com/python/cpython/pull/24038

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42794] test_nntplib fails on CI

[Marc-Andre Lemburg]

Marc-Andre Lemburg  added the comment:

On 01.01.2021 13:57, Christian Heimes wrote:
> 
> Does this issue mean that I should include nntplib in PEP 594 again?

The test fails because it was relying on an external news server's
configuratoin. This doesn't mean the code itself is broken, just the
test, so clearly: no.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42796] tempfile doesn't seem to play nicely with os.chdir on Windows

[Eryk Sun]

Eryk Sun  added the comment:

> Windows doesn't let you remove files and directories that are used 
> by a process. 

Windows does allow deleting open files/directories, but read/execute, 
write/append, and delete/rename access have to be explicitly shared when 
opening a file or directory. WinAPI SetCurrentDirectoryW (called by os.chdir) 
does not share delete access when opening a directory as the new working 
directory, and the handle is kept open to use as the NTAPI RootDirectory handle 
when opening relative paths. So the directory can only be deleted after either 
the working directory changes or the process exits.

See bpo-35144 for the source of the recursion error. An onerror handler was 
added that retries rmtree() after attempting to reset permissions. I proposed a 
workaround in the linked issue, but I don't think it's enough. Maybe there 
should be a separate onerror function for Windows.

The two common PermissionError cases to handle in Windows are readonly files 
and sharing violations. If the readonly attribute is set, we can remove it and 
retry the unlink() or rmdir() call. I don't think there's no need for a 
recursive call since rmtree() only removes empty directories. 

For a sharing violation (winerror 32), all that can be done is to set an atexit 
function that retries deleting the directory. If rmtree() still fails, emit a 
resource warning and give up.

--
nosy: +eryksun

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25479] Increase unit test coverage for abc.py

[Irit Katriel]

Change by Irit Katriel :


--
versions:  -Python 3.8, Python 3.9

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25479] Increase unit test coverage for abc.py

[Irit Katriel]

Irit Katriel  added the comment:

This PR probably doesn't improve test coverage because the feature is tested 
indirectly (and directly from test_typing). But I think this test should be 
added nevertheless for completeness and to demonstrate how the feature works. 

That said, this test shows that the documentation of issubclass is not quite 
accurate when it states that "a class is considered a subclass of itself" 
 (https://docs.python.org/3/library/functions.html#issubclass).  

That should probably be a separate bpo.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42796] tempfile doesn't seem to play nicely with os.chdir on Windows

[Gabriele Tornetta]

Gabriele Tornetta  added the comment:

That makes sense, but I wonder what the "right" behaviour should be in this 
case. Surely the infinite recursion should be fixed at the very minimum. 
Perhaps the code on Windows could be enhanced to catch the case whereby one is 
trying to delete the cwd and do something like chdir('..') and then delete the 
temp folder. However, I suspect that something like this still wouldn't be 
enough. For example, this works fine

~~~ python
def test_chdir():
with tempfile.TemporaryDirectory() as tempdir:
old = os.getcwd()
os.chdir(tempdir)
os.chdir(old)
~~~

whereas this doesn't (same stacktrace as the original case)

~~~ python
def test_chdir():
with tempfile.TemporaryDirectory() as tempdir:
old = os.getcwd()
os.chdir(tempdir)
with open(os.path.join(tempdir, "delme")) as fout:
fout.write("Hello")
os.chdir(old)
~~~

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42796] tempfile doesn't seem to play nicely with os.chdir on Windows

[Christian Heimes]

Christian Heimes  added the comment:

The code fails because TemporaryDirectory.__exit__() is unable to remove the 
directory. Windows doesn't let you remove files and directories that are used 
by a process. On POSIX-like operating systems like Linux support removing of 
opened files. For example anonymous temporary files use the trick.

--
nosy: +christian.heimes

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42794] test_nntplib fails on CI

[Christian Heimes]

Christian Heimes  added the comment:

Does this issue mean that I should include nntplib in PEP 594 again?

--
nosy: +christian.heimes

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34752] warnings.warn fails silently with unicode input

[Dong-hee Na]

Change by Dong-hee Na :


--
resolution:  -> wont fix
stage:  -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42794] test_nntplib fails on CI

[Dong-hee Na]

Dong-hee Na  added the comment:

> For tests with the external environment,
How about skipping tests if servers are not available?

Hmm, I change my mind this is not a good idea :(

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42801] Exception catching function crashes on recursive list

[Dong-hee Na]

Dong-hee Na  added the comment:

FYI,I am able to reproduce on Python 3.9
The master version is not able to reproduce.

--
nosy: +corona10

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42794] test_nntplib fails on CI

[Dong-hee Na]

Dong-hee Na  added the comment:

> How to handle similar breakage of external servers?

For tests with the external environment,
How about skipping tests if servers are not available?
It is assumed that if there is a change related to NNTP, it is well checked in 
the CI and review.
This is because, at this point, reviewers and patch submitters check whether 
tests with external servers are passed.

The reason for testing with the outside is to confirm that the whole operation 
works well.
If external servers are not available, we can emit warning messages so that we 
can recognize when an issue occurs.

Other than that, I can think of local server testing or mocking testing, but I 
am not sure if it is easy way for the SSL environment.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34752] warnings.warn fails silently with unicode input

[Zackery Spytz]

Zackery Spytz  added the comment:

Python 2.7 is no longer supported, so I think this issue should be closed.

--
nosy: +ZackerySpytz

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42794] test_nntplib fails on CI

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:

The test was passed on my computer because 
test.test_nntplib.NetworkedNNTP_SSLTests was skipped because of the 
configuration of SSL on Ubuntu 20.04 (see issue41561).

After using custom openssl.cnf I get the same errors.

$ OPENSSL_CONF=~/py/openssl.cnf ./python -m test -vuall test_nntplib -m 
'test_description*'

The NNTP server nntp.aioe.org is used instead of snews.gmane.org since 2010 
(45ca9874955b1eaf3d941b7a278b594fad50d4ee). Sadly there is no reference to any 
discussion, maybe Antoine remember some details. What other alternatives were 
considered? How to handle similar breakage of external servers?

--
nosy: +pitrou
Added file: https://bugs.python.org/file49714/openssl.cnf

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42797] Allow doctest to select tests via -m/--match option

[Costas Basdekis]

Costas Basdekis  added the comment:

Thanks for the thorough feedback Steven (and happy new year).

About -m flag: we could use -k as other testing frameworks use (pytest), or 
even -t.

About selecting multiple indexes: what you described is my exact use case, as I 
have a lot of failing examples in one method with verbose output, and also the 
examples depend on previous examples to be able to run, I'm currently debugging 
with `-m Ground.step:3,4,6,7`.

So I think you have very valid points, and I'd like to find a way to make the 
extra overhead be worth it:
* Currently the failing case output is f'File "{path}", line {line}, in 
{name}': we can add the index as f'File "{path}", line {line}, in {name}, 
example {index}', so it would be easy to know the indexes
* I think globs in the pattern have been very useful to me in the past (with 
frameworks that allowed it), because sometimes similarly named functions can 
have the same types of errors you try to focus on. In any case, it looks like 
less effort to allow arbitrary globs rather than matching on module name parts

I understand I'm adding complexity, and if we could support the same behaviour 
in a simpler way I'd be glad to attempt that. In the very least I think 
allowing a `finder=None` argument in `testmod` would allow more complex 
solutions, even if they are not accepted in `doctest`.

In the end I'd welcome even a small improvement (for my personal usecase).

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42794] test_nntplib fails on CI

[Dong-hee Na]

Dong-hee Na  added the comment:

I submit the patch to use group_name which is mentioned from 
https://news.aioe.org/manual/aioe-hierarchy/

IMHO, it will be not changed frequently than what we used before.

--
stage: patch review -> 

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42794] test_nntplib fails on CI

[Dong-hee Na]

Change by Dong-hee Na :


--
keywords: +patch
pull_requests: +22877
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/24037

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42794] test_nntplib fails on CI

[Dong-hee Na]

Dong-hee Na  added the comment:

4 ways / 2 ways

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42794] test_nntplib fails on CI

[Dong-hee Na]

Dong-hee Na  added the comment:

== CPython 3.10.0a3+ (heads/master:c8a7b8fa1b, Jan 1 2021, 08:28:41) [GCC 7.5.0]
== Linux-5.4.0-1031-azure-x86_64-with-glibc2.27 little-endian
== cwd: /home/corona10/cpython/build/test_python_66899æ
== CPU count: 2
== encodings: locale=UTF-8, FS=utf-8
0:00:00 load avg: 0.00 Run tests sequentially
0:00:00 load avg: 0.00 [1/1] test_nntplib
test_descriptions (test.test_nntplib.NNTPv1Tests) ... ok
test_descriptions (test.test_nntplib.NNTPv2Tests) ... ok
test_descriptions (test.test_nntplib.NetworkedNNTPTests) ... ok
test_descriptions (test.test_nntplib.NetworkedNNTP_SSLTests) ... ERROR

==
ERROR: test_descriptions (test.test_nntplib.NetworkedNNTP_SSLTests)
--
Traceback (most recent call last):
  File "/home/corona10/cpython/Lib/test/test_nntplib.py", line 250, in wrapped
meth(self)
  File "/home/corona10/cpython/Lib/test/test_nntplib.py", line 99, in 
test_descriptions
desc = descs[self.GROUP_NAME]
KeyError: 'comp.lang.python'

--

Ran 4 tests in 4.734s

FAILED (errors=1)
test test_nntplib failed
test_nntplib failed

== Tests result: FAILURE ==

1 test failed:
test_nntplib

Total duration: 4.8 sec
Tests result: FAILURE


My test machine success to reproduce this issue.

(Pdb) descs
{}

There might be 4 ways to solve this issue.

1. Re-create group and skip test while descs is empty
2. Update test to use other NNTP server which supports SSL

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42794] test_nntplib fails on CI

[Dong-hee Na]

Change by Dong-hee Na :


--
nosy: +corona10

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com