date:20220115

[issue46386] Improve `test_typing::test_immutability_by_copy_and_pickle`

2022-01-15 Thread Dong-hee Na



Dong-hee Na  added the comment:

Thank you @sobolevn !

--
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue46386] Improve `test_typing::test_immutability_by_copy_and_pickle`

2022-01-15 Thread Dong-hee Na



Dong-hee Na  added the comment:


New changeset 09087b8519316608b85131ee7455b664c00c38d2 by Nikita Sobolev in 
branch 'main':
bpo-46386: improve `test_typing:test_immutability_by_copy_and_pickle` (GH-30613)
https://github.com/python/cpython/commit/09087b8519316608b85131ee7455b664c00c38d2


--
nosy: +corona10

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue46386] Improve `test_typing::test_immutability_by_copy_and_pickle`

2022-01-15 Thread Nikita Sobolev



Nikita Sobolev  added the comment:

Thank you, Jelle. Will send a PR to typing_extensions today as well :)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40066] Enum: modify repr, str; update docs

2022-01-15 Thread Ethan Furman



Ethan Furman  added the comment:


New changeset acf7403f9baea3ae1119fc6b4a3298522188bf96 by Ethan Furman in 
branch 'main':
bpo-40066:  [Enum] update str() and format() output (GH-30582)
https://github.com/python/cpython/commit/acf7403f9baea3ae1119fc6b4a3298522188bf96


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue46386] Improve `test_typing::test_immutability_by_copy_and_pickle`

2022-01-15 Thread Jelle Zijlstra



Jelle Zijlstra  added the comment:

The additional tests would also be useful to have in 
https://github.com/python/typing/tree/master/typing_extensions if you're 
interested.

--
nosy: +Jelle Zijlstra

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue46393] Generate frozenset constants when explicitly appropriate

2022-01-15 Thread Dennis Sweeney



Dennis Sweeney  added the comment:

There's also the hacky expression {*()} to get an empty set

--
nosy: +Dennis Sweeney

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue46393] Generate frozenset constants when explicitly appropriate

2022-01-15 Thread Terry J. Reedy



Terry J. Reedy  added the comment:

Sigh.  You are right.  I will close this tomorrow.


This also means that 'set()' is not guaranteed to return an empty built-in set. 
I did think of this workaround for that:
>>> (empty:={None}).clear()
>>> empty
set()
 
Go ahead and propose something on python-ideas if you want, pointing out that 
only displays (and comprehensions) are guaranteed to result in a builtin.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue46387] `test_field_descriptor` in `test_collections` should test all pickle protocols

2022-01-15 Thread Raymond Hettinger



Raymond Hettinger  added the comment:

I approved this but the code wasn't wrong.  Once an object has demonstrated 
that it can pickle at all, it is the testing responsibility of the pickle 
module tests to make sure that new protocols handle the same inputs as the old 
ones.

I went ahead and applied the PR because it is harmless, but it is a gratuitous 
test, so I don't recommend sweeping through all other pickling tests and 
modifying them in the same way.

--
assignee:  -> rhettinger
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue46387] `test_field_descriptor` in `test_collections` should test all pickle protocols

2022-01-15 Thread Raymond Hettinger



Raymond Hettinger  added the comment:


New changeset 37eab55ac9da6b6361f136a1da15bfcef12ed954 by Nikita Sobolev in 
branch 'main':
bpo-46387: test all pickle protos in `test_field_descriptor` in 
`test_collections` (GH-30614)
https://github.com/python/cpython/commit/37eab55ac9da6b6361f136a1da15bfcef12ed954


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43476] Enabling access to showsyntaxerror for IDLE's shell

2022-01-15 Thread Terry J. Reedy



Terry J. Reedy  added the comment:

Whatever you worked out is probably better than depending on something that I 
hope to significantly change.

--
resolution:  -> out of date
stage:  -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45447] IDLE: Support syntax highlighting for .pyi stub files

2022-01-15 Thread Terry J. Reedy



Terry J. Reedy  added the comment:

A minimal version of util.py just for this issue is fine.  What is blocking the 
issue deciding exactly what the minimum should be.  Are both the extension list 
and function needed?

Alex says somewhere in PR comments that ispythonsource passes directories.  
That seems wrong.  Perhaps moving and revising it and making no-extension files 
browsable and removing the x.py(?) limitation should be a separate issue.  IDLE 
users on *nix don't mind using extensions.  I have not seen a complaint, though 
perhaps people who do mind silently use something else.  I need to check again 
how the editor function is used and decide if we can leave it alone for now.  
So don't remove anything just now.

I need to experiment with Ron's suggestion on my Mac.

The Windows context menu is definitely a separate issue.

Please add idle_test/example.pyi with the line in msg403741 for manual testing 
now and possibly future automatic testing.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue46393] Generate frozenset constants when explicitly appropriate

2022-01-15 Thread Steven D'Aprano



Steven D'Aprano  added the comment:

The difficulty is that frozenset may have been shadowed, or builtins 
monkey-patched, so we cannot know what frozenset({1, 2, 3}) will return until 
runtime.

Should we re-consider a frozenset display literal?

f{1, 2, 3}

works for me.

--
nosy: +steven.daprano

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue43371] Mock.assert_has_calls works strange

2022-01-15 Thread Roy Smith

Roy Smith added the comment:

I agree that this is confusing and that what we need is an assertion for the
top-level mock having specific calls in a specific order, and ignores any
intervening extra calls to mocked functions. In other words, a version of
assert_has_calls() which looks at call_args_list instead of mock_calls.

I just finished up a session of head-banging with some tests that were failing
(Python 3.7), and eventually ended up with the

self.assertEqual(my_mock.call_args_list, [call(...), call(...)])

idiom as noted in msg397172 (but without first banging a few new dents into the
top of my desk). This exact same experience is related in a recent
stackoverflow thread
(https://stackoverflow.com/questions/69360318/python-unittest-mock-assert-has-calls-returning-calls-to-other-mocks)
so this seems to be a common source of confusion.

I am neutral on whether this is implemented as a new flag to assert_has_calls()
or as a new assertion method.

As an aside, what I was trying to do was test if my code constructed its
several instances of a class in the correct way. At one point I hit upon the
idea of:

MyMockedClass().__init__.assert_has_calls()

which expressed my desired logic exactly and simply, but couldn't get that to
work. It's unclear if I just never found the proper incantation, or if that's
fundamentally unworkable.

--
nosy: +roysmith

___
Python tracker

___
___
Python-bugs-list mailing list
Unsubscribe:
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue46393] Generate frozenset constants when explicitly appropriate

2022-01-15 Thread Terry J. Reedy



New submission from Terry J. Reedy :

The CPython compiler is capable of making frozenset constants without being 
explicitly asked to.  Exactly how it does so is, of course, 'hidden' from 
python code.  With current main:
.
>>> dis('{1,2,3}')
  1   0 BUILD_SET0
  2 LOAD_CONST   0 (frozenset({1, 2, 3}))
  4 SET_UPDATE   1
  6 RETURN_VALUE

Suppose one wants actually wants a frozenset, not a mutable set.  
'frozenset({1,2,3})' is compiled as the above followed by a frozenset call -- 
making an unneeded double conversion to get what already exists. 
To avoid the intermediate set, one can use a constant tuple instead.

>>> dis('frozenset((1,2,3))')
  1   0 LOAD_NAME0 (frozenset)
  2 LOAD_CONST   0 ((1, 2, 3))
  4 CALL_FUNCTION1
  6 RETURN_VALUE

Even nicer would be

  1   0 (frozenset({1, 2, 3}))
  2 RETURN_VALUE

'set((1,2,3))' is compiled the same as 'frozenset((1,2,3)), but frozenset does 
not having the option is using a more efficient display form.  I cannot think 
of any reason to not call frozenset during compile time when the iterable is a 
constant tuple.

Serhiy, I not sure how this relates to your issue 33318 and the discussion 
therein about stages, but it does relate to your interest in compile time 
constants.

--
components: Interpreter Core
messages: 410666
nosy: serhiy.storchaka, terry.reedy
priority: normal
severity: normal
stage: test needed
status: open
title: Generate frozenset constants when explicitly appropriate
type: enhancement
versions: Python 3.11

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue46392] MessageIDHeader is too strict for message-id

2022-01-15 Thread bpoaugust



New submission from bpoaugust :

The email headerregistry class MessageIDHeader is too strict when parsing 
existing Message-Ids. It can truncate Message-Ids that are valid according to 
the obsolete rules.

As the saying has it: 
"Be liberal in what you accept, and conservative in what you send."

I think the parser should be much closer to the UnstructuredHeader.

--
components: email
messages: 410665
nosy: barry, bpoaugust, r.david.murray
priority: normal
severity: normal
status: open
title: MessageIDHeader is too strict for message-id

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39663] IDLE: Add additional tests for pyparse

2022-01-15 Thread Terry J. Reedy



Change by Terry J. Reedy :


--
type:  -> enhancement

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue46388] Improve test coverage of functools.total_ordering

2022-01-15 Thread Raymond Hettinger



Raymond Hettinger  added the comment:

Thanks for the PR.

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue46388] Improve test coverage of functools.total_ordering

2022-01-15 Thread Raymond Hettinger



Raymond Hettinger  added the comment:


New changeset 0a28118324f64851b684ec3afdd063c47513a236 by Russel Webber in 
branch 'main':
bpo-46388: Test NotImplemented code path for functools.total_ordering (GH-30616)
https://github.com/python/cpython/commit/0a28118324f64851b684ec3afdd063c47513a236


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue46372] int/float specializations should mutate the LHS in-place when possible

2022-01-15 Thread Raymond Hettinger



Change by Raymond Hettinger :


--
nosy: +vstinner

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

93 matches

Mail list logo