[issue27584] New addition of vSockets to the python socket module
Cathy Avery added the comment: There is an outstanding review on my pull request at https://github.com/python/cpython/pull/2489 as there is an red X at changes requested by kushaldas and I believe I have made the necessary changes. Again please let me know if there is anything that I need to do as I am new to this process. Thanks, Cathy -- ___ Python tracker <http://bugs.python.org/issue27584> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue27584] New addition of vSockets to the python socket module
Cathy Avery added the comment: Hi, I believe I am waiting for a final review. Is there anything else I need to be doing at this point. Thanks, Cathy -- ___ Python tracker <http://bugs.python.org/issue27584> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue27584] New addition of vSockets to the python socket module
Cathy Avery added the comment: That should do it. -- ___ Python tracker <http://bugs.python.org/issue27584> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue27584] New addition of vSockets to the python socket module
Cathy Avery added the comment: You will also need linux/vm_sockets.h in order to build. -- ___ Python tracker <http://bugs.python.org/issue27584> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue27584] New addition of vSockets to the python socket module
Cathy Avery added the comment: OK thanks! -- ___ Python tracker <http://bugs.python.org/issue27584> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue27584] New addition of vSockets to the python socket module
Cathy Avery added the comment: So I revised my code based on the reviews and I passed all the checks ... now what? Thanks, Cathy -- ___ Python tracker <http://bugs.python.org/issue27584> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue27584] New addition of vSockets to the python socket module
Cathy Avery added the comment: Fedora 25 has the proper headers. -- ___ Python tracker <http://bugs.python.org/issue27584> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue27584] New addition of vSockets to the python socket module
Cathy Avery added the comment: The build and test bots failed but I don't understand why. The build could not find module _socket but that is not new and other modules failed. The test could not import fcntl which I did add but should not fail as I have run this test many time and other tests import fcntl. https://github.com/python/cpython/pull/2489 -- ___ Python tracker <http://bugs.python.org/issue27584> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue27584] New addition of vSockets to the python socket module
Cathy Avery added the comment: I also issued a pull request https://github.com/python/cpython/pull/2489 Let me know if I screwed it up. Thanks, Cathy -- ___ Python tracker <http://bugs.python.org/issue27584> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue27584] New addition of vSockets to the python socket module
Cathy Avery added the comment: Help file. -- Added file: http://bugs.python.org/file46978/REAME.txt ___ Python tracker <http://bugs.python.org/issue27584> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue27584] New addition of vSockets to the python socket module
Cathy Avery added the comment: I've attached the third version of VSOCK patch addressing the concerns of the last rev. I've also included a README file that lists instructions on how to setup a test environment. Thanks -- Added file: http://bugs.python.org/file46977/0001-bpo-27584-New-addition-of-vSockets-to-the-python-soc.patch ___ Python tracker <http://bugs.python.org/issue27584> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue27584] New addition of vSockets to the python socket module
Cathy Avery added the comment: The vsock code is now in the linux upstream kernel and qemu. I will be resubmitting my vsock patches for python. So from what I can tell the tip of the devel tree is for 3.7 and that the source control has switched to git. My question is do I need a github account or can I push git patches directly to this issues page? Thanks, Cathy -- ___ Python tracker <http://bugs.python.org/issue27584> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue27584] New addition of vSockets to the python socket module
Cathy Avery added the comment: First make sure the driver is in your kernel. It will be with RHEL. Look in /lib/modeles/"your kernel name"/kernel/net/vmw_vsock/vmw_vsock_vmci_transport. I have never tried it on vmware fusion. I have tested it on ESX. See if there is a VMCI option to enable on your VM's settings. Start the vm and do an lsmod to see if vmw_vsock_vmci_transport is loaded. I've attached a little C program thats netcat for vsock. Its a quick confirmation that your transport is loaded correctly. It will show you your CID. run ./nc-vsock CID = 973033371 CID = 0x39ff4f9b usage: ./nc-vsock [-l [-t ] | ] -- Added file: http://bugs.python.org/file45964/nc-vsock ___ Python tracker <http://bugs.python.org/issue27584> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue27584] New addition of vSockets to the python socket module
Cathy Avery added the comment: Sorry about the typo the drivers have been there for about 4 years. -- ___ Python tracker <http://bugs.python.org/issue27584> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue27584] New addition of vSockets to the python socket module
Cathy Avery added the comment: Is there a format checker I could use on the patch? VMCI and the vmw_vsock_vmci_transport kernel modules are located in the upstream linux tree at git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git They have been there for about years. These drivers are part of various downstream kernels such as RHEL. You will need a Vmware virtual machine in order to test it. Only the virtio-vsock driver is a new vsock application that needs to be custom built. -- ___ Python tracker <http://bugs.python.org/issue27584> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue27584] New addition of vSockets to the python socket module
Cathy Avery added the comment: Is there anything else that is needed for this patch? Thanks! -- ___ Python tracker <http://bugs.python.org/issue27584> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue27584] New addition of vSockets to the python socket module
Cathy Avery added the comment: Please forgive the long delay in providing this update. I got a little sidetracked. Attached is the patch for Python 3.7. It includes fixes suggested in rev 1 plus VSOCK tests in test_socket.py. Thanks, Cathy -- versions: +Python 3.7 -Python 3.6 Added file: http://bugs.python.org/file45411/vsock_rev2.patch ___ Python tracker <http://bugs.python.org/issue27584> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue27584] New addition of vSockets to the python socket module
Cathy Avery added the comment: Sure I can add tests. I would like to base them on the existing socket tests. Where are those? I did add a version + .. versionadded:: 3.4 It just not may not be the right one. -- ___ Python tracker <http://bugs.python.org/issue27584> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue27584] New addition of vSockets to the python socket module
New submission from Cathy Avery: I have added AF_VSOCK support to python's 3.6 socket module ( socketmodule.c socketmodule.h cloned from https://hg.python.org/cpython ). The implementation is very similar to AF_NETLINK. AF_VSOCK requires the VMware-specific VMCI transport which is currently upstream or the virtio-vsock drivers developed by Stefan Hajnoczi at Red Hat. The virtio-vsock drivers are not upstream yet but more information with source and build instructions can be found at http://qemu-project.org/Features/VirtioVsock. More information on vSocket programming can be found at https://pubs.vmware.com/vsphere-60/topic/com.vmware.ICbase/PDF/ws9_esx60_vmci_sockets.pdf The VMCI transport supports SOCK_DGRAM and SOCK_STREAM on both Linux and Windows. Virtio-vsock currently supports SOCK_STREAM only on Linux. My python addition supports SOCK_STREAM and SOCK_DGRAM calls on Linux only. I have tested my implementation on both driver sets on Linux. Attached is a diff file so you can see which files I've modified. These include a new configure.ac. I have already tested the new file generation by running autoreconf. Also included in the patch is an updated socket.rst file however I could not get the final html page to be double spaced. -- components: Library (Lib) files: vsocket.patch hgrepos: 349 keywords: patch messages: 270935 nosy: Cathy Avery, gregory.p.smith priority: normal severity: normal status: open title: New addition of vSockets to the python socket module type: enhancement versions: Python 3.6 Added file: http://bugs.python.org/file43816/vsocket.patch ___ Python tracker <http://bugs.python.org/issue27584> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
