[issue12489] email.errors.HeaderParseError if base64url is used
Christian Theune added the comment: So, in addition to +/ and -_ there are quite a few base64 variants. Worst thing: there are the two ambigious variants -_ and _-, even though _- supposedly is non-standard for its use. See http://en.wikipedia.org/wiki/Base64 The shortest fix I can see would be to not use binascii directly from the email module but go through the base64 module (as pointed out by the blogpost) and call the urlsafe version. That should catch both cases. Preparing a patch right now. -- nosy: +ctheune, r.david.murray ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12489 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12489] email.errors.HeaderParseError if base64url is used
Changes by Christian Theune c...@gocept.com: -- hgrepos: +239 versions: +Python 3.4, Python 3.5 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12489 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12489] email.errors.HeaderParseError if base64url is used
Changes by Christian Theune c...@gocept.com: -- hgrepos: +240 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12489 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12489] email.errors.HeaderParseError if base64url is used
Changes by Christian Theune c...@gocept.com: Added file: http://bugs.python.org/file34944/732e7d4515c0.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12489 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12489] email.errors.HeaderParseError if base64url is used
Changes by Christian Theune c...@gocept.com: -- keywords: +patch Added file: http://bugs.python.org/file34943/62b280b61de7.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12489 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1514420] Missing module code does spurious file search
Christian Theune added the comment: I don't think the security risk exists due to this bug. As Python is searching for various places anyway, an attacker could just symlink one of those places anyway instead of 'stdin'. -- nosy: +ctheune ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1514420 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16285] Update urllib to RFC 3986
Christian Theune added the comment: I'll update this. -- nosy: +ctheune ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16285 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16285] Update urllib quoting to RFC 3986
Changes by Christian Theune c...@gocept.com: -- title: Update urllib to RFC 3986 - Update urllib quoting to RFC 3986 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16285 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16285] Update urllib quoting to RFC 3986
Changes by Christian Theune c...@gocept.com: -- hgrepos: +241 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16285 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16285] Update urllib quoting to RFC 3986
Changes by Christian Theune c...@gocept.com: -- hgrepos: -242 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16285 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16285] Update urllib quoting to RFC 3986
Changes by Christian Theune c...@gocept.com: -- hgrepos: +242 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16285 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16285] Update urllib quoting to RFC 3986
Changes by Christian Theune c...@gocept.com: -- versions: +Python 3.5 -Python 3.4 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16285 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16285] Update urllib quoting to RFC 3986
Changes by Christian Theune c...@gocept.com: -- keywords: +patch Added file: http://bugs.python.org/file34950/0be3805cade1.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16285 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10362] AttributeError: addinfourl instance has no attribute 'tell'
Christian Theune added the comment: I don't think this will be solved. File-like objects (in this case IO wrappers for the socket) may have different capabilities and tarfile is just expecting too much. My patch for #15002 relieved the situation somewhat by providing tell() but the IO stream just isn't seekable. I think you'll have to download to a temporary file first to give tarfile all the capabilities it needs. I guess this should be rejected. -- nosy: +ctheune, r.david.murray ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10362 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10362] AttributeError: addinfourl instance has no attribute 'tell'
Christian Theune added the comment: Not being an export on tar at all, but I tried getting anything working without tell() and seek() but couldn't. The code reads as if its supposed to support some tar formats that do not require seeking, but that would be rather hard to predict on a file-by-file basis, I guess. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10362 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue15002] urllib2 does not download 4 MB file completely using ftp
Christian Theune added the comment: Looking into this. It seems that it doesn't happen for all servers, I can download large files reliably from other sources. I'll make another wireshark recording to get more details for me to analyze. -- nosy: +ctheune ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15002 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue15002] urllib2 does not download 4 MB file completely using ftp
Christian Theune added the comment: This is actually the same problem as #18879. Changing the sample to keep a reference to the addinfourl object avoids this issue. This is even worse than #18879 in the sense that the error goes undetected and just leaves you with partial data. Looking at the solution in #18879 I think we can reuse that, maybe even better by refactoring that to a common file proxy object. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15002 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue15002] urllib2 does not download 4 MB file completely using ftp
Changes by Christian Theune c...@gocept.com: -- versions: +Python 3.4, Python 3.5 -Python 3.2, Python 3.3 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15002 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18879] tempfile.NamedTemporaryFile can close the file too early, if not assigning to a variablwe
Christian Theune added the comment: #15002 uses this patch to fix a similar wrapping problem in urllib. Also, this affects 2.7 as well and #15002 does report the problem for 2.7. I'd like to get this fix backported. Would that be OK? -- nosy: +ctheune title: tempfile.NamedTemporaryFile can close the file too early, if not assigning to a variable - tempfile.NamedTemporaryFile can close the file too early, if not assigning to a variablwe versions: +Python 2.7, Python 3.5 -Python 3.3 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18879 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue15002] urllib2 does not download 4 MB file completely using ftp
Christian Theune added the comment: I wasn't able to come up with a good testcase. :( I tried similar approaches as in #18879 but I wasn't able to make them trigger the behaviour as it also seems to be an issue regarding actual network performance ... :/ Backport to 2.7 is currently missing as I'd need #18879 to be backported. If that is OK (I'd like to have this in 2.7) then I'd be happy to port both. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15002 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue15002] urllib2 does not download 4 MB file completely using ftp
Changes by Christian Theune c...@gocept.com: -- hgrepos: +237 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15002 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue15002] urllib2 does not download 4 MB file completely using ftp
Christian Theune added the comment: Antoine, I'm adding you here as I'm leveraging your patch from #18879. I'd need some feedback about the backport, but this patch should be OK for 3.4. Also, if you had an idea how to test this - I tried, but failed so far. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15002 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue15002] urllib2 does not download 4 MB file completely using ftp
Changes by Christian Theune c...@gocept.com: -- keywords: +patch Added file: http://bugs.python.org/file34915/d3c6ab639306.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15002 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue15002] urllib2 does not download 4 MB file completely using ftp
Christian Theune added the comment: Antoine, could you check my last comment in here? (The nosy list got reset accidentally when I made that comment and got a conflict from the tracker). -- nosy: +pitrou ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15002 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21202] Naming a file` io.py` causes cryptic error message
Changes by Christian Theune c...@gocept.com: -- hgrepos: +238 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21202 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21202] Naming a file` io.py` causes cryptic error message
Christian Theune added the comment: I managed to create a patch that relies (in hopefully reasonably safe manner) on embedding an object repr for identification in this and similar cases. This is basically what implements what Martin suggested. Caveat emptor: my C knowledge is only good enough to be dangerous. Thomas Wouters and RDM helped me through it. I haven't adapted the tests yet (lots of failures due to the output change) but I managed them to stop crashing. The 'repr.py' in the root is my current testbed to see what's going on. -- nosy: +ctheune, r.david.murray, twouters ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21202 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21202] Naming a file` io.py` causes cryptic error message
Changes by Christian Theune c...@gocept.com: -- keywords: +patch Added file: http://bugs.python.org/file34937/4ae151db1bd9.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21202 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18099] wsgiref sets Content-Length: 0 on 304 Not Modified
Changes by Christian Theune c...@gocept.com: -- versions: +Python 3.5 -Python 3.3 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18099 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18099] wsgiref sets Content-Length: 0 on 304 Not Modified
Changes by Christian Theune c...@gocept.com: -- hgrepos: +235 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18099 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18099] wsgiref sets Content-Length: 0 on 304 Not Modified
Changes by Christian Theune c...@gocept.com: -- hgrepos: +236 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18099 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18099] wsgiref sets Content-Length: 0 on 304 Not Modified
Changes by Christian Theune c...@gocept.com: -- keywords: +patch Added file: http://bugs.python.org/file34887/125e080bbe15.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18099 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18099] wsgiref sets Content-Length: 0 on 304 Not Modified
Changes by Christian Theune c...@gocept.com: Added file: http://bugs.python.org/file34888/762d11a72249.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18099 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16381] Introduce option to force the interpreter to exit upon MemoryErrors
Christian Theune added the comment: I feel unsure how to help this move along. I agree that making it possible for applications to carefully work with MemoryErrors is a good idea. I don't think heuristics to determine which situation we are in will solve this but make it more spooky. (This is a semantic issue anyways). My goal is to use the flag to make it easier for operators to deal with applications that don't get it right. This isn't to defend bad programming but to support temporary relief. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16381 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16381] Introduce option to force the interpreter to exit upon MemoryErrors
Changes by Christian Theune c...@gocept.com: -- nosy: +barry ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16381 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16381] Introduce option to force the interpreter to exit upon MemoryErrors
Christian Theune added the comment: I pondered PyErr_NoMemory as well. However, I noticed not all locations in Python use PyErr_NoMemory to raise a MemoryError, and I'm also afraid that external libraries will have the same problem. Can you explain why you consider PyErr_NoMemory to be the better option? (I can think of performance but I wouldn't want to trade it in against reliability.) -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16381 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16381] Introduce option to force the interpreter to exit upon MemoryErrors
New submission from Christian Theune: I run long-running server processes (web apps, etc) a lot and I keep encountering the situation that many applications will not properly deal with MemoryError exceptions but end up in an unusable state. From an operational perspective I wish the process in this case would just fail and exit. I talked to Guido about this general idea at EuroPython2012 and he encouraged me to look into this. Here's a patch: https://bitbucket.org/ctheune/cpython/changeset/323bb572344d46df669d3dbec4431cf6720fc5b4 I think it does what I want it to do, but a) my C knowledge is really bad and b) I'm not sure whether this is the right approach anyway. I'd appreciate feedback and possibly inclusion in the core. -- components: Interpreter Core hgrepos: 158 messages: 174413 nosy: ctheune, gvanrossum priority: normal severity: normal status: open title: Introduce option to force the interpreter to exit upon MemoryErrors type: enhancement versions: Python 3.4 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16381 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16381] Introduce option to force the interpreter to exit upon MemoryErrors
Changes by Christian Theune c...@gocept.com: -- keywords: +patch Added file: http://bugs.python.org/file27821/9430a5c65114.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16381 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16381] Introduce option to force the interpreter to exit upon MemoryErrors
Christian Theune added the comment: Grr. Sorry. The automatic patch extraction went wrong and I didn't notice. Here's a manual try. -- Added file: http://bugs.python.org/file27822/issue16381.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16381 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16381] Introduce option to force the interpreter to exit upon MemoryErrors
Changes by Christian Theune c...@gocept.com: Removed file: http://bugs.python.org/file27821/9430a5c65114.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16381 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue5457] ZipFile writes incorrect modification time (second is off-by-one)
New submission from Christian Theune c...@gocept.com: See the attached unit test. On seconds that are 0 and 60 the written second is reduced by 1. (The test doesn't explicitly prove that this happens during writing, but we checked this manually. The read function is fine.) -- components: Library (Lib) files: zipbug.py message_count: 1.0 messages: 83364 nosy: ctheune nosy_count: 1.0 severity: normal status: open title: ZipFile writes incorrect modification time (second is off-by-one) type: behavior versions: Python 2.4, Python 2.5, Python 2.6, Python 3.0 Added file: http://bugs.python.org/file13281/zipbug.py ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5457 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue3334] 2to3 looses indentation on import fix
New submission from Christian Theune [EMAIL PROTECTED]: I got this output from 2to3: (This is from setuptools egg_info.py) -import bdist_egg; bdist_egg.write_safety_flag(cmd.egg_info, safe) +from . import bdist_egg; bdist_egg.write_safety_flag(cmd.egg_info, safe) -- assignee: collinwinter components: 2to3 (2.x to 3.0 conversion tool) messages: 69510 nosy: collinwinter, ctheune severity: normal status: open title: 2to3 looses indentation on import fix versions: Python 3.0 ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue3334 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue2513] 64bit cross compilation on windows
Christian Theune [EMAIL PROTECTED] added the comment: Mark, I think you mixed me up with Christian Heimes, so I'm removing myself here (at least for now). __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue2513 __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1787] segfault in obmalloc.c
New submission from Christian Theune: Python 2.4.4 on Linux crashes with following backtrace. Application is a Zope server. The other threads seem to be idle at that moment, only the segfaulting thread gives a reasonable backtrace (see attachment). -- components: Interpreter Core files: backtrace messages: 59697 nosy: ctheune severity: critical status: open title: segfault in obmalloc.c type: crash versions: Python 2.4 Added file: http://bugs.python.org/file9121/backtrace __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1787 __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
