[issue35155] Clarify Protocol Handlers in urllib.request Docs
Change by Denton Liu : -- stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.org/issue35155> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue35155] Clarify Protocol Handlers in urllib.request Docs
Denton Liu added the comment: If there aren't anymore comments, I think this PR is ready for a second round of reviews. Thanks! -- ___ Python tracker <https://bugs.python.org/issue35155> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue35155] Clarify Protocol Handlers in urllib.request Docs
Denton Liu added the comment: Unfortunately, inline markup can't be combined with roles. Using asterisks, it shows up as `**_open()` and using braces, `{}_open`. I'm not sure how this works but it _might_ be possible to change how :meth: role is interpreted but I believe that's outside the scope of this change. -- ___ Python tracker <https://bugs.python.org/issue35155> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue35155] Clarify Protocol Handlers in urllib.request Docs
Denton Liu added the comment: I gave that a try but it seems like it just outputs the {} literally in the case of the method role. -- ___ Python tracker <https://bugs.python.org/issue35155> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue35155] Clarify Protocol Handlers in urllib.request Docs
Denton Liu added the comment: Pinging again for updates. Would appreciate a PR review. Thanks! -- ___ Python tracker <https://bugs.python.org/issue35155> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue35155] Clarify Protocol Handlers in urllib.request Docs
Denton Liu added the comment: Pinging for updates. -- ___ Python tracker <https://bugs.python.org/issue35155> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue35155] Clarify Protocol Handlers in urllib.request Docs
Change by Denton Liu : -- keywords: +patch pull_requests: +9616 stage: -> patch review ___ Python tracker <https://bugs.python.org/issue35155> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue35155] Clarify Protocol Handlers in urllib.request Docs
New submission from Denton Liu : The urllib.request documentation that they can add their own protocol handlers, however they are unclear on how they should be named. We should replace instances of things like protocol_request with _request to make it clear that we are literally replacing "protocol" with the literal protocol. I am creating this issue because I had to actually read the urllib.request source code in order to figure out how to use the protocol handler APIs. -- assignee: docs@python components: Documentation messages: 329210 nosy: Denton-L, docs@python priority: normal severity: normal status: open title: Clarify Protocol Handlers in urllib.request Docs type: enhancement versions: Python 3.4, Python 3.5, Python 3.6, Python 3.7, Python 3.8 ___ Python tracker <https://bugs.python.org/issue35155> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com