[issue24255] Replace debuglevel-related logic with logging
Eryn Wells added the comment: Actually, I spoke too soon. My current employer isn't too keen on us contributing to open source, so I can't do this. Sorry! -- ___ Python tracker <https://bugs.python.org/issue24255> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24255] Replace debuglevel-related logic with logging
Eryn Wells added the comment: Hi, it sounds like my original patch is the preferred approach. I can put up a GitHub PR for that. -- ___ Python tracker <https://bugs.python.org/issue24255> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24255] Replace debuglevel-related logic with logging
Eryn Wells added the comment: Here's a patch that replaces all the debuglevel stuff with logging. There's a single module-level logger that handles it all. I wasn't sure if it would be okay to break API compatibility, so I kept the debuglevel flag and the set_debuglevel() method even though they don't do anything. Most of the information that was being print()ed is still there, but I cleaned it up a little and added a few more messages. The INFO level messages are pretty sparse, with DEBUG providing a lot more raw data from the request. -- keywords: +patch Added file: http://bugs.python.org/file39651/http-client-logging.patch ___ Python tracker <http://bugs.python.org/issue24255> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24255] Replace debuglevel-related logic with logging
Eryn Wells added the comment: Hi. This is my first issue, but I'd be willing to have a go at updating this module. Do either of you have specific ideas about what changes you want here? My thought was to import logging, create a logger object, and start by replacing all the self.debuglevel stuff with appropriate log statements. Does that make sense? Do each of the classes need separate loggers, or is just one module-level logger enough? -- nosy: +erynofwales ___ Python tracker <http://bugs.python.org/issue24255> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
