[issue24260] TabError behavior doesn't match documentation

[Facundo Batista]

Facundo Batista  added the comment:

Found this after seeing (once again) somebody asking for help in Python 
Argentina after having a file mixing tabs and spaces.

This tends to catch new people.

I'm +1 to just raise an error if the file mixes tabs and spaces for 
indentation. I've never seen a real usage case where it was not an accident, 
even if the mix was in different blocks, so it actually worked "fine" (and even 
in those cases, then the user copies lines around, and the program starts to 
behave weirdly).

--
nosy: +facundobatista

___
Python tracker 
<https://bugs.python.org/issue24260>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41400] Remove references to nonexisting __ne__ methods

[Facundo Batista]

Facundo Batista  added the comment:

>From a "consumer" POV, it's totally useful to see that `__ne__` is part of 
>what Set (and others) provides, even if it's implemented in the Set class 
>itself or wherever.

So +1 to leave it like it's currently is.

--
nosy: +facundobatista

___
Python tracker 
<https://bugs.python.org/issue41400>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18417] urlopen() has a hidden default for its timeout argument

[Facundo Batista]

Change by Facundo Batista :


--
nosy:  -facundobatista

___
Python tracker 
<https://bugs.python.org/issue18417>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37168] Decimal divisions sometimes 10x or 100x too large

[Facundo Batista]

Change by Facundo Batista :


--
nosy:  -facundobatista

___
Python tracker 
<https://bugs.python.org/issue37168>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40486] pathlib's iterdir doesn't specify what happens if directory content change

[Facundo Batista]

Facundo Batista  added the comment:

However, Serhiy, `os.listdir()` builds a list quickly and gives you that, so 
the chance of the directory being modified is quite low (however, for big 
directories, that may happen, and it's probably good to notice that in the 
docs).

For `Path.iterdir()` that list is not built, and as it's iteration is external, 
the amount of time between getting one item to the other is unbound, *anything* 
could happen in the middle. 

In short, I think that both docs should state that the directory could change 
while it's iterated (in the os.listdir case probably stating that the chances 
are low).

--

___
Python tracker 
<https://bugs.python.org/issue40486>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15947] Assigning new values to instance of pointer types does not check validity

[Facundo Batista]

Facundo Batista  added the comment:

I'm closing this, it looks to me that behaviour changed and this is safe now.

--
stage:  -> resolved
status: open -> closed

___
Python tracker 
<https://bugs.python.org/issue15947>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40153] json dump with repeated key

[Facundo Batista]

Facundo Batista  added the comment:

The balance here is allow an invalid JSON to be created (but documenting that 
on some situations that will happen), or sticking to always produce valid 
JSONs, but with a hit in performance (which we don't know so far if it's big or 
small).

--

___
Python tracker 
<https://bugs.python.org/issue40153>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40486] pathlib's iterdir doesn't expecify what happens if directory content change

[Facundo Batista]

New submission from Facundo Batista :

Documentation for Path.iterdir ( 
https://docs.python.org/3/library/pathlib.html#pathlib.Path.iterdir ) doesn't 
specify what happens when the directory change.

This is important, as the function does NOT return a list (which would imply 
that a "snapshot" of the directory will be returned).

Also, it's not only relevant what would happen if somebody else changes the 
directory after the iteration is started (will that change be reflected?) but 
also if it's ALLOWED for the same code that iterates the dir content to change 
it (or problems would arise, like when changing a dictionary while being 
iterated).

--
assignee: docs@python
components: Documentation
messages: 367981
nosy: docs@python, facundobatista
priority: normal
severity: normal
status: open
title: pathlib's iterdir doesn't expecify what happens if directory content 
change
versions: Python 3.9

___
Python tracker 
<https://bugs.python.org/issue40486>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40382] Make 'rt' the default for open in docs

[Facundo Batista]

New submission from Facundo Batista :

This is mostly a confusion about 'r' being a synonym of 'rt', while it's more 
explicit if we consider 'r' as one default, and 't' as other (as other parts of 
the documentation do).

Doing `help(open)` we get:

mode is an optional string that specifies the mode in which the file
is opened. It defaults to 'r' which means open for reading in text
mode. 

Later in the same text it's stated:

The default mode is 'rt' (open for reading text).

Which reflects the wording I want to have, but is confusing that initially it 
said a different thing.

If we get the html docs, it says "The default mode is 'r' (open for reading 
text, synonym of 'rt')."

Why not just stating that the default mode is 'rt'?

--
assignee: docs@python
components: Documentation
messages: 367219
nosy: docs@python, facundobatista
priority: normal
severity: normal
stage: needs patch
status: open
title: Make 'rt' the default for open in docs
type: enhancement
versions: Python 3.9

___
Python tracker 
<https://bugs.python.org/issue40382>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40153] json dump with repeated key

[Facundo Batista]

Facundo Batista  added the comment:

It's a theoretical issue, I didn't hit it myself.

--

___
Python tracker 
<https://bugs.python.org/issue40153>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40153] json dump with repeated key

[Facundo Batista]

New submission from Facundo Batista :

As stated in docs [0], JSON structures must not have duplicated keys.

>>> json.dumps({1:2, "1":3})
'{"1": 2, "1": 3}'

This is related to https://bugs.python.org/issue34972 . 



[0] "The RFC specifies that the names within a JSON object should be unique, 
..." https://docs.python.org/3/library/json.html#repeated-names-within-an-object

--
messages: 365581
nosy: facundobatista
priority: normal
severity: normal
status: open
title: json dump with repeated key
versions: Python 3.6, Python 3.7, Python 3.8, Python 3.9

___
Python tracker 
<https://bugs.python.org/issue40153>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34972] json dump silently converts int keys to string

[Facundo Batista]

Facundo Batista  added the comment:

I understand (and agree with) the merits of automatically converting the int to 
str when dumping to a string.

However, this result really surprised me:

>>> json.dumps({1:2, "1":3})
'{"1": 2, "1": 3}'

Is it a valid JSON?

--
nosy: +facundobatista

___
Python tracker 
<https://bugs.python.org/issue34972>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39275] Traceback off by one line when

[Facundo Batista]

Facundo Batista  added the comment:

This is a duplicate of https://bugs.python.org/issue16482 -- closing it.

--
resolution:  -> duplicate
stage:  -> resolved
status: open -> closed

___
Python tracker 
<https://bugs.python.org/issue39275>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39275] Traceback off by one line when

[Facundo Batista]

New submission from Facundo Batista :

When using pdb to debug, the traceback is off by one line.

For example, this simple script:

```
print("line 1")
import pdb;pdb.set_trace()
print("line 2")
print("line 3", broken)
print("line 4")
```

...when run produces the following traceback (after hitting 'n' in pdb, of 
course):

```
Traceback (most recent call last):
  File "/home/facundo/foo.py", line 3, in 
print("line 2")
NameError: name 'broken' is not defined
```

--
messages: 359678
nosy: facundobatista
priority: normal
severity: normal
status: open
title: Traceback off by one line when
versions: Python 3.6, Python 3.9

___
Python tracker 
<https://bugs.python.org/issue39275>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33160] Negative values in positional access inside formatting

[Facundo Batista]

New submission from Facundo Batista :

This works fine:

>>> "{[0]}".format([1, 2, 3])
'1'

This should work too:

>>> "{[-1]}".format([1, 2, 3])
Traceback (most recent call last):
  File "", line 1, in 
TypeError: list indices must be integers or slices, not str

--
messages: 314549
nosy: facundobatista
priority: normal
severity: normal
status: open
title: Negative values in positional access inside formatting
versions: Python 3.6

___
Python tracker 
<https://bugs.python.org/issue33160>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26680] Incorporating float.is_integer into the numeric tower and Decimal

[Facundo Batista]

Change by Facundo Batista :


--
nosy:  -facundobatista

___
Python tracker 
<https://bugs.python.org/issue26680>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32487] assertRaises should return the "captured" exception

[Facundo Batista]

New submission from Facundo Batista :

Sometimes it's nice to do extra checks on the error raised and captured by 
self.assertRaises call.

Yes, the same can be achieved using assertRaises as a context manager and then 
accessing the `exception` attribute in the context manager, but it looks too 
cumbersome to just get the exception, when it can be simply returned by the 
assertRaises call.

Note 1: Currently it returns None, so no backward compatibility problem.

Note 2: assertRaises in testtools does this and is very useful

--
messages: 309414
nosy: facundobatista
priority: normal
severity: normal
stage: needs patch
status: open
title: assertRaises should return the "captured" exception
type: enhancement
versions: Python 3.7

___
Python tracker 
<https://bugs.python.org/issue32487>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28700] test_dbm failure: KeyError: b'0' (intermittent in 3.5, reliable in 3.6)

[Facundo Batista]

Facundo Batista  added the comment:

I have this failure on my machine too (Ubuntu 17.04, kernel 4.10.0-37-generic).

Installing `libgdbm-dev` and running configure with 
`--with-dbmliborder=gdbm:bdb` didn't help.

--
nosy: +facundobatista

___
Python tracker 
<https://bugs.python.org/issue28700>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29696] Use namedtuple in Formatter.parse iterator response

[Facundo Batista]

New submission from Facundo Batista:

Right now:

>>> Formatter().parse("mira como bebebn los peces en el {rio} {de} {la} plata")

>>> next(_)
('mira como bebebn los peces en el ', 'rio', '', None)

This returned tuple should be a namedtuple, so it's self-explained for people 
exploring this (and usage of the fields become clearer)

--
components: Library (Lib)
messages: 288807
nosy: facundobatista
priority: normal
severity: normal
status: open
title: Use namedtuple in Formatter.parse iterator response
type: behavior
versions: Python 3.5

___
Python tracker 
<http://bugs.python.org/issue29696>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28135] assertRaises should return the exception in its simple form

[Facundo Batista]

New submission from Facundo Batista:

So, you could do:

  exc = self.assertRaises(ValueError, somefunc, someargs)

And then, explore "exc" as will. 

Yes, you can get the exception if you use assertRaises as a context manager, 
but that leads to more cumbersome code:

  with self.assertRaises(ValueError) as cm:
  somefunc(someargs)
  exc = cm.exception

--
messages: 276334
nosy: facundobatista
priority: normal
severity: normal
status: open
title: assertRaises should return the exception in its simple form

___
Python tracker 
<http://bugs.python.org/issue28135>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28019] itertools.count() falls back to fast (integer) mode when step rounds to 1

[Facundo Batista]

Facundo Batista added the comment:

I think the fix nails it; all the problem was that the "fast" mode was wrongly 
detected, and all the problems (counting badly, or a bad repr, etc) is a 
problem after setting cnt into PY_SSIZE_T_MAX.

IIUC there is nothing special to do when step=1.0, as later on the original 
objects are used (they don't suffer a wrong cast to integer anymore).

--
nosy: +facundobatista

___
Python tracker 
<http://bugs.python.org/issue28019>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28019] itertools.count() falls back to fast (integer) mode when step rounds to 1

[Facundo Batista]

Changes by Facundo Batista :


--
versions: +Python 3.5

___
Python tracker 
<http://bugs.python.org/issue28019>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26826] Expose new copy_file_range() syscall in os module.

[Facundo Batista]

Facundo Batista added the comment:

It looked ok to me (I couldn't try it, as I still have 4.4 kernel).

One thing to the be done is to improve the test coverage (trying the usage of 
all the parameters, at least).

--
nosy: +facundobatista

___
Python tracker 
<http://bugs.python.org/issue26826>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24974] ICC on Windows 8.1: _decimal fails to compile with default fp model

[Facundo Batista]

Changes by Facundo Batista :


--
nosy:  -facundobatista

___
Python tracker 
<http://bugs.python.org/issue24974>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23887] HTTPError doesn't have a good "repr" representation

[Facundo Batista]

Changes by Facundo Batista :


--
resolution:  -> fixed
status: open -> closed

___
Python tracker 
<http://bugs.python.org/issue23887>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23887] HTTPError doesn't have a good "repr" representation

[Facundo Batista]

Facundo Batista added the comment:

Hi Berker, I like your patch, will apply it after doing a test for it.

--

___
Python tracker 
<http://bugs.python.org/issue23887>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23887] HTTPError doesn't have a good "repr" representation

[Facundo Batista]

New submission from Facundo Batista:

I normally print(repr()) the exception I got, for debugging purposes. I use 
repr() because for builtin exceptions, str() will print only the message, and 
not the exception type.

But for HTTPError, the repr() of it is "HTTPError()", without further 
explanation...

--
messages: 240262
nosy: facundobatista
priority: normal
severity: normal
status: open
title: HTTPError doesn't have a good "repr" representation
versions: Python 3.4

___
Python tracker 
<http://bugs.python.org/issue23887>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22058] datetime.datetime() should accept a datetime.date as init parameter

[Facundo Batista]

Facundo Batista added the comment:

El 24/07/14 a las 15:01, Tim Peters escibió:

> "datetime.date() should accept a datetime.datetime as init
> parameter"
> 
> instead?  That's what the example appears to be getting at.
> 
> If so, -1.  Datetime objects already have .date(), .time(), and
> .timetz() methods to extract, respectively, the date, naive time, and

Ah, I wasn't aware of the .date() method.

I guess because it's more natural to me to do int(a_float) than
a_float.integer().

So, unless anyody wants to pursue with this, I'll close the issue.

Thanks!

--

___
Python tracker 
<http://bugs.python.org/issue22058>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22058] datetime.datetime() should accept a datetime.date as init parameter

[Facundo Batista]

Changes by Facundo Batista :


--
title: datetime.datetime() should accept a datetime.date as constructor -> 
datetime.datetime() should accept a datetime.date as init parameter

___
Python tracker 
<http://bugs.python.org/issue22058>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22058] datetime.datetime() should accept a datetime.date as constructor

[Facundo Batista]

New submission from Facundo Batista:

Currently (tested on py3.4):

>>> from datetime import datetime, date
>>> d = datetime.now()
>>> date(d)
Traceback (most recent call last):
  File "", line 1, in 
TypeError: an integer is required (got type datetime.datetime)

IMO, it's like doing int(float), a truncation of some info. For example, this 
is what I want to happen:

>>> d
datetime.datetime(2014, 7, 24, 11, 38, 44, 966613)
>>> date(d)
datetime.date(2014, 7, 24)

--
messages: 223840
nosy: facundobatista
priority: normal
severity: normal
status: open
title: datetime.datetime() should accept a datetime.date as constructor
versions: Python 3.5

___
Python tracker 
<http://bugs.python.org/issue22058>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13866] {urllib, urllib.parse}.urlencode should not use quote_plus

[Facundo Batista]

Changes by Facundo Batista :


--
stage: resolved -> patch review
versions: +Python 3.4 -Python 3.3

___
Python tracker 
<http://bugs.python.org/issue13866>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19272] Can't pickle lambda (while named functions are ok)

[Facundo Batista]

Facundo Batista added the comment:

Jesús, Amaury:

What if pickle would assign a random unique name to the lambda (like, an UUID) 
so it can be pickled and unpickled?

--

___
Python tracker 
<http://bugs.python.org/issue19272>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19272] Can't pickle lambda (while named functions are ok)

[Facundo Batista]

Facundo Batista added the comment:

Ethan, lambda functions are included in "functions defined at the top level of 
a module".

Probably we should note there something like "except lambdas, because function 
pickling is by name, not by code".

--

___
Python tracker 
<http://bugs.python.org/issue19272>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19272] Can't pickle lambda (while named functions are ok)

[Facundo Batista]

New submission from Facundo Batista:

This is ok:

Python 3.4.0a3+ (default:86af5991c809, Oct 13 2013, 16:42:52) 
...
>>> import pickle
>>> def f():  
...   pass
... 
>>> pickle.dumps(f)
b'\x80\x03c__main__\nf\nq\x00.'


However, when trying to pickle a lambda, it fails:
>>> 
>>> pickle.dumps(lambda: None)
Traceback (most recent call last):
  File "", line 1, in 
_pickle.PicklingError: Can't pickle : attribute lookup 
builtins.function failed


(Found this because I'm getting the same problem but when trying to use 
concurrent.futures.ProcessExecutor)

--
components: Library (Lib)
messages: 200062
nosy: facundobatista
priority: normal
severity: normal
status: open
title: Can't pickle lambda (while named functions are ok)
type: behavior
versions: Python 3.3, Python 3.4

___
Python tracker 
<http://bugs.python.org/issue19272>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15947] Assigning new values to instance of pointer types does not check validity

[Facundo Batista]

New submission from Facundo Batista:

In the doc it says:

"""
Assigning a new value to instances of the pointer types c_char_p, c_wchar_p, 
and c_void_p changes the memory location they point to, not the contents of the 
memory block [...].

>>> s = "Hello, World"
>>> c_s = c_wchar_p(s)
>>> print(c_s)
c_wchar_p('Hello, World')
>>> c_s.value = "Hi, there"
>>> print(c_s)
c_wchar_p('Hi, there')
>>> print(s) # first object is unchanged
Hello, World
>>>
"""

However, c_s it's not getting "Hi, there" as "the memory location it points 
to", otherwise next access will surely segfault.

OTOH, if it *does* change the memory location, but the value is cached locally, 
which is the point of letting it change the memory location? Shouldn't it raise 
AttributeError or something?

Thanks!

--
components: ctypes
messages: 170518
nosy: facundobatista
priority: normal
severity: normal
status: open
title: Assigning new values to instance of pointer types does not check validity
type: behavior
versions: Python 3.2

___
Python tracker 
<http://bugs.python.org/issue15947>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue10897] UNIX mmap unnecessarily dup() file descriptor

[Facundo Batista]

Changes by Facundo Batista :


--
nosy:  -facundobatista

___
Python tracker 
<http://bugs.python.org/issue10897>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue6116] frame.f_locals keeps references to things for too long

[Facundo Batista]

Facundo Batista  added the comment:

Antoine, to see if I understood correctly... if we build the dict, and just 
return it but don't save it in the frame, this leak would be solved? (yes, it'd 
be slower because everytime it's asked, it'd need to be built again)

--

___
Python tracker 
<http://bugs.python.org/issue6116>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue6116] frame.f_locals keeps references to things for too long

[Facundo Batista]

Facundo Batista  added the comment:

Making a copy of f_locals values to return a dictionary that doesn't hold 
references to the locals of the frame is not that simple (for me, at least):

- shallow copy: we'll return always a new dict, with the values being a copy of 
locals; this is simpler, but what about other objects that are referenced in in 
those values? For example, in locals exists a list A which holds a reference to 
object B; the new dict we return will have copy of A, but this copy will still 
reference B.

- deep copy: we'll return a new dict with a deep copy of all values; this is 
safer, but what about memory? In any case, how we could do a deep copy here? 
calling Python's code copy.deepcopy()?

I want to add a fourth option to JP's initial ones:

- have other attribute, something like f_locals_weak that is a list of tuples 
[(name, value), ...], being the values a weak reference to the real locals.

What do you think?

Regards,

--
nosy: +facundobatista

___
Python tracker 
<http://bugs.python.org/issue6116>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue7221] DispatcherWithSendTests_UsePoll with test_asyncore does nothing

[Facundo Batista]

Changes by Facundo Batista :


--
assignee: facundobatista -> 

___
Python tracker 
<http://bugs.python.org/issue7221>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2756] urllib2 add_header fails with existing unredirected_header

[Facundo Batista]

Facundo Batista  added the comment:

Senthil, I'm assigning this issue to you because you know more about this 
subject than me. Feel free to unassign if will not be working in it.

Thanks!

--
assignee: facundobatista -> orsenthil

___
Python tracker 
<http://bugs.python.org/issue2756>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5340] Change in cgi behavior breaks existing software

[Facundo Batista]

Changes by Facundo Batista :


--
assignee: facundobatista -> 

___
Python tracker 
<http://bugs.python.org/issue5340>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1545463] New-style classes fail to cleanup attributes

[Facundo Batista]

Changes by Facundo Batista :


--
versions:  -Python 2.5.3

___
Python tracker 
<http://bugs.python.org/issue1545463>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue4079] new urllib2.Request 'timeout' attribute needs to have a default

[Facundo Batista]

Facundo Batista  added the comment:

I'm ok with the proposed changes from Sidnei (yes, a patch is needed).

--

___
Python tracker 
<http://bugs.python.org/issue4079>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue7633] decimal.py: type conversion in context methods

[Facundo Batista]

Facundo Batista  added the comment:

Juanjo, ping me in private if you want help with the doc toolchain, I can show 
you how to touch the .rst and see the changes after processing.

--

___
Python tracker 
<http://bugs.python.org/issue7633>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5911] built-in compile() should take encoding option.

[Facundo Batista]

Changes by Facundo Batista :


--
nosy: +facundobatista

___
Python tracker 
<http://bugs.python.org/issue5911>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue6845] Restart support in binary upload for ftplib

[Facundo Batista]

Facundo Batista  added the comment:

I like this. I'd love to see a test of this, though.

Pablo, do you think you could came up with a test? Thanks!

--

___
Python tracker 
<http://bugs.python.org/issue6845>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue6795] decimal.py: minor issues && usability

[Facundo Batista]

Facundo Batista  added the comment:

Issue 1: +1 to raise ValueError

Issue 3: -0 to change actual behaviour

Thanks!

--

___
Python tracker 
<http://bugs.python.org/issue6795>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue6274] subprocess.Popen() may leak file descriptors

[Facundo Batista]

Facundo Batista  added the comment:

Applied the patch (slightly modified) to trunk (2.7), 2.6, and 3k branches.

--
resolution:  -> fixed
status: open -> closed

___
Python tracker 
<http://bugs.python.org/issue6274>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue6274] subprocess.Popen() may leak file descriptors

[Facundo Batista]

New submission from Facundo Batista :

If something bad happens between a os.pipe() call is called, and the
returned file descriptors are closed, those file descriptors are never
closed.

In a long lived process this is a problem.

Patch (against trunk) to solve this is attached.

--
assignee: facundobatista
files: subprocess.py.diff
keywords: patch
messages: 89301
nosy: facundobatista
severity: normal
status: open
title: subprocess.Popen() may leak file descriptors
type: resource usage
versions: Python 2.6, Python 2.7, Python 3.1
Added file: http://bugs.python.org/file14278/subprocess.py.diff

___
Python tracker 
<http://bugs.python.org/issue6274>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1424152] urllib/urllib2: HTTPS over (Squid) Proxy fails

[Facundo Batista]

Facundo Batista  added the comment:

Hans, please take a look to my comment 79573 in this same bug. If you
could do that, it'd be amazing...

Thank you!

--

___
Python tracker 
<http://bugs.python.org/issue1424152>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5435] test_httpservers on Debian Testing

[Facundo Batista]

Facundo Batista  added the comment:

CGI tests shouldn't be run as root, it seems, as it breaks the inherent
protection.

--
nosy: +facundobatista
resolution:  -> invalid
status: open -> closed

___
Python tracker 
<http://bugs.python.org/issue5435>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5445] codecs.StreamWriter.writelines problem when passed generator

[Facundo Batista]

Facundo Batista  added the comment:

When fixing this, note that the builtin name "list" should not be
overwritten by the argument name.

--
message_count: 1.0 -> 2.0
nosy: +facundobatista
nosy_count: 1.0 -> 2.0

___
Python tracker 
<http://bugs.python.org/issue5445>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3676] Obsolete references to PEP 291 in py3k lib

[Facundo Batista]

Facundo Batista  added the comment:

Removed the messages in decimal.py (r.69674).

___
Python tracker 
<http://bugs.python.org/issue3676>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue4796] Decimal to receive from_float method

[Facundo Batista]

Facundo Batista  added the comment:

Raymond, Mark, thanks for this work!

I'd include the following in the PEP (under the "from float"
discussion), what do you think?

"""
Update: The .from_float() method was added to Python 2.7 and 3.1
versions, providing lossless and exact conversion from float to Decimal 
(see issue 4796 [7]_ for further information).


It has the following syntax::

Decimal.from_float(floatNumber)

where ``floatNumber`` is the float number origin of the construction.  
Example::

>>> Decimal.from_float(1.1)
Decimal('1.100088817841970012523233890533447265625')
"""

--
nosy: +facundobatista

___
Python tracker 
<http://bugs.python.org/issue4796>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue4608] urllib.request.urlopen does not return an iterable object

[Facundo Batista]

Facundo Batista  added the comment:

Senthil, do you think you could provide a test case for this?

Thank you!

--
assignee:  -> facundobatista
nosy: +facundobatista

___
Python tracker 
<http://bugs.python.org/issue4608>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue4607] uuid behavior with multiple threads

[Facundo Batista]

Facundo Batista  added the comment:

Yes, _buffer is not longer global.

Thanks for the report!

--
nosy: +facundobatista
resolution:  -> out of date
status: open -> closed

___
Python tracker 
<http://bugs.python.org/issue4607>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1424152] urllib/urllib2: HTTPS over (Squid) Proxy fails

[Facundo Batista]

Facundo Batista  added the comment:

Everything looks ok, with one detail, the new set_tunnel() function.

Should this function be public? If yes, new documentation should be
added. If not, it should start with "_". 

I think that it should be public, because we're using it from somewhere
else. So, please provide new patchs for documentation (don't bother to
modify actual code patches).

Thank you!

___
Python tracker 
<http://bugs.python.org/issue1424152>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1251] ssl module doesn't support non-blocking handshakes

[Facundo Batista]

Facundo Batista  added the comment:

Bill, should this issue be closed?

Or Senthil found a bug in the actual code and you're waiting for him to
point out where is the problem or a way to reproduce it?

--
nosy: +facundobatista

___
Python tracker 
<http://bugs.python.org/issue1251>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue4753] Faster opcode dispatch on gcc

[Facundo Batista]

Changes by Facundo Batista :


--
nosy: +facundobatista

___
Python tracker 
<http://bugs.python.org/issue4753>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue4084] Decimal.max(NaN, x) gives incorrect results when x is finite and long

[Facundo Batista]

Facundo Batista <[EMAIL PROTECTED]> added the comment:

Commited in trunk and Py3, thanks Mark!

Please, could you commit it in 2.5? The only change I've made in the
patch is adding the issue number to Misc/NEWS, the rest is ok.

After that, just close this.

Thanks again!

--
versions:  -Python 2.6, Python 2.7, Python 3.0, Python 3.1

___
Python tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue4084>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue4087] Document the effects of NotImplemented on == and !=

[Facundo Batista]

Facundo Batista <[EMAIL PROTECTED]> added the comment:

2008/10/9 Raymond Hettinger <[EMAIL PROTECTED]>:

> Alternatively, we could decide to allow decimal/float 
> comparisons -- the float can be converted to a decimal
> exactly and compared exactly -- it would be slow but 
> it would work and have precise semantics.

-0

Note that this could lead to surprising behaviours, when doing these
comparations... Decimal("1.1")==1.1 will be true, buy maybe
Decimal("1.235445687")==1.235445687 will not (I didn't try if this
particular comparison will fail, but hope you get the idea).

This is why I suggested the other way... we now allow comparison to
integers, let's allow comparisons when the floats are equal to the
integers, and no more.

___
Python tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue4087>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue4087] equality involving Decimals is not transitive; strange set behaviour results

[Facundo Batista]

Facundo Batista <[EMAIL PROTECTED]> added the comment:

(Ok, remember that I'm not a "numeric" guy before start hitting me, :p )

I think that if we have Decimal(1)==1, and 1==1.0, to have Decimal(1)==1.0.

We always rejected comparison with "unsupported types", but having this
situation, I'd propose to put something like the following at the
beggining of __eq__() and similars:

def __eq__(self, other):
if isinstance(other, float) and int(other)==other:
other = int(other)

What do you think?

___
Python tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue4087>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1028088] Cookies without values are silently ignored (by design?)

[Facundo Batista]

Changes by Facundo Batista <[EMAIL PROTECTED]>:


--
nosy: +facundobatista

___
Python tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1028088>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1202] zlib.crc32() and adler32() return value

[Facundo Batista]

Facundo Batista <[EMAIL PROTECTED]> added the comment:

Let me reopen this, I think we have an issue with this fix.

The conclusion of this discussion so far is that in 3.0 the crc32 will
behave like the standard, which is a good thing (tm), but in 2.6 it will
not: it should return a signed integer. I agree with this outcome!

The documentation for 2.6, the commit message for the fix and what it's
said here states that: "2.6 always returns signed, 2**31...2**31-1 come
back as negative integers."

This is *not* actually happening:

>>> s = "*"*10
>>> print zlib.crc32(s)  # 2.6, 32 bits
-872059092
>>> print zlib.crc32(s)  # 2.6, 64 bits
3422908204

The problem in the code is, IMHO, that the "32b rounding" is being
forced by assigning the result to an int (Modules/zlibmodule.c, line
929), but this "rounding" does not actually work for 64b (because the
int has 64 bit, and even as it's signed, the number stays big and positive).

Thank you!

--
nosy: +facundobatista
resolution: fixed -> 
status: closed -> open

___
Python tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1202>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2486] Decimal slowdown in 3.0 due to str/unicode changes

[Facundo Batista]

Facundo Batista <[EMAIL PROTECTED]> added the comment:

Nick said:

> So I would suggest either a new directory in the sandbox, or 
> re-using Facundo's original directory (which includes the 
> telco benchmark)

+1


> And I agree that it is far more sensible to target 2.7/3.1 at 
> this stage - the 3.0 slowdown, while real, actually isn't as bad 
> as I expected, and even if it's large enough to be unacceptable 
> to heavy users of Decimal, the only consequence is that they will 

I'm not seeing this job as a way to solve the 3.0 slowdown, but more as
the way to slowly, but steadily, replace parts of Decimal from Python to
C as needed.

So, I'm +1 to target this to 3.1, and I'm -0 to register the slowdown in
the releases notes (those who use Decimal aren't really in it for speed...).

Thank you!!

___
Python tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue2486>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3817] ftplib: ABOR does not consider 225 response code

[Facundo Batista]

Facundo Batista <[EMAIL PROTECTED]> added the comment:

Giampaolo, should we close this one as duplicate of 3818 (that you
created one minute later)?

--
nosy: +facundobatista

___
Python tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue3817>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3808] test_cgi is giving deprecation warnings

[Facundo Batista]

Facundo Batista <[EMAIL PROTECTED]> added the comment:

Fixed in r66326. Thank you!

--
resolution:  -> fixed
status: open -> closed

___
Python tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue3808>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3808] test_cgi is giving deprecation warnings

[Facundo Batista]

Facundo Batista <[EMAIL PROTECTED]> added the comment:

My fault, I'm exercising functions that have to raise a deprecation
warning... should I remove these tests?

Thank you!

___
Python tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue3808>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3801] cgi.parse_qsl does not return list

[Facundo Batista]

Facundo Batista <[EMAIL PROTECTED]> added the comment:

Dumb error, it was even only in 2.6, 3.0 was ok.

Thanks for noticing it, I fixed it and added tests for both versions.

Thank you again!!

--
nosy: +facundobatista
resolution:  -> fixed
status: open -> closed

___
Python tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue3801>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2305] Update What's new in 2.6

[Facundo Batista]

Facundo Batista <[EMAIL PROTECTED]> added the comment:

The parse_qs() and parse_qsl() relocation from module cgi to urlparse
needs an entry in the "What's new..." (alerting you through here,
because I commited this last night).

See issue 600362 for further info, or ask me directly, :)

--
nosy: +facundobatista

___
Python tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue2305>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue600362] relocate cgi.parse_qs() into urlparse

[Facundo Batista]

Facundo Batista <[EMAIL PROTECTED]> added the comment:

Commited in r66196 and r66199, this went into 2.6/3.0 rc1!!

Thank you all for the effort!

--
resolution:  -> fixed
status: open -> closed

___
Python tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue600362>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2486] Decimal slowdown in 3.0 due to str/unicode changes

[Facundo Batista]

Facundo Batista <[EMAIL PROTECTED]> added the comment:

Can not get into this now, but I'll be able to deal with this in some
weeks...

--
assignee:  -> facundobatista

___
Python tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue2486>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue600362] relocate cgi.parse_qs() into urlparse

[Facundo Batista]

Facundo Batista <[EMAIL PROTECTED]> added the comment:

Senthil, please update the patchs, adding a DeprecationWarning in 3.0 and
a PendingDeprecationWarning in 2.6.

Thanks!

___
Python tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue600362>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2464] urllib2 can't handle http://www.wikispaces.com

[Facundo Batista]

Facundo Batista <[EMAIL PROTECTED]> added the comment:

Gregory... I tried to fill the path in urlunparse, and other functions
that use this started to fail.

As we're so close to final releases, I'll leave this as it's right now,
that actually fixed the bug...

___
Python tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue2464>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2464] urllib2 can't handle http://www.wikispaces.com

[Facundo Batista]

Facundo Batista <[EMAIL PROTECTED]> added the comment:

Maybe we can put it in urlunparse... do you all agree with this test cases?

def test_alwayspath(self):
u = urlparse.urlparse("http://netloc/path;params?query#fragment";)
self.assertEqual(urlparse.urlunparse(u),
"http://netloc/path;params?query#fragment";)

u = urlparse.urlparse("http://netloc?query#fragment";)
self.assertEqual(urlparse.urlunparse(u),
"http://netloc/?query#fragment";)

u = urlparse.urlparse("http://netloc#fragment";)
self.assertEqual(urlparse.urlunparse(u), "http://netloc/#fragment";)



Maybe we could backport this more general fix...

___
Python tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue2464>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2464] urllib2 can't handle http://www.wikispaces.com

[Facundo Batista]

Facundo Batista <[EMAIL PROTECTED]> added the comment:

Senthil: I don't like that.

Creating a public method called "fix_broken", introducing new behaviours
now in beta, and actually not fixing the url in any broken possibility
(just the path if it's not there), it's way too much for this fix.

I commited the change I proposed. Maybe in the future will have a
"generic url fixing" function, now is not the moment.

--
resolution:  -> fixed
status: open -> closed

___
Python tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue2464>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3556] test_raiseMemError consumes an insane amount of memory

[Facundo Batista]

Facundo Batista <[EMAIL PROTECTED]> added the comment:

Terry, I don't get to understand your comment. Could you please explain
in more detail? Thank you!

___
Python tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue3556>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2464] urllib2 can't handle http://www.wikispaces.com

[Facundo Batista]

Facundo Batista <[EMAIL PROTECTED]> added the comment:

Senthil:

Look at that URL that the server returned in the second redirect:

http://www.wikispaces.com?responseToken=ee3fca88a9b0dc865152d8a9e5b6138d

See that the "?" appears without a path between the host and it.

Check the item 3.2.2 in the RFC 2616, it says that a HTTP URL should be:

  http_URL = "http:" "//" host [ ":" port ] [ abs_path [ "?" query ]]

So, we should fix that URL that the server returned. Guess what: if we
put a "/" (as obligates the RFC), everything works ok.

The patch I attach here does that. All tests pass ok.

What do you think?

--
keywords: +patch
Added file: http://bugs.python.org/file11127/issue2464-facundo.diff

___
Python tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue2464>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3556] test_raiseMemError consumes an insane amount of memory

[Facundo Batista]

Facundo Batista <[EMAIL PROTECTED]> added the comment:

Antoine, it works great, both in 2.6 and in 3.0 (with the obvious small
modification).

--
nosy: +facundobatista

___
Python tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue3556>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2756] urllib2 add_header fails with existing unredirected_header

[Facundo Batista]

Facundo Batista <[EMAIL PROTECTED]> added the comment:

What I think is that the AbstractHTTPHandler is grabbing the headers, in
the do_open() method, in an incorrect way.

Check the get_header() method from Request:

def get_header(self, header_name, default=None):
return self.headers.get(
header_name,
self.unredirected_hdrs.get(header_name, default))

What it's doing there is to grab the header from self.header, and if not
there use the one in self.unredirected_hdrs, and if not there return the
default.

So, to emulate this behaviour, in do_open() I just grabbed first the
unredirected headers, and then updated it with the normal ones.

See my simple patch I attach here, which solves the issue, and passes
all the tests also.

Added file: http://bugs.python.org/file11126/issue2756-facundo.diff

___
Python tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue2756>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2776] urllib2.urlopen() gets confused with path with // in it

[Facundo Batista]

Changes by Facundo Batista <[EMAIL PROTECTED]>:


--
resolution:  -> fixed
status: open -> closed

___
Python tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue2776>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2776] urllib2.urlopen() gets confused with path with // in it

[Facundo Batista]

Facundo Batista <[EMAIL PROTECTED]> added the comment:

Commited in revs 65710 and 65711.

Thank you all!!

___
Python tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue2776>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue600362] relocate cgi.parse_qs() into urlparse

[Facundo Batista]

Facundo Batista <[EMAIL PROTECTED]> added the comment:

This is ok, maybe with some small changes in the docs.

I asked in python-dev if this should go now or wait until 2.7/3.1

___
Python tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue600362>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1432] Strange behavior of urlparse.urljoin

[Facundo Batista]

Facundo Batista <[EMAIL PROTECTED]> added the comment:

Commited in revs 65679 and 65680.

Thank you all!!

--
resolution:  -> fixed
status: open -> closed

___
Python tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1432>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1432] Strange behavior of urlparse.urljoin

[Facundo Batista]

Facundo Batista <[EMAIL PROTECTED]> added the comment:

Senthil: We should ask for advice in the web-sig list to see if this is
enough a "bug to be fixed" now that we're in beta for the releases.

Thanks!

___
Python tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1432>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2275] urllib2 header capitalization

[Facundo Batista]

Facundo Batista <[EMAIL PROTECTED]> added the comment:

I'm ok with these patchs, Senthil.

John, what do you think about this?

___
Python tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue2275>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3455] os.remove()method document error

[Facundo Batista]

Facundo Batista <[EMAIL PROTECTED]> added the comment:

zkfarmer, please try the following from your IDLE:

>>> myfilename = r"c:\tmp\test.txt"
>>> fh = open(myfilename, "w")
>>> fh.write("test\n")
>>> fh.close()
>>> fh = open(myfilename)
>>> import os
>>> os.remove(myfilename)

Traceback (most recent call last):
  File "", line 1, in 
os.remove(myfilename)
WindowsError: [Error 32] The process cannot access the file because it
is being used by another process: 'c:\\tmp\\test.txt'
>>> 

...and copy here what happened.

Thanks!

--
nosy: +facundobatista

___
Python tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue3455>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3451] Asymptotically faster divmod and str(long)

[Facundo Batista]

Changes by Facundo Batista <[EMAIL PROTECTED]>:


--
nosy: +marketdickinson

___
Python tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue3451>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3449] Update decimal module to version 1.68 of the IBM specification

[Facundo Batista]

Facundo Batista <[EMAIL PROTECTED]> added the comment:

The patch looks great, feel free to apply it and commit.

For the record: the name issue that Mark talked about is not in this
last change, it was before, and we handled it the way we now decide
(hey, at least we're coherent with ourselves, ;) ).

Thank you Mark!

___
Python tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue3449>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3449] Update decimal module to version 1.68 of the IBM specification

[Facundo Batista]

Facundo Batista <[EMAIL PROTECTED]> added the comment:

-0 to rename it, specially considering that we had a reduce builtin in
our history... better to not confuse it. But we'd need to convert the
name in the tests...

___
Python tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue3449>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2417] [py3k] Integer floor division (//): small int check omitted

[Facundo Batista]

Facundo Batista <[EMAIL PROTECTED]> added the comment:

Commited in r65220.

Thank you everybody!!

--
resolution:  -> fixed
status: open -> closed

___
Python tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue2417>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2417] [py3k] Integer floor division (//): small int check omitted

[Facundo Batista]

Facundo Batista <[EMAIL PROTECTED]> added the comment:

Alexander, tried the issue2417a.diff patch against 65210, and does not
apply cleanly, could you please submit an updated one?

Thanks!

___
Python tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue2417>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3396] rlcompleter can't autocomplete members of callable objects

[Facundo Batista]

Facundo Batista <[EMAIL PROTECTED]> added the comment:

Ah, sorry, missed that point.

Ok, I included this change and now it works ok.

Also worked a little that code (change the name of the variable
"object", used extend() for a list instead of adding to itself, and
removed a comparison from a loop).

Commited in r65168.

--
resolution:  -> fixed
status: open -> closed

___
Python tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue3396>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3396] rlcompleter can't autocomplete members of callable objects

[Facundo Batista]

Facundo Batista <[EMAIL PROTECTED]> added the comment:

I don't understand.

I tried the following:

Python 2.6b2+ (trunk:65167M, Jul 21 2008, 09:51:48) 
[GCC 4.1.3 20070929 (prerelease) (Ubuntu 4.1.2-16ubuntu2)] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> import rlcompleter
>>> import readline
>>> readline.parse_and_bind("tab: complete")

Then I wrote "int". Then I pressed TAB. Nothing happened. I pressed TAB
again, and the following appeared:

>>> int
int( intern(  

To me this is the expected behaviour: if the system has two alternatives
(in this case it does not if it should follow with "(" or "e"), don't
continue with the first tab, and then show all the options with the
second tab (I'm used to this in bash).

Is this wrong according to you?

___
Python tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue3396>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3418] heavy resource usage with string functions

[Facundo Batista]

Facundo Batista <[EMAIL PROTECTED]> added the comment:

The issue is that you're creating a string of 2GB. It's expectable that
it'll use a lot of resources.

Test this, for example: 

>>> a = "." * 2147483647

--
nosy: +facundobatista
resolution:  -> invalid
status: open -> closed

___
Python tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue3418>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3338] cPickle segfault with deep recursion

[Facundo Batista]

Facundo Batista <[EMAIL PROTECTED]> added the comment:

Confirmed in... 

Python 2.6b1+ (trunk:65017M, Jul 16 2008, 13:37:00) 
[GCC 4.1.3 20070929 (prerelease) (Ubuntu 4.1.2-16ubuntu2)] on linux2

...with a more simple case:

"""
import sys, cPickle
sys.setrecursionlimit(10405) 

class rec(object):
child = None
def __init__(self, counter):
  if counter > 0:
self.child = rec(counter-1)

mychain = rec(2600)
cPickle.dumps(mychain)
"""

Note that if we put the recursion limit in 10405 we get a segfault, but
if we put it 10404, we get a "RuntimeError: maximum recursion depth
exceeded". 

Considering that 10400 is exactly 2600 * 4, maybe this is a useful hint.

Another behaviour I got: With a recursion limit big big enough, doing
rec(1670) works ok, and rec(1671) segfaults.

And a very nasty one:

I put rec(1671) to see in which recursion limit we have the conversion
of RecursionLimit to SegFault. Testing, I tried with recursion limit in
6700, and sometimes it worked ok, and sometimes it segfaulted. Yes,
*sometimes*, :(

--
nosy: +facundobatista

___
Python tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue3338>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2702] pickling of large recursive structures crashes cPickle

[Facundo Batista]

Facundo Batista <[EMAIL PROTECTED]> added the comment:

Thanks Darryl.

We'll continue in that issue, as the patched commited in this one did
not introduce a regression (it just didn't fix the other bug also).

___
Python tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue2702>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3380] documentation for ElementTree is unusable

[Facundo Batista]

Facundo Batista <[EMAIL PROTECTED]> added the comment:

Here's the link:
http://docs.python.org/dev/library/xml.etree.elementtree.html#the-element-interface

--
nosy: +facundobatista
resolution:  -> out of date
status: open -> closed

___
Python tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue3380>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2674] unittest.TestProgram uses sys.exit()

[Facundo Batista]

Facundo Batista <[EMAIL PROTECTED]> added the comment:

That class is normally used at the end of the testing suite, as is
recommended in the documentation.

In any case, I don't see that like a bug, so we shouldn't be changing
that behaviour, because of compatibility.

What do you think? Maybe the documentation should be more explicit about
this? Thanks!

--
nosy: +facundobatista

___
Python tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue2674>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3159] glob.py improvements

[Facundo Batista]

Facundo Batista <[EMAIL PROTECTED]> added the comment:

If readability is enhanced is questionable, but is rejected on the basis
that cosmetic-only changes are not generally recommended: only
difficults following the code evolution in the repository.

The only change that I see regarding performance is the one involving
startswith, and it's actually wrong:

[EMAIL PROTECTED]:~$ timeit.py -s "s='qwerty'" "s[0]=='q';s[0]=='x'"
100 loops, best of 3: 0.338 usec per loop
[EMAIL PROTECTED]:~$ timeit.py -s "s='qwerty'"
"s.startswith('q');s.startswith('x')"
100 loops, best of 3: 0.854 usec per loop

Thanks anyway!

--
nosy: +facundobatista
resolution:  -> rejected
status: open -> closed

___
Python tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue3159>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com