[issue40065] py39: remove deprecation note for xml.etree.cElementTree

2020-06-20 Thread Ido Michael


Ido Michael  added the comment:

Thanks Tal.

Yes, I also got the impression we want to clean this, sorry Christian.

Please let me know how to follow up on this.

--

___
Python tracker 
<https://bugs.python.org/issue40065>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue19670] SimpleCookie Generates Non-RFC6265-Compliant Cookies

2020-06-20 Thread Ido Michael


Ido Michael  added the comment:

Opened a PR:
GH-21017

The documentation in the internal functions was helpful.
Should I also add it once decided on the format in here? 
Doc/library/http.cookies.rst:55

--

___
Python tracker 
<https://bugs.python.org/issue19670>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue19670] SimpleCookie Generates Non-RFC6265-Compliant Cookies

2020-06-20 Thread Ido Michael


Change by Ido Michael :


--
keywords: +patch
pull_requests: +20191
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/21017

___
Python tracker 
<https://bugs.python.org/issue19670>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue33689] Blank lines in .pth file cause a duplicate sys.path entry

2020-06-06 Thread Ido Michael


Ido Michael  added the comment:

Created a PR: GH-20679 

I did see some of the changes are already in the code for example, 
test_underpth_nosite_file.test_sity.py already had pth_lines filter out: ''.

I think it's because this issue relevant only for 3.6?
Or maybe this issue was solved already and this bug report is redundant

--

___
Python tracker 
<https://bugs.python.org/issue33689>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue33689] Blank lines in .pth file cause a duplicate sys.path entry

2020-06-06 Thread Ido Michael


Change by Ido Michael :


--
keywords: +patch
pull_requests: +19893
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/20679

___
Python tracker 
<https://bugs.python.org/issue33689>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue40065] py39: remove deprecation note for xml.etree.cElementTree

2020-06-06 Thread Ido Michael


Ido Michael  added the comment:

Tal, is there a decision to this debate or can I just move the dep. warning?

--
nosy: +Ido Michael, taleinat

___
Python tracker 
<https://bugs.python.org/issue40065>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue40594] urljoin since 3.5 incorrectly filters out double slashes

2020-06-06 Thread Ido Michael


Ido Michael  added the comment:

I can take this

--
nosy: +Ido Michael, taleinat

___
Python tracker 
<https://bugs.python.org/issue40594>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue33689] Blank lines in .pth file cause a duplicate sys.path entry

2020-06-06 Thread Ido Michael


Change by Ido Michael :


--
nosy: +taleinat

___
Python tracker 
<https://bugs.python.org/issue33689>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue19670] SimpleCookie Generates Non-RFC6265-Compliant Cookies

2020-06-05 Thread Ido Michael


Ido Michael  added the comment:

I think it can be closed?

--
nosy: +Ido Michael

___
Python tracker 
<https://bugs.python.org/issue19670>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue19670] SimpleCookie Generates Non-RFC6265-Compliant Cookies

2020-06-05 Thread Ido Michael


Change by Ido Michael :


--
nosy: +taleinat

___
Python tracker 
<https://bugs.python.org/issue19670>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue40673] urllib.request.URLopener raises different exceptions based on implementation detail

2020-05-25 Thread Ido Michael


Ido Michael  added the comment:

Does it includes the FancyURLopener? This class is derived from URLopener.

Also what needs to be done?
Remove the URLopener, URLopener_Tests and DummyURLopeners ?

--
nosy: +Ido Michael

___
Python tracker 
<https://bugs.python.org/issue40673>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue40736] better message for re.search TypeError ("expected string or bytes-like object")

2020-05-25 Thread Ido Michael


Ido Michael  added the comment:

I agree it should be more informative and have the same standard as the rest of 
the Errors messages.

Can I start a PR?

--
nosy: +Ido Michael

___
Python tracker 
<https://bugs.python.org/issue40736>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue10572] Move test sub-packages to Lib/test

2020-05-25 Thread Ido Michael


Change by Ido Michael :


--
nosy:  -Ido Michael

___
Python tracker 
<https://bugs.python.org/issue10572>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue40373] urlunparse does not escape slash (/) for http+unix:// in netloc field

2020-05-24 Thread Ido Michael


Change by Ido Michael :


--
nosy: +taleinat

___
Python tracker 
<https://bugs.python.org/issue40373>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue40373] urlunparse does not escape slash (/) for http+unix:// in netloc field

2020-05-24 Thread Ido Michael


Ido Michael  added the comment:

Did you try using the urllib.urlencode() function? 
Also it's not clear to me what happens if you give the expected string to 
urlunsplit() ? I believe it will keep the format as is, str or URL encoded.

Tal what do you think?

--
nosy: +Ido Michael

___
Python tracker 
<https://bugs.python.org/issue40373>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue38580] select()'s documentation claims only sequences are accepted, but it allows all iterables

2020-05-24 Thread Ido Michael


Ido Michael  added the comment:

Hey Tal, I see this issue is pending and pretty much done, what else there's to 
fix here?

--
nosy: +Ido Michael

___
Python tracker 
<https://bugs.python.org/issue38580>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue39244] multiprocessing.get_all_start_methods() wrong default on macOS

2020-05-24 Thread Ido Michael


Ido Michael  added the comment:

Fixed Tal's comments, I took the darwin if check out of the 
reduction.HAVE_SEND_HANDLE, also fixed the test

--

___
Python tracker 
<https://bugs.python.org/issue39244>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23082] pathlib relative_to() can give confusing error message

2020-05-24 Thread Ido Michael


Ido Michael  added the comment:

Hey looks like this PR is good to go?

--
nosy: +Ido Michael

___
Python tracker 
<https://bugs.python.org/issue23082>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue39725] unrelated `from None` exceptions hide prior exception information

2020-03-30 Thread Ido Michael


Change by Ido Michael :


--
nosy:  -Ido Michael

___
Python tracker 
<https://bugs.python.org/issue39725>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35885] configparser: indentation

2020-03-30 Thread Ido Michael


Ido Michael  added the comment:

ping

--

___
Python tracker 
<https://bugs.python.org/issue35885>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue10572] Move test sub-packages to Lib/test

2020-03-22 Thread Ido Michael


Ido Michael  added the comment:

GH-18727

Only tkinter module for start.

--

___
Python tracker 
<https://bugs.python.org/issue10572>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35885] configparser: indentation

2020-03-22 Thread Ido Michael


Ido Michael  added the comment:

@SilentGhost Added documentation to the module and a test for a give space 
indent in the module test.

--

___
Python tracker 
<https://bugs.python.org/issue35885>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15436] __sizeof__ is not documented

2020-03-22 Thread Ido Michael


Change by Ido Michael :


--
nosy:  -Ido Michael

___
Python tracker 
<https://bugs.python.org/issue15436>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue38856] asyncio ProactorEventLoop: wait_closed() can raise ConnectionResetError

2020-03-22 Thread Ido Michael


Change by Ido Michael :


--
nosy:  -Ido Michael

___
Python tracker 
<https://bugs.python.org/issue38856>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue39107] Upgrade tcl/tk to 8.6.10 (Windows and maxOS)

2020-03-22 Thread Ido Michael


Change by Ido Michael :


--
nosy:  -Ido Michael

___
Python tracker 
<https://bugs.python.org/issue39107>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue10572] Move test sub-packages to Lib/test

2020-03-16 Thread Ido Michael


Ido Michael  added the comment:

Hey Eric,

I'm not sure what you mean, you don't recommend the change in general?
Or you just don't recommend Git for this and saying I should use Mercurial 
instead?

--

___
Python tracker 
<https://bugs.python.org/issue10572>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue38856] asyncio ProactorEventLoop: wait_closed() can raise ConnectionResetError

2020-03-15 Thread Ido Michael


Ido Michael  added the comment:

Is this open for a PR?

--
nosy: +Ido Michael

___
Python tracker 
<https://bugs.python.org/issue38856>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue39725] unrelated `from None` exceptions lose prior exception information

2020-03-15 Thread Ido Michael


Ido Michael  added the comment:

Can I take this change into a PR?
Or is it still in the process?

--
nosy: +Ido Michael

___
Python tracker 
<https://bugs.python.org/issue39725>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue39955] argparse print_help breaks when help is blank space

2020-03-15 Thread Ido Michael


Ido Michael  added the comment:

Looks like both the original and this are still issues.
Can I take this?

--
nosy: +Ido Michael

___
Python tracker 
<https://bugs.python.org/issue39955>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue39107] Upgrade tcl/tk to 8.6.10 (Windows and maxOS)

2020-03-15 Thread Ido Michael


Ido Michael  added the comment:

I can take this for Mac V 10.14.6 if there was a decision?

--
nosy: +Ido Michael

___
Python tracker 
<https://bugs.python.org/issue39107>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue33689] Blank lines in .pth file cause a duplicate sys.path entry

2020-03-15 Thread Ido Michael


Ido Michael  added the comment:

I can take this and have a PR

--
nosy: +Ido Michael

___
Python tracker 
<https://bugs.python.org/issue33689>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue10572] Move test sub-packages to Lib/test

2020-03-15 Thread Ido Michael


Ido Michael  added the comment:

+ Distutils is last priority

--

___
Python tracker 
<https://bugs.python.org/issue10572>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue10572] Move test sub-packages to Lib/test

2020-03-15 Thread Ido Michael


Ido Michael  added the comment:

Before I put more time into that, here's the strategy here:

1. Module by module migration.
2. By this order
 tkinter/test
  distutils/tests
  ctypes/tests
  lib2to3/tests
  unittest/test

*  sqlite3/test - excluded because needs more work.

Please let me know if there is a different order or more exclusions?

--

___
Python tracker 
<https://bugs.python.org/issue10572>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue10572] Move test sub-packages to Lib/test

2020-03-01 Thread Ido Michael


Ido Michael  added the comment:

I've created a clean PR - will do it in 2 rounds:
This PR GH-18727, contains the modified test of ctypes, sqlite3 and tkinter 
modules. Once that's approved I'll deal with the other remaining 3.

--

___
Python tracker 
<https://bugs.python.org/issue10572>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue10572] Move test sub-packages to Lib/test

2020-03-01 Thread Ido Michael


Change by Ido Michael :


--
pull_requests: +18084
pull_request: https://github.com/python/cpython/pull/18727

___
Python tracker 
<https://bugs.python.org/issue10572>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue38691] importlib: PYTHONCASEOK should be ignored when using python3 -E

2020-03-01 Thread Ido Michael


Ido Michael  added the comment:

@vstinner ready for review.

--

___
Python tracker 
<https://bugs.python.org/issue38691>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue39753] inspecting a partial with bound keywods gives incorrect signature

2020-03-01 Thread Ido Michael


Ido Michael  added the comment:

Is it a bug? I can add the signature and set a PR

--
nosy: +Ido Michael

___
Python tracker 
<https://bugs.python.org/issue39753>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue39814] Hyphens not generated for split-words in a "note" directive

2020-03-01 Thread Ido Michael


Ido Michael  added the comment:

Looks like a bug in the dev repo? What's the class responsible for rendering 
the notes?

I can take this

--
nosy: +Ido Michael

___
Python tracker 
<https://bugs.python.org/issue39814>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue37970] urllib.parse docstrings incomplete

2020-02-23 Thread Ido Michael


Ido Michael  added the comment:

Created PR, most of the documentation besides the func signature looked 
alright: GH-18631

--

___
Python tracker 
<https://bugs.python.org/issue37970>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue37970] urllib.parse docstrings incomplete

2020-02-23 Thread Ido Michael


Change by Ido Michael :


--
pull_requests: +17997
pull_request: https://github.com/python/cpython/pull/18631

___
Python tracker 
<https://bugs.python.org/issue37970>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue38691] importlib: PYTHONCASEOK should be ignored when using python3 -E

2020-02-23 Thread Ido Michael


Ido Michael  added the comment:

Added a new clean PR with the code changes, will let you know once the tests 
are fixed: GH-18627

--

___
Python tracker 
<https://bugs.python.org/issue38691>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue38691] importlib: PYTHONCASEOK should be ignored when using python3 -E

2020-02-23 Thread Ido Michael


Change by Ido Michael :


--
pull_requests: +17991
pull_request: https://github.com/python/cpython/pull/18627

___
Python tracker 
<https://bugs.python.org/issue38691>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue39244] multiprocessing.get_all_start_methods() wrong default on macOS

2020-02-23 Thread Ido Michael


Ido Michael  added the comment:

Created a new clean PR GH-18625

--

___
Python tracker 
<https://bugs.python.org/issue39244>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue39244] multiprocessing.get_all_start_methods() wrong default on macOS

2020-02-23 Thread Ido Michael


Change by Ido Michael :


--
pull_requests: +17990
pull_request: https://github.com/python/cpython/pull/18625

___
Python tracker 
<https://bugs.python.org/issue39244>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue39128] Document happy eyeball parameters in loop.create_connection signature docs

2020-02-23 Thread Ido Michael


Ido Michael  added the comment:

Created new PR and removed the old one GH-18624

--

___
Python tracker 
<https://bugs.python.org/issue39128>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue39128] Document happy eyeball parameters in loop.create_connection signature docs

2020-02-23 Thread Ido Michael


Change by Ido Michael :


--
pull_requests: +17989
pull_request: https://github.com/python/cpython/pull/18624

___
Python tracker 
<https://bugs.python.org/issue39128>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35885] configparser: indentation

2020-02-23 Thread Ido Michael


Ido Michael  added the comment:

New PR: GH-18623

--

___
Python tracker 
<https://bugs.python.org/issue35885>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35885] configparser: indentation

2020-02-23 Thread Ido Michael


Change by Ido Michael :


--
pull_requests: +17988
pull_request: https://github.com/python/cpython/pull/18623

___
Python tracker 
<https://bugs.python.org/issue35885>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35885] configparser: indentation

2020-02-23 Thread Ido Michael


Change by Ido Michael :


--
pull_requests: +17986
pull_request: https://github.com/python/cpython/pull/18621

___
Python tracker 
<https://bugs.python.org/issue35885>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35885] configparser: indentation

2020-02-23 Thread Ido Michael


Change by Ido Michael :


--
pull_requests: +17985
pull_request: https://github.com/python/cpython/pull/18620

___
Python tracker 
<https://bugs.python.org/issue35885>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue38691] importlib: PYTHONCASEOK should be ignored when using python3 -E

2020-02-22 Thread Ido Michael


Change by Ido Michael :


--
pull_requests: +17977
pull_request: https://github.com/python/cpython/pull/18612

___
Python tracker 
<https://bugs.python.org/issue38691>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue38035] shared_semaphores cannot be shared across unrelated processes

2020-02-22 Thread Ido Michael


Ido Michael  added the comment:

@taleinat what do you think?

--
nosy: +taleinat

___
Python tracker 
<https://bugs.python.org/issue38035>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue38691] importlib: PYTHONCASEOK should be ignored when using python3 -E

2020-02-18 Thread Ido Michael


Ido Michael  added the comment:

Yes I saw those in the morning, thanks for patching it up. I will debug this 
over the weekend and will update.

--

___
Python tracker 
<https://bugs.python.org/issue38691>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue39244] multiprocessing.get_all_start_methods() wrong default on macOS

2020-02-16 Thread Ido Michael


Ido Michael  added the comment:

Fixed the bug to default any macos into 'spawn'
PR: GH-18529

--
nosy: +Ido Michael

___
Python tracker 
<https://bugs.python.org/issue39244>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue39244] multiprocessing.get_all_start_methods() wrong default on macOS

2020-02-16 Thread Ido Michael


Change by Ido Michael :


--
keywords: +patch
pull_requests: +17905
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/18529

___
Python tracker 
<https://bugs.python.org/issue39244>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue37970] urllib.parse docstrings incomplete

2020-02-16 Thread Ido Michael


Ido Michael  added the comment:

Tal, I can also fix that so we can close this issue.
Are you talking about the Doc/library/urllib.parse.rst file?

--

___
Python tracker 
<https://bugs.python.org/issue37970>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue10572] Move test sub-packages to Lib/test

2020-02-16 Thread Ido Michael


Ido Michael  added the comment:

Moved all 6 modules tests under Lib/test/MODULE_NAME_test
Created this PR: GH-18524

--

___
Python tracker 
<https://bugs.python.org/issue10572>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue10572] Move test sub-packages to Lib/test

2020-02-16 Thread Ido Michael


Change by Ido Michael :


--
pull_requests: +17901
pull_request: https://github.com/python/cpython/pull/18524

___
Python tracker 
<https://bugs.python.org/issue10572>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue39128] Document happy eyeball parameters in loop.create_connection signature docs

2020-02-16 Thread Ido Michael


Ido Michael  added the comment:

Created 2nd PR with the Algorithm documentation:
GH-18523

--

___
Python tracker 
<https://bugs.python.org/issue39128>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue39128] Document happy eyeball parameters in loop.create_connection signature docs

2020-02-16 Thread Ido Michael


Change by Ido Michael :


--
pull_requests: +17900
pull_request: https://github.com/python/cpython/pull/18523

___
Python tracker 
<https://bugs.python.org/issue39128>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35885] configparser: indentation

2020-02-16 Thread Ido Michael


Ido Michael  added the comment:

Created PR GH-18522

--

___
Python tracker 
<https://bugs.python.org/issue35885>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35885] configparser: indentation

2020-02-16 Thread Ido Michael


Change by Ido Michael :


--
keywords: +patch
pull_requests: +17899
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/18522

___
Python tracker 
<https://bugs.python.org/issue35885>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue27873] multiprocessing.pool.Pool.map should take more than one iterable

2020-02-16 Thread Ido Michael


Ido Michael  added the comment:

Can this issue be closed, I see it was merged successfully?

--

___
Python tracker 
<https://bugs.python.org/issue27873>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue37970] urllib.parse docstrings incomplete

2020-02-10 Thread Ido Michael


Ido Michael  added the comment:

Hey Senthil,
Yes the PEP guides was fixed a while ago, also the new comment of adding the 
same change for the second function were taken care of.

--

___
Python tracker 
<https://bugs.python.org/issue37970>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue37970] urllib.parse docstrings incomplete

2020-02-10 Thread Ido Michael


Ido Michael  added the comment:

Any update on this? Adding @Tal Einat on the PR

--

___
Python tracker 
<https://bugs.python.org/issue37970>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue39128] Document happy eyeball parameters in loop.create_connection signature docs

2020-02-10 Thread Ido Michael


Ido Michael  added the comment:

Thanks Julien, I forgot about this part, will create a new PR.

I thought referencing the abstract of the algorithm + a link to the IETF RFC:

  Happy Eyeballs: Success with Dual-Stack Hosts
   When a server's IPv4 path and protocol are working, but the server's
   IPv6 path and protocol are not working, a dual-stack client
   application experiences significant connection delay compared to an
   IPv4-only client.  This is undesirable because it causes the dual-
   stack client to have a worse user experience.  This document
   specifies requirements for algorithms that reduce this user-visible
   delay and provides an algorithm.

https://tools.ietf.org/html/rfc6555

--

___
Python tracker 
<https://bugs.python.org/issue39128>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue10572] Move test sub-packages to Lib/test

2020-02-04 Thread Ido Michael


Ido Michael  added the comment:

Thanks Brett,

I'll check this out over the week.
Let's take this module for instance: Lib/distutils.

I looked on this one test file by now, it looks decoupled (test_bdist.py), 

1.What to look for
2.Once decided it's not the right path, just migrate to Lib/tests/"module" and 
make sure it runs fine?

--

___
Python tracker 
<https://bugs.python.org/issue10572>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35885] configparser: indentation

2020-02-02 Thread Ido Michael


Ido Michael  added the comment:

Can I take this?
What needs to be done? adding an indent flag and if it's passed indent the keys?

--
nosy: +Ido Michael

___
Python tracker 
<https://bugs.python.org/issue35885>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue38101] Update devguide triaging keywords

2020-02-02 Thread Ido Michael


Ido Michael  added the comment:

It treats the PR as a cpython while it's on the devguide repo, here is the link:
https://github.com/python/devguide/pull/570

--

___
Python tracker 
<https://bugs.python.org/issue38101>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue38101] Update devguide triaging keywords

2020-02-02 Thread Ido Michael


Ido Michael  added the comment:

Added a PR: GH-570

--

___
Python tracker 
<https://bugs.python.org/issue38101>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue39128] Document happy eyeball parameters in loop.create_connection signature docs

2020-02-02 Thread Ido Michael


Ido Michael  added the comment:

Created PR added arguments to method signature in doc.
GH-18315

--
nosy: +Ido Michael

___
Python tracker 
<https://bugs.python.org/issue39128>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue39128] Document happy eyeball parameters in loop.create_connection signature docs

2020-02-02 Thread Ido Michael


Change by Ido Michael :


--
keywords: +patch
pull_requests: +17691
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/18315

___
Python tracker 
<https://bugs.python.org/issue39128>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue10572] Move test sub-packages to Lib/test

2020-02-02 Thread Ido Michael


Ido Michael  added the comment:

Are there any conclusions? what needs to be done?

--
nosy: +Ido Michael

___
Python tracker 
<https://bugs.python.org/issue10572>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue38691] [easy] importlib: PYTHONCASEOK should be ignored when using python3 -E

2020-02-02 Thread Ido Michael


Ido Michael  added the comment:

Created this PR: GH-18314

--
nosy: +Ido Michael

___
Python tracker 
<https://bugs.python.org/issue38691>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue38691] [easy] importlib: PYTHONCASEOK should be ignored when using python3 -E

2020-02-02 Thread Ido Michael


Change by Ido Michael :


--
keywords: +patch
pull_requests: +17690
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/18314

___
Python tracker 
<https://bugs.python.org/issue38691>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue39274] Conversion from fractions.Fraction to bool

2020-02-02 Thread Ido Michael


Ido Michael  added the comment:

Hi all,

I think this issue can be closed right?
Saw a successful PR.

--
nosy: +Ido Michael

___
Python tracker 
<https://bugs.python.org/issue39274>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue37404] asyncio sock_recv blocks on ssl sockets.

2020-02-02 Thread Ido Michael


Ido Michael  added the comment:

Sorry it broke the version, what could I have done to avoid this?
Also can we close this issue?

--

___
Python tracker 
<https://bugs.python.org/issue37404>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34344] Fix the docstring for AbstractEventLoopPolicy.get_event_loop

2019-12-01 Thread Ido Michael


Ido Michael  added the comment:

@yselivanov

Can we close this?

--

___
Python tracker 
<https://bugs.python.org/issue34344>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue37883] threading.Lock.locked is not documented

2019-12-01 Thread Ido Michael


Ido Michael  added the comment:

Hey Tal, created a new PR: GH-17427
Also fixed the signed CLA issue

--

___
Python tracker 
<https://bugs.python.org/issue37883>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue37883] threading.Lock.locked is not documented

2019-12-01 Thread Ido Michael


Change by Ido Michael :


--
pull_requests: +16906
pull_request: https://github.com/python/cpython/pull/17427

___
Python tracker 
<https://bugs.python.org/issue37883>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue37883] threading.Lock.locked is not documented

2019-11-27 Thread Ido Michael


Ido Michael  added the comment:

Thanks, Tal, I think this one can be closed, I don't think I have permissions 
to close it

--

___
Python tracker 
<https://bugs.python.org/issue37883>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue38351] Modernize email example from %-formatting to f-string

2019-10-09 Thread Ido Michael


Ido Michael  added the comment:

So what was decided?

I can fix this issue and I can wait for a final conclusion as it wasn't clear 
from the thread.

--
nosy: +Ido Michael

___
Python tracker 
<https://bugs.python.org/issue38351>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34344] Fix the docstring for AbstractEventLoopPolicy.get_event_loop

2019-09-28 Thread Ido Michael


Ido Michael  added the comment:

I've fixed the documentation according to the thread.

Here's the PR: GH-16463

Ido

--
nosy: +Ido Michael

___
Python tracker 
<https://bugs.python.org/issue34344>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34344] Fix the docstring for AbstractEventLoopPolicy.get_event_loop

2019-09-28 Thread Ido Michael


Change by Ido Michael :


--
keywords: +patch
pull_requests: +16048
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/16463

___
Python tracker 
<https://bugs.python.org/issue34344>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue38035] shared_semaphores cannot be shared across unrelated processes

2019-09-28 Thread Ido Michael


Ido Michael  added the comment:

@ned.deily any thoughts?

I can start working on it.

Ido

--
nosy: +Ido Michael

___
Python tracker 
<https://bugs.python.org/issue38035>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue37970] urllib.parse docstrings incomplete

2019-09-28 Thread Ido Michael


Ido Michael  added the comment:

Committed a PR: GH-16458

I've read all of the thread and changed the docstring to the latest suggestion 
by @zach.ware

Ido

--
nosy: +Ido Michael

___
Python tracker 
<https://bugs.python.org/issue37970>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue37970] urllib.parse docstrings incomplete

2019-09-28 Thread Ido Michael


Change by Ido Michael :


--
keywords: +patch
pull_requests: +16039
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/16458

___
Python tracker 
<https://bugs.python.org/issue37970>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue37404] asyncio sock_recv blocks on ssl sockets.

2019-09-28 Thread Ido Michael


Ido Michael  added the comment:

Fixed this issue since the CLA of the past user wasn't signed.

Added a check for the socket type in each of the methods: 
sock_recv, sock_recv_into, sock_sendall, sock_connect, sock_accept.

PR: GH-16457

--
nosy: +Ido Michael

___
Python tracker 
<https://bugs.python.org/issue37404>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue37404] asyncio sock_recv blocks on ssl sockets.

2019-09-28 Thread Ido Michael


Change by Ido Michael :


--
pull_requests: +16037
pull_request: https://github.com/python/cpython/pull/16457

___
Python tracker 
<https://bugs.python.org/issue37404>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue37883] threading.Lock.locked is not documented

2019-09-27 Thread Ido Michael


Change by Ido Michael :


--
keywords: +patch
pull_requests: +16017
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/16420

___
Python tracker 
<https://bugs.python.org/issue37883>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue37883] threading.Lock.locked is not documented

2019-09-26 Thread Ido Michael


Ido Michael  added the comment:

P.S PR: https://github.com/python/cpython/pull/16420

--

___
Python tracker 
<https://bugs.python.org/issue37883>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue37883] threading.Lock.locked is not documented

2019-09-26 Thread Ido Michael


Ido Michael  added the comment:

Hey Remi,

I've fixed it and created PR on the issue.

Ido

--
nosy: +Ido Michael

___
Python tracker 
<https://bugs.python.org/issue37883>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue38101] Update devguide triaging keywords

2019-09-22 Thread Ido Michael


Ido Michael  added the comment:

Thanks Karthikeyan!

Found it, so for the last one pep3121, would you like to describe PEP in 
general or Extension Module Initialization and Finalization?

Ido

--

___
Python tracker 
<https://bugs.python.org/issue38101>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15436] __sizeof__ is not documented

2019-09-22 Thread Ido Michael


Ido Michael  added the comment:

I can add those changes if someone didn't take it already?

Ido

--
nosy: +Ido Michael

___
Python tracker 
<https://bugs.python.org/issue15436>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue27873] multiprocessing.pool.Pool.map should take more than one iterable

2019-09-22 Thread Ido Michael


Ido Michael  added the comment:

Hey,

Is it still open?
What else needs to be done?

Ido

--
nosy: +Ido Michael

___
Python tracker 
<https://bugs.python.org/issue27873>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue36947] [Good first issue] Fix 3.3.3.1 Metaclasses Documentation

2019-09-22 Thread Ido Michael


Ido Michael  added the comment:

Hey,

Is someone working on this issue? 
Can I take it?

Ido

--
nosy: +Ido Michael

___
Python tracker 
<https://bugs.python.org/issue36947>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue38101] Update devguide triaging keywords

2019-09-22 Thread Ido Michael


Ido Michael  added the comment:

Hi Lisa,

I can take this (first commit), where can I edit the dev guide?

I could see someone did update the easy keyword in it?

Ido

--
nosy: +Ido Michael

___
Python tracker 
<https://bugs.python.org/issue38101>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com