[issue29308] venv should match virtualenv VIRTUAL_ENV_DISABLE_PROMPT config

2017-01-24 Thread Jack Bennett

Jack Bennett added the comment:

That works fine here.

Thank you

On 24 January 2017 at 13:15, Vinay Sajip <rep...@bugs.python.org> wrote:

>
> Vinay Sajip added the comment:
>
> Other scripts (activate, activate.csh, activate.csh) support this
> environment variable already. This patch updates Activate.ps1 to respect
> the variable - can you confirm if this change works for you?
>
> --
> assignee:  -> vinay.sajip
> keywords: +patch
> stage:  -> patch review
> Added file: http://bugs.python.org/file46407/fix-29308-01.diff
>
> ___
> Python tracker <rep...@bugs.python.org>
> <http://bugs.python.org/issue29308>
> ___
>

--

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue29308>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue29308] venv should match virtualenv VIRTUAL_ENV_DISABLE_PROMPT config

2017-01-18 Thread Jack Bennett

New submission from Jack Bennett:

virtualenv has 
https://virtualenv.pypa.io/en/latest/reference/#envvar-VIRTUAL_ENV_DISABLE_PROMPT
 to block activate from trying to overwrite the prompt function. 

Users of venv can't do that, 3.6 added prompt but even None defaults to the 
current folder name.

If I may suggest either respecting the virtualenv variable or perhaps 
prompt=False

Specifically we've ran into this in powershell while making cmder stricter on 
the prompt over here: https://github.com/cmderdev/cmder/issues/1207

Thanks, Jack

--
components: Library (Lib)
messages: 285729
nosy: Jack Bennett
priority: normal
severity: normal
status: open
title: venv should match virtualenv VIRTUAL_ENV_DISABLE_PROMPT config
type: behavior
versions: Python 3.6

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue29308>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com