[issue43292] xml.ElementTree iterparse filehandle left open
Change by Jacob Walls : -- keywords: +patch nosy: +jacobtylerwalls nosy_count: 4.0 -> 5.0 pull_requests: +29815 stage: -> patch review pull_request: https://github.com/python/cpython/pull/31696 ___ Python tracker <https://bugs.python.org/issue43292> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue25707] Add the close method for ElementTree.iterparse() object
Change by Jacob Walls : -- keywords: +patch nosy: +jacobtylerwalls nosy_count: 4.0 -> 5.0 pull_requests: +29816 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/31696 ___ Python tracker <https://bugs.python.org/issue25707> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue46798] xml.etree.ElementTree: get() doesn't return default value, always ATTLIST value
Jacob Walls added the comment: I agree not a bug. To ignore the document default you can set `specified_attributes` on the parser as documented: https://docs.python.org/3/library/pyexpat.html#xml.parsers.expat.xmlparser.specified_attributes Also, this was explicitly worked on recently in bpo-42151, so hard to imagine reversing course so soon. I suggest the issue be re-closed. -- nosy: +jacobtylerwalls ___ Python tracker <https://bugs.python.org/issue46798> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue45948] Unexpected instantiation behavior for xml.etree.ElementTree.XMLParser(target=None)
Change by Jacob Walls : -- pull_requests: +29458 pull_request: https://github.com/python/cpython/pull/31299 ___ Python tracker <https://bugs.python.org/issue45948> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue34191] argparse: Missing subparser error message should be more clear
Jacob Walls added the comment: Duplicate of issue29298 (fixed) -- nosy: +jacobtylerwalls ___ Python tracker <https://bugs.python.org/issue34191> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue45948] Unexpected instantiation behavior for xml.etree.ElementTree.XMLParser(target=None)
Change by Jacob Walls : -- keywords: +patch nosy: +jacobtylerwalls nosy_count: 1.0 -> 2.0 pull_requests: +29329 stage: -> patch review pull_request: https://github.com/python/cpython/pull/31152 ___ Python tracker <https://bugs.python.org/issue45948> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue38941] xml.etree.ElementTree.Element inconsistent warning for bool
Change by Jacob Walls : -- keywords: +patch nosy: +jacobtylerwalls nosy_count: 6.0 -> 7.0 pull_requests: +29326 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/31149 ___ Python tracker <https://bugs.python.org/issue38941> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue41259] Find adverbs is not correct on the documentation
Jacob Walls added the comment: Fixed in PR 21420, suggest closing as fixed. -- nosy: +jacobtylerwalls ___ Python tracker <https://bugs.python.org/issue41259> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue41255] Argparse.parse_args exits on unrecognized option with exit_on_error=False
Change by Jacob Walls : -- nosy: +jacobtylerwalls nosy_count: 6.0 -> 7.0 pull_requests: +29183 pull_request: https://github.com/python/cpython/pull/30832 ___ Python tracker <https://bugs.python.org/issue41255> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue46440] ArgumentParser.parse_args exits on missing required argument with exit_on_error=False
Change by Jacob Walls : -- keywords: +patch nosy: +jacobtylerwalls nosy_count: 1.0 -> 2.0 pull_requests: +29018 stage: -> patch review pull_request: https://github.com/python/cpython/pull/30832 ___ Python tracker <https://bugs.python.org/issue46440> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue32731] getpass.getuser() raises an unspecified exceptions (ImportError, OSError, etc)
Change by Jacob Walls : -- nosy: +jacobtylerwalls nosy_count: 4.0 -> 5.0 pull_requests: +27977 pull_request: https://github.com/python/cpython/pull/29739 ___ Python tracker <https://bugs.python.org/issue32731> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue31162] urllib.request.urlopen CERTIFICATE_VERIFY_FAILED error
Jacob Walls added the comment: Third voice chiming in to say not a bug, also. I think the last two messages inadvertently moved to pending and then back to open. I suggest closing. -- nosy: +jacobtylerwalls ___ Python tracker <https://bugs.python.org/issue31162> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20116] urlparse.parse_qs should take argument for query separator
Jacob Walls added the comment: Greetings. I believe this is mooted by #42967 as well as changes even prior to that. https://bugs.python.org/issue42967 -- nosy: +jacobtylerwalls ___ Python tracker <https://bugs.python.org/issue20116> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue44516] Update bundled pip to 21.1.3
New submission from Jacob Walls : Greetings, all. I take it this is fully resolved? -- nosy: +jacobtylerwalls ___ Python tracker <https://bugs.python.org/issue44516> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue44587] BooleanOptionalAction displays default=SUPPRESS unlike other action types
Change by Jacob Walls : -- components: +Library (Lib) type: -> behavior ___ Python tracker <https://bugs.python.org/issue44587> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue35277] Upgrade bundled pip/setuptools
Jacob Walls added the comment: Presumably this can be closed. -- nosy: +jacobtylerwalls ___ Python tracker <https://bugs.python.org/issue35277> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue43077] Update bundled pip to 21.0.1 and setuptools to 52.0.0
Jacob Walls added the comment: Presumably this can be closed. -- nosy: +jacobtylerwalls ___ Python tracker <https://bugs.python.org/issue43077> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue44455] compileall should exit nonzero for nonexistent directories
Change by Jacob Walls : -- components: +Library (Lib) type: -> behavior ___ Python tracker <https://bugs.python.org/issue44455> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue44242] enum.IntFlag regression: missing values cause TypeError
Jacob Walls added the comment: With the followup patch merged, can this be closed now? -- nosy: +jacobtylerwalls ___ Python tracker <https://bugs.python.org/issue44242> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue22234] urllib.parse.urlparse accepts any falsy value as an url
Jacob Walls added the comment: Well, now I've looked at the CPython test failure more closely, and it's in `test.test_venv.EnsurePipTest` where we just download latest pip. Their release cadence suggests a new release in July, about 2-4 weeks from now. So I'll wait on adding the DeprecationWarning for passing `None` unless folks ask for it during review, and am happy to wait a few weeks for green CI. -- ___ Python tracker <https://bugs.python.org/issue22234> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue22234] urllib.parse.urlparse accepts any falsy value as an url
Jacob Walls added the comment: Both this ticket and #19094 started from one method in urllib.parse and then generalized a proposal for the rest of the submodule to move away from duck-typing and to instead raise TypeErrors (or at least some error) for invalid types. The attached PR does that. But it broke pip, which was passing None to the `fragment` argument of `urlunsplit()`. In a blaze of efficiency, Pip already merged my fix, but since the CPython test suite depends on the current version of pip -- perhaps there's an argument for at least raising a deprecation warning for ``None`` and then converting to '' or b''? In any case, green CI makes patches more reviewable, so I'm inclined to add such a warning/conversion for now and then see how feedback goes. Cheers, all. BTW: perhaps we can close this as dupe of #19094? -- ___ Python tracker <https://bugs.python.org/issue22234> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue22334] test_tcl.test_split() fails on "x86 FreeBSD 7.2 3.x" buildbot
Change by Jacob Walls : -- nosy: -jacobtylerwalls ___ Python tracker <https://bugs.python.org/issue22334> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue22334] test_tcl.test_split() fails on "x86 FreeBSD 7.2 3.x" buildbot
Jacob Walls added the comment: Sorry for noise; I typo-d when linking a PR on GitHub. Unlinked. -- ___ Python tracker <https://bugs.python.org/issue22334> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue22334] test_tcl.test_split() fails on "x86 FreeBSD 7.2 3.x" buildbot
Change by Jacob Walls : -- pull_requests: -25293 ___ Python tracker <https://bugs.python.org/issue22334> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue22334] test_tcl.test_split() fails on "x86 FreeBSD 7.2 3.x" buildbot
Change by Jacob Walls : -- nosy: +jacobtylerwalls nosy_count: 5.0 -> 6.0 pull_requests: +25293 pull_request: https://github.com/python/cpython/pull/26687 ___ Python tracker <https://bugs.python.org/issue22334> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue22234] urllib.parse.urlparse accepts any falsy value as an url
Change by Jacob Walls : -- nosy: +jacobtylerwalls nosy_count: 7.0 -> 8.0 pull_requests: +25291 pull_request: https://github.com/python/cpython/pull/26687 ___ Python tracker <https://bugs.python.org/issue22234> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37880] For argparse add_argument with action='store_const', const should default to None.
Jacob Walls added the comment: Sounds reasonable to me. -- components: +Library (Lib) nosy: +jacobtylerwalls type: -> behavior versions: +Python 3.11 -Python 3.9 ___ Python tracker <https://bugs.python.org/issue37880> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19094] urljoin should raise a TypeError if URL is not a string
Change by Jacob Walls : -- pull_requests: +25276 pull_request: https://github.com/python/cpython/pull/26687 ___ Python tracker <https://bugs.python.org/issue19094> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19094] urljoin should raise a TypeError if URL is not a string
Jacob Walls added the comment: Hi vajrasky, do you have any interest in converting your patch to a GitHub PR? If not I can see about doing so myself. Cheers. -- nosy: +jacobtylerwalls ___ Python tracker <https://bugs.python.org/issue19094> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue43802] Seg fault on macOS using multiprocessing.JoinableQueue
Jacob Walls added the comment: Unfortunately, at the outset I should have tested this without multiprocessing. I can reproduce without multiprocessing[1], which meant I could more easily pinpoint the failure. There is an expensive O(nm) algorithm[2] in the music21 library that is overflowing. I appreciate your time looking into this. Closing. Regards, Jacob [1] in the provided script, after one call to lc.save() call lc.rebuildMetadataCache(useMultiprocessing=False) [2] music21.analysis.discrete.Ambitus.getPitchRanges(), and I plan to do something about it. -- resolution: -> not a bug stage: -> resolved status: open -> closed ___ Python tracker <https://bugs.python.org/issue43802> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue43802] Seg fault on macOS using multiprocessing.JoinableQueue
Jacob Walls added the comment: Thanks for this detailed reply. I reproduced on Python 3.9.4 on the same iMac from my original report running macOS 10.13.6, but with much lesser frequency (I wouldn't use the word "consistently" anymore). I tried on a MacBook Pro with worn-out hardware running a newer OS (10.15.4) and could not reproduce the issue there. I also built cPython (Python 3.10.0a7+ (heads/master:ac05f82ad4, Apr 10 2021, 20:16:36) [Clang 10.0.0 (clang-1000.10.44.4)] on darwin) using --with-pydebug and ran the test case a few times on the good-hardware iMac, and observed the file parsing (predictably) slow to a crawl, but no reproduction of the segfault. This leads me to believe that, yes, this is a race condition I'm encountering on fast hardware. Possibly related to issue-25769, since music21 makes heavy use of weakrefs and since music21.metadata.caching.MetadataCachingJob.run() calls gc.collect(). Perhaps I can look into engineering a minimal test case based on that discussion, involving a deliberately expensive __eq__() call. To answer your original question: my first report on 3.9.2 was on this specific version: 3.9.2 (v3.9.2:1a79785e3e, Feb 19 2021, 09:06:10) \n[Clang 6.0 (clang-600.0.57)] -- ___ Python tracker <https://bugs.python.org/issue43802> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue43802] Seg fault on macOS using multiprocessing.JoinableQueue
New submission from Jacob Walls :
macOS 10.13.6
Python 3.9.2
I can consistently reproduce a seg fault while using
multiprocessing.JoinableQueue in Python 3.9.2.
My use case is the sheet music processing library music21. My fork includes a
folder of 209 files I use to reproduce, running 3 cores, shown in the script
below. (This is a subset of the over 1,000 files found here:
https://github.com/MarkGotham/When-in-Rome/tree/master/Corpus/OpenScore-LiederCorpus
Using this set of 1,000 files reproduces nearly every time; using the 209 files
I committed to my fork was enough to reproduce about 75% of the time.)
I'm a contributor to music21, so if this is an overwhelming amount of
information to debug, I will gladly pare this down as much as I can or create
some methods to access the multiprocessing functionality more directly. Many
thanks for any assistance.
pip3 install
git+https://github.com/jacobtylerwalls/music21.git@bpo-investigation
from music21 import corpus
# suggest using a unique name each attempt
lc = corpus.corpora.LocalCorpus(name='bpo-investigation')
# point to the directory of files I committed to my fork for this investigation
lc.addPath('/Library/Frameworks/Python.framework/Versions/3.9/lib/python3.9/site-packages/music21/bpo-files')
# parse the files using multiprocessing
# calls music21.metadata.bundles.MetadataBundle.addFromPaths()
# which calls music21.metadata.caching.process_parallel()
lc.save()
# CTRL-C to recover from seg fault
# then, wipe out the entries in .music21rc so that you can cleanly reproduce
again
from music21 import environment
us = environment.UserSettings()
us['localCorporaSettings'] = {}
quit()
Process: Python [31677]
Path:
/Library/Frameworks/Python.framework/Versions/3.9/Resources/Python.app/Contents/MacOS/Python
Identifier:Python
Version: 3.9.2 (3.9.2)
Code Type: X86-64 (Native)
Parent Process:Python [31674]
Responsible: Python [31677]
User ID: 501
Date/Time: 2021-04-10 11:21:19.294 -0400
OS Version:Mac OS X 10.13.6 (17G14042)
Report Version:12
Anonymous UUID:E7B0208A-19D6-ABDF-B3EA-3910A56B3E72
Sleep/Wake UUID: C4B83F57-6AD1-469E-82AE-88214FAA6283
Time Awake Since Boot: 14 seconds
Time Since Wake: 5900 seconds
System Integrity Protection: enabled
Crashed Thread:0 Dispatch queue: com.apple.main-thread
Exception Type:EXC_BAD_ACCESS (SIGSEGV)
Exception Codes: KERN_INVALID_ADDRESS at 0x000100b3acd8
Exception Note:EXC_CORPSE_NOTIFY
Termination Signal:Segmentation fault: 11
Termination Reason:Namespace SIGNAL, Code 0xb
Terminating Process: exc handler [0]
VM Regions Near 0x100b3acd8:
-->
__TEXT 0001068bb000-0001068bc000 [4K] r-x/rwx
SM=COW
[/Library/Frameworks/Python.framework/Versions/3.9/Resources/Python.app/Contents/MacOS/Python]
Thread 0 Crashed:: Dispatch queue: com.apple.main-thread
0 org.python.python 0x000106944072 PyObject_RichCompare
+ 258
1 org.python.python 0x000106943e9b
PyObject_RichCompareBool + 43
2 org.python.python 0x0001069ce3c0 min_max + 624
3 org.python.python 0x000106940bab cfunction_call + 59
4 org.python.python 0x000106901cad _PyObject_MakeTpCall
+ 365
5 org.python.python 0x0001069d865c call_function + 876
6 org.python.python 0x0001069d5b8b
_PyEval_EvalFrameDefault + 25371
7 org.python.python 0x000106902478
function_code_fastcall + 104
8 org.python.python 0x0001069d85cc call_function + 732
9 org.python.python 0x0001069d5ad2
_PyEval_EvalFrameDefault + 25186
10 org.python.python 0x0001069d92c3 _PyEval_EvalCode +
2611
11 org.python.python 0x000106902401
_PyFunction_Vectorcall + 289
12 org.python.python 0x0001069d85cc call_function + 732
13 org.python.python 0x0001069d5ad2
_PyEval_EvalFrameDefault + 25186
14 org.python.python 0x0001069d92c3 _PyEval_EvalCode +
2611
15 org.python.python 0x000106902401
_PyFunction_Vectorcall + 289
16 org.python.python 0x000106901b05
_PyObject_FastCallDictTstate + 293
17 org.python.python 0x0001069026e8
_PyObject_Call_Prepend + 152
18 org.python.python 0x00010695be85 slot_tp_init + 165
19 org.python.python 0x0001069573d9 type_call + 345
20 org.python.python 0x000106901cad _PyObject_MakeTpCall
+ 365
21 org.python.python 0x0001069d865c call_function + 876
22 org.python.python 0x0001069d5af3
_PyEval_EvalFrameDefa
[issue43496] Save As dialog in IDLE doesn't accept keyboard shortcuts on MacOS
New submission from Jacob Walls : Cmd-A to select all or Cmd-Z to undo, etc., have no effect when typing in the "Save As:" or "Tags:" fields of the native Save As... dialog on MacOS. Cmd-R, curiously, opens a Finder window. IDLE dialogs such as Search behave as expected (Cmd-A selects all). Python 3.9.2 macOS 10.15.7 (and 10.13.6) Pardon me if my search for existing tickets came up short. -- assignee: terry.reedy components: IDLE, macOS messages: 388699 nosy: jacobtylerwalls, ned.deily, ronaldoussoren, terry.reedy priority: normal severity: normal status: open title: Save As dialog in IDLE doesn't accept keyboard shortcuts on MacOS type: behavior versions: Python 3.9 ___ Python tracker <https://bugs.python.org/issue43496> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24650] Error in yield expression documentation
Change by Jacob Walls : -- keywords: +patch nosy: +jacobtylerwalls nosy_count: 4.0 -> 5.0 pull_requests: +23449 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/24663 ___ Python tracker <https://bugs.python.org/issue24650> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
