[issue42226] imghdr.what is missing docstring, has a logic error, and is overly complex
Change by Jeremy Howard : -- resolution: -> rejected stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.org/issue42226> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue42226] imghdr.what is missing docstring, has a logic error, and is overly complex
Change by Jeremy Howard : -- keywords: +patch pull_requests: +21988 stage: -> patch review pull_request: https://github.com/python/cpython/pull/23069 ___ Python tracker <https://bugs.python.org/issue42226> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue42226] imghdr.what is missing docstring, has a logic error, and is overly complex
New submission from Jeremy Howard : imghdr.what does not set f if h is passed, but still passed f to tests functions. None of the tests functions use it - they would not be able to anyway since it is not always set. imghdr.what is missing a docstring. imghdr.what has a complex highly nest structure with multiple return paths which makes the logic hard to follow. -- components: Library (Lib) messages: 380114 nosy: jph00 priority: normal severity: normal status: open title: imghdr.what is missing docstring, has a logic error, and is overly complex type: behavior versions: Python 3.10 ___ Python tracker <https://bugs.python.org/issue42226> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com