[issue11751] Increase distutils.filelist / packaging.manifest test coverage
Justin Love pyt...@justinlove.name added the comment: Still can't reproduce (though I got one failure and three other errors) $ patch -p 1 distutils2-manifest.diff $ ../devinabox/cpython/python.exe runtests.py ... test_glob_to_re (distutils2.tests.test_manifest.ManifestTestCase) ... ok ... -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11751 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11751] Increase distutils.filelist / packaging.manifest test coverage
Justin Love pyt...@justinlove.name added the comment: re: test_glob_to_re Could not reproduce (OS X 10.6) I built branch 2.7, and also tried the expressions from glob_to_re on my system 2.7 and 3.2, all returned the (?ms) version. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11751 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11751] Increase distutils.filelist / packaging.manifest test coverage
Justin Love pyt...@justinlove.name added the comment: Incorporated some formatting suggestions. Removed _actions. Just as well, as I accidentally left in the 'blarg' bogus action ;^) Added a test for implicit-include. Whether 'this cannot happen' can happen depends on the output of _parse_template_line. If you wanted to remove the catch-all and still have test backup, you'd probably have to restort to some form of fuzz-testing _process_template_line. As the code stands now it could be removed. I left it alone as insurance against future changes. -- Added file: http://bugs.python.org/file23244/packaging-manifest_v3.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11751 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11751] Increase distutils.filelist / packaging.manifest test coverage
Justin Love pyt...@justinlove.name added the comment: Sorry, it's been sitting at the bottom of my starred list for months, the prospect of reloading context always making it a little less attractive than something else. I turned out I had to update to even have 'packaging' Error was caused by an actual change in behavior - I was testing the argument-check by providing an action with no argument. The new code assumes a single 'word' is a filename, and translates it to include, eg. 'include include' which then passes the parse. I modified the Manifest to test against the list of actions, since this makes it harder for users to make a mistake. Of course we could just drop the test, or only check multi-argument actions. -- Added file: http://bugs.python.org/file23235/packaging-manifest_v2.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11751 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11751] Increase distutils.filelist test coverage
Justin Love pyt...@justinlove.name added the comment: Removed NO COVER Combined test_translate_pattern Added on to some test names to make them more descriptive -- Added file: http://bugs.python.org/file21562/increase_distutils_filelist_test_coverage_v2.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11751 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11751] Increase distutils/filelist test coverage
New submission from Justin Love pyt...@justinlove.name: Increase test coverage of distutils/filelist.py from 49% to 100%. One line was marked as excluded because it was a this cannot happen error, and I agreed. -- components: Tests files: increase_distutils_filelist_test_coverage.patch keywords: patch messages: 132869 nosy: jlove priority: normal severity: normal status: open title: Increase distutils/filelist test coverage type: behavior Added file: http://bugs.python.org/file21518/increase_distutils_filelist_test_coverage.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11751 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
