[issue37292] _xxsubinterpreters: Can't unpickle objects defined in __main__
Change by Maciej Szulik : -- nosy: +maciej.szulik ___ Python tracker <https://bugs.python.org/issue37292> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue15751] Support subinterpreters in the GIL state API
Change by Maciej Szulik : -- nosy: +maciej.szulik ___ Python tracker <https://bugs.python.org/issue15751> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10915] Make the PyGILState API compatible with multiple interpreters
Change by Maciej Szulik : -- nosy: +maciej.szulik ___ Python tracker <https://bugs.python.org/issue10915> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue33608] Add a cross-interpreter-safe mechanism to indicate that an object may be destroyed.
Change by Maciej Szulik : -- nosy: +maciej.szulik ___ Python tracker <https://bugs.python.org/issue33608> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue36877] [meta] Move fields from _PyRuntimeState to PyInterpreterState.
Change by Maciej Szulik : -- nosy: +maciej.szulik ___ Python tracker <https://bugs.python.org/issue36877> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue36876] Global C variables are a problem.
Change by Maciej Szulik : -- nosy: +maciej.szulik ___ Python tracker <https://bugs.python.org/issue36876> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue39511] [subinterpreters] Per-interpreter singletons (None, True, False, etc.)
Change by Maciej Szulik : -- nosy: +maciej.szulik ___ Python tracker <https://bugs.python.org/issue39511> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue38880] Subinterpreters: List interpreters associated with a channel end
Change by Maciej Szulik : -- nosy: +maciej.szulik ___ Python tracker <https://bugs.python.org/issue38880> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue36225] Lingering subinterpreters should be implicitly cleared on shutdown
Change by Maciej Szulik : -- nosy: +maciej.szulik ___ Python tracker <https://bugs.python.org/issue36225> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue29860] smtplib.py doesn't capitalize EHLO.
Changes by Maciej Szulik : -- nosy: +maciej.szulik ___ Python tracker <http://bugs.python.org/issue29860> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue29891] urllib.request.Request accepts but doesn't check bytes headers
Changes by Maciej Szulik : -- nosy: +maciej.szulik ___ Python tracker <http://bugs.python.org/issue29891> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue28879] smtplib send_message should add Date header if it is missing, per RFC5322
Maciej Szulik added the comment: I've chatted a bit with David about this feature. Here are some thoughts: - check what SMTP standard says about some validation rules - add validate method, probably into email package -- ___ Python tracker <http://bugs.python.org/issue28879> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue28879] smtplib send_message should add Date header if it is missing, per RFC5322
Maciej Szulik added the comment: I tend to agree with Eric Lafontaine, looking at the quote Henning von Bargen posted the originator address field is also required, but yet we don't explicitly check its presence in the code, but rely on the SMTP server to error out. -- nosy: +maciej.szulik ___ Python tracker <http://bugs.python.org/issue28879> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue25591] refactor imaplib tests
Maciej Szulik added the comment: Thank you David, of course I'll remind you :) -- ___ Python tracker <http://bugs.python.org/issue25591> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue28320] Hostname validation is False by default in imaplib
New submission from Maciej Szulik: According to David [1] hostname validation should be True by default for the imaplib, my tests clearly show something different. Additionally he states you Christian were doing so, that's why I'm opening this not to forget about the problem and discuss eventually what should happen. [1] http://bugs.python.org/review/25591/diff/16398/Lib/test/test_imaplib.py#newcode451 -- assignee: christian.heimes components: email messages: 22 nosy: barry, christian.heimes, maciej.szulik, r.david.murray priority: normal severity: normal stage: needs patch status: open title: Hostname validation is False by default in imaplib type: security versions: Python 3.7 ___ Python tracker <http://bugs.python.org/issue28320> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue25591] refactor imaplib tests
Maciej Szulik added the comment: David I apologize for 2 emails from Reitveld, for some reason it didn't show me all in one view :/ (I need to master Reitveld better). I've just updated patch according to your comments. -- Added file: http://bugs.python.org/file44896/new_imap_tests_v5.diff ___ Python tracker <http://bugs.python.org/issue25591> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue25591] refactor imaplib tests
Changes by Maciej Szulik : -- hgrepos: -322 ___ Python tracker <http://bugs.python.org/issue25591> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue25591] refactor imaplib tests
Maciej Szulik added the comment: Thanks, I'll try to update the patch in the following days. -- ___ Python tracker <http://bugs.python.org/issue25591> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue27321] Email parser creates a message object that can't be flattened
Changes by Maciej Szulik : -- nosy: +maciej.szulik ___ Python tracker <http://bugs.python.org/issue27321> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue25591] refactor imaplib tests
Maciej Szulik added the comment: David I'm uploading the patch with all the review comments addressed. The changes from just the review can be seen here: https://bitbucket.org/soltysh/cpython/commits/91708e0c6e7c5230bd69b1135b82ef47b6dc4d43?at=default (please ignore the changes to test_logincapa_withclient_certfile, these are not part of the final patch). -- Added file: http://bugs.python.org/file43023/new_imap_tests_v4.diff ___ Python tracker <http://bugs.python.org/issue25591> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue27132] New assert method that checks an error message for a list of strings
Maciej Szulik added the comment: You could, but then you end up writing nasty regex-es to do that. The idea here is to create a native function that will verify a number of words in whatever order. -- ___ Python tracker <http://bugs.python.org/issue27132> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue27132] New assert method that checks an error message for a list of strings
New submission from Maciej Szulik: To quote David from http://bugs.python.org/review/25591/diff/16398/Lib/test/test_imaplib.py: "I've been thinking I'd like a new assert method that checks an error message for a list of strings in any order, but I haven't opened an issue for it :)" -- components: Tests messages: 266454 nosy: maciej.szulik, r.david.murray priority: normal severity: normal status: open title: New assert method that checks an error message for a list of strings type: enhancement ___ Python tracker <http://bugs.python.org/issue27132> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue5996] abstract class instantiable when subclassing dict
Changes by Maciej Szulik : -- nosy: +maciej.szulik ___ Python tracker <http://bugs.python.org/issue5996> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue27010] email library could "recover" from bad mime boundary like (some?) email clients do
Changes by Maciej Szulik : -- nosy: +maciej.szulik ___ Python tracker <http://bugs.python.org/issue27010> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue26543] imaplib noop Debug
Changes by Maciej Szulik : -- nosy: +maciej.szulik ___ Python tracker <http://bugs.python.org/issue26543> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue26176] EmailMessage example doesn't work
Changes by Maciej Szulik : -- nosy: +maciej.szulik ___ Python tracker <http://bugs.python.org/issue26176> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue26399] CSV Injection Vulnerability
Maciej Szulik added the comment: Closing in favor of http://psf.upfronthosting.co.za/roundup/meta/issue580 -- nosy: +maciej.szulik resolution: -> wont fix status: open -> closed ___ Python tracker <http://bugs.python.org/issue26399> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue26375] Python 2.7.10 and 3.4.4 hang on imaplib.IMAP4_SSL()
Changes by Maciej Szulik : -- nosy: +maciej.szulik ___ Python tracker <http://bugs.python.org/issue26375> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue26314] interned strings are stored in a dict, a set would use less memory
Changes by Maciej Szulik : -- nosy: +maciej.szulik ___ Python tracker <http://bugs.python.org/issue26314> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue26306] Can't create abstract tuple
Changes by Maciej Szulik : -- nosy: +maciej.szulik ___ Python tracker <http://bugs.python.org/issue26306> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue26110] Speedup method calls 1.2x
Changes by Maciej Szulik : -- nosy: +maciej.szulik ___ Python tracker <http://bugs.python.org/issue26110> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue26252] Add an example to importlib docs on setting up an importer
Changes by Maciej Szulik : -- nosy: +maciej.szulik ___ Python tracker <http://bugs.python.org/issue26252> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue25591] refactor imaplib tests
Maciej Szulik added the comment: David I think I've re-implemented, using the new style, all the methods from ThreadedNetworkedTests and ThreadedNetworkedTestsSSL, the new classes are NewIMAPTests and NewIMAPSSLTests accordingly. -- stage: -> patch review Added file: http://bugs.python.org/file41675/new_imap_tests_v3.diff ___ Python tracker <http://bugs.python.org/issue25591> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue25591] refactor imaplib tests
Maciej Szulik added the comment: David can you please take a look once more, I've applied all the changes you've asked for. I'm currently working on adding the existing tests rewritten to use the new framework so it's easy to compare. It's still in progress but the general idea should maintain. -- keywords: +patch Added file: http://bugs.python.org/file41610/new_imap_tests_v2.diff ___ Python tracker <http://bugs.python.org/issue25591> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11245] Implementation of IMAP IDLE in imaplib?
Changes by Maciej Szulik : -- nosy: +maciej.szulik ___ Python tracker <http://bugs.python.org/issue11245> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue23942] Explain naming of the patch files in the bug tracker
Maciej Szulik added the comment: Ezio, I've meant we should provide some guidelines with information the system will pick whatever they choose based on submission date. More informational than as a requirement. -- ___ Python tracker <http://bugs.python.org/issue23942> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21815] imaplib truncates some untagged responses
Maciej Szulik added the comment: I was looking for that but I missed the Stage field, thanks David will remember for the future :) -- stage: patch review -> commit review ___ Python tracker <http://bugs.python.org/issue21815> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21815] imaplib truncates some untagged responses
Maciej Szulik added the comment: I've checked the patch: it looks good, applies cleanly to latest default and passes all the tests. I'm ok with merging this as is. -- ___ Python tracker <http://bugs.python.org/issue21815> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21815] imaplib truncates some untagged responses
Maciej Szulik added the comment: Lita can you please apply the changes from latest review (from SilentGhost). Especially the one regarding newline, which currently fails to apply this patch on default. If all those will be cleaned I'll recommend this patch for David for inclusion. -- ___ Python tracker <http://bugs.python.org/issue21815> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21815] imaplib truncates some untagged responses
Maciej Szulik added the comment: Lita if you still have problems or want to ask questions reach out to me on IRC, I'm soltysh on freenode. -- ___ Python tracker <http://bugs.python.org/issue21815> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue25591] refactor imaplib tests
Maciej Szulik added the comment: I'm reopening this issue per discussion with David we've had on IRC. The scope of this issue to refactor current tests to make them more readable and clean. The most important work is: 1. having single _setup method 2. the _setup method should addClenup to clean the environment 3. have stubs with implemented mostly used methods, all others should be implemented ad-hoc in test methods 4. use unittest.main() for running tests We'll do it along current tests to show the improvement. Once we reach satisfactory level we will remove the old tests. This issue is to show this progress. -- assignee: -> maciej.szulik keywords: -patch resolution: duplicate -> status: closed -> open superseder: Test imaplib API on all methods specified in RFC 3501 -> title: improve test coverage for the imaplib -> refactor imaplib tests ___ Python tracker <http://bugs.python.org/issue25591> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue22137] Test imaplib API on all methods specified in RFC 3501
Maciej Szulik added the comment: Per the discussion we've had with David on IRC here's what happening. The last patch I've submitted is meant to clean up the tests by: 1. having single _setup method 2. the _setup method should addClenup to clean the environment 3. have stubs with implemented mostly used methods, all others should be implemented ad-hoc in test methods 4. use unittest.main() for running tests The current idea is to create tests along the current one, to show how the new improve the readability. For this work I'm reopening previously submitted issue http://bugs.python.org/issue25591 The current issue will be on dependent on it and no further work should be done unless we have the tests cleared. -- keywords: -patch ___ Python tracker <http://bugs.python.org/issue22137> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13940] imaplib: Mailbox names are not quoted
Maciej Szulik added the comment: siemer thx for the comments in the review. I'll try to address them by the end of this week. -- ___ Python tracker <http://bugs.python.org/issue13940> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21815] imaplib truncates some untagged responses
Maciej Szulik added the comment: Perfect, thanks! -- ___ Python tracker <http://bugs.python.org/issue21815> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21815] imaplib truncates some untagged responses
Maciej Szulik added the comment: Hey Lita, final call ;) Can you address berkerpeksag comments from review? Otherwise, I'm planning to take ownership of this issue and resubmit your patch with addressed comments. -- ___ Python tracker <http://bugs.python.org/issue21815> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue25591] improve test coverage for the imaplib
Changes by Maciej Szulik : -- superseder: -> Test imaplib API on all methods specified in RFC 3501 ___ Python tracker <http://bugs.python.org/issue25591> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue22137] Test imaplib API on all methods specified in RFC 3501
Maciej Szulik added the comment: Resubmitting from http://bugs.python.org/issue25591, which I filled in unnecessarily. Here are the rewritten test case I've developed during PyCon sprints along with David. Once we'll have the entire test suite in place it'll be safer to introduce any changes I'd like to cover, including updating the implementation to newest RFC 3501 version. -- hgrepos: +325 Added file: http://bugs.python.org/file41264/new_imap_tests.diff ___ Python tracker <http://bugs.python.org/issue22137> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue25591] improve test coverage for the imaplib
Maciej Szulik added the comment: I've just found the original issue where I wanted to submit the new tests. I'm closing this in favor of http://bugs.python.org/issue22137. -- resolution: -> duplicate status: open -> closed ___ Python tracker <http://bugs.python.org/issue25591> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13940] imaplib: Mailbox names are not quoted
Maciej Szulik added the comment: >From imaplib.IMAP4 class description we're stating to quote parameters if >necessary. This patch adds that capability according to >https://tools.ietf.org/html/rfc3501#section-5.1 -- keywords: +patch Added file: http://bugs.python.org/file41037/issue13940.patch ___ Python tracker <http://bugs.python.org/issue13940> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13940] imaplib: Mailbox names are not quoted
Maciej Szulik added the comment: Currently working on a patch for this. -- ___ Python tracker <http://bugs.python.org/issue13940> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue25591] improve test coverage for the imaplib
New submission from Maciej Szulik: Our current imaplib implementation lacks quite a few of tests and the ones present are written in different styles. I'd like to propose rewriting the test case with this new style I've developed during PyCon sprints along with David. Once we'll have the entire test suite in place it'll be safer to introduce any changes I'd like to cover, including updating the implementation to newest RFC 3501 version. -- components: email files: new_imap_tests.diff hgrepos: 322 keywords: patch messages: 254417 nosy: barry, maciej.szulik, r.david.murray priority: normal severity: normal status: open title: improve test coverage for the imaplib type: enhancement versions: Python 3.6 Added file: http://bugs.python.org/file40991/new_imap_tests.diff ___ Python tracker <http://bugs.python.org/issue25591> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24218] Also support SMTPUTF8 in smtplib's send_message method.
Maciej Szulik added the comment: David one small comment regarding typo in smtplib.py, but most importantly I'd suggest adding additional test case to cover the path (the newly added one) where you get a UnicodeEncodeError upon encoding from or to with UTF8 and then failing to find SMTPUTF8 on the server side. I see we already have test case to cover SMTPNotSupportedError but this covers just the case where the server does not have SMTPUTF8. -- ___ Python tracker <http://bugs.python.org/issue24218> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24218] Also support SMTPUTF8 in smtplib's send_message method.
Changes by Maciej Szulik : -- nosy: +maciej.szulik ___ Python tracker <http://bugs.python.org/issue24218> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24211] Add RFC 6532 support to the email library
Maciej Szulik added the comment: David one small nit in docs, but otherwise the patch looks good, applies cleanly and works as expected. -- ___ Python tracker <http://bugs.python.org/issue24211> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24211] Add RFC 6532 support to the email library
Changes by Maciej Szulik : -- nosy: +maciej.szulik ___ Python tracker <http://bugs.python.org/issue24211> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1100942] Add datetime.time.strptime and datetime.date.strptime
Maciej Szulik added the comment: Berker per your comment updated patch changing those two new methods (namely date.strptime and time.strptime) to be classmethod and not staticmethods. -- Added file: http://bugs.python.org/file39345/issue1100942.patch ___ Python tracker <http://bugs.python.org/issue1100942> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1100942] Add datetime.time.strptime and datetime.date.strptime
Maciej Szulik added the comment: I've just double checked, this patch applies cleanly to latest tip. I wouldn't mind having this reviewed and merged. -- ___ Python tracker <http://bugs.python.org/issue1100942> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21800] Implement RFC 6855 (IMAP Support for UTF-8) in imaplib.
Maciej Szulik added the comment: David, I've changed according to your suggestion, appreciate review. -- Added file: http://bugs.python.org/file39324/issue21800.patch ___ Python tracker <http://bugs.python.org/issue21800> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21800] Implement RFC 6855 (IMAP Support for UTF-8) in imaplib.
Maciej Szulik added the comment: Yes, I can update that (that IMAP testing bug - http://bugs.python.org/issue22137, is taking me longer than I expected it ;)). I just want to make sure if I understand you correctly what's needs to be done is removing the utf8_enable code from init, we will enable ascii by default and only explicit call to enable method will enable it, am I missing something? -- ___ Python tracker <http://bugs.python.org/issue21800> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21800] Implement RFC 6855 (IMAP Support for UTF-8) in imaplib.
Maciej Szulik added the comment: David I did the review and there's one thing that worries me the most, actually two: 1. changing the usual meaning of None in the IMAP's __init__ method, where None has the same meaning as True, where I think it should be the opposite. 2. I'm not sure we want to have UTF8 enabled based on the init's flag. I've seen our IMAP library as a wrapper around protocol itself. Whereas the user must be aware of required steps needed to proceed. In this case enabling UTF8 support is just the next command the client can, but doesn't have to sent directly, but only in AUTH state. -- ___ Python tracker <http://bugs.python.org/issue21800> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue22137] Test imaplib API on all methods specified in RFC 3501
Maciej Szulik added the comment: Thanks Milan for the info, I was about to ping you about that. I have a working prototype for the tests that I've been working on during PyCon sprints with David. I'll try to submit new patch within a couple of next days. -- ___ Python tracker <http://bugs.python.org/issue22137> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16914] timestamping in smtplib.py to help troubleshoot server timeouts/delays
Maciej Szulik added the comment: Review comments addressed in latest patch. -- Added file: http://bugs.python.org/file39077/issue16914.patch ___ Python tracker <http://bugs.python.org/issue16914> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16914] timestamping in smtplib.py to help troubleshoot server timeouts/delays
Maciej Szulik added the comment: After talking to David I'm submitting the patch once again with one slight change in ACKS file (I've put the names in the sorted order). -- Added file: http://bugs.python.org/file39073/issue16914.patch ___ Python tracker <http://bugs.python.org/issue16914> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue22137] Test imaplib API on all methods specified in RFC 3501
Maciej Szulik added the comment: Milan one more thing to change in your patch, in all your TCs you're modifying client state, I mean this part: # lets cheat a bit here: client.state = 'SELECTED' It's OK to do that on the mocked server, but this is not acceptable doing on the tested library. It's better to call client.login() to change the state to 'AUTH' properly and only after that, call the actual method under test. -- ___ Python tracker <http://bugs.python.org/issue22137> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13940] imaplib: Mailbox names are not quoted
Maciej Szulik added the comment: Joe is correct, according to the spec the names containing special chars (atom-specials) require names to be quoted (https://tools.ietf.org/html/rfc3501#section-5.1): 1)Any character which is one of the atom-specials (see the Formal Syntax) will require that the mailbox name be represented as a quoted string or literal. I'll be working on a patch for that. -- nosy: +maciej.szulik ___ Python tracker <http://bugs.python.org/issue13940> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue22137] Test imaplib API on all methods specified in RFC 3501
Maciej Szulik added the comment: One more thing I didn't mention before is, please update it to match current default, as it's failing patching, right now. -- ___ Python tracker <http://bugs.python.org/issue22137> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue23959] Update imaplib to support RFC3501
Maciej Szulik added the comment: I'm volunteering myself to work on this as a follow-up work to http://bugs.python.org/issue22137. -- ___ Python tracker <http://bugs.python.org/issue23959> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue23959] Update imaplib to support RFC3501
New submission from Maciej Szulik: Current imaplib implementation follows obsoleted RFC2060. It should be updated to follow RFC3501. -- components: email messages: 241022 nosy: barry, maciej.szulik, r.david.murray priority: normal severity: normal status: open title: Update imaplib to support RFC3501 type: enhancement ___ Python tracker <http://bugs.python.org/issue23959> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue22137] Test imaplib API on all methods specified in RFC 3501
Maciej Szulik added the comment: Milan, thanks for your patch, I've added comments to it (look for review link next to submitted file), can you address them please? Other option is, if you don't mind, I'll take over this issue and finish on top of your work. -- nosy: +maciej.szulik ___ Python tracker <http://bugs.python.org/issue22137> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue23942] Explain naming of the patch files in the bug tracker
New submission from Maciej Szulik: During the lifecycle of a bug you do: 1. submit a patch 2. get a review with some comments 3. re-submit the patch Talking to R. David Murray I got info there's no convention on naming those, I think it will be valuable to have some information in the devguide about that. Apparently you can either (when just fixing the patch) to stick with exactly the same name or add increasing suffix, eg. mypatch-1, mypatch-2, etc.). Otherwise you can change the name, but the review system will be able to pick up the right patch, so you should not worry about that. -- components: Devguide messages: 240800 nosy: ezio.melotti, maciej.szulik, willingc priority: normal severity: normal status: open title: Explain naming of the patch files in the bug tracker ___ Python tracker <http://bugs.python.org/issue23942> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16914] timestamping in smtplib.py to help troubleshoot server timeouts/delays
Maciej Szulik added the comment: Uploading updated version of the patch. -- Added file: http://bugs.python.org/file38974/issue16914.patch ___ Python tracker <http://bugs.python.org/issue16914> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21815] imaplib truncates some untagged responses
Maciej Szulik added the comment: Lita always look for them next to your uploaded file, there's a review link that points to Rietveld Code Review Tool. There you'll find all those information, just for future use :) -- ___ Python tracker <http://bugs.python.org/issue21815> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue917120] imaplib: incorrect quoting in commands
Changes by Maciej Szulik : -- nosy: +maciej.szulik ___ Python tracker <http://bugs.python.org/issue917120> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21815] imaplib truncates some untagged responses
Maciej Szulik added the comment: Lita thanks for your patch!. Are you able to address berkerpeksag comments from review? Otherwise if you don't mind I'll take it over and I'll do that. -- nosy: +maciej.szulik ___ Python tracker <http://bugs.python.org/issue21815> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16914] timestamping in smtplib.py to help troubleshoot server timeouts/delays
Maciej Szulik added the comment: Moving this enhancement to python 3.5. I'm adding updated patch plus tests for debug messages, updated what's new docs -- nosy: +maciej.szulik versions: +Python 3.5 -Python 3.4 Added file: http://bugs.python.org/file38924/issue16914.patch ___ Python tracker <http://bugs.python.org/issue16914> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19662] smtpd.py should not decode utf-8
Maciej Szulik added the comment: I've included Leslie's comments in rst file. The 3rd version is attached in issue19662_v3.patch. -- Added file: http://bugs.python.org/file35409/issue19662_v3.patch ___ Python tracker <http://bugs.python.org/issue19662> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19662] smtpd.py should not decode utf-8
Maciej Szulik added the comment: I've implemented all your proposed changes, because for most of your changes I was thinking pretty the same way for the whole day today, to make the code more elegant. The current state of work is attached as issue19662_v2.patch -- Added file: http://bugs.python.org/file35404/issue19662_v2.patch ___ Python tracker <http://bugs.python.org/issue19662> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19662] smtpd.py should not decode utf-8
Maciej Szulik added the comment: I'm attaching file issue19662_v1.patch. David please have a look at it and let me know if this is it, if not I'm waiting for your suggestions. -- Added file: http://bugs.python.org/file35390/issue19662_v1.patch ___ Python tracker <http://bugs.python.org/issue19662> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21555] gcmodule.c could use pytime.h
Changes by Maciej Szulik : -- nosy: +maciej.szulik ___ Python tracker <http://bugs.python.org/issue21555> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19662] smtpd.py should not decode utf-8
Maciej Szulik added the comment: I'll try to take care of this issue in the following few days. -- ___ Python tracker <http://bugs.python.org/issue19662> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19662] smtpd.py should not decode utf-8
Maciej Szulik added the comment:
Sreepriya, are you still working on this issue? If no I'll be happy to take it
over, is yes start with fixing following things:
- start with test - this is the most important to have each feautre tested
- decode_data, as David mentioned, needs to have default value True, meaning
that __init__ should look like this:
def __init__(self, server, conn, addr, data_size_limit=DATA_SIZE_DEFAULT,
map=None, decode_data=True)
Assigning True in __init__ will make this value always True, and that's not the
point.
- add deprecation warning about this parameter using warnings module:
warnings.warn('decode_data=True is deprecated, data will not be decoded by
default', DeprecationWarning, 2)
- as for the found_terminator method what David means is to decode data in the
first if, where commands are checked, to simplify processing of this part
(David please correct me if I'm wrong) and not what you did
- and finally you need to update the docs to include decode_data parameter with
information about how it works and it's deprecation
--
nosy: +maciej.szulik
___
Python tracker
<http://bugs.python.org/issue19662>
___
___
Python-bugs-list mailing list
Unsubscribe:
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1100942] Add datetime.time.strptime and datetime.date.strptime
Changes by Maciej Szulik : -- hgrepos: -232 ___ Python tracker <http://bugs.python.org/issue1100942> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1100942] Add datetime.time.strptime and datetime.date.strptime
Maciej Szulik added the comment: Sorry it took me that long - but I'm finally attaching fixed patch. I've also checked it again current default branch and updated descriptions accordingly. -- hgrepos: +232 Added file: http://bugs.python.org/file34778/issue1100942_20140409.patch ___ Python tracker <http://bugs.python.org/issue1100942> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1100942] Add datetime.time.strptime and datetime.date.strptime
Maciej Szulik added the comment: You're right, I'll change this description removing 'This is equivalent...' sentence from description. I guess the same applies to time.strptime as well. -- ___ Python tracker <http://bugs.python.org/issue1100942> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1100942] Add datetime.time.strptime and datetime.date.strptime
Maciej Szulik added the comment: Alexander yes it's correct. It's checking for time part in date.strptime and for time part in time.strptime. The only problem I came into is that when passing 0 hours or 0 minutes into date.strptime it won't raise an exception, though doc explicitly says: "(...) ValueError is raised if the date string (...) the time part is nonzero". So I'm not sure whether this is enough or should I add additional checks if time part was set? -- ___ Python tracker <http://bugs.python.org/issue1100942> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1100942] Add datetime.time.strptime and datetime.date.strptime
Maciej Szulik added the comment: I've just checked the patch still applies to current HEAD. What about the question regarding 0's in date.strptime(...) I asked in previous comment? I'd like to move this issue forward now when 3.4 is released. -- ___ Python tracker <http://bugs.python.org/issue1100942> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1100942] Add datetime.time.strptime and datetime.date.strptime
Maciej Szulik added the comment: I'm attaching merged and fixed patch (issue1100942_full.patch). Though during testing I found one issue with the patch: during checking for time part in date class I'm using (in _datetimemodule.c->date_strptime) DATE_GET_HOUR etc, but when given time parts are 0's then the test fails. Should I leave the patch as is, because possibility for 0's is very low or should I check the format string for time parts existence? Any further advice is appreciated. -- Added file: http://bugs.python.org/file33240/issue1100942_full.patch ___ Python tracker <http://bugs.python.org/issue1100942> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1100942] Add datetime.time.strptime and datetime.date.strptime
Maciej Szulik added the comment: Julian I'm almost done with this issue. I just need to polish that a little bit and I'll provide working patch withing few hours. Sorry for not writing about that later, but I'm just starting with this and I had some time figuring it out. -- ___ Python tracker <http://bugs.python.org/issue1100942> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1100942] Add datetime.time.strptime and datetime.date.strptime
Changes by Maciej Szulik : -- nosy: +maciej.szulik ___ Python tracker <http://bugs.python.org/issue1100942> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue15927] csv.reader() does not support escaped newline when quoting=csv.QUOTE_NONE
Maciej Szulik added the comment: I've confirmed that bug in the latest repo version, still exists. I attach patch for py3k. I'll try to have a look at it in the current version, as soon as it will be fixed I'll port it to 2.7. -- nosy: +maciej.szulik versions: +Python 3.4 Added file: http://bugs.python.org/file27509/test_csv_py3k.py ___ Python tracker <http://bugs.python.org/issue15927> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
