[issue35328] Set a environment variable for venv prompt

2020-09-19 Thread Mathias Fredriksson 


Change by Mathias Fredriksson :


--
pull_requests: +21368
pull_request: https://github.com/python/cpython/pull/22324

___
Python tracker 
<https://bugs.python.org/issue35328>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35328] Set a environment variable for venv prompt

2020-09-19 Thread Mathias Fredriksson 


Mathias Fredriksson  added the comment:

I believe GH-21587 does not fully address this issue because VIRTUAL_ENV_PROMPT 
is being conditionally set only if VIRTUAL_ENV_DISABLE_PROMPT is unset. Shell 
prompts must set VIRTUAL_ENV_DISABLE_PROMPT to non-empty to prevent venv from 
hijacking PS1. I'm one of the maintainers of the Pure prompt for zsh, and it 
would be great if VIRTUAL_ENV_PROMPT could always be set, just as VIRTUAL_ENV 
is too.

--
nosy: +mafredri

___
Python tracker 
<https://bugs.python.org/issue35328>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com