[issue14796] Calendar module test coverage improved
Changes by Oleg Plakhotnyuk : Added file: http://bugs.python.org/file25705/test_calendar.patch ___ Python tracker <http://bugs.python.org/issue14796> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14796] Calendar module test coverage improved
Changes by Oleg Plakhotnyuk : Removed file: http://bugs.python.org/file25632/test_calendar.patch ___ Python tracker <http://bugs.python.org/issue14796> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14796] Calendar module test coverage improved
Oleg Plakhotnyuk added the comment: I didn't event know that there is such a handy assertRaisesRegex context. Many thanks for pointing this out! -- Added file: http://bugs.python.org/file25632/test_calendar.patch ___ Python tracker <http://bugs.python.org/issue14796> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14796] Calendar module test coverage improved
Changes by Oleg Plakhotnyuk : Removed file: http://bugs.python.org/file25562/test_calendar.patch ___ Python tracker <http://bugs.python.org/issue14796> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14796] Calendar module test coverage improved
Oleg Plakhotnyuk added the comment: Thanks for the review. I'll happily tune the patch myself. Just when I have some spare time again. -- ___ Python tracker <http://bugs.python.org/issue14796> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14796] Calendar module test coverage improved
New submission from Oleg Plakhotnyuk : I've improved calendar.py test coverage a bit. Before: 41071% calendar (.../Lib/calendar.py) After: 41077% calendar (.../Lib/calendar.py) -- components: Tests files: test_calendar.patch keywords: patch messages: 160519 nosy: Oleg.Plakhotnyuk, giampaolo.rodola, ncoghlan, rhettinger priority: normal severity: normal status: open title: Calendar module test coverage improved versions: Python 3.3 Added file: http://bugs.python.org/file25562/test_calendar.patch ___ Python tracker <http://bugs.python.org/issue14796> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13394] Patch to increase aifc lib test coverage
Changes by Oleg Plakhotnyuk : Added file: http://bugs.python.org/file24692/test_aifc_3_2.patch ___ Python tracker <http://bugs.python.org/issue13394> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13394] Patch to increase aifc lib test coverage
Changes by Oleg Plakhotnyuk : Removed file: http://bugs.python.org/file24691/test_aifc_3_2.patch ___ Python tracker <http://bugs.python.org/issue13394> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13394] Patch to increase aifc lib test coverage
Oleg Plakhotnyuk added the comment: For convenience I have uploaded the separate patch without warnings. Which means that it will generate some output during tests run. -- Added file: http://bugs.python.org/file24691/test_aifc_3_2.patch ___ Python tracker <http://bugs.python.org/issue13394> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14089] Patch to increase fractions lib test coverage
Changes by Oleg Plakhotnyuk : Added file: http://bugs.python.org/file24630/test_fractions.patch ___ Python tracker <http://bugs.python.org/issue14089> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14089] Patch to increase fractions lib test coverage
Changes by Oleg Plakhotnyuk : Removed file: http://bugs.python.org/file24605/test_fractions.patch ___ Python tracker <http://bugs.python.org/issue14089> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14089] Patch to increase fractions lib test coverage
New submission from Oleg Plakhotnyuk : The last few missing bits to complete test coverage of 'fractions.py' library. ./python.exe -E -Wd -m test -v -T -D ../coverage/test_fractions test_fractions lines cov% module (path) 270 100% fractions (/Users/family/Documents/code/python/repo/Lib/fractions.py) -- components: Tests files: test_fractions.patch keywords: patch messages: 153979 nosy: Oleg.Plakhotnyuk, mark.dickinson, rhettinger priority: normal severity: normal status: open title: Patch to increase fractions lib test coverage type: behavior versions: Python 3.3 Added file: http://bugs.python.org/file24605/test_fractions.patch ___ Python tracker <http://bugs.python.org/issue14089> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13806] Audioop decompression frames size check fix
Oleg Plakhotnyuk added the comment: Yes, that tests really should be there too. Added them to patch. -- Added file: http://bugs.python.org/file24344/audioop_size_check.patch ___ Python tracker <http://bugs.python.org/issue13806> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13806] Audioop decompression frames size check fix
Changes by Oleg Plakhotnyuk : Removed file: http://bugs.python.org/file24285/audioop_size_check.patch ___ Python tracker <http://bugs.python.org/issue13806> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13806] Audioop decompression frames size check fix
Changes by Oleg Plakhotnyuk : Added file: http://bugs.python.org/file24285/audioop_size_check.patch ___ Python tracker <http://bugs.python.org/issue13806> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13806] Audioop decompression frames size check fix
Changes by Oleg Plakhotnyuk : Removed file: http://bugs.python.org/file24284/audioop_size_check.patch ___ Python tracker <http://bugs.python.org/issue13806> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13806] Audioop decompression frames size check fix
Oleg Plakhotnyuk added the comment: Yep, you're right. Didn't noticed audioop_check_size() function at first. The fact that audioop accepts unicode strings seems weird to me too. I've replaced strings with bytes in tests. However, I'm afraid to add restrictions to library itself because of backward compatibility. -- Added file: http://bugs.python.org/file24284/audioop_size_check.patch ___ Python tracker <http://bugs.python.org/issue13806> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13806] Audioop decompression frames size check fix
Changes by Oleg Plakhotnyuk : Removed file: http://bugs.python.org/file24260/audioop_size_check.patch ___ Python tracker <http://bugs.python.org/issue13806> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13681] Aifc read compressed frames fix
Oleg Plakhotnyuk added the comment: Ok, I have opened issue 13806 with audioop fix alone. However, I cannot change current issue's dependencies to reflect that current issue depends on issue 13806. Could anyone do this for me please? -- Added file: http://bugs.python.org/file24261/aifc_compression.patch ___ Python tracker <http://bugs.python.org/issue13681> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13806] Audioop decompression frames size check fix
New submission from Oleg Plakhotnyuk : According to documentation (http://docs.python.org/library/audioop.html), adpcm2lin, alaw2lin and ulaw2lin are using 'width' argument to represent output frames width. However, in audioop.c module there are checks that are raising exceptions if input frames length is not multiple of 'width'. I have replaced checking of 'len' to match 'size' with checking of 'len*size' to match 'size' in order to retain only basic length validity checks. -- components: Library (Lib) files: audioop_size_check.patch keywords: patch messages: 151459 nosy: Oleg.Plakhotnyuk, ezio.melotti, sandro.tosi priority: normal severity: normal status: open title: Audioop decompression frames size check fix type: behavior versions: Python 3.2, Python 3.3 Added file: http://bugs.python.org/file24260/audioop_size_check.patch ___ Python tracker <http://bugs.python.org/issue13806> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13681] Aifc read compressed frames fix
Changes by Oleg Plakhotnyuk : Removed file: http://bugs.python.org/file24112/aifc_compression.patch ___ Python tracker <http://bugs.python.org/issue13681> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13589] Aifc low level serialization primitives fix
Oleg Plakhotnyuk added the comment: I have absolutely no idea :-) I just covered every line of code with tests. Some bugs prevented me from do it, so I fixed them. -- ___ Python tracker <http://bugs.python.org/issue13589> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13394] Patch to increase aifc lib test coverage
Oleg Plakhotnyuk added the comment: The last, fifth, patch goes to issue 13681 -- ___ Python tracker <http://bugs.python.org/issue13394> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13681] Aifc read compressed frames fix
Oleg Plakhotnyuk added the comment: I have put changes to both aifc and audioop module in this single patch. The reason is that aifc test reading compressed frames will work properly only after audioop fix has been applied. -- ___ Python tracker <http://bugs.python.org/issue13681> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13681] Aifc read compressed frames fix
New submission from Oleg Plakhotnyuk : This patch resolves two issues: 1. ADPCM compressed audio files reading. Such files have frame size of 4 bits. Aifc lib cannot represent 4 bits frame size because it uses integer bytes count variable. I have replaced it with bits count. 2. ALAW/ULAW/ADPCM audio data decompression. According to documentation (http://docs.python.org/library/audioop.html), adpcm2lin, alaw2lin and ulaw2lin are using 'width' argument to represent output frames width. However, in audioop.c module there are checks that are raising exceptions if input frames length is not multiple of 'width'. I have replaced checking of 'len' to match 'size' with checking of 'len*size' to match 'size' in order to retain only basic length validity checks. -- components: Library (Lib), Tests files: aifc_compression.patch keywords: patch messages: 150373 nosy: Oleg.Plakhotnyuk, ezio.melotti, r.david.murray priority: normal severity: normal status: open title: Aifc read compressed frames fix type: behavior versions: Python 3.2, Python 3.3 Added file: http://bugs.python.org/file24112/aifc_compression.patch ___ Python tracker <http://bugs.python.org/issue13681> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13394] Patch to increase aifc lib test coverage
Oleg Plakhotnyuk added the comment: Fourth patch goes to issue 13680 -- ___ Python tracker <http://bugs.python.org/issue13394> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13680] Aifc comptype write fix
New submission from Oleg Plakhotnyuk : Two changes have been made to the library: 1. Lowercase compression type support have been added to the sample width validation routine during write operation. Everywhere else compression types are used in both lowercase and uppercase. 2. Redundant invalid compression type check has been removed. It cannot be executed using public module interface, therefore I think it is not necessary. -- components: Library (Lib), Tests files: aifc_comptypes.patch keywords: patch messages: 150365 nosy: Oleg.Plakhotnyuk, ezio.melotti, r.david.murray priority: normal severity: normal status: open title: Aifc comptype write fix type: behavior versions: Python 3.2, Python 3.3 Added file: http://bugs.python.org/file24110/aifc_comptypes.patch ___ Python tracker <http://bugs.python.org/issue13680> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13394] Patch to increase aifc lib test coverage
Oleg Plakhotnyuk added the comment: Third patch goes to issue 13594 -- ___ Python tracker <http://bugs.python.org/issue13394> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13394] Patch to increase aifc lib test coverage
Oleg Plakhotnyuk added the comment: The split is in progress. There will be at least two more patches. Regarding your comments: 1) Sorry for my english :-) It is fully determined by the input. With this particular test input the assertNotEqual will always pass. So I've removed it. 2) These were simple prints, not warnings. I've replaced them with warnings and tested with assertWarns. It resulted in some changes to aifc library itself, but they are trivial and cannot affect behavior. 3) Fixed. Thanks. -- Added file: http://bugs.python.org/file23945/test_aifc.patch ___ Python tracker <http://bugs.python.org/issue13394> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13394] Patch to increase aifc lib test coverage
Changes by Oleg Plakhotnyuk : Removed file: http://bugs.python.org/file23934/test_aifc.patch ___ Python tracker <http://bugs.python.org/issue13394> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13594] Aifc markers write fix
New submission from Oleg Plakhotnyuk : 1. Markers serialization test coverage improved. 2. Marker name changed from string to bytes, because _write_string function uses bytes. 3. Check for closed file handle moved to 'close' method, because otherwise I caught 'attempt to write to closed file' error. -- components: Library (Lib) files: aifc_markers.patch keywords: patch messages: 149402 nosy: Oleg.Plakhotnyuk, ezio.melotti, r.david.murray priority: normal severity: normal status: open title: Aifc markers write fix type: behavior versions: Python 3.2, Python 3.3 Added file: http://bugs.python.org/file23944/aifc_markers.patch ___ Python tracker <http://bugs.python.org/issue13594> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13394] Patch to increase aifc lib test coverage
Changes by Oleg Plakhotnyuk : -- title: Patch to increase aifc lib test coverage with couple of minor fixes -> Patch to increase aifc lib test coverage ___ Python tracker <http://bugs.python.org/issue13394> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13589] Aifc low level serialization primitives fix
Changes by Oleg Plakhotnyuk : -- title: Aifc float serialization fix -> Aifc low level serialization primitives fix ___ Python tracker <http://bugs.python.org/issue13589> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13589] Aifc float serialization fix
Changes by Oleg Plakhotnyuk : Added file: http://bugs.python.org/file23940/aifc_numbers_fix.patch ___ Python tracker <http://bugs.python.org/issue13589> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13589] Aifc float serialization fix
Changes by Oleg Plakhotnyuk : Removed file: http://bugs.python.org/file23939/aifc_numbers_fix.patch ___ Python tracker <http://bugs.python.org/issue13589> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13589] Aifc float serialization fix
Changes by Oleg Plakhotnyuk : Added file: http://bugs.python.org/file23939/aifc_numbers_fix.patch ___ Python tracker <http://bugs.python.org/issue13589> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13589] Aifc float serialization fix
Changes by Oleg Plakhotnyuk : Removed file: http://bugs.python.org/file23935/aifc_numbers_fix.patch ___ Python tracker <http://bugs.python.org/issue13589> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13589] Aifc float serialization fix
Changes by Oleg Plakhotnyuk : Removed file: http://bugs.python.org/file23932/aifc_numbers_fix.patch ___ Python tracker <http://bugs.python.org/issue13589> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13589] Aifc float serialization fix
Oleg Plakhotnyuk added the comment: Forget about "patch must be applied before" thing. I've made independent patch. :-) -- Added file: http://bugs.python.org/file23935/aifc_numbers_fix.patch ___ Python tracker <http://bugs.python.org/issue13589> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13394] Patch to increase aifc lib test coverage with couple of minor fixes
Changes by Oleg Plakhotnyuk : Added file: http://bugs.python.org/file23934/test_aifc.patch ___ Python tracker <http://bugs.python.org/issue13394> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13394] Patch to increase aifc lib test coverage with couple of minor fixes
Changes by Oleg Plakhotnyuk : Removed file: http://bugs.python.org/file23931/test_aifc.patch ___ Python tracker <http://bugs.python.org/issue13394> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13589] Aifc float serialization fix
Changes by Oleg Plakhotnyuk : -- type: -> behavior ___ Python tracker <http://bugs.python.org/issue13589> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13394] Patch to increase aifc lib test coverage with couple of minor fixes
Oleg Plakhotnyuk added the comment: Second patch goes to issue 13589 -- ___ Python tracker <http://bugs.python.org/issue13394> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13589] Aifc float serialization fix
Oleg Plakhotnyuk added the comment: Second patch goes to issue 13589 -- ___ Python tracker <http://bugs.python.org/issue13589> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13589] Aifc float serialization fix
Oleg Plakhotnyuk added the comment: Patch must be applied after http://bugs.python.org/file23931/test_aifc.patch from issue 13394. Not sure if review tool can handle this correctly. -- ___ Python tracker <http://bugs.python.org/issue13589> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13589] Aifc float serialization fix
New submission from Oleg Plakhotnyuk : 1. Fixed _write_float to handle infinity, NaN and negative numbers correctly. 2. Renamed _write_long to _write_ulong because it actually writes unsigned value. 3. Added _read_ushort as counterpart of _write_ushort. This is never used anywhere except test that ushorts are written correctly. But it seems right to me to have both read and write function in the same module. -- components: Library (Lib) files: aifc_numbers_fix.patch keywords: patch messages: 149343 nosy: Oleg.Plakhotnyuk, ezio.melotti, r.david.murray priority: normal severity: normal status: open title: Aifc float serialization fix versions: Python 3.2, Python 3.3 Added file: http://bugs.python.org/file23932/aifc_numbers_fix.patch ___ Python tracker <http://bugs.python.org/issue13589> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13394] Patch to increase aifc lib test coverage with couple of minor fixes
Oleg Plakhotnyuk added the comment: Sounds perfectly reasonable. Here goes the first patch with pure test coverage. -- Added file: http://bugs.python.org/file23931/test_aifc.patch ___ Python tracker <http://bugs.python.org/issue13394> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13394] Patch to increase aifc lib test coverage with couple of minor fixes
Changes by Oleg Plakhotnyuk : Removed file: http://bugs.python.org/file23734/test_aifc.patch ___ Python tracker <http://bugs.python.org/issue13394> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13438] "Delete patch set" review action doesn't work
New submission from Oleg Plakhotnyuk :
I got following error when trying to delete outdated patch set:
Environment:
Request Method: POST
Request URL: http://bugs.python.org/review/13394/patchset/3680/delete
Django Version: 1.1.1 SVN-17047
Python Version: 2.5.2
Installed Applications:
['django.contrib.auth',
'django.contrib.contenttypes',
'django.contrib.sessions',
'django.contrib.sites',
'django.contrib.admin',
'gae2django',
'rietveld_helper',
'codereview']
Installed Middleware:
('django.middleware.common.CommonMiddleware',
'django.contrib.sessions.middleware.SessionMiddleware',
'django.contrib.auth.middleware.AuthenticationMiddleware',
'roundup_helper.middleware.LookupRoundupUser',
'gae2django.middleware.FixRequestUserMiddleware',
'rietveld_helper.middleware.AddUserToRequestMiddleware',
'django.middleware.doc.XViewMiddleware')
Traceback:
File "/home/roundup/trackers/tracker/rietveld/django/core/handlers/base.py" in
get_response
88. response = middleware_method(request, callback,
callback_args, callback_kwargs)
File "/home/roundup/trackers/tracker/rietveld/rietveld_helper/middleware.py" in
process_view
21. response = view_func(request, *view_args, **view_kwargs)
File "/home/roundup/trackers/tracker/rietveld/codereview/views.py" in
post_wrapper
557. return func(request, *args, **kwds)
File "/home/roundup/trackers/tracker/rietveld/codereview/views.py" in
login_wrapper
569. return func(request, *args, **kwds)
File "/home/roundup/trackers/tracker/rietveld/codereview/views.py" in
issue_wrapper
643. return func(request, *args, **kwds)
File "/home/roundup/trackers/tracker/rietveld/codereview/views.py" in
patchset_wrapper
706. return func(request, *args, **kwds)
File "/home/roundup/trackers/tracker/rietveld/codereview/views.py" in
patchset_owner_wrapper
718. return func(request, *args, **kwds)
File "/home/roundup/trackers/tracker/rietveld/codereview/views.py" in
xsrf_wrapper
597. return func(request, *args, **kwds)
File "/home/roundup/trackers/tracker/rietveld/codereview/views.py" in
delete_patchset
1669. for patchset in patchsets_after:
File "/home/roundup/trackers/tracker/rietveld/django/db/models/query.py" in
_result_iter
106. self._fill_cache()
File "/home/roundup/trackers/tracker/rietveld/django/db/models/query.py" in
_fill_cache
692. self._result_cache.append(self._iter.next())
File "/home/roundup/trackers/tracker/rietveld/django/db/models/query.py" in
iterator
238. for row in self.query.results_iter():
File "/home/roundup/trackers/tracker/rietveld/django/db/models/sql/query.py" in
results_iter
287. for rows in self.execute_sql(MULTI):
File "/home/roundup/trackers/tracker/rietveld/django/db/models/sql/query.py" in
execute_sql
2369. cursor.execute(sql, params)
File "/home/roundup/trackers/tracker/rietveld/django/db/backends/util.py" in
execute
19. return self.cursor.execute(sql, params)
Exception Type: ProgrammingError at /review/13394/patchset/3680/delete
Exception Value: schema "datetime" does not exist
Last trace frame's local vars exploration revealed this:
'SELECT "codereview_patchset"."id", "codereview_patchset"."gae_key",
"codereview_patchset"."gae_parent_ctype_id",
"codereview_patchset"."gae_parent_id", "codereview_patchset"."gae_ancestry",
"codereview_patchset"."issue_id", "codereview_patchset"."message",
"codereview_patchset"."data", "codereview_patchset"."url",
"codereview_patchset"."owner_id", "codereview_patchset"."created",
"codereview_patchset"."modified", "codereview_patchset"."n_comments" FROM
"codereview_patchset" WHERE "codereview_patchset"."issue_id" = 13394 AND
created > datetime.datetime(2011, 11, 20, 11, 36, 4, 343046)'
I believe that it should look something like this:
'SELECT ... AND created > %s' % datetime.datetime(2011, 11, 20, 11, 36, 4,
343046)
I'm not sure where should I post this issue. I didn't find
"rietveld/django/db/backends/util.py" in sources at rietveld.googlecode.com,
therefore I posted it here.
--
messages: 147994
nosy: Oleg.Plakhotnyuk
priority: normal
severity: normal
status: open
title: "Delete patch set" review action doesn't work
type: behavior
___
Python tracker
<http://bugs.python.org/issue13438>
___
___
Python-bugs-list mailing list
Unsubscribe:
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13394] Patch to increase aifc lib test coverage with couple of minor fixes
Changes by Oleg Plakhotnyuk : Removed file: http://bugs.python.org/file23733/test_aifc.patch ___ Python tracker <http://bugs.python.org/issue13394> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13394] Patch to increase aifc lib test coverage with couple of minor fixes
Oleg Plakhotnyuk added the comment: Minor style fixes -- Added file: http://bugs.python.org/file23734/test_aifc.patch ___ Python tracker <http://bugs.python.org/issue13394> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13394] Patch to increase aifc lib test coverage with couple of minor fixes
Changes by Oleg Plakhotnyuk : Removed file: http://bugs.python.org/file23677/test_aifc.patch ___ Python tracker <http://bugs.python.org/issue13394> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13394] Patch to increase aifc lib test coverage with couple of minor fixes
Oleg Plakhotnyuk added the comment: 1. Test coverage increased to 95%. 2. G722 compressed files reading in aifc.py fixed (it used to use 0 bytes frame size). 3. audioop's ulaw2lin, alaw2lin and adpcm2lin length checks fixed (width should be used for output only, because input sequence frame length is always 1 byte). 4. aifc.py _write_float infinity and NaN proper checking. 5. Other minor aifc.py clean ups. -- nosy: +haypo Added file: http://bugs.python.org/file23733/test_aifc.patch ___ Python tracker <http://bugs.python.org/issue13394> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13394] Patch to increase aifc lib test coverage with couple of minor fixes
Changes by Oleg Plakhotnyuk : Removed file: http://bugs.python.org/file23678/test_aifc2.patch ___ Python tracker <http://bugs.python.org/issue13394> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13394] Patch to increase aifc lib test coverage with couple of minor fixes
Oleg Plakhotnyuk added the comment: Thanks for your review, Ezio! Here goes new patch with all issues you've mentioned been fixed. -- Added file: http://bugs.python.org/file23678/test_aifc2.patch ___ Python tracker <http://bugs.python.org/issue13394> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13394] Patch to increase aifc lib test coverage with couple of minor fixes
New submission from Oleg Plakhotnyuk : I've increased coverage of aifc.py by test_aifc.py: before: [1/1] test_aifc lines cov% module (path) 56063% aifc (/Users/family/Documents/code/python/repo/Lib/aifc.py) ... after: [1/1] test_aifc lines cov% module (path) 56182% aifc (/Users/family/Documents/code/python/repo/Lib/aifc.py) ... I have also encountered couple of problems in aifc.py: 1. When using setmark() with string name to write to aiff file, you get Exception TypeError: "'str' does not support the buffer interface". 2. When using close() of Aifc_write object, it attempts to close it again in __del__() which ends with ValueError: write to closed file. I propose following solutions to above problems in patch attached: 1. Use bytes type for mark names, because entire aifc library already uses bytes anyway. 2. Make file pointer check in close() and reset it after actually closing the file. I don't think that these fixes will cause major backward compatibility problems, because with current version of aifc there is no way to write markers at all anyway. I plan to increase test coverage of aifc.py further in subsequent patches. Just want to make it in several small steps :-) Please provide any feedback regarding to what should I do to make this patch committed. Thanks! -- components: Library (Lib), Tests files: test_aifc.patch keywords: patch messages: 147550 nosy: Oleg.Plakhotnyuk priority: normal severity: normal status: open title: Patch to increase aifc lib test coverage with couple of minor fixes type: behavior versions: Python 3.4 Added file: http://bugs.python.org/file23677/test_aifc.patch ___ Python tracker <http://bugs.python.org/issue13394> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13241] Assertion failed in _PyUnicode_CheckConsistency during build of default branch on Mac OS X
Oleg Plakhotnyuk added the comment: Ah, of course. Initially I've tried to compile using this: i686-apple-darwin10-llvm-gcc-4.2 (GCC) 4.2.1 (Based on Apple Inc. build 5658) (LLVM build 2336.1.00) XCode version 4.2, build 4C199 -- ___ Python tracker <http://bugs.python.org/issue13241> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13241] Assertion failed in _PyUnicode_CheckConsistency during build of default branch on Mac OS X
Changes by Oleg Plakhotnyuk : -- status: open -> pending ___ Python tracker <http://bugs.python.org/issue13241> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13241] Assertion failed in _PyUnicode_CheckConsistency during build of default branch on Mac OS X
Changes by Oleg Plakhotnyuk : -- resolution: works for me -> fixed status: pending -> open ___ Python tracker <http://bugs.python.org/issue13241> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13241] Assertion failed in _PyUnicode_CheckConsistency during build of default branch on Mac OS X
Changes by Oleg Plakhotnyuk : -- status: open -> pending ___ Python tracker <http://bugs.python.org/issue13241> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13241] Assertion failed in _PyUnicode_CheckConsistency during build of default branch on Mac OS X
Changes by Oleg Plakhotnyuk : -- resolution: -> works for me ___ Python tracker <http://bugs.python.org/issue13241> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13241] Assertion failed in _PyUnicode_CheckConsistency during build of default branch on Mac OS X
Oleg Plakhotnyuk added the comment: Thank you all for help. I finally managed to build it. :-) So here are complete steps I've taken to build python after OS reinstall: 1. Install XCode 4.2 2. Install MacPorts 3. sudo port -v selfupdate 4. sudo port install gcc46 5. ./configure CC=gcc-mp-4.6 LDFLAGS=-L/opt/local/lib --with-pydebug && make -j2 Should I post this somewhere for others who may face similar problems? -- ___ Python tracker <http://bugs.python.org/issue13241> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13241] Assertion failed in _PyUnicode_CheckConsistency during build of default branch on Mac OS X
Oleg Plakhotnyuk added the comment: Oh yes. I am building with this command line: ./configure --with-pydebug && make -j2 -- ___ Python tracker <http://bugs.python.org/issue13241> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13241] Assertion failed in _PyUnicode_CheckConsistency during build of default branch on Mac OS X
New submission from Oleg Plakhotnyuk : Trying to build latest development revision: localhost:repo family$ hg summary parent: 73044:a985d733b3a3 tip #12753: Add support for Unicode name aliases and named sequences. branch: default commit: (clean) update: (current) Constantly getting this error: ./python.exe -SE -m sysconfig --generate-posix-vars Could not find platform dependent libraries Consider setting $PYTHONHOME to [:] Assertion failed: (compact->utf8_length == 0), function _PyUnicode_CheckConsistency, file Objects/unicodeobject.c, line 399. make: *** [sysconfig] Abort trap However, tag v3.2.2 seems to build successfully. OS: Mac OS X 10.6.8 GCC: 4.2.1 If you have troubles reproducing this issue, feel free to ask any information I can provide that can help. Thank you in advance! -- messages: 146120 nosy: Oleg.Plakhotnyuk priority: normal severity: normal status: open title: Assertion failed in _PyUnicode_CheckConsistency during build of default branch on Mac OS X type: compile error ___ Python tracker <http://bugs.python.org/issue13241> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
