[issue34453] ipaddress module accepts some strange IPv6 addresses that it shouldn't

2018-08-22 Thread Prudvi RajKumar Maddala


Prudvi RajKumar Maddala  added the comment:

Hi Ikcl, are you working on the fix? I'd like to work on it.

--
nosy: +prudvinit

___
Python tracker 
<https://bugs.python.org/issue34453>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34465] ipaddress should accept bytearray in addition to bytes

2018-08-23 Thread Prudvi RajKumar Maddala


Prudvi RajKumar Maddala  added the comment:

I think it should be supported too. How about a list of bytes? eg : 
[127,0,0,1].. Should that be supported as well?

--
nosy: +prudvinit

___
Python tracker 
<https://bugs.python.org/issue34465>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34453] ipaddress module accepts some strange IPv6 addresses that it shouldn't

2018-08-24 Thread Prudvi RajKumar Maddala


Prudvi RajKumar Maddala  added the comment:

Hi lkcl, can you help me understand why exactly the below IPv6 addresses are 
invalid?
('::::::00.00.00.00', False)
('::::::000.000.000.000', False)

I pulled the above addresses from your git testcase.

But, below 2 IPv6 addresses are given as valid
('::::::123.123.123.123', True)
('::::::123.123.123.123', True)

I don't see any difference between both. Both of them have IPv4 styled 
suffixes. According to the code, they are getting converted at runtime. Can you 
please clarify? 

Thanks

--

___
Python tracker 
<https://bugs.python.org/issue34453>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34465] ipaddress should accept bytearray in addition to bytes

2018-08-24 Thread Prudvi RajKumar Maddala


Change by Prudvi RajKumar Maddala :


--
keywords: +patch
pull_requests: +8379
stage:  -> patch review

___
Python tracker 
<https://bugs.python.org/issue34465>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34494] simple "sequence" class ignoring __len__

2018-08-25 Thread Prudvi RajKumar Maddala


Prudvi RajKumar Maddala  added the comment:

I think it should hang, since we are not throwing any StopIteration exception 
to break the infinite loop

--
nosy: +prudvinit

___
Python tracker 
<https://bugs.python.org/issue34494>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34453] ipaddress module accepts some strange IPv6 addresses that it shouldn't

2018-08-25 Thread Prudvi RajKumar Maddala


Prudvi RajKumar Maddala  added the comment:

I think Michal is right

--

___
Python tracker 
<https://bugs.python.org/issue34453>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34514] assertEqual doesn't use maxDiff when comparing dictionaries

2018-08-26 Thread Prudvi RajKumar Maddala


Prudvi RajKumar Maddala  added the comment:

Hello Victor, can you tell me what is 'maxDiff'? Can you give me a simple 
example of expected output and actual output by taking a simple dictionary?

Thanks

--
nosy: +prudvinit

___
Python tracker 
<https://bugs.python.org/issue34514>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34514] assertEqual doesn't use maxDiff when comparing dictionaries

2018-08-27 Thread Prudvi RajKumar Maddala


Prudvi RajKumar Maddala  added the comment:

I see that maxDiff is applied correctly when comparing dictionaries. I don't 
think that's an issue.

--

___
Python tracker 
<https://bugs.python.org/issue34514>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34516] httplib sets unbefitting "Host" in request header when requests an ipv6 format url.

2018-08-27 Thread Prudvi RajKumar Maddala


Prudvi RajKumar Maddala  added the comment:

I don't think urllib module is part of core python library. It's a 3rd party 
library which we usually install using pip

--
nosy: +prudvinit

___
Python tracker 
<https://bugs.python.org/issue34516>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34541] pathlib.Path.iterdir doesn't throw an exception until you start iterating

2018-08-29 Thread Prudvi RajKumar Maddala


Change by Prudvi RajKumar Maddala :


--
keywords: +patch
pull_requests: +8467
stage:  -> patch review

___
Python tracker 
<https://bugs.python.org/issue34541>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34541] pathlib.Path.iterdir doesn't throw an exception until you start iterating

2018-08-29 Thread Prudvi RajKumar Maddala


Change by Prudvi RajKumar Maddala :


--
pull_requests: +8470

___
Python tracker 
<https://bugs.python.org/issue34541>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34541] pathlib.Path.iterdir doesn't throw an exception until you start iterating

2018-08-29 Thread Prudvi RajKumar Maddala


Prudvi RajKumar Maddala  added the comment:

Made changes, pathlib.Path('.').iterdir() now throws a FileNotFoundError if the 
path is not valid.

--
nosy: +prudvinit

___
Python tracker 
<https://bugs.python.org/issue34541>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com