[issue45382] platform() is not able to detect windows 11

2022-03-28 Thread Tim Golden


Tim Golden  added the comment:

> I don't see why the wmi module ( https://pypi.org/project/WMI/ ) can't be 
> used instead to get the information

Well I can speak here as the author of that module and as an (occasional) core 
developer. The wmi module stands on the shoulderes of the pywin32 
win32com.client code -- which is an _enormous_ dependency to bring into Python. 
(And which no-one would realistically agree to...)

--

___
Python tracker 
<https://bugs.python.org/issue45382>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue45621] Small fixes to mmap

2021-10-29 Thread Tim Golden


Change by Tim Golden :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 
<https://bugs.python.org/issue45621>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue45621] Small fixes to mmap

2021-10-29 Thread Tim Golden


Tim Golden  added the comment:


New changeset 7bddd96982072d04bd6314da1ee7f40b7f875f00 by Tim Golden in branch 
'main':
bpo-45621: Small changes to mmap (GH-29247)
https://github.com/python/cpython/commit/7bddd96982072d04bd6314da1ee7f40b7f875f00


--

___
Python tracker 
<https://bugs.python.org/issue45621>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue45621] Small fixes to mmap

2021-10-27 Thread Tim Golden


Change by Tim Golden :


--
keywords: +patch
pull_requests: +27511
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/29247

___
Python tracker 
<https://bugs.python.org/issue45621>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue45621] Small fixes to mmap

2021-10-27 Thread Tim Golden


New submission from Tim Golden :

Following issue40915 a few small items still need to be addressed, mostly 
cosmetic / naming:

* A comment should have been removed but wasn't
* A comment should have been added but wasn't
* The use of the string "TEST" should be avoided in tests particularly where 
there is a shared namespace and therefore the chance of a collision

--
assignee: tim.golden
messages: 405073
nosy: tim.golden
priority: low
severity: normal
status: open
title: Small fixes to mmap
type: behavior
versions: Python 3.11

___
Python tracker 
<https://bugs.python.org/issue45621>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue40915] multiple problems with mmap.resize() in Windows

2021-10-26 Thread Tim Golden


Change by Tim Golden :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 
<https://bugs.python.org/issue40915>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue40915] multiple problems with mmap.resize() in Windows

2021-10-26 Thread Tim Golden


Tim Golden  added the comment:


New changeset aea5ecc458084e01534ea6a11f4181f369869082 by Tim Golden in branch 
'main':
bpo-40915: Fix mmap resize bugs on Windows (GH-29213)
https://github.com/python/cpython/commit/aea5ecc458084e01534ea6a11f4181f369869082


--

___
Python tracker 
<https://bugs.python.org/issue40915>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue40915] multiple problems with mmap.resize() in Windows

2021-10-25 Thread Tim Golden


Change by Tim Golden :


--
keywords: +patch
pull_requests: +27477
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/29213

___
Python tracker 
<https://bugs.python.org/issue40915>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue2733] mmap resize fails on anonymous memory

2021-10-23 Thread Tim Golden


Change by Tim Golden :


--
resolution: later -> duplicate
superseder:  -> multiple problems with mmap.resize()  in Windows

___
Python tracker 
<https://bugs.python.org/issue2733>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue2733] mmap resize fails on anonymous memory

2021-10-23 Thread Tim Golden


Tim Golden  added the comment:

Superseded by issue40915

--

___
Python tracker 
<https://bugs.python.org/issue2733>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue2733] mmap resize fails on anonymous memory

2021-10-23 Thread Tim Golden


Change by Tim Golden :


--
resolution:  -> later
stage:  -> resolved
status: open -> closed

___
Python tracker 
<https://bugs.python.org/issue2733>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue40915] multiple problems with mmap.resize() in Windows

2021-10-23 Thread Tim Golden


Change by Tim Golden :


--
assignee:  -> tim.golden

___
Python tracker 
<https://bugs.python.org/issue40915>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue12562] calling mmap twice fails on Windows

2021-10-23 Thread Tim Golden


Tim Golden  added the comment:

(switching stage to resolved because it's closed/rejected; sorry for the noise)

--
stage:  -> resolved

___
Python tracker 
<https://bugs.python.org/issue12562>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue2733] mmap resize fails on anonymous memory

2021-10-23 Thread Tim Golden


Tim Golden  added the comment:

https://bugs.python.org/issue40915 is related
Retargetting for 3.10+

--
assignee:  -> tim.golden
versions: +Python 3.10, Python 3.11 -Python 2.7, Python 3.2

___
Python tracker 
<https://bugs.python.org/issue2733>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue14170] print unicode string error in win8 cmd console

2021-10-22 Thread Tim Golden


Tim Golden  added the comment:

Closing this as out-of-date. The original bug was reported against 2.7 and 
Win8, both of which are either end-of-life now.

No follow up in 9 years and I'm quite certain that modern Pythons handle all 
manner of Unicode chars on the console.

--
resolution:  -> out of date
stage:  -> resolved
status: open -> closed

___
Python tracker 
<https://bugs.python.org/issue14170>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34240] Convert test_mmap to use tempfile

2021-10-22 Thread Tim Golden


Tim Golden  added the comment:

Closing as no longer reproducible in the current codebase on my current laptop

--
resolution:  -> not a bug
stage: patch review -> resolved
status: open -> closed

___
Python tracker 
<https://bugs.python.org/issue34240>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue40912] _PyOS_SigintEvent is never closed on Windows

2020-06-11 Thread Tim Golden


Change by Tim Golden :


--
assignee:  -> tim.golden

___
Python tracker 
<https://bugs.python.org/issue40912>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue40913] time.sleep ignores errors on Windows

2020-06-11 Thread Tim Golden


Tim Golden  added the comment:

Thanks, Eryk. I've had a couple of casts at this (and also with an eye to 
https://bugs.python.org/issue40912 in a very similar area).

Trouble is I can't come up with a way of adding a set.. function which doesn't 
seem wholly artificial, given that it's basically creating an anonymous event 
and checking its return. I can't come up with a non-testing scenario where the 
ability to override would be useful.

If I understand your proposal, a tentative "set..." function would have to take 
a HANDLE parameter so that it could be overridden by a test? That means its 
normal use would be something like:

setSigintEvent(CreateEvent(NULL, ));

so either the error checking for that would be inside the function, which feels 
weird, or would happen outside, which feels like the functions not doing 
anything. (I appreciate I may be overthinking here).

I'm very much open to suggestions here, but it seems to me that either:

We make the (simple) change without tests;

or we add a setSigintEvent function as above whose only purpose is to be 
overridden -- and then only for testing.

--

___
Python tracker 
<https://bugs.python.org/issue40913>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue40913] time.sleep ignores errors on Windows

2020-06-11 Thread Tim Golden


Change by Tim Golden :


--
assignee:  -> tim.golden

___
Python tracker 
<https://bugs.python.org/issue40913>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue40913] time.sleep ignores errors on Windows

2020-06-10 Thread Tim Golden


Tim Golden  added the comment:

Thinking about testing here.. is there any straightforward way to cause 
WaitForSingleObjectEx to fail?

The code change would be fairly slight and amenable to inspection, but it would 
be good to actually test it ;)

--

___
Python tracker 
<https://bugs.python.org/issue40913>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue38324] [Windows] test_locale and test__locale failures on Windows

2019-09-30 Thread Tim Golden


Tim Golden  added the comment:

This is the existing issue https://bugs.python.org/issue37945 which I haven't 
had time to progress. Please feel free to follow up

--

___
Python tracker 
<https://bugs.python.org/issue38324>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue37945] test_locale failing

2019-08-26 Thread Tim Golden


Tim Golden  added the comment:

This feels like one of those changes where what's in place is clearly flawed 
but any change seems like it'll break stuff which people have had in place for 
years.

I'll try to look at a least-breaking change but I'm honestly not sure what that 
would look like.

--

___
Python tracker 
<https://bugs.python.org/issue37945>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue37945] test_locale failing

2019-08-26 Thread Tim Golden


Tim Golden  added the comment:

I agree that that could be a fix. And certainly, if it turns out that this 
could never have (recently) worked as Eryk is suggesting, then let's go for it.

But I still have this uneasy feeling that it's not failing on the buildbots and 
I can't see any sign of a skipped test in the test stdio. I just wonder whether 
there's something else at play here.

--

___
Python tracker 
<https://bugs.python.org/issue37945>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue37945] test_locale failing

2019-08-26 Thread Tim Golden


Tim Golden  added the comment:

Thanks, Eryk. Your explanation is as clear as always. But my question is, then: 
why is my machine failing this test [the only one which uses this two-part 
locale] and not the buildbots or (presumably) any other Windows developer?

--

___
Python tracker 
<https://bugs.python.org/issue37945>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue37945] test_locale failing

2019-08-25 Thread Tim Golden


Tim Golden  added the comment:

Just to save you looking, the code in 
https://github.com/python/cpython/blob/master/Modules/_localemodule.c#L107 
converts the 2-tuple to lang.encoding form so the C module is seeing 
"en_GB.cp1252"

--

___
Python tracker 
<https://bugs.python.org/issue37945>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue37945] test_locale failing

2019-08-25 Thread Tim Golden


Tim Golden  added the comment:

Ok; so basically this doesn't work:


import locale
locale.setlocale(locale.LC_CTYPE, locale.getdefaultlocale())


It gives "locale.Error: unsupported locale setting" which comes from 
https://github.com/python/cpython/blob/master/Modules/_localemodule.c#L107

(For locale.getdefaultlocale() you could substitute locale.getlocale() or 
simply ("en_GB", "cp1252")). On my machine it raises that exception on Python 
2.7.15, 3.6.6 and on master. 

Interestingly, none of the other tests in test_locale appear to exercise the 
2-tuple 2nd param to setlocale. When you call setlocale and it returns the 
previous setting, it's a single string, eg "en_GB" etc. Passing that back in 
works. But when you call getlocale, it returns the 2-tuple, eg ("en_GB", 
"cp1252"). But all the other tests use the setlocale-returns-current trick for 
their setup/teardown.

I've quickly tested on 3.5 on Linux and the 2-tuple version works ok. I assume 
it's working on buildbots or we'd see the Turkish test failing every time. So 
is there something different about my C runtime, I wonder?

--

___
Python tracker 
<https://bugs.python.org/issue37945>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue37945] test_locale failing

2019-08-25 Thread Tim Golden


New submission from Tim Golden :

On a Win10 machine I'm consistently seeing test_locale (and test__locale) fail. 
I'll attach pythoninfo.

==
ERROR: test_getsetlocale_issue1813 (test.test_locale.TestMiscellaneous)
--
Traceback (most recent call last):
  File "C:\Users\tim\work-in-progress\cpython\lib\test\test_locale.py", line 
531, in test_getsetlocale_issue1813
locale.setlocale(locale.LC_CTYPE, loc)
  File "C:\Users\tim\work-in-progress\cpython\lib\locale.py", line 604, in 
setlocale
return _setlocale(category, locale)
locale.Error: unsupported locale setting

--
assignee: tim.golden
components: Library (Lib)
files: pythoninfo.txt
messages: 350466
nosy: tim.golden
priority: normal
severity: normal
status: open
title: test_locale failing
type: behavior
versions: Python 3.9
Added file: https://bugs.python.org/file48561/pythoninfo.txt

___
Python tracker 
<https://bugs.python.org/issue37945>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue36800] Invalid coding error hidden on Windows

2019-05-05 Thread Tim Golden


Tim Golden  added the comment:

Python 3.6.6 (v3.6.6:4cf1f54eb7, Jun 27 2018, 03:37:03) [MSC v.1900 64 bit 
(AMD64)] on win32

I can't reproduce this on Windows. And it does seem an unlikely combination of 
effect and cause.

Do I take it that if you take out all the "logging..." lines, the thing works? 
ie you do correctly import threading and it shows a reasonable value when you 
print(threading)?

--

___
Python tracker 
<https://bugs.python.org/issue36800>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue35140] encoding problem: gbk

2018-11-02 Thread Tim Golden


Tim Golden  added the comment:

I'm afraid you'll have to use English in this forum so that all current and 
future readers have the best chance of understanding the situation. Thank you 
very much for making the effort this far.

If anyone on this issue knows of a Chinese-language forum where this issue 
could explored before coming back here, please say so. Otherwise I'll ask 
around on Twitter etc. to see what's available

--

___
Python tracker 
<https://bugs.python.org/issue35140>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34239] Convert test_bz2 to use tempfile

2018-07-28 Thread Tim Golden


Change by Tim Golden :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 
<https://bugs.python.org/issue34239>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34240] Convert test_mmap to use tempfile

2018-07-27 Thread Tim Golden


Tim Golden  added the comment:

Thanks for the information, eryksun.

For the moment, I can only say with a fair degree of certainty that using the 
tempfile functions as I have in test_bz2 & test_mmap appears to solve the issue 
which is repeatably if intermittently present without that change.

I'll be trying to narrow the issue down before making any further changes

--

___
Python tracker 
<https://bugs.python.org/issue34240>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34239] Convert test_bz2 to use tempfile

2018-07-26 Thread Tim Golden


Tim Golden  added the comment:


New changeset 6a62e1d365934de82ff7c634981b3fbf218b4d5f by Tim Golden in branch 
'master':
bpo-34239: Convert test_bz2 to use tempfile (#8485)
https://github.com/python/cpython/commit/6a62e1d365934de82ff7c634981b3fbf218b4d5f


--

___
Python tracker 
<https://bugs.python.org/issue34239>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34240] Convert test_mmap to use tempfile

2018-07-26 Thread Tim Golden


Change by Tim Golden :


--
keywords: +patch
pull_requests: +8008
stage:  -> patch review

___
Python tracker 
<https://bugs.python.org/issue34240>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34240] Convert test_mmap to use tempfile

2018-07-26 Thread Tim Golden


New submission from Tim Golden :

test_mmap currently uses the test.support.TESTFN functionality which creates a 
temporary file local to the test directory named around the pid. 

This can give rise to race conditions where tests are competing with each other 
to delete and recreate the file.

--
assignee: tim.golden
messages: 322444
nosy: tim.golden
priority: normal
severity: normal
status: open
title: Convert test_mmap to use tempfile
versions: Python 3.8

___
Python tracker 
<https://bugs.python.org/issue34240>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34239] Convert test_bz2 to use tempfile

2018-07-26 Thread Tim Golden


Change by Tim Golden :


--
keywords: +patch
pull_requests: +8007
stage:  -> patch review

___
Python tracker 
<https://bugs.python.org/issue34239>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34239] Convert test_bz2 to use tempfile

2018-07-26 Thread Tim Golden


New submission from Tim Golden :

test_bz2 currently uses the test.support.TESTFN functionality which creates a 
temporary file local to the test directory named around the pid. 

This can give rise to race conditions where tests are competing with each other 
to delete and recreate the file.

--
assignee: tim.golden
messages: 322441
nosy: tim.golden
priority: normal
severity: normal
status: open
title: Convert test_bz2 to use tempfile
type: behavior
versions: Python 3.8

___
Python tracker 
<https://bugs.python.org/issue34239>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34195] test_nt_helpers fails with case difference in drive letter

2018-07-25 Thread Tim Golden


Tim Golden  added the comment:


New changeset ff64add8d4be2e37c552ba702f629b0b6639cd33 by Tim Golden in branch 
'master':
bpo-34195: Fix case-sensitive comparison in test_nt_helpers (GH-8448)
https://github.com/python/cpython/commit/ff64add8d4be2e37c552ba702f629b0b6639cd33


--

___
Python tracker 
<https://bugs.python.org/issue34195>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34195] test_nt_helpers fails with case difference in drive letter

2018-07-25 Thread Tim Golden


Tim Golden  added the comment:

Test fixed to ignore case and volume differences between paths

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 
<https://bugs.python.org/issue34195>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34195] test_nt_helpers fails with case difference in drive letter

2018-07-24 Thread Tim Golden


Change by Tim Golden :


--
keywords: +patch
pull_requests: +7970
stage: needs patch -> patch review

___
Python tracker 
<https://bugs.python.org/issue34195>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34195] test_nt_helpers fails with case difference in drive letter

2018-07-23 Thread Tim Golden


Tim Golden  added the comment:

I think I've got down to the determining factor. For info:

PYTHONHOME has nothing to do with it: the same thing happens if I cd into 
PCBuild\win32 and run python_d.exe directly

For historical reasons the directory in which I'm building 
(c:\work-in-progress) is actually a junction to c:\users\\work-in-progress. 
There is some commentary in the API docs about traversing junctions, so 
presumably that's special-cased in some way which results in an uppercase drive 
letter.

If I rebuild in, eg, c:\temp which is a normal directory, I don't see the 
uppercase conversion. So, while I still need to fix the underlying test to be 
case-insensitive, it looks like the Mystery of the Uppercase Drive Letter is at 
least mostly solved.

--

___
Python tracker 
<https://bugs.python.org/issue34195>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34195] test_nt_helpers fails with case difference in drive letter

2018-07-23 Thread Tim Golden


Tim Golden  added the comment:

@eryksun almost idly I ran your ctypes code in the built interpreter. As 
written, it produces a lower-case c:\\ as yours did.

But...

Running Debug|Win32 interpreter...
Python 3.8.0a0 (heads/master:7a3056f, Jul 23 2018, 08:23:33) [MSC v.1912 32 bit 
(Intel)] on win32
Type "help", "copyright", "credits" or "license" for more information.
>>> import ctypes, sys
>>>
>>> sys.executable
'c:\\work-in-progress\\python\\cpython\\PCbuild\\win32\\python_d.exe'
>>> kernel32 = ctypes.WinDLL('kernel32', use_last_error=True)
>>> path = (ctypes.c_wchar * 4)()
>>> kernel32.GetVolumePathNameW(sys.executable, path, 4)
1
>>> path.value
'C:\\'
>>>

--

___
Python tracker 
<https://bugs.python.org/issue34195>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34195] test_nt_helpers fails with case difference in drive letter

2018-07-23 Thread Tim Golden


Tim Golden  added the comment:

Thanks, @eryksun. Whatever the reason, it's consistently failing in the way I 
describe. A case-insensitive test is obviously good for that and for the other 
reasons you give, so I'll patch the test anyway.

--

___
Python tracker 
<https://bugs.python.org/issue34195>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34195] test_nt_helpers fails with case difference in drive letter

2018-07-23 Thread Tim Golden


Tim Golden  added the comment:

import nt, sys; assert 
sys.executable.startswith(nt._getvolumepathname(sys.executable))

This code fails only when run from the python.bat as created by 
pcbuild\build.bat. The obvious difference is that the batch file sets 
PYTHONHOME which, presumably, is used to form sys.executable (haven't checked 
the startup code yet).

The docs for GetVolumePathName [*] don't specify that the drive letter of the 
path returned will be upper-case, but it doesn't seem unlikely.

So... it looks as though the test is unduly sensitive to case-differences in 
the face of something like PYTHONHOME which affects the way in which 
sys.executable is formed.

Phew! I'll put a test patch together later...

[*] 
https://docs.microsoft.com/en-us/windows/desktop/api/fileapi/nf-fileapi-getvolumepathnamew

--

___
Python tracker 
<https://bugs.python.org/issue34195>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34195] test_nt_helpers fails with case difference in drive letter

2018-07-23 Thread Tim Golden


New submission from Tim Golden :

>From a fresh build on Win10 with VS2017:

python -munittest -v test.test_ntpath.TestNtpath.test_nt_helpers

gives the following error:

==
FAIL: test_nt_helpers (test.test_ntpath.TestNtpath)
--
Traceback (most recent call last):
  File "c:\work-in-progress\python\cpython\lib\test\test_ntpath.py", line 432, 
in test_nt_helpers
self.assertEqual(drive, nt._getvolumepathname(sys.executable))
AssertionError: 'c:\\' != 'C:\\'
- c:\
? ^
+ C:\
? ^


Ad hoc, it appears that:

`sys.executable` gives a lower-case path while `nt._getvolumepathname` gives an 
upper-case drive letter.

While the test could be trivially fixed, it seems worth investigating a little 
further to see what's happening inside `nt._getvolumepathname`

--
assignee: tim.golden
components: Windows
messages: 322185
nosy: paul.moore, steve.dower, tim.golden, zach.ware
priority: normal
severity: normal
stage: needs patch
status: open
title: test_nt_helpers fails with case difference in drive letter
type: behavior
versions: Python 3.8

___
Python tracker 
<https://bugs.python.org/issue34195>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue30979] the winapi fails to run shortcuts (because considers a shortcut not a valid Win32App)

2017-07-21 Thread Tim Golden

Tim Golden added the comment:

For shell objects such as shortcuts you could use os.startfile which invokes 
ShellExecute under the covers

--

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue30979>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue30731] Use correct executable manifest for windows

2017-06-22 Thread Tim Golden

Changes by Tim Golden <m...@timgolden.me.uk>:


--
components: +Windows
nosy: +paul.moore, steve.dower, tim.golden, zach.ware

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue30731>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue22028] Python 3.4.1 Installer ended prematurely (Windows msi)

2017-06-18 Thread Tim Golden

Tim Golden added the comment:

[Housekeeping] Closing this as fixed. The mimetypes fix is in; the 3.4 
installer is well out of support. If any other issues arise on current 
installers they should be raised as new issues.

--
resolution:  -> fixed
stage:  -> resolved
status: open -> closed

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue22028>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue8631] subprocess.Popen.communicate(...) hangs on Windows

2017-06-18 Thread Tim Golden

Tim Golden added the comment:

I can't reproduce either on 2.7 or on 3.5 with any of the examples shown. 
Closing again as not-a-bug.

--
resolution:  -> not a bug
status: open -> closed
versions:  -Python 2.7, Python 3.4

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue8631>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue30161] Using `with` statement causes dict to start papering over attribute errors

2017-04-25 Thread Tim Golden

Tim Golden added the comment:

I think you're suppressing sys.stderr after the "with". Try a NameError 
or anything.

Alternatively, try a "with" which isn't using sys.stderr

Obviously, the next question is why *that's* happening.

--
nosy: +tim.golden

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue30161>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue29624] Python 3.5.3 x86 web installer cannot install launcher

2017-02-23 Thread Tim Golden

Tim Golden added the comment:

Since the webmaster@ address tends to bear the brunt of these, can I 
make sure I understand the situation?

* The only installers affected are those for x86/32-bit Windows 3.5.3

* By default [I just checked] the launcher checkbox is not checked

* If it *is* checked by the user, the entire install will abort

* If it is left unchecked, the install will succeed and it is then 
possible to run the x64 installer and select only the installer option.

Is there a possibility of producing a repaired installer? And/or should 
we hide that specific set of installers for the moment?

--

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue29624>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue29525] Python 2.7.13 for Windows broken (from prompt)

2017-02-10 Thread Tim Golden

Tim Golden added the comment:

Although I don't remember seeing a crash out as quick as this, common 
causes for this kind of thing are to do with environment variables 
pointing to still-existing or part-existing installations. Can you try:

set PY

from a command prompt, please, to see if any Python-related env vars are 
present. (Typically PYTHONHOME is the culprit)

--

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue29525>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue29037] Python 2.7.13 prints version header and exits immediately on Windows 10 x64

2016-12-28 Thread Tim Golden

Tim Golden added the comment:

Do you have any Python environment variables set?

If you're not sure, try at a command prompt:

SET PY

--

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue29037>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue28365] 3.5.2 syntax issue

2016-10-05 Thread Tim Golden

Tim Golden added the comment:

This sometimes happens when someone copies from a book or a tutorial and
includes as though code the banner header which is only meant to
illustrate the context.

--

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue28365>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue28065] Update Windows build to xz-5.2.2

2016-09-11 Thread Tim Golden

Tim Golden added the comment:

Applies, builds & tests ok for me for Win32 Release build (ie build.bat 
-e) on Win 8.1 x64.

--

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue28065>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue27417] Call CoInitializeEx on startup

2016-06-29 Thread Tim Golden

Tim Golden added the comment:

As it happens, all the code I use which calls CoInitialise[Ex] does so 
with STA. But do I understand correctly that, if you implement this, 
there's no way for me to select MTA? If so I would consider that a major 
drawback.

--

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue27417>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue27305] Crash with "pip list --outdated" on Windows 10 with Python 2.7.12rc1

2016-06-13 Thread Tim Golden

Tim Golden added the comment:

Built 64-bit 2.7 but can't reproduce on tip, 2.7.12rc1 or 2.7.11 tags.

--

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue27305>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue27305] Crash with "pip list --outdated" on Windows 10 with Python 2.7.12rc1

2016-06-13 Thread Tim Golden

Tim Golden added the comment:

The crash is actually happening in Modules/_ssl.c:_get_peer_alt_names.

 >  _ssl.pyd!_get_peer_alt_names(x509_st * certificate)  Line 810 + 0x2 
bytes   C
_ssl.pyd!_decode_certificate(x509_st * certificate)  Line 1187 + 0x8 
bytes   C
_ssl.pyd!PySSL_peercert(PySSLSocket * self, _object * args)  Line 1335  
C

I note that Benjamin committed a leak-fix change a day or so before 
2.7.12rc1 was tagged:

   https://hg.python.org/cpython/rev/66cd109f3f21

As it stands, I can't build 64-bit with my setup and the 32-bit build 
seems fine so it's hard to bisect. I'll try to get a 64-bit build 
working to give better information. (The trace above is from an attached 
debugger).

--

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue27305>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue27305] Crash with "pip list --outdated" on Windows 10 with Python 2.7.12rc1

2016-06-13 Thread Tim Golden

Tim Golden added the comment:

I can reproduce with the download build but not with a freshly-built executable

--

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue27305>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue27305] Crash with "pip list --outdated" on Windows 10 with Python 2.7.12rc1

2016-06-13 Thread Tim Golden

Tim Golden added the comment:

I did wonder about that. It's good that we can reproduce the issue
without pip, but it's probably going to be messy to debug! I've got VS
2008 on this machine but no time at the moment to build & debug.

Don't know if Zach or Steve might be able to jump in. If not, I can
probably try to get to it tomorrow.

--

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue27305>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue27305] Crash with "pip list --outdated" on Windows 10 with Python 2.7.12rc1

2016-06-13 Thread Tim Golden

Tim Golden added the comment:

Thanks, Paul. Adding Benjamin as 2.7 release manager. This looks like a release 
blocker to me.

--
nosy: +benjamin.peterson

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue27305>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue27305] Crash with "pip list --outdated" on Windows 10 with Python 2.7.12rc1

2016-06-13 Thread Tim Golden

Tim Golden added the comment:

James, which installer did you use (just so I can try to reproduce as
closely as possible)?

--

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue27305>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue27305] Crash with "pip list --outdated" on Windows 10 with Python 2.7.12rc1

2016-06-13 Thread Tim Golden

Tim Golden added the comment:

Re-opening at user's request on Paul Moore's advice. He's already nosy so can 
comment here if needed.

It would be good to get independent verification. I'll try to install the rc 
for 2.7.12 to see if I can reproduce.

--
resolution: third party -> 
stage: resolved -> 
status: closed -> open

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue27305>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue27045] Forward slashes in Windows paths

2016-05-17 Thread Tim Golden

Tim Golden added the comment:

The key point here is that if I run the example as given on my Win 8.1 
box, it doesn't work. (The venv I'm using is called nw0).

d:\tim\.venvs>dir nw0\Scripts\activate.bat
  Volume in drive D is New Volume
  Volume Serial Number is 2639-22DA

  Directory of d:\tim\.venvs\nw0\Scripts

30/03/2016  07:45   547 activate.bat
1 File(s)547 bytes
0 Dir(s)  458,354,536,448 bytes free

d:\tim\.venvs>
d:\tim\.venvs>nw0/Scripts/activate.bat
'nw0' is not recognized as an internal or external command,
operable program or batch file.

d:\tim\.venvs>

--

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue27045>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue27045] Forward slashes in Windows paths

2016-05-17 Thread Tim Golden

Tim Golden added the comment:

I haven't tested everywhere but some versions of Windows don't in fact 
accept forward slashes on the cmd.exe command line. Suggest changing to 
backslashes as there's no reason to do otherwise.

--
nosy: +tim.golden

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue27045>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue25444] Py Launch Icon

2015-10-20 Thread Tim Golden

Changes by Tim Golden <m...@timgolden.me.uk>:


--
nosy:  -tim.golden

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue25444>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue25143] 3.5 install fails poorly on Windows XP

2015-09-23 Thread Tim Golden

Tim Golden added the comment:

I'd just bail as early as poss. from the installer. If it's possible to 
detect Windows versions, stick something like "The last version to 
support WinXP is 3.4". If that's too tricky, perhaps something "Your 
system may be unsupported. Please try an earlier version of Python"

--

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue25143>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue25164] Windows default installation path is inconsistent between per-user and system-wide installation

2015-09-23 Thread Tim Golden

Tim Golden added the comment:

I don't feel that strongly, but my preference would be 
"python35[-whatever]" rather than the version with the spaces & the 
dots. Both for ease of use and for some kind of continuity with the 
c:\pythonxy we've had for many years.

--

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue25164>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue24672] shutil.rmtree failes on non ascii filenames

2015-07-20 Thread Tim Golden

Tim Golden added the comment:

Can you confirm whether it also fails if you pass in a unicode string? eg

shutil.rmtree(ufilename.txt)

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24672
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue24432] Upgrade windows builds to use OpenSSL 1.0.2b

2015-07-03 Thread Tim Golden

Tim Golden added the comment:

Zach, is there a write-up in the devguide for how to do this? And/or
could you send me the same email, please?

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24432
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue24537] Py_Initialize unable to load the file system codec

2015-07-02 Thread Tim Golden

Tim Golden added the comment:

I'm not sure why you expect this to work: the Python C API relies on the 
presence of a Python installation to work. It's not, in itself, a means of 
bundling Python. I assume you must have at least had the python .dll present or 
the program wouldn't even have had the initialisation code to run.

Part of Python's startup code needs to load certain modules very early in order 
to, for example, bootstrap the import mechanism and filesystem support which 
needs encodings to be available to decode filenames etc.

If you're still unsure of what the issue is, can I suggest you take this to the 
Python mailing list:

https://mail.python.org/mailman/listinfo/python-list

where there is a much bigger audience of people available to help.

--
resolution:  - not a bug
stage:  - resolved
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24537
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue2528] Change os.access to check ACLs under Windows

2015-05-23 Thread Tim Golden

Tim Golden added the comment:

Thanks for the very thorough review. This isn't going to make it into 
3.5, but I'll rework it in the light of your comments and see if people 
are happy with it in the optional argument variation.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2528
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue22107] tempfile module misinterprets access denied error on Windows

2015-05-22 Thread Tim Golden

Tim Golden added the comment:

That is a possibility which hadn't occurred to me. @eryksun, would you
mind eyeballing the patch over on issue2582? It almost certainly won't
apply cleanly as it's been almost two years since I last refreshed it,
but you can hopefully gauge the intent.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22107
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21916] Create unit tests for turtle textonly

2015-05-21 Thread Tim Golden

Tim Golden added the comment:

Tests failed on Windows probably because of NamedTemporaryFile

--
nosy: +tim.golden

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21916
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21916] Create unit tests for turtle textonly

2015-05-21 Thread Tim Golden

Tim Golden added the comment:

@RDM I'm sitting with Greg at a London Python session and we've run through 
these tests on 3.4/3.5. I know you were reviewing this code at PyCon. Are you 
happy for me to commit from here?

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21916
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue22107] tempfile module misinterprets access denied error on Windows

2015-05-21 Thread Tim Golden

Tim Golden added the comment:

My reluctance to commit the os.access patch is because it will cause 
such a behaviour change in a function which has been pretty stable for a 
long while. It'll certainly be more correct, but at the undoubted 
expense of breaking someone's long-working code.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22107
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21916] Create unit tests for turtle textonly

2015-05-21 Thread Tim Golden

Tim Golden added the comment:

Serhiy's offered a review and we can take it from here. :)

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21916
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue24127] Fatal error in launcher: Job information querying failed

2015-05-05 Thread Tim Golden

Tim Golden added the comment:

To eliminate pip from the equation, can you just try running: py on its own 
command line?

Also: what platform are you on? Win7? Win8.1? 32-bit or 64-bit? Are you running 
in an unusually restrictive user environment?

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24127
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue24005] Documentation Error: Extra line Break

2015-04-30 Thread Tim Golden

Tim Golden added the comment:

Jaivish Kothari,

Thanks for making the effort to contribute. Can I suggest you have a
look at the Core Mentorship site:

  http://pythonmentors.com/

and perhaps join the Core Mentorship list:

  http://mail.python.org/mailman/listinfo/core-mentorship

TJG

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24005
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue24035] When Caps Locked, Shift + alpha-character still displayed as uppercase

2015-04-23 Thread Tim Golden

Tim Golden added the comment:

Perhaps unsurprisingly, I can't reproduce this on Python 2.7.9 32-bit running 
on Win7 Home Premium. 

Python doesn't handle CapsLock/Shift interaction directly: it just gets what it 
gets from the underlying OS or framework. So I'm at a loss to know what might 
cause the effect you're seeing in so particular a way as to affect one version 
of Python in one i/o framework but not another.

Can you reproduce the situation on a different machine?

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24035
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue12712] weave build_tools library identification

2015-04-20 Thread Tim Golden

Tim Golden added the comment:

I can't see anything here which is clearly a Python bug. If the OP or anyone 
else cares to come back (after more than 4 years!) with a clearly-reproducible 
problem I'm happy to revisit.

I apologise for waking up this issue after so long; we really should have 
closed it within days...

--
resolution:  - not a bug
stage:  - resolved
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12712
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue24005] Documentation Error: Extra line Break

2015-04-19 Thread Tim Golden

Tim Golden added the comment:

One small thing to bear in mind is that the existing code (ie with the extra 
linefeed) raises an IndentationError if cut-and-pasted into the interactive 
interpreter; with the OP's change, it succeeds. Might not have been their 
intention, but certainly is the case.

(Doesn't make it a bug, as such, but makes it more than a stylistic difference 
of opinion).

--
nosy: +tim.golden

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24005
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue24005] Documentation Error: Extra line Break

2015-04-19 Thread Tim Golden

Tim Golden added the comment:

(Laughs). I admit, I was so close to the trees, I missed the fact that 
the doc is, as you say, a What's New, and for Python 2.4. Agree that to 
change this now would be somewhat ludicrous.

If some similar patch were proposed to some more current, relevant 
document I'd still be at least open to the change proposed for the 
reasons I gave but let's close this one now.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24005
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23970] Update distutils.msvccompiler for VC14

2015-04-15 Thread Tim Golden

Tim Golden added the comment:

Adding Paul Moore as he's essentially the intersection between distutils  
Windows

--
nosy: +paul.moore

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23970
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23452] Build errors using VS Express 2013 in win32 mode

2015-04-12 Thread Tim Golden

Tim Golden added the comment:

Well, in the interests of due diligence, I checked out  built each of the four 
flavours (32/64 Release/Debug) independently and without any errors. I then 
rebuilt each with the wrong Platform (ie for Win32 in the x64 directory and 
vice versa) without cleaning first and also without error.

So I'm going to close this on the ground that we can't reproduce it. If someone 
can come up with a recipe for reproducing the problem we can re-open (or start 
a new issue).

--
resolution:  - works for me
stage:  - resolved
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23452
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21411] Enable Treat Warning as Error on 32-bit Windows

2015-04-09 Thread Tim Golden

Tim Golden added the comment:

Sounds good to me. It's really a question as to the point where
practicality beats purity...

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21411
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23861] Make stdprinter use DebugOutputString when no stdout/stderr available

2015-04-04 Thread Tim Golden

Tim Golden added the comment:

Are we talking about re-implementing StdPrinter in terms of 
OutputDebugString? (Either always, on Windows, or as a fallback?)

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23861
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23856] build.bat -e shouldn't also build

2015-04-03 Thread Tim Golden

New submission from Tim Golden:

PCBuild\build.bat takes an argument of -e to pull in external libraries. 

Either by accident or by design the main build will run in addition. However if 
you'd run pcbuild -e simply to pull in externals, you might not have specified 
extra build params, such as -d or -p x64.

The attached patch naively drops out after get_externals has been called; other 
possibilities might include carrying on if -e was not the only parameter.

--
components: Windows
files: build-externals.patch
keywords: patch
messages: 239957
nosy: steve.dower, tim.golden, zach.ware
priority: normal
severity: normal
stage: patch review
status: open
title: build.bat -e shouldn't also build
type: behavior
versions: Python 3.5
Added file: http://bugs.python.org/file38813/build-externals.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23856
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23856] build.bat -e shouldn't also build

2015-04-03 Thread Tim Golden

Tim Golden added the comment:

Fair enough

--
resolution:  - not a bug
stage: patch review - resolved
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23856
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21319] WindowsRegistryFinder never added to sys.meta_path

2015-04-02 Thread Tim Golden

Tim Golden added the comment:

Turns out to be non-issue after all! I was working through the import code for 
other reasons and noticed that the WindowsRegistryFinder was there. I'll spare 
you the complications of debugging the _bootstrap part of import, but basically 
the code in _bootstrap.py:_setup loads the nt module directly instead of 
having it masquerade as os as it normally does. Therefore os.__name__ is 
indeed nt and the WindowsRegistryFinder is added to sys.meta_path

--
resolution:  - works for me
stage: test needed - resolved
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21319
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21319] WindowsRegistryFinder never added to sys.meta_path

2015-03-25 Thread Tim Golden

Tim Golden added the comment:

I think they stopped using them a while back in favour of a pywin32.pth
file.

I don't think I even knew you could use the registry for sys.path.

If no-one's shouted since the changes to importlib (which was 3.3?) I
think we can quietly drop this and hope no-one notices...

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21319
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21319] WindowsRegistryFinder never added to sys.meta_path

2015-03-25 Thread Tim Golden

Tim Golden added the comment:

Adding Mark Hammond in case I'm wrong about the (lack of) impact on pywin32

--
nosy: +mhammond

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21319
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23765] Remove IsBadStringPtr calls in ctypes

2015-03-24 Thread Tim Golden

Tim Golden added the comment:

Unless someone comes back who remembers what the ulterior motive was: I 
agree; remove the check and just the crash happen.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23765
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue22028] Python 3.4.1 Installer ended prematurely (Windows msi)

2015-03-09 Thread Tim Golden

Tim Golden added the comment:

This has come up again in issue23604. Steve, please apply your patch. I think 
it should go against 2.7, 3.4  3.5 especially since all those versions now 
ship with ensurepip.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22028
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23604] Python 3.4 and 2.7 installation no Script folder and no pip installed

2015-03-09 Thread Tim Golden

Tim Golden added the comment:

This is a duplicate of issue22028. 

Daiyue Weng: to move forward, can you apply the fix referred to in this post:

https://mail.python.org/pipermail/python-list/2015-January/696688.html

(ie the removing corrupted keys section from 
http://www.swarley.me.uk/blog/2014/04/23/python-pip-and-windows-registry-corruption/).

Steve: if you can, please commit your change from issue22028; I just don't have 
the time at the moment to run up a clone and test it, but it looks safe to me.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23604
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23524] Use _set_thread_local_invalid_parameter_handler in posixmodule

2015-02-27 Thread Tim Golden

Tim Golden added the comment:

The problem is that this isn't an area I'm particularly familiar with
(either in Python nor in Windows) so I need time to ramp up my awareness
of what Steve's proposing plus then assessing the change. I'll try...
but I rather hope Zach gets there first!

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23524
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue22107] tempfile module misinterprets access denied error on Windows

2015-02-17 Thread Tim Golden

Tim Golden added the comment:

And, just to be clear to Serhiy who I know doesn't use Windows,
os.access really is a worthless function in its present form: worse,
even, because it can be misleading. I have a long-standing patch to
convert it to use AccessCheck but I've never quite had the guts to
commit it because I fear the breakage would be too great.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22107
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23465] Implement PEP 486 - Make the Python Launcher aware of virtual environments

2015-02-15 Thread Tim Golden

Changes by Tim Golden m...@timgolden.me.uk:


--
components: +Windows
nosy: +tim.golden, zach.ware

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23465
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23463] Incorrect behaviour when opening files containing colons on Windows

2015-02-14 Thread Tim Golden

Changes by Tim Golden m...@timgolden.me.uk:


--
resolution:  - not a bug
stage:  - resolved
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23463
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23463] Incorrect behaviour when opening files containing colons on Windows

2015-02-14 Thread Tim Golden

Tim Golden added the comment:

Colons are valid in filenames to introduce Alternate Data Stream:

https://msdn.microsoft.com/en-us/library/cc422524.aspx

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23463
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue17023] Subprocess does not find executable on Windows if it is PATH with quotes

2015-02-08 Thread Tim Golden

Changes by Tim Golden m...@timgolden.me.uk:


--
resolution:  - wont fix
stage:  - resolved
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17023
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



  1   2   3   4   5   6   7   >