[issue11754] Check calculated constants in test_string.py
chalmer_lowe added the comment: Discussed with David Murray at PyCon Sprints 2015. Considered the fact that to preserve backwards compatibility, it seems important that rather than a) merely checking for the presence of each constant string (as the test does now) OR b) checking for each desired character (regardless of order) as noted in msg221766 the tests should check for the exact strings that have historically been published in Python. Doing so seems to be the right path to ensure that: a) the strings exist AND b) the strings have not inadvertently changed. -- nosy: +chalmerlowe Added file: http://bugs.python.org/file38956/issue11754_patch.txt ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11754 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11754] Check calculated constants in test_string.py
chalmer_lowe added the comment: Based on review comments, in order to reduce unnecessary redundancy in the tests: - composed later strings from previously defined substrings, where it made sense to do so. -- Added file: http://bugs.python.org/file38975/issue11754_patch_2.txt ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11754 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
