[issue10324] Modules/binascii.c: simplify expressions

2010-11-09 Thread Senthil Kumaran 

Senthil Kumaran orsent...@gmail.com added the comment:

At first, I was worried if this simplification would cause any harm to  
readability of the algorithm. Fortunately, it didn't.
Committed in r86357.

--
nosy: +orsenthil
resolution:  - fixed
stage: commit review - committed/rejected
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10324
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue10324] Modules/binascii.c: simplify expressions

2010-11-06 Thread Nicolas Kaiser 

Nicolas Kaiser ni...@nikai.net added the comment:

Sorry, found it - with patched builds of Python 2.6.5 and 3.1.2:

python2.6 test_binascii.py
test_base64invalid (__main__.BinASCIITest) ... ok
test_base64valid (__main__.BinASCIITest) ... ok
test_crc32 (__main__.BinASCIITest) ... ok
test_empty_string (__main__.BinASCIITest) ... ok
test_exceptions (__main__.BinASCIITest) ... ok
test_functions (__main__.BinASCIITest) ... ok
test_hex (__main__.BinASCIITest) ... ok
test_qp (__main__.BinASCIITest) ... ok
test_uu (__main__.BinASCIITest) ... ok

--
Ran 9 tests in 0.002s

OK

python3.1 test_binascii.py
test_base64invalid (__main__.BinASCIITest) ... ok
test_base64valid (__main__.BinASCIITest) ... ok
test_crc32 (__main__.BinASCIITest) ... ok
test_empty_string (__main__.BinASCIITest) ... ok
test_exceptions (__main__.BinASCIITest) ... ok
test_functions (__main__.BinASCIITest) ... ok
test_hex (__main__.BinASCIITest) ... ok
test_no_binary_strings (__main__.BinASCIITest) ... ok
test_qp (__main__.BinASCIITest) ... ok
test_uu (__main__.BinASCIITest) ... ok

--
Ran 10 tests in 0.006s

OK

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10324
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue10324] Modules/binascii.c: simplify expressions

2010-11-05 Thread Nicolas Kaiser 

New submission from Nicolas Kaiser ni...@nikai.net:

Hi there!

I noticed two expressions that can be simplified like:
 (a || (!a  b)) = (a || b)

Best regards,
Nicolas Kaiser
---
--- a/Modules/binascii.c2010-11-05 13:21:22.075303326 +0100
+++ b/Modules/binascii.c2010-11-05 13:24:16.986174756 +0100
@@ -1337,8 +1337,7 @@ binascii_b2a_qp (PyObject *self, PyObjec
 ((data[in] == '\t' || data[in] == ' ')  (in + 1 == datalen)) ||
 ((data[in]  33) 
  (data[in] != '\r')  (data[in] != '\n') 
- (quotetabs ||
-(!quotetabs  ((data[in] != '\t')  (data[in] != ' '))
+ (quotetabs || ((data[in] != '\t')  (data[in] != ' ')
 {
 if ((linelen + 3) = MAXLINESIZE) {
 linelen = 0;
@@ -1410,8 +1409,7 @@ binascii_b2a_qp (PyObject *self, PyObjec
 ((data[in] == '\t' || data[in] == ' ')  (in + 1 == datalen)) ||
 ((data[in]  33) 
  (data[in] != '\r')  (data[in] != '\n') 
- (quotetabs ||
-(!quotetabs  ((data[in] != '\t')  (data[in] != ' '))
+ (quotetabs || ((data[in] != '\t')  (data[in] != ' ')
 {
 if ((linelen + 3 )= MAXLINESIZE) {
 odata[out++] = '=';

--
components: Extension Modules
messages: 120490
nosy: nikai
priority: normal
severity: normal
status: open
title: Modules/binascii.c: simplify expressions
type: feature request
versions: Python 3.3

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10324
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue10324] Modules/binascii.c: simplify expressions

2010-11-05 Thread Nicolas Kaiser 

Changes by Nicolas Kaiser ni...@nikai.net:


--
keywords: +patch
Added file: http://bugs.python.org/file19504/python-binascii.diff

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10324
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue10324] Modules/binascii.c: simplify expressions

2010-11-05 Thread Terry J. Reedy 

Terry J. Reedy tjre...@udel.edu added the comment:

As near as I can tell, since  and || are logical rather than bitwise, and 
since the variable reference 'quotetabs' has no side effect, you are correct. 
Have you run the unittest on a patched build?

--
nosy: +terry.reedy
stage:  - commit review
type: feature request - performance
versions: +Python 3.2 -Python 3.3

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10324
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue10324] Modules/binascii.c: simplify expressions

2010-11-05 Thread Nicolas Kaiser 

Nicolas Kaiser ni...@nikai.net added the comment:

That's ./Lib/test/test_unittest.py?

With patched builds of Python 2.6.5 and 3.1.2:

--
Ran 126 tests in 0.015s

OK

--
Ran 187 tests in 0.054s

OK

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10324
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue10324] Modules/binascii.c: simplify expressions

2010-11-05 Thread Terry J. Reedy 

Terry J. Reedy tjre...@udel.edu added the comment:

test_binascii.py

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10324
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com