[issue10379] locale.format() input regression

[Berker Peksag]

Changes by Berker Peksag :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue10379] locale.format() input regression

[Berker Peksag]

Berker Peksag added the comment:


New changeset 6dbdedb0b18a5ca850ab8ce512fda24d5a9d0688 by Berker Peksag in 
branch 'master':
bpo-10379: Add %char examples to locale.format() docs (GH-1145)
https://github.com/python/cpython/commit/6dbdedb0b18a5ca850ab8ce512fda24d5a9d0688


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue10379] locale.format() input regression

[Berker Peksag]

Berker Peksag added the comment:

I think the solution in PR 259 is great, but I still find the documentation a 
little bit vague. I've just opened PR 1145 to add some examples specifiers.

--
nosy: +berker.peksag
stage: needs patch -> patch review
versions: +Python 3.7 -Python 2.7, Python 3.5, Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue10379] locale.format() input regression

[Berker Peksag]

Changes by Berker Peksag :


--
pull_requests: +1276

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue10379] locale.format() input regression

[R. David Murray]

R. David Murray added the comment:

Oops.  I merged the patch without coming back here first :(.  Still getting 
used to the new workflow.

It turns out that format has a parameter, monetary, that isn't supported by 
format_string.  So what we did was add that parameter to format_string and 
deprecate format.

If there is objection to this solution I will revert the merge.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue10379] locale.format() input regression

[R. David Murray]

R. David Murray added the comment:


New changeset 1cf93a76c2cf307f2e1e514a8944864f746337ea by R. David Murray 
(Garvit Khatri) in branch 'master':
bpo-10379: add 'monetary' to format_string, deprecate format
https://github.com/python/cpython/commit/1cf93a76c2cf307f2e1e514a8944864f746337ea


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue10379] locale.format() input regression

[R. David Murray]

Changes by R. David Murray :


--
stage: backport needed -> needs patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue10379] locale.format() input regression

[R. David Murray]

Changes by R. David Murray :


--
stage: needs patch -> backport needed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue10379] locale.format() input regression

[Garvit Khatri]

Changes by Garvit Khatri :


--
pull_requests: +229

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue10379] locale.format() input regression

[Eric V. Smith]

Changes by Eric V. Smith :


--
assignee: docs@python -> 
keywords: +easy
stage:  -> needs patch
type:  -> behavior

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue10379] locale.format() input regression

[Eric V. Smith]

Changes by Eric V. Smith :


--
versions: +Python 3.5, Python 3.6 -Python 3.3, Python 3.4

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue10379] locale.format() input regression

[Wolfgang Maier]

Changes by Wolfgang Maier :


--
nosy: +wolma

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue10379] locale.format() input regression

[Eric V. Smith]

Eric V. Smith added the comment:

Barry meant that the upstream program that triggered this error has been 
changed to call format_string() instead of format(). The bug still exists in 
format().

My suggestion is to have format() be an alias for format_string(). Deprecating 
format() is an optional step, but may not be worth the hassle.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10379
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue10379] locale.format() input regression

[Barry A. Warsaw]

Barry A. Warsaw added the comment:

On Apr 02, 2013, at 11:32 AM, Eric V. Smith wrote:

My suggestion is to have format() be an alias for
format_string(). Deprecating format() is an optional step, but may not be
worth the hassle.

Agreed on both counts.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10379
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue10379] locale.format() input regression

[Eric V. Smith]

Eric V. Smith added the comment:

So I guess the question is: would this be a bug fix and applied to 2.7 and 3.3, 
or just an enhancement for 3.4?

I think it would be a bug fix and thus should be backported. It's not like we'd 
be breaking any working code, unless it was expecting the exception.

--
versions: +Python 3.3, Python 3.4 -Python 3.1, Python 3.2

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10379
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue10379] locale.format() input regression

[Barry A. Warsaw]

Barry A. Warsaw added the comment:

On Apr 02, 2013, at 03:04 PM, Eric V. Smith wrote:

I think it would be a bug fix and thus should be backported. It's not like
we'd be breaking any working code, unless it was expecting the exception.

That would be my preference.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10379
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue10379] locale.format() input regression

[Mark Lawrence]

Mark Lawrence added the comment:

msg120978 The bug has been fixed upstream  Have I missed something as on 
Windows Vista...?

c:\Users\Mark\MyPythonpython
Python 3.3.1rc1 (v3.3.1rc1:92c2cfb92405, Mar 25 2013, 22:39:19) [MSC v.1600 32 
bit (Intel)] on win32
Type help, copyright, credits or license for more information.
 import locale; print(locale.format('%.0f KB', 100))
Traceback (most recent call last):
  File stdin, line 1, in module
  File c:\python33\lib\locale.py, line 193, in format
format specifier, %s not valid) % repr(percent))
ValueError: format() must be given exactly one %char format specifier, '%.0f 
KB' not valid

--
nosy: +BreamoreBoy

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10379
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue10379] locale.format() input regression

[R. David Murray]

R. David Murray rdmur...@bitdance.com added the comment:

Yeah, obviously that language can be improved.  'exactly' was meant to imply 
'nothing but', but clearly it doesn't.

If we want to restore more stringent backward compatibility and allow trailing 
text, it would be possible to make format an alias for format_string.  I'm not 
sure this is a good idea, but it is the most sensible way to restore backward 
compatibility while still fixing the original bug that I can think of.

Or...perhaps there is little need of both 'format' and 'format_string' as 
public APIs, and we could deprecate (without removing) one of them.

On the other hand, I believe the original bug affects the Ubuntu code that 
triggered this report...in other words, absent this fix chances are there would 
eventually have been a bug report against that code that would have 
necessitated that it change to use format_string anyway in order to get the 
correct locale-specific number formatting.

--
nosy: +lemburg

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10379
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue10379] locale.format() input regression

[Łukasz Langa]

Łukasz Langa luk...@langa.pl added the comment:

Please use the deprecation process when possible. That would mean creating an 
alias for the function you want to remove somewhat like this (taken from 
configparser):

def readfp(self, fp, filename=None):
Deprecated, use read_file instead.
warnings.warn(
This method will be removed in future versions.  
Use 'parser.read_file()' instead.,
PendingDeprecationWarning, stacklevel=2
)
self.read_file(fp, source=filename)

--
nosy: +lukasz.langa

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10379
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue10379] locale.format() input regression

[Barry A. Warsaw]

Barry A. Warsaw ba...@python.org added the comment:

The bug has been fixed upstream by replacing .format() with .format_string().  
I'm not sure I understand why there are two different methods - .format() seems 
kind of pointless to me, but then I don't use the locale module enough to say 
what's useful.

For Python 2.7 I think the only thing we can do is to update the docs so that 
the distinction and restrictions are clear.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10379
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue10379] locale.format() input regression

[R. David Murray]

R. David Murray rdmur...@bitdance.com added the comment:

Well, the distinction is that, before the bug fix that caused your issue, the 
'format_string' method would use a regex to extract the % specifiers from the 
input string, and call 'format' to replace that % specifier with a properly 
localized result string.  That is, 'format' was designed to handle a single % 
specifier with no extra text, basically as a helper method for format_string.  
The fact that it didn't reject extra text was, according to an internal 
comment, a defect of the implementation.  (Passing any extra text would cause 
the implementation to fail to do the internationalization that was the entire 
reason for calling it.)

When I fixed the bug I extracted the 'replace a single % specifier' code into 
an internal method, and made the format method live up to what I perceived to 
be its documented interface by rejecting extra input characters so that it 
could safely call the new internal substitution routine.

Now, from the perspective of a *user* of the locale module, I fail to see the 
point in having both 'format' and 'format_string' exposed.  If you want to 
format a single % specifier, just pass it to format_string.  Thus my suggestion 
to make them both do the same thing (to cater to other code that may be calling 
format incorrectly) and then deprecate one of them (presumably format).  

To bad I didn't think of that when I fixed the original bug.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10379
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue10379] locale.format() input regression

[Barry A. Warsaw]

Barry A. Warsaw ba...@python.org added the comment:

On Nov 12, 2010, at 12:15 AM, R. David Murray wrote:

Now, from the perspective of a *user* of the locale module, I fail to see the
point in having both 'format' and 'format_string' exposed.  If you want to
format a single % specifier, just pass it to format_string.  Thus my
suggestion to make them both do the same thing (to cater to other code that
may be calling format incorrectly) and then deprecate one of them (presumably
format).

+1

To bad I didn't think of that when I fixed the original bug.

Dang.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10379
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue10379] locale.format() input regression

[Barry A. Warsaw]

New submission from Barry A. Warsaw ba...@python.org:

@mission[~:1001]% python2.7 -c import locale; print locale.format('%.0f KB', 
100)
Traceback (most recent call last):
  File string, line 1, in module
  File /usr/lib/python2.7/locale.py, line 189, in format
format specifier, %s not valid) % repr(percent))
ValueError: format() must be given exactly one %char format specifier, '%.0f 
KB' not valid
@mission[~:1002]% python2.6 -c import locale; print locale.format('%.0f KB', 
100)
100 KB

--
messages: 120905
nosy: barry
priority: normal
severity: normal
status: open
title: locale.format() input regression
versions: Python 2.7

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10379
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue10379] locale.format() input regression

[Amaury Forgeot d'Arc]

Amaury Forgeot d'Arc amaur...@gmail.com added the comment:

This was changed by issue2522 on purpose; no suffix is allowed in 
locale.format().

--
nosy: +amaury.forgeotdarc, r.david.murray

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10379
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue10379] locale.format() input regression

[Barry A. Warsaw]

Barry A. Warsaw ba...@python.org added the comment:

Okay, so line 187 of locale.py has this test:

if not match or len(match.group())!= len(percent):

the problematic part is the len test.  When format string is '%.0f KB' 
match.group() is '%.0f' but of course percent is the full string.

This seems like a bogus test, since clearly the given input is a valid format 
string.  I'm not sure what the intent of this test is.  The Python 2.6 test is:

if percent[0] != '%':

which is perhaps too naive.

I guess I don't understand why this test is here.  Wouldn't it make more sense 
to either just let any TypeError from _format() to percolate up, or to catch 
that TypeError and transform it into the ValueError?  Why try to replicate the 
logic of str.__mod__()?

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10379
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue10379] locale.format() input regression

[Eric Smith]

Changes by Eric Smith e...@trueblade.com:


--
nosy: +eric.smith

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10379
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue10379] locale.format() input regression

[Barry A. Warsaw]

Barry A. Warsaw ba...@python.org added the comment:

Hmm.  So I guess the answer is to use locale.format_string() instead.  But the 
documentation for locale.format() is not entirely clear about the prohibition 
on trailing text.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10379
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue10379] locale.format() input regression

[Eric Smith]

Eric Smith e...@trueblade.com added the comment:

I agree the documentation isn't terribly clear on what a %char specifier or 
whole format string is.

FWIW, this is also a 3.1 and greater issue.

--
versions: +Python 3.1, Python 3.2

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10379
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue10379] locale.format() input regression

[Eric Smith]

Changes by Eric Smith e...@trueblade.com:


--
assignee:  - d...@python
components: +Documentation
nosy: +d...@python

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10379
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com