[issue10613] gzip._PaddedFile calls getattr with arguments in reversed order
New submission from Charles Harris charlesr.har...@gmail.com: The attached patch fixes the problem. -- components: Library (Lib) files: gzip.patch keywords: patch messages: 123171 nosy: charris44 priority: normal severity: normal status: open title: gzip._PaddedFile calls getattr with arguments in reversed order versions: Python 3.2 Added file: http://bugs.python.org/file19919/gzip.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10613 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10613] gzip._PaddedFile calls getattr with arguments in reversed order
Éric Araujo mer...@netwok.org added the comment: Thanks for the report and patch. Can you add a test, to prevent a regression? -- nosy: +eric.araujo stage: - unit test needed type: - behavior versions: +Python 2.7, Python 3.1 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10613 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10613] gzip._PaddedFile calls getattr with arguments in reversed order
Charles Harris charlesr.har...@gmail.com added the comment: Hi Eric, On Thu, Dec 2, 2010 at 8:12 PM, Ãric Araujo rep...@bugs.python.org wrote: Where are the guidelines for writing python tests? Chuck -- Added file: http://bugs.python.org/file19921/unnamed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10613 ___Hi Eric,brbrdiv class=gmail_quoteOn Thu, Dec 2, 2010 at 8:12 PM, Ãric Araujo span dir=ltrlt;a href=mailto:rep...@bugs.python.org;rep...@bugs.python.org/agt;/span wrote:brblockquote class=gmail_quote style=margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex; br Ãric Araujo lt;a href=mailto:mer...@netwok.org;mer...@netwok.org/agt; added the comment:br br Thanks for the report and patch. Â Can you add a test, to prevent a regression?br br --br nosy: +eric.araujobr stage: Â -gt; unit test neededbr type: Â -gt; behaviorbr versions: +Python 2.7, Python 3.1br divdiv/divdiv class=h5br/div/div/blockquotedivbrWhere are the guidelines for writing python tests?brbrChuck br/divbr/div ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10613] gzip._PaddedFile calls getattr with arguments in reversed order
Changes by Charles Harris charlesr.har...@gmail.com: Removed file: http://bugs.python.org/file19921/unnamed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10613 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10613] gzip._PaddedFile calls getattr with arguments in reversed order
Éric Araujo mer...@netwok.org added the comment: The best way is to learn by imitation. If you prefer to read, there is some guidance on http://www.python.org/dev/workflow/ and http://www.python.org/dev/faq/#how-to-test-a-patch . Concretely, you need to open a file, wrap it in a _PaddedFile and check that attributes like name and closed are good (using assertEqual). You’ll also want to follow patch guidelines at http://www.python.org/dev/patches/ -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10613 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10613] gzip._PaddedFile calls getattr with arguments in reversed order
Charles Harris charlesr.har...@gmail.com added the comment: Looks like this was fixed by r86555 and a test added. I think you can close the ticket. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10613 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10613] gzip._PaddedFile calls getattr with arguments in reversed order
Éric Araujo mer...@netwok.org added the comment: Good catch. I’m tired, I should have noticed that :) -- resolution: - duplicate stage: unit test needed - committed/rejected status: open - closed superseder: - gzip module calls getattr incorrectly ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10613 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
