[issue10860] Handle empty port after port delimiter in httplib
Roundup Robot devn...@psf.upfronthosting.co.za added the comment: New changeset e0499b2b28aa by Petri Lehtinen in branch '2.7': Issue #10860: Skip the new test if HTTPS is not available http://hg.python.org/cpython/rev/e0499b2b28aa New changeset a3939c2f6727 by Petri Lehtinen in branch '3.2': Issue #10860: Skip the new test if HTTPS is not available http://hg.python.org/cpython/rev/a3939c2f6727 New changeset 2dd106799aa9 by Petri Lehtinen in branch 'default': Issue #10860: Skip the new test if HTTPS is not available http://hg.python.org/cpython/rev/2dd106799aa9 -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10860 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10860] Handle empty port after port delimiter in httplib
Roundup Robot devn...@psf.upfronthosting.co.za added the comment: New changeset a3e48273dce3 by Łukasz Langa in branch '2.7': Fixes #10860: Handle empty port after port delimiter in httplib http://hg.python.org/cpython/rev/a3e48273dce3 -- nosy: +python-dev ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10860 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10860] Handle empty port after port delimiter in httplib
Łukasz Langa luk...@langa.pl added the comment: Patch merged. Thanks, Shawn. -- nosy: +lukasz.langa resolution: - fixed stage: patch review - committed/rejected status: open - closed versions: -Python 3.1 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10860 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10860] Handle empty port after port delimiter in httplib
Roundup Robot devn...@psf.upfronthosting.co.za added the comment: New changeset 6ac59218c049 by Łukasz Langa in branch '3.2': Fixes #10860: Handle empty port after port delimiter in httplib http://hg.python.org/cpython/rev/6ac59218c049 New changeset 18dc3811f2b8 by Łukasz Langa in branch 'default': Merged fix for #10860 from 3.2 http://hg.python.org/cpython/rev/18dc3811f2b8 -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10860 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10860] Handle empty port after port delimiter in httplib
Shawn Ligocki sligo...@gmail.com added the comment: Great! Glad it landed :) -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10860 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10860] Handle empty port after port delimiter in httplib
Changes by Senthil Kumaran orsent...@gmail.com: -- assignee: - orsenthil ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10860 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10860] Handle empty port after port delimiter in httplib
Éric Araujo mer...@netwok.org added the comment: From RFC 3986, section 6.2.3 “Scheme-Based Normalization”: The syntax and semantics of URIs vary from scheme to scheme, as described by the defining specification for each scheme. Implementations may use scheme-specific rules, at further processing cost, to reduce the probability of false negatives. For example, because the http scheme makes use of an authority component, has a default port of 80, and defines an empty path to be equivalent to /, the following four URIs are equivalent: http://example.com http://example.com/ http://example.com:/ http://example.com:80/ IOW, the empty string is not an invalid port. The patch fixes that. It includes tests but lacks a doc update. I think it works for https URIs too, but I’d like a test to make sure. -- resolution: invalid - stage: needs patch - patch review status: pending - open versions: +Python 3.3 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10860 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10860] Handle empty port after port delimiter in httplib
Senthil Kumaran orsent...@gmail.com added the comment: The title got reset by my previous response. Changing it again. I vote for closing this report as Invalid as I see that the error message which is raised is proper and meaningful. httplib.InvalidURL: nonnumeric port: '' -- priority: normal - low resolution: - invalid status: open - pending title: urllib2 crashes on valid URL - Handle empty port after port delimiter in httplib ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10860 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10860] Handle empty port after port delimiter in httplib
Éric Araujo mer...@netwok.org added the comment: The redirection is a red hearing, the error is clearly that an empty port after a port delimiter (like in http://host:) breaks httplib. Do you want to work on a patch? Helpful guidelines are found at http://www.python.org/dev/patches/ -- stage: - needs patch title: urllib2 crashes on valid URL - Handle empty port after port delimiter in httplib type: crash - behavior ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10860 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10860] Handle empty port after port delimiter in httplib
Shawn Ligocki sligo...@gmail.com added the comment: Sure, I can work on a patch. Should an empty port default to 80? In other words does http://foo.com/; == http://foo.com:/;? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10860 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10860] Handle empty port after port delimiter in httplib
Éric Araujo mer...@netwok.org added the comment: Yes. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10860 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10860] Handle empty port after port delimiter in httplib
Georg Brandl ge...@python.org added the comment: Except if it's an HTTPS URL :) -- nosy: +georg.brandl ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10860 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10860] Handle empty port after port delimiter in httplib
Shawn Ligocki sligo...@gmail.com added the comment: Here's a patch for 2.7 (from the hg checkout http://code.python.org/hg/branches/release2.7-maint/) How does it look? Apparently there was already a testcase for www.python.org: failing! -- keywords: +patch Added file: http://bugs.python.org/file20308/issue.10860.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10860 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
