[issue10989] ssl.SSLContext(True).load_verify_locations(None, True) segfault

2011-01-29 Thread Georg Brandl

Georg Brandl ge...@python.org added the comment:

It's reviewed by Antoine, so you can commit.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10989
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue10989] ssl.SSLContext(True).load_verify_locations(None, True) segfault

2011-01-29 Thread STINNER Victor

STINNER Victor victor.stin...@haypocalc.com added the comment:

Ok, fixed in r88228. Not backport needed, SSLContext was introduced in Python 
3.2.

--
resolution: accepted - fixed
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10989
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue10989] ssl.SSLContext(True).load_verify_locations(None, True) segfault

2011-01-28 Thread STINNER Victor

STINNER Victor victor.stin...@haypocalc.com added the comment:

Should it be fixed in Python 3.2 or not? (load_verify_locations was introduced 
with SSLContext in Python 3.2)

--
priority: high - release blocker

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10989
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue10989] ssl.SSLContext(True).load_verify_locations(None, True) segfault

2011-01-28 Thread Antoine Pitrou

Antoine Pitrou pit...@free.fr added the comment:

Well, I think you can commit.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10989
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue10989] ssl.SSLContext(True).load_verify_locations(None, True) segfault

2011-01-27 Thread STINNER Victor

STINNER Victor victor.stin...@haypocalc.com added the comment:

Here is a patch including a test.

The test pass on regrtest with -R 3:3: (no reference leak).

--
keywords: +patch
Added file: http://bugs.python.org/file20563/ssl.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10989
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue10989] ssl.SSLContext(True).load_verify_locations(None, True) segfault

2011-01-27 Thread Antoine Pitrou

Antoine Pitrou pit...@free.fr added the comment:

Looks good to me.

--
resolution:  - accepted
stage: needs patch - commit review

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10989
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue10989] ssl.SSLContext(True).load_verify_locations(None, True) segfault

2011-01-23 Thread STINNER Victor

New submission from STINNER Victor victor.stin...@haypocalc.com:

ssl.SSLContext(True).load_verify_locations(None, True) does segfault. 
Py_DECREF(cafile_bytes) in Modules/_ssl.c:1686 should be replaced by 
Py_XDECREF(cafile_bytes).

--
components: Library (Lib)
messages: 126901
nosy: haypo, pitrou
priority: normal
severity: normal
status: open
title: ssl.SSLContext(True).load_verify_locations(None, True) segfault
versions: Python 3.2, Python 3.3

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10989
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue10989] ssl.SSLContext(True).load_verify_locations(None, True) segfault

2011-01-23 Thread Antoine Pitrou

Antoine Pitrou pit...@free.fr added the comment:

Needs a patch + tests :)

--
nosy: +georg.brandl
priority: normal - high
stage:  - needs patch
type:  - crash

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10989
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com