[issue10992] tests failing when run under coverage
Changes by Brett Cannon br...@python.org: -- assignee: - brett.cannon ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10992 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10992] tests failing when run under coverage
Brett Cannon br...@python.org added the comment: The attached patch has all tests passing when run under coverage.py. Most places are flat-out skipped since there is no good way around the tests short of coding up a second set of test values. Plus editing doctests to have optional values is way too painful, so in those cases I just skip the whole doctest. -- Added file: http://bugs.python.org/file20586/issue10992.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10992 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10992] tests failing when run under coverage
Brett Cannon br...@python.org added the comment: Attached is a patch against test_gc that shows what I think should be done for the tests failing because of refcounts. Basically I added a refcount_test decorator to test.support that skips a decorated test if it is not being run under CPython and otherwise unsets the trace function. This should work for all tests that are discovered to fail because of refcounts. -- keywords: +patch Added file: http://bugs.python.org/file20566/test_gc.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10992 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10992] tests failing when run under coverage
Brett Cannon br...@python.org added the comment: Attached is a patch for test_descr. I suspect the __locals__ failures will all be the same; simply skip the test when a trace function is set. And thanks for identifying the cause of the failures, Kristian; helps me make sure I am not misdiagnosing the problem. -- Added file: http://bugs.python.org/file20568/test_descr.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10992 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10992] tests failing when run under coverage
Kristian Vlaardingerbroek kristian.vlaardingerbr...@gmail.com added the comment: Following tests in test_descr.py fail with both methods: test_iter_items test_iter_keys test_iter_values regrtest -T causes the following test to fail aswell: test_slots The test_iter_* tests fail because __locals__ gets added to the namespace of the class it is testing when tracing is enabled. test_slots fails on line 1031 in a section marked Test lookup leaks [SF bug 572567] -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10992 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10992] tests failing when run under coverage
Kristian Vlaardingerbroek kristian.vlaardingerbr...@gmail.com added the comment: Following tests in test_descr.py fail: test_collect_generations (line 261) test_frame (line 183) test_get_count (line 249) These tests count the number of allocations and a trace function can mess this up. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10992 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10992] tests failing when run under coverage
Kristian Vlaardingerbroek kristian.vlaardingerbr...@gmail.com added the comment: test_metaclass has some doctests failing because of the added __locals__. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10992 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10992] tests failing when run under coverage
Kristian Vlaardingerbroek kristian.vlaardingerbr...@gmail.com added the comment: msg127022 applies to test_gc and not test_descr -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10992 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10992] tests failing when run under coverage
Changes by Kristian Vlaardingerbroek kristian.vlaardingerbr...@gmail.com: -- nosy: +Kristian.Vlaardingerbroek ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10992 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10992] tests failing when run under coverage
New submission from Brett Cannon br...@python.org: A bunch of tests fail when run under coverage (trend seems to be refcount tests). This is to act as a meta-issue to keep track of what tests need to be fixed. [fail under both coverage.py and regrtest -T] test_ctypes test_descr test_gc test_metaclass test_pydoc test_trace [coverage.py only] test_genexps test_sys [regrtest -T only] test_array test_importlib test_runpy -- components: Tests messages: 126913 nosy: brett.cannon priority: normal severity: normal stage: needs patch status: open title: tests failing when run under coverage type: behavior versions: Python 3.3 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10992 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
