[issue11045] shutil._make_tarball misses a guard against loggger=None
Éric Araujo mer...@netwok.org added the comment: This was fixed in 615a29295d5f. -- resolution: accepted - fixed stage: needs patch - committed/rejected status: open - closed title: shutil._make_tarball - shutil._make_tarball misses a guard against loggger=None ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11045 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11045] shutil._make_tarball
Éric Araujo mer...@netwok.org added the comment: Arg, #9173 had a patch including a test. Not sure which bug is superseded by the other. -- nosy: +fdrake, paulsmith, v_peter ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11045 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11045] shutil._make_tarball
Changes by Éric Araujo mer...@netwok.org: -- nosy: +eric.araujo ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11045 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11045] shutil._make_tarball
Kelsey kelsey.highto...@gmail.com added the comment: Adding patch to ticket -- keywords: +patch Added file: http://bugs.python.org/file20609/check-logger-is-none.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11045 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11045] shutil._make_tarball
Éric Araujo mer...@netwok.org added the comment: I’ve checked the code and this is the only place where logger.* is not protected by a check for None. There is no unit test, though. My patch adds two things: Make one formatting call lazy (use logging.info(one, two) instead of one % two), lower-case one message for consistent output). If we want to be ultra-conservative, Kelsey’s patch is to be preferred. -- nosy: +georg.brandl Added file: http://bugs.python.org/file20610/fix-11045.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11045 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11045] shutil._make_tarball
Raymond Hettinger rhettin...@users.sourceforge.net added the comment: Please apply right away. -- nosy: +rhettinger resolution: - accepted versions: -Python 3.1, Python 3.2, Python 3.3 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11045 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11045] shutil._make_tarball
Changes by Raymond Hettinger rhettin...@users.sourceforge.net: -- versions: +Python 3.1, Python 3.2 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11045 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11045] shutil._make_tarball
Raymond Hettinger rhettin...@users.sourceforge.net added the comment: For 3.2, just make the one-line fix. I'm worry that a test may be hard to get right and would be a risk in and of itself this late in the release cycle. For the backports, a test would be nice (since we have time to fix a test if it turns out to be problematic). -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11045 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11045] shutil._make_tarball
Éric Araujo mer...@netwok.org added the comment: Indeed, I tried writing a small test to go into the faulty code path, but without calling the private function directly it’s not trivial. I’ll apply the minimal change shortly if there is no opposition from Georg. -- assignee: tarek - eric.araujo status: open - pending ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11045 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11045] shutil._make_tarball
Éric Araujo mer...@netwok.org added the comment: Fixed for 3.2rc2 in r88240. Would it be right to call the internal function in the test? -- priority: high - normal status: pending - open ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11045 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11045] shutil._make_tarball
New submission from Tarek Ziadé ziade.ta...@gmail.com: This line : logger.info(creating %s % archive_dir) should check that logger is not None before being called.. -- assignee: tarek components: Library (Lib) messages: 127300 nosy: tarek priority: high severity: normal status: open title: shutil._make_tarball type: behavior versions: Python 2.7, Python 3.1, Python 3.2, Python 3.3 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11045 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11045] shutil._make_tarball
Tarek Ziadé ziade.ta...@gmail.com added the comment: will fix + write patch -- stage: - needs patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11045 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11045] shutil._make_tarball
Kelsey kelsey.highto...@gmail.com added the comment: Adding stacktrace to ticket -- nosy: +kelseyhightower Added file: http://bugs.python.org/file20574/distutils2_logger.info_bug.txt ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11045 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
