[issue11439] subversion keyword breakage
Roundup Robot devn...@psf.upfronthosting.co.za added the comment: New changeset f15442543e24 by Senthil Kumaran in branch '2.7': Fix closes Issue11439 - Handle the SVN Keywords in 2.7 by replacing them with a high number so that code relying on them does not break. http://hg.python.org/cpython/rev/f15442543e24 New changeset 3e26c9033306 by Senthil Kumaran in branch '3.2': Fix closes Issue11439 Remove the SVN keywords from the code as it is no longer applicable in hg. Patch Contributed by Neil Muller. http://hg.python.org/cpython/rev/3e26c9033306 New changeset 6b9f0a6efaeb by Senthil Kumaran in branch 'default': merge from 3.2 - Fix closes Issue11439 Remove the SVN keywords from the code as it is no longer applicable in hg. Patch Contributed by Neil Muller. http://hg.python.org/cpython/rev/6b9f0a6efaeb -- nosy: +python-dev resolution: - fixed stage: needs patch - committed/rejected status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11439 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11439] subversion keyword breakage
Senthil Kumaran sent...@uthcode.com added the comment: Thanks for the patch, Neil. -- nosy: +orsenthil ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11439 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11439] subversion keyword breakage
Neil Muller drnlmuller+b...@gmail.com added the comment: SVN_Revision.diff replaces the remaining $Revision$ keywords in 2.7 with the values from the last SVN checkout I have. This seems the correct minimal fix for the issues caused by code parsing the revision tag in Python 2. I've left the various other keywords untouched in 2.7 (mainly $Id$ tags) untouched, since they appear to be unused. -- keywords: +patch Added file: http://bugs.python.org/file22578/SVN_Revision.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11439 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11439] subversion keyword breakage
Neil Muller drnlmuller+b...@gmail.com added the comment: This patch removes or replaces a number SVN keywords which aren't buried in comments. I've removed '__revision__ = $Id$' cases - mainly present in distutils - as no-one appears to using these. I've replaced values in tarfile.py, but they can probably be removed as well. -- Added file: http://bugs.python.org/file22579/cleanup_3.3svn_keywords.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11439 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11439] subversion keyword breakage
Stefan Krah stefan-use...@bytereef.org added the comment: Building matplotlib with the 2.7.2 release fails due to this issue: Traceback (most recent call last): File setup.py, line 162, in module if check_for_tk() or (options['build_tkagg'] is True): File /home/stefan/src/matplotlib-1.0.1/setupext.py, line 832, in check_for_tk (Tkinter.__version__.split()[-2], Tkinter.TkVersion, Tkinter.TclVersion)) IndexError: list index out of range Python 2.7.2 (default, Jun 20 2011, 13:19:22) [GCC 4.4.3] on linux2 Type help, copyright, credits or license for more information. import Tkinter Tkinter.__version__ '$Revision$' -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11439 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11439] subversion keyword breakage
Changes by Terry J. Reedy tjre...@udel.edu: -- versions: -Python 2.5 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11439 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11439] subversion keyword breakage
Changes by Skip Montanaro s...@pobox.com: -- nosy: -skip.montanaro ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11439 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11439] subversion keyword breakage
Neil Muller drnlmuller+b...@gmail.com added the comment: This also affects a number of files under Lib, including some that set their version using $Revision$. Since I stumbled on this issue by encountering some code that checks the version string in tkinker breaking, this is an issue that can break existing code. Mercurial does have the keyword extension (http://mercurial.selenic.com/wiki/KeywordExtension) which can provide something similar, but should be some sort of recommended configuration for this and there'll be discrepancies between the id's from svn and mercurial (which may or may not be an issue in practice). find ./Lib -name *.py | xargs grep -n '\$Revision\$' ./Lib/tarfile.py:32:__version__ = $Revision$ ./Lib/pydoc.py:45:__version__ = $Revision$ ./Lib/tkinter/__init__.py:33:__version__ = $Revision$ ./Lib/pickle.py:26:__version__ = $Revision$ # Code version -- nosy: +Neil Muller ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11439 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11439] subversion keyword breakage
Stefan Krah stefan-use...@bytereef.org added the comment: I've also looked at the keyword extension, but for example HeadURL does not seem to be supported by default: http://comments.gmane.org/gmane.comp.version-control.mercurial.devel/31214 -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11439 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11439] subversion keyword breakage
Antoine Pitrou pit...@free.fr added the comment: These verbose numbers don't seem to serve a purpose, they should simply be removed (or replaced by a static, non-moving number higher than the highest svn rev). The keyword extension is generally frown upon, because it introduces complexity, performance issues, and also possibly undesired behaviour. Endly, I don't think this is a critical issue at all. -- priority: critical - normal ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11439 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11439] subversion keyword breakage
Antoine Pitrou pit...@free.fr added the comment: version numbers, not verbose numbers, sorry. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11439 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11439] subversion keyword breakage
New submission from Stefan Krah stefan-use...@bytereef.org: Several files rely on properly substituted subversion keywords. In the cpython clone the keywords aren't substituted. 3.3 example: $ find . -name *.c | xargs grep -n '\$' ./Modules/_bsddb.c:102:static char *rcs_id = $Id$; ./Modules/pyexpat.c:1818:static char *rcsid = $Revision$; ./Modules/getbuildinfo.c:28:#define SVNVERSION $WCRANGE$$WCMODS?M:$ ./Modules/_hotshot.c:1402:static char *rcsid = $Revision$; ./Python/sysmodule.c:1147:static const char headurl[] = $HeadURL$; Python 3.3a0 (default:a69ef22b60e3, Mar 8 2011, 15:40:56) [GCC 4.4.3] on linux2 Type help, copyright, credits or license for more information. import pyexpat pyexpat.__version__ '400s)' 2.5 example: Python does not build without at least changing Include/patchlevel.h and Python/sysmodule.c. -- components: Interpreter Core messages: 130335 nosy: georg.brandl, pitrou, skrah priority: critical severity: normal stage: needs patch status: open title: subversion keyword breakage type: behavior versions: Python 2.5, Python 2.6, Python 2.7, Python 3.1, Python 3.2, Python 3.3 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11439 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11439] subversion keyword breakage
Changes by Skip Montanaro s...@pobox.com: -- nosy: +skip.montanaro ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11439 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11439] subversion keyword breakage
Skip Montanaro s...@pobox.com added the comment: See also issue 11421. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11439 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
