[issue11500] Fixes failing urllib2 proxy tests on OSX

[Ronald Oussoren]

Ronald Oussoren  added the comment:

The patch got merged.

--
resolution:  -> fixed
stage:  -> committed/rejected
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11500] Fixes failing urllib2 proxy tests on OSX

[Roundup Robot]

Roundup Robot  added the comment:

New changeset 682903e066db by Ronald Oussoren in branch '3.1':
Issue #11500: Fixed a bug in the os x proxy bypass code for fully qualified IP 
addresses in the proxy exception list
http://hg.python.org/cpython/rev/682903e066db

New changeset aafb0fed1811 by Ronald Oussoren in branch '3.2':
Issue #11500: Fixed a bug in the os x proxy bypass code for fully qualified IP 
addresses in the proxy exception list.
http://hg.python.org/cpython/rev/aafb0fed1811

New changeset 166dcfc2c0fa by Ronald Oussoren in branch 'default':
Issue #11500: Fixed a bug in the os x proxy bypass code for fully qualified IP 
addresses in the proxy exception list.
http://hg.python.org/cpython/rev/166dcfc2c0fa

New changeset 8f0756010720 by Ronald Oussoren in branch '2.7':
Issue #11500: Fixed a bug in the os x proxy bypass code for fully qualified
http://hg.python.org/cpython/rev/8f0756010720

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11500] Fixes failing urllib2 proxy tests on OSX

[Ronald Oussoren]

Ronald Oussoren  added the comment:

Patch looks great, I'll commit shortly.

Thanks for the patch.

--
nosy: +ronaldoussoren

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11500] Fixes failing urllib2 proxy tests on OSX

[Scott Wilson]

Scott Wilson  added the comment:

This patch adds test coverage to the osx proxy bypass code and includes the 
previous one line patch.

Also adds a test for the proxy_no=* case.

--
Added file: http://bugs.python.org/file21134/proxy_bypass_osx_w_tests.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11500] Fixes failing urllib2 proxy tests on OSX

[Scott Wilson]

Changes by Scott Wilson :


--
nosy: +orsenthil -ronaldoussoren
type:  -> behavior

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11500] Fixes failing urllib2 proxy tests on OSX

[Scott Wilson]

New submission from Scott Wilson :

Fixes a bug in the os x proxy bypass code for fully qualified IP addresses in 
the proxy exception list. 

Tests that fail on os x without this patch:

test_urllib2.HandlerTests.test_proxy_https
test_urllib2.HandlerTests.test_proxy_https_proxy_authorization

Will create a separate issue to improve test coverage in this area.

--
assignee: ronaldoussoren
components: Macintosh
files: proxy_bypass_osx.diff
keywords: patch
messages: 130841
nosy: ronaldoussoren, rswilson
priority: normal
severity: normal
status: open
title: Fixes failing urllib2 proxy tests on OSX
versions: Python 2.6, Python 2.7, Python 3.1, Python 3.2, Python 3.3
Added file: http://bugs.python.org/file21120/proxy_bypass_osx.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com