[issue11557] Increase coverage in logging module
Roundup Robot devnull@devnull added the comment: New changeset 44139ece7a31 by Vinay Sajip in branch 'default': Closes issue #11557: removal of non-idiomatic code in test_logging. http://hg.python.org/cpython/rev/44139ece7a31 -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11557 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11557] Increase coverage in logging module
Changes by Vinay Sajip vinay_sa...@yahoo.co.uk: -- status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11557 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11557] Increase coverage in logging module
Éric Araujo mer...@netwok.org added the comment: I saw this commit pass by and noticed a few instances of non-idiomatic unittest code, like unnecessary lambdas or overuse of assertEqual where other methods would give more useful messages in case of failure. Here’s a patch to better it. -- assignee: vinay.sajip - trentm nosy: +eric.araujo, trentm status: closed - open Added file: http://bugs.python.org/file22245/cleanup-test_logging.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11557 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11557] Increase coverage in logging module
Changes by Éric Araujo mer...@netwok.org: -- assignee: trentm - vinay.sajip nosy: -trentm ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11557 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11557] Increase coverage in logging module
Roundup Robot devnull@devnull added the comment: New changeset 41dc66528c4e by Vinay Sajip in branch 'default': Attempt fix of #11557 by changing teardown logic. http://hg.python.org/cpython/rev/41dc66528c4e -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11557 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11557] Increase coverage in logging module
STINNER Victor victor.stin...@haypocalc.com added the comment: This issue is not fixed: the test does still fail... sometimes. Recent example (AMD64 FreeBSD 8.2 3.x buildbot): -- (...) [283/354] test_logging Warning -- logging._handlerList was modified by test_logging test test_logging failed -- Traceback (most recent call last): File /usr/home/buildbot/buildarea/3.x.krah-freebsd/build/Lib/test/test_logging.py, line 2449, in test_no_kwargs self.assertEqual(logging.root.level, logging.WARNING) AssertionError: 20 != 30 (...) 1 test failed: test_logging (...) Re-running test 'test_logging' in verbose mode (...) test_log (test.test_logging.BasicConfigTest) ... ok test_no_kwargs (test.test_logging.BasicConfigTest) ... FAIL test_stream (test.test_logging.BasicConfigTest) ... ok (...) test_compute_rollover_W0 (test.test_logging.TimedRotatingFileHandlerTest) ... Warning -- logging._handlerList was modified by test_logging test test_logging failed -- Traceback (most recent call last): File /usr/home/buildbot/buildarea/3.x.krah-freebsd/build/Lib/test/test_logging.py, line 2449, in test_no_kwargs self.assertEqual(logging.root.level, logging.WARNING) AssertionError: 20 != 30 ok FAIL: test_no_kwargs (test.test_logging.BasicConfigTest) Traceback (most recent call last): File /usr/home/buildbot/buildarea/3.x.krah-freebsd/build/Lib/test/test_logging.py, line 2449, in test_no_kwargs self.assertEqual(logging.root.level, logging.WARNING) AssertionError: 20 != 30 -- http://www.python.org/dev/buildbot/all/builders/AMD64%20FreeBSD%208.2%203.x/builds/98/steps/test/logs/stdio -- resolution: fixed - ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11557 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11557] Increase coverage in logging module
Roundup Robot devnull@devnull added the comment: New changeset 31bb4788aa1c by Vinay Sajip in branch 'default': Attempt fix of #11557 by changing setup/teardown logic. http://hg.python.org/cpython/rev/31bb4788aa1c -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11557 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11557] Increase coverage in logging module
Roundup Robot devnull@devnull added the comment: New changeset 0494afdc8615 by Vinay Sajip in branch 'default': Attempt fix of #11557 by refining setup/teardown logic. http://hg.python.org/cpython/rev/0494afdc8615 -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11557 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11557] Increase coverage in logging module
Roundup Robot devnull@devnull added the comment: New changeset d93e18e6a3e8 by Vinay Sajip in branch 'default': Attempt fix of #11557 by refining test logic. http://hg.python.org/cpython/rev/d93e18e6a3e8 -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11557 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11557] Increase coverage in logging module
Vinay Sajip vinay_sa...@yahoo.co.uk added the comment: Hi Victor, - Original Message From: STINNER Victor rep...@bugs.python.org To: vinay_sa...@yahoo.co.uk Sent: Wed, 20 April, 2011 11:20:11 Subject: [issue11557] Increase coverage in logging module STINNER Victor victor.stin...@haypocalc.com added the comment: This issue is not fixed: the test does still fail... sometimes. Recent example (AMD64 FreeBSD 8.2 3.x buildbot): Yes, I know it's not fixed yet - I'm still working on it. The annoying thing, it works for me locally, and just fails on some of the buildbots. So I have to make changes, check them in, and wait for the buildbots to pick them up ... if I don't get a solution in the time I have at the moment to work on this, I'll leave the test as skipped so that further failures are avoided, until I get time to look at this again. But I've got some time today, so I hope to make progress on this issue, as it looks as if Natalia couldn't find the time ... Regards, Vinay -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11557 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11557] Increase coverage in logging module
Vinay Sajip vinay_sa...@yahoo.co.uk added the comment: Marking as closed, since d93e18e6a3e8 now appears to pass on all 3.x buildbots. -- resolution: - fixed status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11557 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11557] Increase coverage in logging module
Roundup Robot devnull@devnull added the comment: New changeset 024967cdc2f0 by Victor Stinner in branch 'default': Issue #11557: disable test_logging.test_no_kwargs (fail on most buildbots) http://hg.python.org/cpython/rev/024967cdc2f0 -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11557 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11557] Increase coverage in logging module
STINNER Victor victor.stin...@haypocalc.com added the comment: test_logging.test_no_kwargs fails on AMD64 Snow Leopard 2 3.x, x86 Ubuntu Shared 3.x, sparc solaris10 gcc 3.x, AMD64 Leopard 3.x, x86 XP-4 3.x, x86 Windows7 3.x, x86 Tiger 3.x, PPC Tiger 3.x, ... I disabled the test because it became difficult to see new regressions because of this issue. I'm trying to figure out if my new faulthandler works on not on 3.x buildbots. --- Re-running test 'test_logging' in verbose mode test_flat (test.test_logging.BuiltinLevelsTest) ... ok (...) test_compute_rollover_H (test.test_logging.TimedRotatingFileHandlerTest) ... ok test_compute_rollover_M (test.test_logging.TimedRotatingFileHandlerTest) ... ok test_compute_rollover_MIDNIGHT (test.test_logging.TimedRotatingFileHandlerTest) ... ok test_compute_rollover_S (test.test_logging.TimedRotatingFileHandlerTest) ... ok test_compute_rollover_W0 (test.test_logging.TimedRotatingFileHandlerTest) ... Warning -- logging._handlerList was modified by test_logging test test_logging failed -- Traceback (most recent call last): File /Users/buildbot/buildarea/3.x.parc-snowleopard-1/build/Lib/test/test_logging.py, line 2427, in test_no_kwargs self.assertEqual(logging.root.level, logging.WARNING) AssertionError: 20 != 30 -- nosy: +haypo ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11557 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11557] Increase coverage in logging module
Roundup Robot devnull@devnull added the comment: New changeset c7f7672b70a9 by Vinay Sajip in branch 'default': Closes issue #11557: Added Natalia Bidart's patch to improve test coverage. http://hg.python.org/cpython/rev/c7f7672b70a9 -- nosy: +python-dev ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11557 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11557] Increase coverage in logging module
Vinay Sajip vinay_sa...@yahoo.co.uk added the comment: Closing, thanks for the patch. -- resolution: - fixed status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11557 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11557] Increase coverage in logging module
R. David Murray rdmur...@bitdance.com added the comment: This seems to be causing some issues on the buildbots: http://www.python.org/dev/buildbot/all/builders/AMD64%20Snow%20Leopard%202%203.x/builds/137 -- nosy: +r.david.murray status: closed - open ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11557 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11557] Increase coverage in logging module
Natalia B. Bidart nataliabid...@gmail.com added the comment: I'll work on a fix during next weekend (sooner if I have an open slot). -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11557 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11557] Increase coverage in logging module
Changes by Gennadiy Zlobin gennad.zlo...@gmail.com: -- nosy: +gennad ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11557 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11557] Increase coverage in logging module
Changes by R. David Murray rdmur...@bitdance.com: -- nosy: +vinay.sajip ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11557 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11557] Increase coverage in logging module
Natalia B. Bidart nataliabid...@gmail.com added the comment: Attaching a patch that increases test coverage for logging/__init__.py by 12%. There are still a lot more to do, but this pacth is big enough. -- keywords: +patch Added file: http://bugs.python.org/file21249/pycon-issue11557.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11557 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11557] Increase coverage in logging module
Changes by Vinay Sajip vinay_sa...@yahoo.co.uk: -- assignee: - vinay.sajip ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11557 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11557] Increase coverage in logging module
Changes by Vinay Sajip vinay_sa...@yahoo.co.uk: -- nosy: +drakeol ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11557 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11557] Increase coverage in logging module
New submission from Natalia B. Bidart nataliabid...@gmail.com: Current coverage is: Name Stmts Miss Cover -- Lib/logging/__init__ 73916278% Lib/logging/config 571 9883% Lib/logging/handlers 60132546% -- TOTAL 191158569% -- components: Tests messages: 130983 nosy: nessita priority: normal severity: normal status: open title: Increase coverage in logging module type: resource usage versions: Python 3.3 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11557 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
