[issue11795] Better core dev guidelines for committing submitted patches
R. David Murray rdmur...@bitdance.com added the comment: Note that the older tradition was to *not* mention the contributor in NEWS (NEWS was just technical notes), but to mention them in the checkin message (and What's New, for things that make the What's New cut). However, since we can't edit checkin messages post-commit like we could with SVN, I suppose this new convention (that some people have been following since well before the switchover...) is more practical. -- nosy: +r.david.murray ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11795 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11795] Better core dev guidelines for committing submitted patches
Changes by Nick Coghlan ncogh...@gmail.com: -- resolution: - fixed stage: needs patch - committed/rejected status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11795 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11795] Better core dev guidelines for committing submitted patches
Nick Coghlan ncogh...@gmail.com added the comment: Enhanced committer guidelines: http://hg.python.org/devguide/rev/774fb024b152 -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11795 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11795] Better core dev guidelines for committing submitted patches
Éric Araujo mer...@netwok.org added the comment: +1 -- nosy: +eric.araujo versions: +3rd party ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11795 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11795] Better core dev guidelines for committing submitted patches
New submission from Nick Coghlan ncogh...@gmail.com: Based on a core-mentoring thread, a couple more points for: http://docs.python.org/devguide/committing.html#handling-other-s-code Attribution: - add to Misc/ACKS if they aren't already there (and didn't add themselves in their patch) - mention Patch by x in the NEWS entry and the checkin message* - If I had to substantially change or fix a patch, I'll usually amend the acknowledgement to Initial patch by x *(If I forget to say something in the checkin message, I generally don't worry about it - ACKS and NEWS are the important ones) Contributor Licensing Agreements - it's unlikely bug fixes will require a CLA unless they touch a *lot* of code - new features often get into CLA-preferred territory, as the associated comments, docstrings and documentation are far more likely to reach a copyrightable standard - for sprints, we now just collect CLAs as a matter of course, since there isn't any real inconvenience in doing so -- assignee: ncoghlan components: Devguide messages: 133212 nosy: ncoghlan priority: normal severity: normal status: open title: Better core dev guidelines for committing submitted patches ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11795 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11795] Better core dev guidelines for committing submitted patches
Changes by Nadeem Vawda nadeem.va...@gmail.com: -- nosy: +nadeem.vawda ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11795 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11795] Better core dev guidelines for committing submitted patches
Changes by Alexander Belopolsky belopol...@users.sourceforge.net: -- nosy: +belopolsky ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11795 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11795] Better core dev guidelines for committing submitted patches
Terry J. Reedy tjre...@udel.edu added the comment: I had some of the same questions, so I agree this would be a good addition. -- nosy: +terry.reedy stage: - needs patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11795 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
