[issue11797] 2to3 does not correct reload
R. David Murray added the comment: Since this patch was applied, imp.reload has been deprecated in favor of importlib.reload. I don't know how we handle differences between python3 versions...is there anything that should be done here, or do we just use imp.reload even though it is deprecated in 3.4? -- nosy: +r.david.murray ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11797 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11797] 2to3 does not correct reload
Roundup Robot added the comment: New changeset 3576c0c6f860 by Benjamin Peterson in branch 'default': add fixer for reload() - imp.reload() (closes #11797)\n\nPatch by Laurie Clark-Michalek and Berker Peksag http://hg.python.org/cpython/rev/3576c0c6f860 -- nosy: +python-dev resolution: - fixed stage: test needed - committed/rejected status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11797 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11797] 2to3 does not correct reload
Berker Peksag added the comment: Could you try to share could with fix_intern? Maybe by moving some things to fixer_utils. Thanks for the suggestion. Here's a new patch. I'm not sure the name of the helper is correct. -- Added file: http://bugs.python.org/file28222/issue11797_v2.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11797 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11797] 2to3 does not correct reload
Changes by Arfrever Frehtes Taifersar Arahesis arfrever@gmail.com: -- nosy: +Arfrever ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11797 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11797] 2to3 does not correct reload
Benjamin Peterson added the comment: Thanks for the patch. Could you try to share could with fix_intern? Maybe by moving some things to fixer_utils. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11797 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11797] 2to3 does not correct reload
Berker Peksag added the comment: Here's a patch that adds tests and updates the documentation. -- nosy: +berker.peksag Added file: http://bugs.python.org/file28084/issue11797.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11797 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11797] 2to3 does not correct reload
Mark Lawrence added the comment: Please find attached a new file with the copyright notice removed. Would someone like to review it please. -- nosy: +BreamoreBoy Added file: http://bugs.python.org/file27875/fix_reload.py ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11797 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11797] 2to3 does not correct reload
Éric Araujo added the comment: FixIntern → FixReload -- stage: - patch review versions: +Python 2.7, Python 3.2, Python 3.3, Python 3.4 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11797 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11797] 2to3 does not correct reload
Éric Araujo added the comment: More importantly, tests would be great. -- stage: patch review - test needed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11797 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11797] 2to3 does not correct reload
Georg Brandl ge...@python.org added the comment: I sure didn't have anything to do with that file :) -- nosy: +georg.brandl ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11797 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11797] 2to3 does not correct reload
Laurie Clark-Michalek bluepepp...@archlinux.us added the comment: Ah, that's my fault. As I mentioned, I simply replaced sys with imp and intern with reload from fix_intern.py. Seeing as the vast majority of the file was not modified, I didn't bother to change the copyright notices. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11797 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11797] 2to3 does not correct reload
Éric Araujo mer...@netwok.org added the comment: File looks good, although I’m not sure about the “Copyright 2006 Georg Brandl” line. I also don’t know if stable branches can get this fix. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11797 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11797] 2to3 does not correct reload
Torsten Landschoff t.landsch...@gmx.net added the comment: The other use case I see is to reload a module during debugging after changing the code. This is especially useful for big GUI applications. -- nosy: +torsten ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11797 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11797] 2to3 does not correct reload
Changes by Éric Araujo mer...@netwok.org: -- nosy: +eric.araujo ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11797 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11797] 2to3 does not correct reload
Changes by Éric Araujo mer...@netwok.org: -- assignee: - benjamin.peterson nosy: +benjamin.peterson ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11797 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11797] 2to3 does not correct reload
New submission from Miki Tebeka miki.teb...@gmail.com: The following code is not changed by 2to3:: import os reload(os) reload has moved to the imp module. -- components: 2to3 (2.x to 3.0 conversion tool) messages: 133223 nosy: tebeka priority: normal severity: normal status: open title: 2to3 does not correct reload ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11797 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11797] 2to3 does not correct reload
Raymond Hettinger raymond.hettin...@gmail.com added the comment: This should get fixed, but I'm *really* curious about what kind of code actually needs to do this ;-) -- keywords: +easy nosy: +rhettinger type: - behavior ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11797 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11797] 2to3 does not correct reload
Laurie Clark-Michalek bluepepp...@archlinux.us added the comment: Find a fixer for this attached. I really just did sed 's/intern/reload' fix_intern.py fix_reload.py, but it seems to work. I didn't write any tests (I couldn't seem to find any for any other fixers). -- keywords: +patch nosy: +BluePeppers Added file: http://bugs.python.org/file21568/fix_reload.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11797 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11797] 2to3 does not correct reload
Miki Tebeka miki.teb...@gmail.com added the comment: Raymond: Sometimes I store configuration in Python files and would like to reload the configuration. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11797 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11797] 2to3 does not correct reload
Raymond Hettinger raymond.hettin...@gmail.com added the comment: Miki: That's a really great use case. Thanks. -- priority: normal - high ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11797 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11797] 2to3 does not correct reload
Changes by Ezio Melotti ezio.melo...@gmail.com: -- nosy: +ezio.melotti ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11797 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11797] 2to3 does not correct reload
Changes by Jesús Cea Avión j...@jcea.es: -- nosy: +jcea ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11797 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
