[issue11824] freeze.py broken due to ABI flags

[Martin v . Löwis]

Martin v. Löwis added the comment:

Thanks for the patch. Closing this issue as it only deals with the ABI flags; 
the remaining issues with freeze are dealt with elsewhere.

--
nosy: +loewis
resolution:  -> fixed
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11824] freeze.py broken due to ABI flags

[Roundup Robot]

Roundup Robot added the comment:

New changeset 4e37a4a036c6 by Martin v. Löwis in branch '3.4':
Issue #11824: Consider ABI tags in freeze. Patch by Meador Inge.
http://hg.python.org/cpython/rev/4e37a4a036c6

New changeset 1b6fc88ae3f5 by Martin v. Löwis in branch 'default':
Merge 3.4: Issue #11824: Consider ABI tags in freeze. Patch by Meador Inge.
http://hg.python.org/cpython/rev/1b6fc88ae3f5

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11824] freeze.py broken due to ABI flags

[Meador Inge]

Meador Inge added the comment:

I don't think the current patch is correct.  It breaks the usage of `freeze.py 
-p $path` since LIBDIR and LIBRARY are blindly used.

Maybe something like the attached that respects -p and -P can be used instead?

As for the testing, I think a reasonable solution to get started with is to add 
some buildbot runs that automate the hello.py freeze on various hosts.  That 
will give us some basic coverage and then more tests can be added over time if 
need be.  I would be happy to help set that up (with given guidance on how to 
access the buildbots).

Even with the attached patch I still can't fully build (on OS X 10.7.5) because 
of issue16047:

Undefined symbols for architecture x86_64:
  "_PyInit__imp", referenced from:
  __PyImport_Inittab in config.o
ld: symbol(s) not found for architecture x86_64

I will take a look at that issue next.

--
assignee:  -> meador.inge
Added file: http://bugs.python.org/file28519/issue11824-0.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11824] freeze.py broken due to ABI flags

[Arfrever Frehtes Taifersar Arahesis]

Changes by Arfrever Frehtes Taifersar Arahesis :


--
nosy: +Arfrever

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11824] freeze.py broken due to ABI flags

[Meador Inge]

Changes by Meador Inge :


--
nosy: +meador.inge

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11824] freeze.py broken due to ABI flags

[Jesús Cea Avión]

Jesús Cea Avión  added the comment:

Ping!

--
nosy: +jcea

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11824] freeze.py broken due to ABI flags

[Antoine Pitrou]

Antoine Pitrou  added the comment:

Barry?

Additionally, if would be nice if we got some tests for the "freeze" tool, 
otherwise I fear we will keep breaking it.

--
nosy: +pitrou
priority: normal -> high
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11824] freeze.py broken due to ABI flags

[Éric Araujo]

Changes by Éric Araujo :


--
nosy: +barry, eric.araujo

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11824] freeze.py broken due to ABI flags

[Andreas Stührk]

New submission from Andreas Stührk :

The recent addition of ABI flags broke the freeze tool as it doesn't construct 
the paths to required files correctly any longer. The attached patch fixes the 
issue for me, but I'm not too sure that I used the right config values.

--
components: Demos and Tools
files: freeze.patch
keywords: patch
messages: 133495
nosy: Trundle
priority: normal
severity: normal
status: open
title: freeze.py broken due to ABI flags
type: behavior
versions: Python 3.2, Python 3.3
Added file: http://bugs.python.org/file21609/freeze.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com