[issue12018] No tests for ntpath.samefile, ntpath.sameopenfile
R. David Murray added the comment: Given that several comments say this should be done, and your analysis indicates it is done, I think it should be safe to close it :) Thanks for the nudge. -- nosy: +r.david.murray resolution: - fixed stage: test needed - resolved status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12018 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12018] No tests for ntpath.samefile, ntpath.sameopenfile
Francis MB added the comment: Can this issue be closed? IMHO it's not clear what still needs to be done. The patch seems to be there already. Thanks in advance! -- nosy: +francismb ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12018 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12018] No tests for ntpath.samefile, ntpath.sameopenfile
Mark Lawrence added the comment: Presumably the changes made in the default branch referred to in msg179037 will have automatically been carried forward to 3.4 and 3.5. -- nosy: +BreamoreBoy versions: +Python 3.4, Python 3.5 -Python 3.2, Python 3.3 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12018 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12018] No tests for ntpath.samefile, ntpath.sameopenfile
Changes by Serhiy Storchaka storch...@gmail.com: -- components: +Tests -Library (Lib) ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12018 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12018] No tests for ntpath.samefile, ntpath.sameopenfile
Ronald Oussoren added the comment: There are tests for samefile and sameopenfile in test_genericpath.GenericTest which is included by test_ntpath (NtCommonTest subclasses test_genericpath.CommonTest which again subclasses GenericTest). I cannot easily test on Windows (the only windows systems I've easy access to are production boxes using py2.7), but if my analysis is correct this issue can be closed -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12018 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12018] No tests for ntpath.samefile, ntpath.sameopenfile
Brian Curtin added the comment: That's true of the default branch due to some changes I recently made in the implementation of the functions, but we should probably put tests into 3.2/3.3. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12018 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12018] No tests for ntpath.samefile, ntpath.sameopenfile
Changes by Sijin Joseph sijinjos...@gmail.com: -- nosy: -sijinjoseph ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12018 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12018] No tests for ntpath.samefile, ntpath.sameopenfile
Santoso Wijaya santoso.wij...@gmail.com added the comment: Attaching a patch to test a use case for ntpath.samefile (looks like sameopenfile is already tested--or at least a use case of it). -- components: +Library (Lib) keywords: +patch nosy: +santa4nt versions: -Python 3.4 Added file: http://bugs.python.org/file21985/test_samefile.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12018 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12018] No tests for ntpath.samefile, ntpath.sameopenfile
Changes by Sijin Joseph sijinjos...@gmail.com: -- nosy: +sijinjoseph ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12018 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12018] No tests for ntpath.samefile, ntpath.sameopenfile
New submission from Ronald Oussoren ronaldousso...@mac.com: Python 3.2 introduced ntpath.samefile, but the implementation is not tested in test_ntpath.py. The same seems true of ntpath.sameopenfile. As noted in #10684 ntpath.samefile is broken on XP, which would have been caught by unittest. I've committed a fix for that particular bug, but haven't added unittests. -- components: Windows keywords: easy messages: 135307 nosy: ronaldoussoren priority: low severity: normal stage: test needed status: open title: No tests for ntpath.samefile, ntpath.sameopenfile type: behavior versions: Python 3.2, Python 3.3, Python 3.4 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12018 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12018] No tests for ntpath.samefile, ntpath.sameopenfile
Changes by Brian Curtin br...@python.org: -- nosy: +brian.curtin ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12018 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
