[issue12222] All pysetup commands should respect exit codes

[Roundup Robot]

Roundup Robot  added the comment:

New changeset ab125793243f by Éric Araujo in branch 'default':
Fix return code of “pysetup run COMMAND” (closes #1)
http://hg.python.org/cpython/rev/ab125793243f

--
resolution:  -> fixed
stage:  -> committed/rejected
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue12222] All pysetup commands should respect exit codes

[Éric Araujo]

Éric Araujo  added the comment:

I committed my patch, except for one change in the run action.  It returns the 
dist.Distribution instance, which is needed by test_uninstall and not trivial 
to fix.  I tried changing the code to use Distribution and command objects 
directly but suddenly the --prefix option was not respected, so I stopped after 
a few tries.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue12222] All pysetup commands should respect exit codes

[Roundup Robot]

Roundup Robot  added the comment:

New changeset 998566bf7fba by Éric Araujo in branch 'default':
Let all pysetup actions return a meaningful 0 or 1 exit code (#1).
http://hg.python.org/cpython/rev/998566bf7fba

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue12222] All pysetup commands should respect exit codes

[Éric Araujo]

Éric Araujo  added the comment:

BTW, some functions do not explicitly return 0, but this is okay: they will 
return None, which is a boolean false value, which is understood as 0 by 
sys.exit.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue12222] All pysetup commands should respect exit codes

[Éric Araujo]

Éric Araujo  added the comment:

Here’s a patch adding “return 1” after all errors, unifying the use of logging 
and cleaning up a few things (like moving KeyboardInterrupt handling from the 
_run function up to the main function).

--
keywords: +patch
Added file: http://bugs.python.org/file22317/p7g-run-cleanup.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue12222] All pysetup commands should respect exit codes

[Éric Araujo]

Changes by Éric Araujo :


--
dependencies: +pysetup --search should return non-zero when a dist is not 
installed and print a message stating the fact.

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue12222] All pysetup commands should respect exit codes

[Tarek Ziadé]

Tarek Ziadé  added the comment:

fixed install in http://hg.python.org/cpython/rev/ebff46b232ed

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue12222] All pysetup commands should respect exit codes

[Tarek Ziadé]

New submission from Tarek Ziadé :

All actions in packaging.run need to respect a basic exit convention 0/1. 

This is important because pysetup will be used in automated scripts so the 
caller needs to know wether the call failed or succedeed. 

Example: pysetup install project => sys,exit(0 or 1)

--
assignee: tarek
components: Distutils2
messages: 137348
nosy: alexis, eric.araujo, tarek
priority: high
severity: normal
status: open
title: All pysetup commands should respect exit codes
versions: Python 3.3

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com