[issue12239] msilib VT_EMPTY SummaryInformation properties raise an error (suggest returning None)

2017-11-24 Thread Berker Peksag 

Berker Peksag  added the comment:

Thanks for the patch, Mark. I updated the test code and commit it to 3.6 and 
master branches.

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed
versions: +Python 3.6, Python 3.7 -Python 3.4, Python 3.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue12239] msilib VT_EMPTY SummaryInformation properties raise an error (suggest returning None)

2017-11-24 Thread Berker Peksag 

Berker Peksag  added the comment:


New changeset 412f00b839eae2bc07ca08a8e615c3d7dc870646 by Berker Peksag in 
branch '3.6':
[3.6] bpo-12239: Make GetProperty() return None for VT_EMPTY (GH-4539)
https://github.com/python/cpython/commit/412f00b839eae2bc07ca08a8e615c3d7dc870646


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue12239] msilib VT_EMPTY SummaryInformation properties raise an error (suggest returning None)

2017-11-24 Thread Berker Peksag 

Change by Berker Peksag :


--
pull_requests: +4476

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue12239] msilib VT_EMPTY SummaryInformation properties raise an error (suggest returning None)

2017-11-24 Thread Berker Peksag 

Berker Peksag  added the comment:


New changeset 19fb134185ce155bc53f517116fca73093ba55e9 by Berker Peksag in 
branch 'master':
bpo-12239: Make GetProperty() return None for VT_EMPTY (GH-4539)
https://github.com/python/cpython/commit/19fb134185ce155bc53f517116fca73093ba55e9


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue12239] msilib VT_EMPTY SummaryInformation properties raise an error (suggest returning None)

2017-11-24 Thread Berker Peksag 

Change by Berker Peksag :


--
pull_requests: +4473
stage: needs patch -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue12239] msilib VT_EMPTY SummaryInformation properties raise an error (suggest returning None)

2017-11-18 Thread Berker Peksag 

Change by Berker Peksag :


--
nosy: +berker.peksag

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue12239] msilib VT_EMPTY SummaryInformation properties raise an error (suggest returning None)

2015-02-14 Thread Mark Lawrence 

Mark Lawrence added the comment:

Can we have a patch review please.

--
nosy: +BreamoreBoy

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12239
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue12239] msilib VT_EMPTY SummaryInformation properties raise an error (suggest returning None)

2015-02-14 Thread Brian Curtin 

Changes by Brian Curtin br...@python.org:


--
nosy:  -brian.curtin

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12239
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue12239] msilib VT_EMPTY SummaryInformation properties raise an error (suggest returning None)

2014-06-23 Thread Mark Lawrence 

Changes by Mark Lawrence breamore...@yahoo.co.uk:


--
nosy: +loewis, steve.dower
versions: +Python 3.4, Python 3.5 -Python 2.7, Python 3.1, Python 3.2

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12239
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue12239] msilib VT_EMPTY SummaryInformation properties raise an error (suggest returning None)

2011-06-11 Thread Mark Mc Mahon 

Changes by Mark Mc Mahon mtnbikingm...@gmail.com:


--
keywords: +patch
Added file: 
http://bugs.python.org/file22332/support_vt_empty_in_summary_getproperty.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12239
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue12239] msilib VT_EMPTY SummaryInformation properties raise an error (suggest returning None)

2011-06-02 Thread Mark Mc Mahon 

New submission from Mark Mc Mahon mtnbikingm...@gmail.com:

Using some.msi where the first property is VT_EMPTY

Using COM:
 from win32com.client import gencache
 com_lib = gencache.EnsureModule('{000C1092---C000-0046}', 
 409, 1, 0)
 com_msi = com_lib.Installer()
 db = com_msi.OpenDatabase('some.msi', 0)
 si = db.GetSummaryInformation(0)
 repr(si.Property(0))
'None'

Using msilib:
 import msilib
 db = msilib.OpenDatabase(r'some.msi', 0)
 si = db.GetSummaryInformation(0)
 si.GetProperty(0)
Traceback (most recent call last):
  File stdin, line 1, in module
NotImplementedError: result of type 0

I aim to submit a patch that so that SummaryInformation.GetProperty() with a 
type of VT_EMPTY will return None.

--
components: Windows
messages: 137478
nosy: markm
priority: normal
severity: normal
status: open
title: msilib VT_EMPTY SummaryInformation properties raise an error (suggest 
returning None)
versions: Python 3.2

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12239
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue12239] msilib VT_EMPTY SummaryInformation properties raise an error (suggest returning None)

2011-06-02 Thread Brian Curtin 

Changes by Brian Curtin br...@python.org:


--
nosy: +brian.curtin

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12239
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue12239] msilib VT_EMPTY SummaryInformation properties raise an error (suggest returning None)

2011-06-02 Thread Brian Curtin 

Changes by Brian Curtin br...@python.org:


--
stage:  - needs patch
type:  - behavior
versions: +Python 2.7, Python 3.1

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12239
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com