[issue12313] make install misses packaging module

[Vinay Sajip]

Vinay Sajip  added the comment:

It's not packaging-related, but other directories are also missing from 
LIBSUBDIRS:

test/test_email test/test_email/data

IMO it's not ideal to use find(1), as in theory a developer may have some 
directories with matching names in the source build that they don't want 
installed - or would that be a no-no?

Ideally at least one buildbot should be set up to install and then test the new 
installation - I presume this error wasn't caught on the buildbots as they all 
test source builds?

--
nosy: +vinay.sajip

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue12313] make install misses packaging module

[Éric Araujo]

Éric Araujo  added the comment:

> Nice to see my search didn't find this bug. ;)
Do you remember what search terms you tried?

> I already committed a change to install packaging, but you may want to
> revert that and commit the patch in this issue.
I honestly don’t know.  Do we have a policy about using intermediary variables 
(like XMLLIBSUBDIRS) or not?  Can we assume find(1) exists on the system and 
use it?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue12313] make install misses packaging module

[Barry A. Warsaw]

Barry A. Warsaw  added the comment:

Nice to see my search didn't find this bug. ;)

I already committed a change to install packaging, but you may want to revert 
that and commit the patch in this issue.  I'll leave that for you to decide!

--
nosy: +barry

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue12313] make install misses packaging module

[Arfrever Frehtes Taifersar Arahesis]

Changes by Arfrever Frehtes Taifersar Arahesis :


--
nosy: +Arfrever

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue12313] make install misses packaging module

[Éric Araujo]

Éric Araujo  added the comment:

> Also you may want to add some of the packaging test directories to
> those excluded in the calls to compileall.py a little further down in
> the libinstall target.

Ah, good one.  I guess doing this could have prevented 
http://hg.python.org/cpython/rev/9041520be581

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue12313] make install misses packaging module

[Ned Deily]

Ned Deily  added the comment:

Listing all those directories to the Makefile does seem very brittle and will 
certainly be a maintenance hassle.  OTOH, there is something to be said for 
being explicit about what gets installed.  I suppose you could add the find 
step to ./configure and pass the list into the Makefile.  Dunno if that is 
really is a good idea, though.

In any case, if a reminder isn't already there, perhaps one should be added to 
the devguide or packaging docs about this when adding test directories.

Also you may want to add some of the packaging test directories to those 
excluded in the calls to compileall.py a little further down in the libinstall 
target.

--
nosy: +ned.deily

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue12313] make install misses packaging module

[Éric Araujo]

New submission from Éric Araujo :

Here’s a patch adding Lib/packaging subdirectories to Makefile.pre.in.  Because 
of our extensive tests for pypi-related code, the list is huge.  Maybe it 
should use a call to find(1) instead of using a fragile manually-maintained 
list, so I’m asking here.

--
components: Installation
files: add-packaging-makefile.pre.in.diff
keywords: patch
messages: 138096
nosy: eric.araujo
priority: normal
severity: normal
stage: patch review
status: open
title: make install misses packaging module
type: behavior
versions: Python 3.3
Added file: http://bugs.python.org/file22316/add-packaging-makefile.pre.in.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com