[issue12313] make install misses test dirs for packaging and email modules
Vinay Sajip vinay_sa...@yahoo.co.uk added the comment: The changes have been checked in by Barry and David, so I'm closing this issue. -- resolution: - fixed status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12313 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12313] make install misses test dirs for packaging and email modules
Roundup Robot devnull@devnull added the comment: New changeset c9d27c63b45c by R David Murray in branch 'default': #12313: update Makefile.pre.in to account for email tests moving to 'test' dir http://hg.python.org/cpython/rev/c9d27c63b45c -- nosy: +python-dev ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12313 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12313] make install misses test dirs for packaging and email modules
R. David Murray rdmur...@bitdance.com added the comment: Well, regardless of whether or not I understand what's going on, clearly those directories in the makefile needed updating, so I did it. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12313 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12313] make install misses test dirs for packaging and email modules
Changes by Vinay Sajip vinay_sa...@yahoo.co.uk: -- nosy: +r.david.murray title: make install misses packaging module - make install misses test dirs for packaging and email modules ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12313 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12313] make install misses test dirs for packaging and email modules
R. David Murray rdmur...@bitdance.com added the comment: Fixing the missing dirs for email has been on my todo list for a while but obviously hasn't gotten done yet. I talked with Antoine about setting up a buildbot that tested an installed version, but I'm not sure when I'll get around to trying *that* either. And in any case, even that would not have caught the test_email omission, since rergrtest uses filename-based discovery to select the tests to run, so it would not have noticed that test_email was missing. I suppose that is a disadvantage of having regrtest recognize test packages. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12313 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12313] make install misses test dirs for packaging and email modules
Vinay Sajip vinay_sa...@yahoo.co.uk added the comment: Perhaps not in the general case, but I found the missing test_email and test_email/data through running regrtest using an installed Python 3.3. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12313 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12313] make install misses test dirs for packaging and email modules
R. David Murray rdmur...@bitdance.com added the comment: Ah. I wouldn't have expected that. For my information, what was the error you got? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12313 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12313] make install misses test dirs for packaging and email modules
Vinay Sajip vinay_sa...@yahoo.co.uk added the comment: R. David Murray rdmur...@bitdance.com added the comment: Ah. I wouldn't have expected that. For my information, what was the error you got? [ 99/356] test_email test test_email crashed -- Traceback (most recent call last): File regrtest.py, line 1036, in runtest_inner ImportError: No module named 'test_email' From the full test results at https://gist.github.com/1022705/45fa6992c25197a3c9f6281fc645da94dcc5feae N.B. I have now fixed the error in my fork, you can see the change I made here: https://bitbucket.org/vinay.sajip/pythonv/compare/..mirror/cpython#chg-Makefile.pre.in Regards, Vinay Sajip -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12313 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12313] make install misses test dirs for packaging and email modules
R. David Murray rdmur...@bitdance.com added the comment: OK, now I'm really confused. I tried to reproduce this by installing from my checkout into a work dir, and then running regrtest using that installed python, and discovered that test_email and its data directory got copied by the installation process. (There were test failures, so I'll have to work on that...) This is without any mention of test_email in the Makefile I used to do the 'make install'. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12313 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12313] make install misses test dirs for packaging and email modules
Vinay Sajip vinay_sa...@yahoo.co.uk added the comment: OK, now I'm really confused. I tried to reproduce this by installing from my checkout into a work dir, and then running regrtest using that installed python, and discovered that test_email and its data directory got copied by the installation process. (There were test failures, so I'll have to work on that...) This is without any mention of test_email in the Makefile I used to do the 'make install'. That does seem odd. On my pythonv fork (which follows the cpython repo pretty closely), the only current failures are test_lib2to3, test_packaging and test_sysconfig - all of which failures are already the subject of tickets on the tracker. On my system at least, test_email doesn't show up any failures. See the latest version of the test log from the Gist link I posted earlier - the comment also references the failure tickets. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12313 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
