[issue12382] [msilib] Obscure exception message when trying to open a non-existent MSI database

[Berker Peksag]

Berker Peksag  added the comment:

Thank you for your patch, William. I added a test case, a NEWS entry and 
committed it to 3.6 and master branches.

--
components: +Library (Lib)
nosy: +paul.moore, steve.dower, zach.ware
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed
versions: +Python 3.6, Python 3.7 -Python 2.7, Python 3.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue12382] [msilib] Obscure exception message when trying to open a non-existent MSI database

[Berker Peksag]

Berker Peksag  added the comment:


New changeset bfa89b21e119bac7fed4a5decc26f1fff8ec359e by Berker Peksag (Miss 
Islington (bot)) in branch '3.6':
bpo-12382: Make OpenDatabase() raise better exception messages (GH-4528)
https://github.com/python/cpython/commit/bfa89b21e119bac7fed4a5decc26f1fff8ec359e


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue12382] [msilib] Obscure exception message when trying to open a non-existent MSI database

[Roundup Robot]

Change by Roundup Robot :


--
pull_requests: +4472

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue12382] [msilib] Obscure exception message when trying to open a non-existent MSI database

[Berker Peksag]

Berker Peksag  added the comment:


New changeset 4864a619dc1cc9092780ccf5a6327e8abf66133d by Berker Peksag in 
branch 'master':
bpo-12382: Make OpenDatabase() raise better exception messages (GH-4528)
https://github.com/python/cpython/commit/4864a619dc1cc9092780ccf5a6327e8abf66133d


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue12382] [msilib] Obscure exception message when trying to open a non-existent MSI database

[Berker Peksag]

Change by Berker Peksag :


--
pull_requests: +4464
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue12382] [msilib] Obscure exception message when trying to open a non-existent MSI database

[Berker Peksag]

Change by Berker Peksag :


--
nosy: +berker.peksag

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue12382] [msilib] Obscure exception message when trying to open a non-existent MSI database

[William Tisäter]

William Tisäter added the comment:

Found this a simple fix for an annoying and time consuming error. Patched as 
discussed earlier and decided to leave the filename out.

--
components: +Windows -Library (Lib)
keywords: +patch
nosy: +tiwilliam
versions: +Python 3.5
Added file: http://bugs.python.org/file35098/12382_msi-open-error-message.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12382
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue12382] [msilib] Obscure exception message when trying to open a non-existent MSI database

[Martin v . Löwis]

Martin v. Löwis mar...@v.loewis.de added the comment:

I'd add them to msierror, with no inclusion of the file name.

If you want the file name in the exception, you should uniformly apply this to 
all errors in OpenDatabase, and then subclass MSIError to, say, MSIOpenError 
which includes a .filename attribute.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12382
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue12382] [msilib] Obscure exception message when trying to open a non-existent MSI database

[Mark Mc Mahon]

Mark Mc Mahon mtnbikingm...@gmail.com added the comment:

The following two error conditions that can be returned by MsiOpenDatabase do 
not have specific handling:

ERROR_CREATE_FAILED (1631)
The database could not be created.

ERROR_OPEN_FAILED (110)
The database could not be opened as requested.

(the messages are those copied from MSDN).

Should extra cases for these go into the case statement in msierror? or should 
they be handled directly in OpenDatabase.

Does the error text above sound OK - should we add : '%s' % msi_file ?

--
nosy: +markm

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12382
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue12382] [msilib] Obscure exception message when trying to open a non-existent MSI database

[Robin Jarry]

Robin Jarry diabete...@gmail.com added the comment:

This sounds OK as long as the error message is explicit :)

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12382
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue12382] [msilib] Obscure exception message when trying to open a non-existent MSI database

[Robin Jarry]

Robin Jarry diabete...@gmail.com added the comment:

changed the headline of the defect for something more meaningful :)

--
title: [msilib] Ambiguous exception message when trying to open a non existing 
MSI database - [msilib] Obscure exception message when trying to open a 
non-existent MSI database

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12382
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue12382] [msilib] Obscure exception message when trying to open a non-existent MSI database

[Tim Golden]

Changes by Tim Golden m...@timgolden.me.uk:


--
nosy: +markmcmahon, tim.golden

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12382
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com