[issue12442] shutil.disk_usage()
Roundup Robot devn...@psf.upfronthosting.co.za added the comment: New changeset bdb3f0e7e268 by Victor Stinner in branch 'default': Issue #12442: nt._getdiskusage() is now using the Windows Unicode API http://hg.python.org/cpython/rev/bdb3f0e7e268 -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12442 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12442] shutil.disk_usage()
Éric Araujo mer...@netwok.org added the comment: Looks like my message on Rietveld was not received or not read: http://bugs.python.org/review/12442/diff/2951/7664#newcode776 -- nosy: +eric.araujo ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12442 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12442] shutil.disk_usage()
Giampaolo Rodola' g.rod...@gmail.com added the comment: I removed the percent usage from the returned namedtuple hence that comment is no longer necessary. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12442 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12442] shutil.disk_usage()
Éric Araujo mer...@netwok.org added the comment: Ah, excellent! Thanks for the new function. About using assertGreater and friends in tests, as Ezio and I suggested, I have done the change in my working copy and will commit it later. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12442 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12442] shutil.disk_usage()
Roundup Robot devnull@devnull added the comment: New changeset 479973c6aa03 by Éric Araujo in branch 'default': Clean up NEWS entry and tests for shutil.disk_usage (#12442) http://hg.python.org/cpython/rev/479973c6aa03 -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12442 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12442] shutil.disk_usage()
Giampaolo Rodola' g.rod...@gmail.com added the comment: Thanks for the further fixes. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12442 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12442] shutil.disk_usage()
Changes by R. David Murray rdmur...@bitdance.com: -- stage: commit review - committed/rejected ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12442 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12442] shutil.disk_usage()
Giampaolo Rodola' g.rod...@gmail.com added the comment: Agreed. New patch removes the percentage and fixes computations on posix as recommended by Charles-François: free = st.f_bavail * st.f_bsize total = st.f_blocks * st.f_frsize used = (total - st.f_bfree * st.f_bsize) -- Added file: http://bugs.python.org/file22532/diskusage3.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12442 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12442] shutil.disk_usage()
Roundup Robot devnull@devnull added the comment: New changeset 2fc102ebaf73 by Giampaolo Rodola' in branch 'default': Issue #12442: add shutil.disk_usage() http://hg.python.org/cpython/rev/2fc102ebaf73 -- nosy: +python-dev ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12442 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12442] shutil.disk_usage()
Changes by Giampaolo Rodola' g.rod...@gmail.com: -- resolution: - fixed stage: patch review - commit review status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12442 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12442] shutil.disk_usage()
Giampaolo Rodola' g.rod...@gmail.com added the comment: New patch includes: - Py_BEGIN/END_ALLOW_THREADS around GetDiskFreeSpaceEx() call - use of assertGreaterEqual / assertLessEqual when testing the percentage usage - use of hasattr(shutil, 'disk_usage') for skipping the test - extended url reference in the comments -- Added file: http://bugs.python.org/file22519/diskusage2.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12442 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12442] shutil.disk_usage()
Antoine Pitrou pit...@free.fr added the comment: Why do you return a percentage? People can compute that themselves if they want to. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12442 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12442] shutil.disk_usage()
Brian Curtin br...@python.org added the comment: Agreed. I think we should pass on the raw data - how the user wants to format and present that is up to them. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12442 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12442] shutil.disk_usage()
New submission from Giampaolo Rodola' g.rod...@gmail.com: Patch in attachment adds a new disk_usage() function to shutil module which retrieves total, used and free disk space given a certain path plus the percentage usage. See original discussion on python-ideas ml: http://mail.python.org/pipermail/python-ideas/2011-June/010480.htm -- assignee: giampaolo.rodola components: Library (Lib) files: diskusage.patch keywords: needs review, patch messages: 139439 nosy: giampaolo.rodola, pitrou, rhettinger priority: normal severity: normal stage: patch review status: open title: shutil.disk_usage() type: feature request versions: Python 3.3 Added file: http://bugs.python.org/file22517/diskusage.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12442 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12442] shutil.disk_usage()
Changes by Brian Curtin br...@python.org: -- nosy: +brian.curtin ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12442 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12442] shutil.disk_usage()
Giampaolo Rodola' g.rod...@gmail.com added the comment: Typo. It's: http://mail.python.org/pipermail/python-ideas/2011-June/010480.html -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12442 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12442] shutil.disk_usage()
Changes by Ezio Melotti ezio.melo...@gmail.com: -- nosy: +ezio.melotti ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12442 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
