[issue12604] VTRACE macro in _sre.c should use do {} while (0)

[Roundup Robot]

Roundup Robot  added the comment:

New changeset f35514dfadf8 by Senthil Kumaran in branch '2.7':
Fix Issue 12604 - Use a proper no-op macro expansion for VTRACE macro in _sre.c
http://hg.python.org/cpython/rev/f35514dfadf8

New changeset ab028084f704 by Senthil Kumaran in branch '3.2':
3.2 - Fix Issue 12604 - Use a proper no-op macro expansion for VTRACE macro in 
_sre.c
http://hg.python.org/cpython/rev/ab028084f704

New changeset 847afc310190 by Senthil Kumaran in branch 'default':
default - Fix closes Issue 12604 - Use a proper no-op macro expansion for 
VTRACE macro in _sre.c
http://hg.python.org/cpython/rev/847afc310190

--
nosy: +python-dev
resolution:  -> fixed
stage: commit review -> committed/rejected
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue12604] VTRACE macro in _sre.c should use do {} while (0)

[Petri Lehtinen]

Petri Lehtinen  added the comment:

Éric Araujo wrote:
> _sre is a module written in C, not Python; we call that an extension
> module. The Library component is used for Python modules, which are
> found in the Lib directory in a checkout of CPython. See #12711.

Ok, I wasn't aware of this. Thanks.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue12604] VTRACE macro in _sre.c should use do {} while (0)

[Éric Araujo]

Changes by Éric Araujo :


--
stage: patch review -> commit review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue12604] VTRACE macro in _sre.c should use do {} while (0)

[Éric Araujo]

Éric Araujo  added the comment:

_sre is a module written in C, not Python; we call that an extension module.  
The Library component is used for Python modules, which are found in the Lib 
directory in a checkout of CPython.  See #12711.

--
nosy: +eric.araujo

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue12604] VTRACE macro in _sre.c should use do {} while (0)

[Petri Lehtinen]

Petri Lehtinen  added the comment:

Should the component really be extension modules? I don't believe _sre.c is a 
part of the API, and the problem is embedding Python as a whole.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue12604] VTRACE macro in _sre.c should use do {} while (0)

[Éric Araujo]

Changes by Éric Araujo :


--
components: +Extension Modules -Library (Lib)
versions: +Python 3.2, Python 3.3

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue12604] VTRACE macro in _sre.c should use do {} while (0)

[Petri Lehtinen]

Changes by Petri Lehtinen :


--
components: +Build, Library (Lib)
keywords: +needs review
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue12604] VTRACE macro in _sre.c should use do {} while (0)

[Petri Lehtinen]

Petri Lehtinen  added the comment:

Attached a patch against 2.7 that adds the suggested fix.

--
keywords: +patch
nosy: +petri.lehtinen
Added file: http://bugs.python.org/file22718/fix_empty_macro.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue12604] VTRACE macro in _sre.c should use do {} while (0)

[Josh Triplett]

New submission from Josh Triplett :

In _sre.c, the VTRACE macro normally gets defined to nothing.  It later gets 
used as the body of control structures such as "else" without braces, which 
causes many compilers to warn (to catch stray semicolons like "else;").  This 
makes it difficult to compile Python as part of a project which uses -Werror, 
such as GRUB.  Please consider defining VTRACE as do {} while(0) instead, as 
the standard convention for an empty function-like macro with no return value.

--
messages: 140827
nosy: joshtriplett
priority: normal
severity: normal
status: open
title: VTRACE macro in _sre.c should use do {} while (0)
versions: Python 2.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com