[issue12810] Remove check for negative unsigned value in socketmodule.c
Roundup Robot devn...@psf.upfronthosting.co.za added the comment: New changeset 4736e172fa61 by Charles-François Natali in branch 'default': Issue12810: Remove check for negative unsigned value in socketmodule.c. Patch http://hg.python.org/cpython/rev/4736e172fa61 -- nosy: +python-dev ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12810 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12810] Remove check for negative unsigned value in socketmodule.c
Charles-François Natali neolo...@free.fr added the comment: Patch committed. Thanks Joel! -- resolution: - fixed stage: commit review - committed/rejected status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12810 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12810] Remove check for negative unsigned value in socketmodule.c
Charles-François Natali neolo...@free.fr added the comment: Thanks. I'll commit this patch tomorrow. I noticed you didn't indicate your full name: do you mind being listed in Misc/ACKS? -- components: +Extension Modules keywords: +easy nosy: +neologix stage: - commit review type: - behavior versions: +Python 3.3 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12810 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12810] Remove check for negative unsigned value in socketmodule.c
Joel j...@jms.id.au added the comment: My full name is Joel Stanley, and yep, please add me to Misc/ACKS. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12810 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12810] Remove check for negative unsigned value in socketmodule.c
New submission from Joel j...@jms.id.au: fixes the following warning: cpython/Modules/socketmodule.c:1748:74: warning: comparison of unsigned expression 0 is always false [-Wtautological-compare] if (cmsgh == NULL || msg-msg_control == NULL || msg-msg_controllen 0) -- files: bad_unsigned_check.patch keywords: patch messages: 142674 nosy: shenki priority: normal severity: normal status: open title: Remove check for negative unsigned value in socketmodule.c Added file: http://bugs.python.org/file22988/bad_unsigned_check.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12810 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com