[issue12820] Tests for Lib/xml/dom/minicompat.py

[Ezio Melotti]

Ezio Melotti added the comment:

Fixed, thanks for the patches!

--
assignee:  -> ezio.melotti
resolution:  -> fixed
stage: patch review -> committed/rejected
status: open -> closed
type: behavior -> enhancement
versions: +Python 3.4

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue12820] Tests for Lib/xml/dom/minicompat.py

[Roundup Robot]

Roundup Robot added the comment:

New changeset 172f825d7fc9 by Ezio Melotti in branch '3.3':
#12820: add tests for the xml.dom.minicompat module.  Patch by John Chandler 
and Phil Connell.
http://hg.python.org/cpython/rev/172f825d7fc9

New changeset f675083b2894 by Ezio Melotti in branch 'default':
#12820: merge with 3.3.
http://hg.python.org/cpython/rev/f675083b2894

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue12820] Tests for Lib/xml/dom/minicompat.py

[Phil Connell]

Phil Connell added the comment:

I happened to spot this issue languishing, and the markups looked pretty 
straightforward, so I just went ahead and did them.

Updated patch attached.

--
nosy: +pconnell
Added file: http://bugs.python.org/file29698/minicompat_tests_markedup.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue12820] Tests for Lib/xml/dom/minicompat.py

[John Chandler]

John Chandler  added the comment:

Just to let you know I haven't forgotten this! I've been pretty busy recently 
so might be a while before I implement the changes to the patch suggested in 
the code review.

John

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue12820] Tests for Lib/xml/dom/minicompat.py

[John Chandler]

John Chandler  added the comment:

Cool, thanks for the feedback! :-)

I'll make the appropriate changes to the tests and add some coverage for 
defproperty as soon as I can.

John

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue12820] Tests for Lib/xml/dom/minicompat.py

[Sandro Tosi]

Sandro Tosi  added the comment:

Hi, I just left a very light review on rietveld (the 'review' link below). I 
think in the next run you can add the tests for defproperty. Thanks for working 
on code coverage!

--
nosy: +ezio.melotti, sandro.tosi
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue12820] Tests for Lib/xml/dom/minicompat.py

[John Chandler]

New submission from John Chandler :

The Lib/xml/dom/minicompat.py module doesn't appear to have any test coverage, 
probably because it's not the largest or most exciting of modules! :-) I 
therefore attach a patch to add test coverage for the EmptyNodeList and 
NodeList classes. I can add tests for the defproperty function if this patch 
proves acceptable.

The patch adds a new file (Lib/test/test_xml_dom_minicompat.py) and modifies 
one line of an existing file (Lib/test/xmltests.py)

I've used Python 3.3.0a0, courtesy of Brett's devinabox, but should be 
back-portable to older versions of Python.

--
components: Tests
files: minicompat_tests.patch
keywords: patch
messages: 142779
nosy: John.Chandler
priority: normal
severity: normal
status: open
title: Tests for Lib/xml/dom/minicompat.py
type: behavior
versions: Python 3.3
Added file: http://bugs.python.org/file23010/minicompat_tests.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com