[issue1284670] Allow to restrict ModuleFinder to get "direct" dependencies

[Jelle Zijlstra]

Jelle Zijlstra  added the comment:

Mike's fix unfortunately didn't work out.

What are the rules about closing old enhancement requests? modulefinder is an 
old and rarely used package, and I feel like the use case is better served by a 
PyPI package.

--
nosy: +Jelle Zijlstra

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1284670] Allow to restrict ModuleFinder to get "direct" dependencies

[mike mcleod]

Change by mike mcleod :


--
pull_requests: +28450
pull_request: https://github.com/python/cpython/pull/30228

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1284670] Allow to restrict ModuleFinder to get "direct" dependencies

[mike mcleod]

mike mcleod  added the comment:

Minor fix after test.

--
Added file: https://bugs.python.org/file50467/2.html

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1284670] Allow to restrict ModuleFinder to get "direct" dependencies

[mike mcleod]

mike mcleod  added the comment:

I have made the changes as indicated in the diff files. I have tested against 
the latest from my GitHub copy.
The result is:
./python -m test -j0
== CPython 3.11.0a2+ (heads/main:3a91617590, Dec 1 2021, 15:11:41) [GCC 11.2.0]
== Linux-5.13.0-22-generic-x86_64-with-glibc2.34 little-endian
== cwd: /home/dougal/Documents/cpython/build/test_python_300237æ
== CPU count: 8
== encodings: locale=UTF-8, FS=utf-8
...
0:01:34 load avg: 8.77 [221/430/1] test_modulefinder passed
== Tests result: FAILURE ==
409 tests OK.
1 test failed:
test_embed
20 tests skipped:
test_curses test_devpoll test_epoll test_ioctl test_kqueue
test_msilib test_ossaudiodev test_smtpnet test_socketserver
test_startfile test_tix test_tk test_ttk_guionly test_urllib2net
test_urllibnet test_winconsoleio test_winreg test_winsound
test_xmlrpc_net test_zipfile64
Total duration: 5 min 30 sec
Tests result: FAILURE

The first diff is attached. But there was a bug in the code and I will upload 
in next comment.

--
Added file: https://bugs.python.org/file50466/1.html

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1284670] Allow to restrict ModuleFinder to get "direct" dependencies

[mike mcleod]

mike mcleod  added the comment:

Ok, I will work on this soon and make further comments.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1284670] Allow to restrict ModuleFinder to get "direct" dependencies

[Irit Katriel]

Irit Katriel  added the comment:

Mike, from looking at the code the change proposed here is not there, so while 
the patch may not apply cleanly anymore, the commits you mention do not make 
this issue irrelevant.

--
nosy: +iritkatriel

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1284670] Allow to restrict ModuleFinder to get "direct" dependencies

[Ethan Furman]

Change by Ethan Furman :


--
nosy: +ethan.furman

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1284670] Allow to restrict ModuleFinder to get "direct" dependencies

[mike mcleod]

mike mcleod  added the comment:

I would like to help with this issue.

I note the history (using Git Dag) of the modulefinder.py shows that it has 
been modified with changes related here:

Author: Éric Araujo   2011-07-28 22:35:29
Committer: Éric Araujo   2011-07-28 22:35:29
Parent: 867754e3e3c907f87d1bb0282df628deb392cd62 (merge 11164)
Child:  cee6bb549946bb096aa380a49f3b11daf2d8713e (Fix bug I unwittingly added 
in 1521d9837d16 (found by Ezio Melotti))
Branches: main, remotes/origin/3.10, remotes/origin/3.6, remotes/origin/3.7, 
remotes/origin/3.8, remotes/origin/3.9, 
remotes/origin/bpo-45514/deprecate-importlib-resources-legacy, 
remotes/origin/buildbot-custom, remotes/origin/main, remotes/upstream/3.10, 
remotes/upstream/3.6, remotes/upstream/3.7, remotes/upstream/3.8, 
remotes/upstream/3.9, 
remotes/upstream/bpo-45514/deprecate-importlib-resources-legacy, 
remotes/upstream/buildbot-custom, remotes/upstream/main, 
remotes/upstream/windeepfreeze
Follows: v3.2.1
Precedes: v3.3.0a1

Modernize modulefinder module and tests a bit.

The tests don’t use an internal distutils function anymore, and use
regular assertEqual with sorted lists instead of a convoluted manual
diff.

and

Author: Éric Araujo   2011-08-01 14:29:07
Committer: Éric Araujo   2011-08-01 14:29:07
Parent: 1e3a68d36b08cd9d59084a37c8cb6c2d911868ce (Modernize modulefinder module 
and tests a bit.)
Child:  cb66eb0deca1d5cd232f97c76a215ecaab958d30 (Issue #13959: Deprecate 
imp.get_suffixes() for new attributes on)
Branches: main, remotes/origin/3.10, remotes/origin/3.6, remotes/origin/3.7, 
remotes/origin/3.8, remotes/origin/3.9, 
remotes/origin/bpo-45514/deprecate-importlib-resources-legacy, 
remotes/origin/buildbot-custom, remotes/origin/main, remotes/upstream/3.10, 
remotes/upstream/3.6, remotes/upstream/3.7, remotes/upstream/3.8, 
remotes/upstream/3.9, 
remotes/upstream/bpo-45514/deprecate-importlib-resources-legacy, 
remotes/upstream/buildbot-custom, remotes/upstream/main, 
remotes/upstream/windeepfreeze
Follows: v3.2.1
Precedes: v3.3.0a1

Fix bug I unwittingly added in 1521d9837d16 (found by Ezio Melotti)

And the modulefinder.py file has been subsequently modified by another 28 
changes.

So I am wondering if this issue is still relevant?

--
nosy: +mikecmcleod

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1284670] Allow to restrict ModuleFinder to get direct dependencies

[Brett Cannon]

Changes by Brett Cannon br...@python.org:


--
nosy:  -brett.cannon

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1284670
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1284670] Allow to restrict ModuleFinder to get direct dependencies

[Éric Araujo]

Changes by Éric Araujo mer...@netwok.org:


Removed file: http://bugs.python.org/file22686/modulefinder-no-recurse.diff

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1284670
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1284670] Allow to restrict ModuleFinder to get direct dependencies

[Éric Araujo]

Éric Araujo mer...@netwok.org added the comment:

I modernized modulefinder a bit in 1521d9837d16; here’s a refreshed patch.

--
Added file: http://bugs.python.org/file22792/modulefinder-no-recurse.diff

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1284670
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1284670] Allow to restrict ModuleFinder to get direct dependencies

[Éric Araujo]

Éric Araujo mer...@netwok.org added the comment:

I applied the patch, added a test and found a bug.  Here’s my progress so far; 
someone can start from it to write more tests and fix the code.

--
nosy: +misc
Added file: http://bugs.python.org/file22686/modulefinder-no-recurse.diff

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1284670
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1284670] Allow to restrict ModuleFinder to get direct dependencies

[Eric Snow]

Changes by Eric Snow ericsnowcurren...@gmail.com:


--
nosy: +ericsnow

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1284670
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1284670] Allow to restrict ModuleFinder to get direct dependencies

[Éric Araujo]

Éric Araujo mer...@netwok.org added the comment:

The depth parameter idea sounds like YAGNI, so let’s stay with a recurse 
boolean :)

--
assignee:  - eric.araujo
nosy:  -BreamoreBoy, misc_from_metz
stage: unit test needed - patch review
versions: +Python 3.3 -Python 3.2

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1284670
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1284670] Allow to restrict ModuleFinder to get direct dependencies

[Nick Coghlan]

Nick Coghlan ncogh...@gmail.com added the comment:

The generalist in me is inclined to suggest a depth parameter (with depth=1 
equivalent to direct dependencies only, and depth = None meaning all 
dependencies), but I must admit I don't have a concrete use case for the extra 
generality. So the simpler, recurse/don't recurse approach is probably a better 
option (building a depth-limited search on top of the recursion flag wouldn't 
be difficult anyway).

Aside from missing docs and unit test updates, the idea seems sound.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1284670
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1284670] Allow to restrict ModuleFinder to get direct dependencies

[Nick Coghlan]

Nick Coghlan ncogh...@gmail.com added the comment:

Although I do find it a little concerning that there is no mention of 
sys.path_hooks or sys.meta_path in the modulefinder source code. I suspect this 
module only works correctly with vanilla filesystem based imports and can't 
handle anything imported via PEP 302.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1284670
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1284670] Allow to restrict ModuleFinder to get direct dependencies

[Mark Lawrence]

Mark Lawrence breamore...@yahoo.co.uk added the comment:

Anyone interested in this or can it be closed?

--
nosy: +BreamoreBoy
versions: +Python 3.2 -Python 2.7

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1284670
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1284670] Allow to restrict ModuleFinder to get direct dependencies

[Éric Araujo]

Éric Araujo mer...@netwok.org added the comment:

Adding jvr and people interested in import machinery, per Misc/maintainers.rst

Michael, can you refresh your patch against the py3k branch? Please also 
generate a unified diff from the top level of the source distribution, as 
detailed in http://www.python.org/dev/patches/ The feature seems useful to me 
and the patch is straightforward. Tests and doc updates are needed; do you want 
to add them?

Mark, I think that feature requests are never closed just because they’re old; 
they have to be rejected, implemented or obsoleted. (Thank you for all your 
triage work.)

--
nosy: +brett.cannon, eric.araujo, jvr, ncoghlan

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1284670
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1284670] Allow to restrict ModuleFinder to get direct dependencies

[Daniel Diniz]

Changes by Daniel Diniz aja...@gmail.com:


--
keywords: +easy

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1284670
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1284670] Allow to restrict ModuleFinder to get direct dependencies

[Daniel Diniz]

Changes by Daniel Diniz aja...@gmail.com:


--
stage:  - test needed
type:  - feature request
versions: +Python 2.7

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1284670
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com