[issue13032] h2py.py can fail with UnicodeDecodeError

[STINNER Victor]

STINNER Victor  added the comment:

I just removed Tools/scripts/h2py.py in bpo-37704.

--
resolution:  -> wont fix
stage:  -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13032] h2py.py can fail with UnicodeDecodeError

[STINNER Victor]

STINNER Victor  added the comment:

I created bpo-37704 to propose to remove Tools/scripts/h2py.py.

--
keywords:  -easy

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13032] h2py.py can fail with UnicodeDecodeError

[Arfrever Frehtes Taifersar Arahesis]

Arfrever Frehtes Taifersar Arahesis  added the comment:

UTF-8 is default encoding in Python 3, so statements with UTF-8 characters 
could be accepted.

Any strings are very rare in these statements. On my system, only generated 
TYPES.py contains 2 strings:
# Included from bits/select.h
__FD_ZERO_STOS = "stosq"
__FD_ZERO_STOS = "stosl"

/usr/include/bits/select.h contains:
# if __WORDSIZE == 64
#  define __FD_ZERO_STOS "stosq"
# else
#  define __FD_ZERO_STOS "stosl"
# endif

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13032] h2py.py can fail with UnicodeDecodeError

[Mike Gilbert]

Changes by Mike Gilbert :


--
nosy: +floppymaster

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13032] h2py.py can fail with UnicodeDecodeError

[STINNER Victor]

STINNER Victor  added the comment:

Using your patch, h2py.py skips all statements that cannot be decoded from 
UTF-8, whereas unpatched h2py.py accepts all statements that can be decoded 
from the locale encoding. I don't know if it is intentional to accept non-ASCII 
statements. It is maybe safer to ensure that a statement is encodable to ASCII 
using:

try:
stmt.encode('ASCII')
exec(stmt, env)
except:
...

Anyway, I would prefer to just drop this script with all Lib/plat-*/ directoes. 
I reopened this topic on python-dev (I already asked when I was working on the 
sys.platform=="linux3" issue: #12326).

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13032] h2py.py can fail with UnicodeDecodeError

[Arfrever Frehtes Taifersar Arahesis]

Changes by Arfrever Frehtes Taifersar Arahesis :


--
keywords: +easy

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13032] h2py.py can fail with UnicodeDecodeError

[Arfrever Frehtes Taifersar Arahesis]

New submission from Arfrever Frehtes Taifersar Arahesis 
:

Tools/scripts/h2py.py fails with UnicodeDecodeError when a header file contains 
characters undecodable in current locale. I suggest to use binary mode. I'm 
attaching a patch.

--
components: Demos and Tools
files: h2py.py.patch
keywords: needs review, patch
messages: 144438
nosy: Arfrever, georg.brandl, haypo
priority: normal
severity: normal
status: open
title: h2py.py can fail with UnicodeDecodeError
versions: Python 3.2, Python 3.3
Added file: http://bugs.python.org/file23230/h2py.py.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com