[issue13099] Sqlite3 & turkish locale

2011-10-04 Thread Thomas Kluyver

New submission from Thomas Kluyver :

When using sqlite3 with the Turkish locale, cursor.lastrowid is not accessible 
after an insert statement if "INSERT" is upper case.

I believe that the cause is that the detect_statement_kind function [1] calls 
the locale-dependent C function tolower(). The Turkish locale specifies a 
different case mapping for I (to a dotless lowercase i: ı), so it's not 
recognised as an insert statement, which looks like it will cause the 
transaction to be committed immediately.

See also the discussion on issue 1813 [2], and a Redhat bug with a test case 
for this [3].


[1] http://hg.python.org/cpython/file/c4b6d9312da1/Modules/_sqlite/cursor.c#l41
[2] http://bugs.python.org/issue1813
[3] https://bugzilla.redhat.com/show_bug.cgi?id=720209

--
components: Extension Modules
messages: 144873
nosy: takluyver
priority: normal
severity: normal
status: open
title: Sqlite3 & turkish locale
versions: Python 2.7, Python 3.2

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue13099] Sqlite3 & turkish locale

2011-10-04 Thread Ezio Melotti

Changes by Ezio Melotti :


--
nosy: +ezio.melotti
stage:  -> test needed
type:  -> behavior

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue13099] Sqlite3 & turkish locale

2011-10-04 Thread Thomas Kluyver

Thomas Kluyver  added the comment:

What form does the test need to be in? There's a script at the redhat bug I 
linked that demonstrates the issue. Do I need to turn it into a function? A 
patch for the existing test suite?

--
type: behavior -> 

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue13099] Sqlite3 & turkish locale

2011-10-04 Thread Ezio Melotti

Ezio Melotti  added the comment:

A patch against Lib/sqlite3/test/regression.py would be nice.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue13099] Sqlite3 & turkish locale

2011-10-04 Thread Roundup Robot

Roundup Robot  added the comment:

New changeset 469555867244 by Antoine Pitrou in branch '3.2':
Issue #13099: Fix sqlite3.Cursor.lastrowid under a Turkish locale.
http://hg.python.org/cpython/rev/469555867244

New changeset 652e2dacbf4b by Antoine Pitrou in branch 'default':
Issue #13099: Fix sqlite3.Cursor.lastrowid under a Turkish locale.
http://hg.python.org/cpython/rev/652e2dacbf4b

New changeset 89713606b654 by Antoine Pitrou in branch '2.7':
Issue #13099: Fix sqlite3.Cursor.lastrowid under a Turkish locale.
http://hg.python.org/cpython/rev/89713606b654

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue13099] Sqlite3 & turkish locale

2011-10-04 Thread Antoine Pitrou

Antoine Pitrou  added the comment:

Fixed, thank you.

--
nosy: +pitrou
resolution:  -> fixed
stage: test needed -> committed/rejected
status: open -> closed
versions: +Python 3.3

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue13099] Sqlite3 & turkish locale

2011-10-04 Thread Thomas Kluyver

Thomas Kluyver  added the comment:

Thanks, Antoine. Should I still try to write a regression test for it?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue13099] Sqlite3 & turkish locale

2011-10-04 Thread Antoine Pitrou

Antoine Pitrou  added the comment:

> Thanks, Antoine. Should I still try to write a regression test for it?

I've had issues writing regression tests for other Turkish
locale-related failures (namely, there are other bugs in some glibcs
that could cause the test to fail anyway). I'm not sure it's worth it
here.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com